Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[ragingduckd]

Thanks for your fast response (as always)! And I also feel stupid now. I've read that earlier bug report and your reaction, but I didn't remember it...

No worries... a forum thread isn't much of a way to distribute this sort of info.

[ragingduckd]

Just released v2.5.4.5 for both official and beta users.  This isn't a major feature-oriented release, so you may not even notice the changes at all:

• It fixes the recent problem where people get automatically kicked when they join your game.  That is, it's safe to turn HTML5 Notifications back on.
• It also includes several developer-oriented contributions by michaeljb.  Among other things, it should be easier to write new UI's for Salvager now.

Update should be automatic for everybody, so if something is still broken for you, start by checking that you're on v2.5.4.5 first.

[Mischief]

Everything's back to normal.  Thanks!

[michaeljb]

Ever hit "End Turn" when you didn't mean to? I've just submitted a pull request for a feature that might be able to help you out:

[jsh357]

Ever hit "End Turn" when you didn't mean to? I've just submitted a pull request for a feature that might be able to help you out:

http://i.imgur.com/jvFYbmG.png

;_;

Glorious...

[SCSN]

Awesome, please do the same for "End Actions", as that one is much more problematic for me than "End Turn".

[ragingduckd]

Ever hit "End Turn" when you didn't mean to? I've just submitted a pull request for a feature that might be able to help you out:

Great work!  I just accepted the pull request and deployed as v2.5.4.6 for beta users.

[assemble_me]

Faboulus, that's heading in the direction I've described here:
http://forum.dominionstrategy.com/index.php?topic=10903.msg372238#msg372238

What's left to do seems to prohibit other buttons from moving around like in that "overpay potion/overpay coin/done overpaying" exampe I gave although that's probably tough as I expect you'd have to implement each button on its own and you probably don't want ALL your buttons moved to the sidebar.

[michaeljb]

You may have noticed a bug in my new "better End Turn" feature--when you play multiple games without refreshing, multiple buttons appear in the side bar.

theblankman has submitted a fix, and since I'm posting about it I think that means I need to give you a random post of his to upvote, so here you go.

[theblankman]

You may have noticed a bug in my new "better End Turn" feature--when you play multiple games without refreshing, multiple buttons appear in the side bar.

theblankman has submitted a fix, and since I'm posting about it I think that means I need to give you a random post of his to upvote, so here you go.

Haha thanks... I guess if people want they can upvote this one now   As to the requests that we move other troublesome buttons... now that we've proven the concept with End Turn, maybe we can have a longer-term effort to make our own full panel of buttons, with better organization, and just have a "Salvager Buttons" option.  It would probably save effort if we do them all at once instead of one or two buttons at a time.  I think I'll make an enhancement request on github to discuss details. 

In other news: Google is apparently prohibiting Windows users from loading extensions that aren't listed on the Chrome Wed Store in the name of malware protection.  I'm not sure, but this sounds like it could affect Salvager beta testers who run Windows.  Devs who are more familiar with Chrome extension distribution than me, what do you make of this? 

[GeoLib]

You may have noticed a bug in my new "better End Turn" feature--when you play multiple games without refreshing, multiple buttons appear in the side bar.

theblankman has submitted a fix, and since I'm posting about it I think that means I need to give you a random post of his to upvote, so here you go.

Haha thanks... I guess if people want they can upvote this one now   As to the requests that we move other troublesome buttons... now that we've proven the concept with End Turn, maybe we can have a longer-term effort to make our own full panel of buttons, with better organization, and just have a "Salvager Buttons" option.  It would probably save effort if we do them all at once instead of one or two buttons at a time.  I think I'll make an enhancement request on github to discuss details. 

In other news: Google is apparently prohibiting Windows users from loading extensions that aren't listed on the Chrome Wed Store in the name of malware protection.  I'm not sure, but this sounds like it could affect Salvager beta testers who run Windows.  Devs who are more familiar with Chrome extension distribution than me, what do you make of this?

May I request that these buttons be not quite so far away as the new end-turn? It would be nice to have them grouped close to where Goko has them now, just not moving around all the damn time. I think always present but greyed-out when you can't use them is the best solution.

[ragingduckd]

In other news: Google is apparently prohibiting Windows users from loading extensions that aren't listed on the Chrome Wed Store in the name of malware protection.  I'm not sure, but this sounds like it could affect Salvager beta testers who run Windows.  Devs who are more familiar with Chrome extension distribution than me, what do you make of this?

Wow... that page is remarkably unclear.  I think the important question is, "does this only affect people running Chromium on Windows?"

If so, then I think we're talking about very few (any?) of our beta testers, and we can ignore this unless someone speaks up to let us know that there's a problem.  If not, then shouldn't my v35 of Chrome (on Windows) already be refusing to install the Salvager beta?

[LibraryAdventurer]

fyi, I run Salvager Beta using Chrome on Windows 7 and it still works fine.

[theblankman]

May I request that these buttons be not quite so far away as the new end-turn? It would be nice to have them grouped close to where Goko has them now, just not moving around all the damn time. I think always present but greyed-out when you can't use them is the best solution.

Of course you may request that, I already did over on github   We're discussing details of how to arrange the buttons but I think there's agreement that the commonly-used ones shouldn't be way off in the corner. 

Wow... that page is remarkably unclear.  I think the important question is, "does this only affect people running Chromium on Windows?"

If so, then I think we're talking about very few (any?) of our beta testers, and we can ignore this unless someone speaks up to let us know that there's a problem.  If not, then shouldn't my v35 of Chrome (on Windows) already be refusing to install the Salvager beta?

Oh good, I'm not the only one who found it unclear   Also good that you're still up and running on Windows, hopefully that means we're cool. 

[sudgy]

Oh good, I'm not the only one who found it unclear   Also good that you're still up and running on Windows, hopefully that means we're cool.

(Remember, cool people use Windows

[theblankman]

Because michaeljb is awesome, there will soon be an alternate "End Actions" button as well.  Because silverspawn is also awesome, I've become aware that things may look a little funny if you use the alternate buttons with your VP counter turned off, and submitted a fix for that.  And this time I am hogging the upvotes for myself

[cyberkev63]

...

Okay, got it.  Thanks.

I've made a change that I think will fix it to the beta code.  That'll get into the deployed version of the beta soon, and then go out in the next official release.

I just successfully updated my avatar and all is good.  As always: Thank you for your great work!

[Awaclus]

The multiplayer lobby looks like this now...



EDIT: The console:

Code: [Select]

gatherUrlCookieParams found the following URL params: [""] FSSDK.js:553
ConnectionMaker merged the following cookie params: ["", cookieid: null] FSSDK.js:563
FS.MessageWebSocketConnection.prototype.connect: currently trying - wss://wss.prod.dominion.makingfun.com:443 FSSDK.js:13424
Starting Goko Salvager 2.5.4.5 init.js:5
Loading Utils utils.js:4
Loading Settings Dialog blacklistSync.js:3
Loading Settings Dialog settingsDialog.js:3
Loading Notifications Module notifications.js:4
Loading autokick speedTweak.js:4
Loading Always Stack alwaysStack.js:4
Loading LaunchScreenLoader launchScreenLoader.js:3
Loading Module Loader module_loader.js:4
Preparing to load module WS Connection module_loader.js:40
FSSDK: webSocket: onopen: top: url:wss://wss.prod.dominion.makingfun.com:443 FSSDK.js:13479
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13522
initMeetingRoom DominionClient.js:15
This element isn't a canvas - TypeError: undefined is not a function FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L960px T0px FSSDK.Notifier.js:115
Loading module WS Connection module_loader.js:55
Loading WS Connection module connection.js:25
Creating WebSocket connection to gokosalvager.com utils.js:8
Preparing to load module Avatars module_loader.js:40
Loading module Avatars module_loader.js:44
Preparing to load module Avatar Upload module_loader.js:40
Loading module Avatar Upload module_loader.js:44
Preparing to load module Blacklist module_loader.js:40
Loading module Blacklist module_loader.js:44
Preparing to load module Blacklist Sync module_loader.js:40
Loading module Blacklist Sync module_loader.js:44
Preparing to load module User Settings Dialog module_loader.js:40
Loading module User Settings Dialog module_loader.js:44
Preparing to load module Launch Screen Loader module_loader.js:40
Loading module Launch Screen Loader module_loader.js:44
Preparing to load module Notifications module_loader.js:40
Loading module Notifications module_loader.js:44
Preparing to load module Lobby Ratings module_loader.js:40
Loading module Lobby Ratings module_loader.js:44
Preparing to load module Deck Tracker module_loader.js:40
Loading module Deck Tracker module_loader.js:44
Preparing to load module Table State module_loader.js:40
Loading module Table State module_loader.js:44
Preparing to load module autokick module_loader.js:40
Loading module autokick module_loader.js:44
Preparing to load module Kingdom Generator module_loader.js:40
Loading module Kingdom Generator module_loader.js:44
Preparing to load module speedTweak module_loader.js:40
Loading module speedTweak module_loader.js:44
Tweaking animation speeds. speedTweak.js:17
Preparing to load module Always Stack module_loader.js:40
Loading module Always Stack module_loader.js:44
Preparing to load module Automatch Game Popup module_loader.js:40
Loading module Automatch Game Popup module_loader.js:44
Preparing to load module Automatch Offer Popup module_loader.js:40
Loading module Automatch Offer Popup module_loader.js:44
Preparing to load module Automatch Seek Popup module_loader.js:40
Loading module Automatch Seek Popup module_loader.js:44
Preparing to load module Automatch module_loader.js:40
Loading module Automatch module_loader.js:44
Preparing to load module QuickGame module_loader.js:40
Loading module QuickGame module_loader.js:44
Preparing to load module Sidebar module_loader.js:40
Loading module Sidebar module_loader.js:44
Preparing to load module Prettified Log Viewer module_loader.js:40
Loading module Prettified Log Viewer module_loader.js:44
Preparing to load module VP Calculator module_loader.js:40
Loading module VP Calculator module_loader.js:44
Preparing to load module VP Toggle module_loader.js:40
Loading module VP Toggle module_loader.js:44
Preparing to load module VP Counter module_loader.js:40
Loading module VP Counter module_loader.js:44
Preparing to load module Chat Box module_loader.js:40
Loading module Chat Box module_loader.js:44
Preparing to load module autozap module_loader.js:40
Loading module autozap module_loader.js:44
Successfully subscribed to player notifications FSSDK.js:20398
Player Info Fetched 
Object {status: (...), name: (...), id: (...), authorizationAgents: (...), creationDate: (...)…}
 DominionClient.js:43
Launch Screen ready. launchScreenLoader.js:66
Connected to gokosalvager.com connection.js:45
TODO: Update icon for status: 1 connection.js:164
Loaded avatar cache from gokosalvager.com avatars.js:20
Retrieved and cached common blacklist blacklist.js:33
Create achievements response: 
Object {message: "Status", source: "Object", tag: "-FSMsgWSTag24", sqA: 25, data: Object…}
 DominionClient.js:33
Quick game script loaded. utils.js:8
Initializing quick game. utils.js:8
Initializing quick game button utils.js:8
Not already loaded Automatch automatch.js:938
Automatch script loaded. utils.js:8
Initializing Automatch utils.js:8
Connecting to Automatch server at wss://gokosalvager.com:443/automatch utils.js:8
Goko.Player.preloader() utils.js:8
Connected to Automatch server.

[ragingduckd]

Hmm... it looks normal for me.  Does it work properly for you with Salvager disabled?

I certainly can't think of anything on our end that could do that... and there's nothing to indicate it in the log.

Edit: This line may be the problem.  Looks like another Goko screwup:

Code: [Select]

This element isn't a canvas - TypeError: undefined is not a function FSSDK.Notifier.js:198


[Joseph2302]

working fine for me, too (with Salvager on)

[Awaclus]

Hmm... it looks normal for me.  Does it work properly for you with Salvager disabled?

I certainly can't think of anything on our end that could do that... and there's nothing to indicate it in the log.

Apparently it doesn't work even without Salvager. I guess I just got Goko'd then.

[yed]

Hmm... it looks normal for me.  Does it work properly for you with Salvager disabled?

I certainly can't think of anything on our end that could do that... and there's nothing to indicate it in the log.

Apparently it doesn't work even without Salvager. I guess I just got Goko'd then.

Do you have any other extensions installed?

[Awaclus]

Hmm... it looks normal for me.  Does it work properly for you with Salvager disabled?

I certainly can't think of anything on our end that could do that... and there's nothing to indicate it in the log.

Apparently it doesn't work even without Salvager. I guess I just got Goko'd then.

Do you have any other extensions installed?

Yes, but they haven't been causing any trouble before, and I tried disabling them and it still didn't work.

[AndrewisFTTW]

I'm trying to reinstall Salvager for Firefox but when I click this link

https://www.gokosalvager.com/firefox-latest-gokosalvager.xpi

I just get a bunch of symbols and text.

[ragingduckd]

I'm trying to reinstall Salvager for Firefox but when I click this link

https://www.gokosalvager.com/firefox-latest-gokosalvager.xpi

I just get a bunch of symbols and text.

Do "Save As," then open the xpi file with Firefox (probably just double-click the icon).  If that fails, open up the Firefox Add-Ons dialog and do "Install Add-On from file."