Investment
Action 5
Gain a gold
A very simple card. I won't say much until there's discussion here.
Tough to call. I guess the best comparison is Hoard, the differences being that Hoard doesn't require an action but does require the purchase of a victory card (which may [Province] or may not [Estate] be ideal). I guess Hoard also allows you to gain multiple Golds, since you can buy multiple victory cards. It's a very loose comparison, actually, but sufficient enough that I suspect $5 is probably fine for this.
But is it interesting enough to want to play with? Not so sure.
General
Action 5
Name a card type. Reveal the top 2 cards of your deck. For every card of the named type revealed, +1 Card. For every different type revealed (including the named type), +$1. Discard the revealed cards.
Originally this had an action and it was almost certainly too strong. Here it's probably too weak, but it's usually going to be 2 cards and a coin or two coin and a card, which is reasonable if not great for 5. And it's got the potential to be much better in the right deck.
Really, really interesting and innovative idea here. I think it needs tweaking, but it's definitely an idea worth working to perfect. So let's think it through a bit.
This card is strengthened with dual-type cards and/or knowledge of the top of your deck. Usually, however, you won't have either, which means the benefits can't be arranged or relied upon. That needs to be taken into account.
Now what about the range of possible benefits? The upside (again, barring dual-typed cards) is a total of 3 cards and coins. On a terminal action, +cards and +coins are roughly equal, with the +cards often being slightly better. Paradoxically, though, Smithy costs $4, and I'm basically positive that a terminal +$3 would have to cost $5. But I think that's because +cards requires support to be stronger than +$, whereas +$ is sufficient on its own to have a good turn.
So let's say that +2 Cards/+$1 and +1 Card/+$2 is somewhere around a $4.5-cost card in terms of power level.
Now, what's the down side? Pretty weak. If you guess Treasure and turn up two Estates, you get +$1 and that's it. Seems to me that will happen quite often, too. I really don't think you can price the card at $5 when the best possible outcome is barely a $5 effect if at all, while the worst possible outcome is worse than a Copper.
With dual-typed cards, you can get up to +2 Cards, +$2, which is very nice, but still inadequate compensation for the risk of whiffing entirely.
I think you can price this at $4 and be just fine. Even then, Smithy will probably usually be stronger.
Edit: Oh, but an Action/Attack card would be worth +$2 on its own, wouldn't it? So the upside is better than I realized. Hmmm.
Calvary
Action-Victory 5
+1 Card
+1 Action
+$1
_______________
Worth 1 VP
Another vanilla peddler. Compared to market, you get a vp instead of a buy.
Seems solid to me. This is essentially a money-earning Great Hall, which makes it a fun pile to race for. Although nothing it does is unique, it's still an interesting card in a board that also had Great Halls, Treasuries, and Peddlers. Depending on the circumstances, there would be reasons to prefer any one of the four. Good card.