Topic: Harem (Read 5414 times)

mameluke · « **on:** January 27, 2013, 08:19:05 am »

Is it just me, or does Harem say Treasure - Reaction for everyone else?

Tables · « **Reply #1 on:** January 27, 2013, 08:20:44 am »

Oh my. Yes, yes it does.

Edit: However, it IS fixed in the beta, meaning Goko are aware and have fixed the problem for the next update.

mameluke · « **Reply #2 on:** January 27, 2013, 08:22:41 am »

Has it really taken us all this long to notice? $:-\$

mameluke · « **Reply #3 on:** January 27, 2013, 08:24:39 am »

hopefully there hasn't been any bugs with crossroads, vagrant, scout, silk roads, etc.

Tables · « **Reply #4 on:** January 27, 2013, 08:25:48 am »

No, there's a topic on GS, and Tanya has said it was just a text error, and will be fixed next update. It's fixed in the private beta, just checked.

mameluke · « **Reply #5 on:** January 27, 2013, 08:35:42 am »

Excellent. Thanks.

pinkymadigan · « **Reply #6 on:** January 28, 2013, 04:43:34 pm »

Quote from: Tables on January 27, 2013, 08:25:48 am

No, there's a topic on GS, and Tanya has said it was just a text error, and will be fixed next update. It's fixed in the private beta, just checked.

I'm so confused as to why they would make the decision to hand code the text and not have it driven by a type tied to the card.

ftl · « **Reply #7 on:** January 28, 2013, 05:29:03 pm »

Possibly because it's part of the image and looks cleaner if it's pre-drawn and not regenerated from a defined "type".

Tables · « **Reply #8 on:** January 28, 2013, 05:43:57 pm »

Quote from: pinkymadigan on January 28, 2013, 04:43:34 pm

Quote from: Tables on January 27, 2013, 08:25:48 am
No, there's a topic on GS, and Tanya has said it was just a text error, and will be fixed next update. It's fixed in the private beta, just checked.

I'm so confused as to why they would make the decision to hand code the text and not have it driven by a type tied to the card.

That sounds like extra unnecessary programming and extra unnecessary code to execute every time a card needs to be drawn.

SirPeebles · « **Reply #9 on:** January 28, 2013, 05:53:05 pm »

Quote from: Tables on January 28, 2013, 05:43:57 pm

Quote from: pinkymadigan on January 28, 2013, 04:43:34 pm
Quote from: Tables on January 27, 2013, 08:25:48 am
No, there's a topic on GS, and Tanya has said it was just a text error, and will be fixed next update. It's fixed in the private beta, just checked.

I'm so confused as to why they would make the decision to hand code the text and not have it driven by a type tied to the card.

That sounds like extra unnecessary programming and extra unnecessary code to execute every time a card needs to be drawn.

Well the images don't appear to be entirely static. Band of Misfits is the biggest example, but also costs change with price reduction and the number displayed on Copper changes with Coppersmith.

michaeljb · « **Reply #10 on:** January 28, 2013, 07:18:01 pm »

Yeah, looks like they're sort of pieced together:

onigame · « **Reply #11 on:** January 28, 2013, 09:16:53 pm »

Quote from: SirPeebles on January 28, 2013, 05:53:05 pm

Quote from: Tables on January 28, 2013, 05:43:57 pm
That sounds like extra unnecessary programming and extra unnecessary code to execute every time a card needs to be drawn.

Well the images don't appear to be entirely static. Band of Misfits is the biggest example, but also costs change with price reduction and the number displayed on Copper changes with Coppersmith.

Also the text changes when the display language changes, even though you would want to reuse other things like art and costs.

Morgrim7 · « **Reply #12 on:** January 29, 2013, 12:51:00 am »

Quote from: mameluke on January 27, 2013, 08:19:05 am

Is it just me, or does Harem say Treasure - Reaction for everyone else?

:O
I wonder what Harem as a reaction would be.

mameluke · « **Reply #13 on:** January 29, 2013, 03:15:17 am »

Harem
Treasure - Reaction

+$2
---
If everyone else in the game thinks you're a loser, you may reveal this card. If you do, they all now know that you have a Harem.

hsiale · « **Reply #14 on:** January 29, 2013, 04:27:32 am »

Quote from: michaeljb on January 28, 2013, 07:18:01 pm

Yeah, looks like they're sort of pieced together:

How do you find such images? I looked through some, funny thing I noticed is that Treasure-Reaction has question marks on the top border already added. The Treasure and Victory templates are for base cards (ones with no place for art), are the templates for kingdom victory or treasure cards also there (I guess yes)?

Drab Emordnilap · « **Reply #15 on:** January 29, 2013, 12:43:07 pm »

Quote from: hsiale on January 29, 2013, 04:27:32 am

Quote from: michaeljb on January 28, 2013, 07:18:01 pm
Yeah, looks like they're sort of pieced together:

How do you find such images? I looked through some, funny thing I noticed is that Treasure-Reaction has question marks on the top border already added. The Treasure and Victory templates are for base cards (ones with no place for art), are the templates for kingdom victory or treasure cards also there (I guess yes)?

The file paths are pretty reasonable.

eHalcyon · « **Reply #16 on:** January 29, 2013, 01:09:10 pm »

Someone should pull them all so we have canonical images for fan cards.

michaeljb · « **Reply #17 on:** January 29, 2013, 01:48:10 pm »

Quote from: hsiale on January 29, 2013, 04:27:32 am

How do you find such images?

Chrome's Developer Tools, resources tab.

Quote

I looked through some, funny thing I noticed is that Treasure-Reaction has question marks on the top border already added.

More Guilds spoilers!! There isn't a Treasure-Reaction, and Fool's Gold remains unique in its dual-type. Or Guilds does have a Treasure-Reaction that also provides a variable amount of currency.

SirPeebles · « **Reply #18 on:** January 29, 2013, 02:50:02 pm »

Quote from: michaeljb on January 29, 2013, 01:48:10 pm

Quote from: hsiale on January 29, 2013, 04:27:32 am
How do you find such images?
Chrome's Developer Tools, resources tab.

Quote
I looked through some, funny thing I noticed is that Treasure-Reaction has question marks on the top border already added.
More Guilds spoilers!! There isn't a Treasure-Reaction, and Fool's Gold remains unique in its dual-type. Or Guilds does have a Treasure-Reaction that also provides a variable amount of currency.

Right, because Goko always plans ahead.

hsiale · « **Reply #19 on:** January 30, 2013, 07:54:13 am »

Quote from: michaeljb on January 29, 2013, 01:48:10 pm

Chrome's Developer Tools, resources tab.

Thanks, took me a bit of time to find my way around it but now I see all the images.

Quote from: eHalcyon on January 29, 2013, 01:09:10 pm

Someone should pull them all so we have canonical images for fan cards.

I'll have all the files soon. How should I make them available?

theory · « **Reply #20 on:** January 30, 2013, 10:17:12 am »

imgur.com is an easy place to upload images

michaeljb · « **Reply #21 on:** January 31, 2013, 12:58:28 am »

Quote from: hsiale on January 30, 2013, 07:54:13 am

Quote from: michaeljb on January 29, 2013, 01:48:10 pm
Chrome's Developer Tools, resources tab.
Thanks, took me a bit of time to find my way around it but now I see all the images.

Glad you got something out of my pretty lazy response

Dominion Strategy Forum

News:

Author Topic: Harem (Read 5414 times)