Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[DStu]

Geronimoo's is java and works on Linux, certainly also works on mac

[h1402686]

I can't get Dominiate to play Lookout. The code in cards.coffee looks like the simulator should be happy to play Lookout until it gets close to the end of the game:

Code: [Select]

makeCard "Lookout", action, {
  ...

  ai_playValue: (state, my) ->
    if state.gainsToEndGame >= 5 or state.cardInfo.Curse in my.draw
      895
    else
      -5

}
Yet the following bot buys Lookout, but never plays it:

Code: [Select]

{
  name: 'LookBug'
  requires: ['Lookout']
  gainPriority: (state, my) -> [
    "Colony" if my.countInDeck("Platinum") > 0
    "Province" if state.countInSupply("Colony") <= 6 \
               or state.countInSupply("Province") <= 6
    "Duchy" if 0 < state.gainsToEndGame() <= 5
    "Estate" if 0 < state.gainsToEndGame() <= 2
    "Platinum"
    "Gold" if my.countInDeck("Gold") < 2
    "Lookout"
    "Silver"
  ]
}

[DStu]

Found the bug.

My version is too far behind to patch fastly, but patch is in ai_value from Lookout

Code: [Select]

-- if state.gainsToEndGame >= 5 or state.cardInfo.Curse in my.draw
++ if state.gainsToEndGame() >= 5 or state.cardInfo.Curse in my.draw

gainsToEndGame is a function.

[h1402686]

Thanks, DStu. Is there a way I can patch it for myself if I'm running from a browser? Just dumping the fixed makeCard code into the "Player 1" window in my browser doesn't work.

[DStu]

Thanks, DStu. Is there a way I can patch it for myself if I'm running from a browser? Just dumping the fixed makeCard code into the "Player 1" window in my browser doesn't work.

I don't thin you can patch, but you can workaround:

Code: [Select]

{
  name: 'LookBug'
  requires: ['Lookout']
  gainPriority: (state, my) -> [
    "Colony" if my.countInDeck("Platinum") > 0
    "Province" if state.countInSupply("Colony") <= 6 \
               or state.countInSupply("Province") <= 6
    "Duchy" if 0 < state.gainsToEndGame() <= 5
    "Estate" if 0 < state.gainsToEndGame() <= 2
    "Platinum"
    "Gold" if my.countInDeck("Gold") < 2
    "Lookout"
    "Silver"
  ]

  actionPriority: (state, my) ->
    if state.gainsToEndGame() > 5 or ...
       "Lookout"
   
}

so just add an actionPriority function to your bot, which returns a list containing the priorities you want your cards played. Note that you have to add all the cards of you bot there, as this overwrites the call of ai_value from cards (IIRC).  You might want to look into old_actionPriority in basicAI.cofffee if you have some more cards in your bot to see how they used to be prioritized.
Maybe

Code: [Select]

  actionPriority: (state, my) ->
    old_actionPriority(state,my)
does also work, at least Lookout is implemented correctly there, but there might be some newer cards (like from Guilds and Dark Ages) that are not listed there anymore.

:e corrected name of old_actionPriority.  Maybe you also have to reference it over the ai, in this case it is

Code: [Select]

my.ai.old_actionPriority(state,my)
I'm not sure what exactly the scope is from which the code is called here.

edit: OK, actionPriority seems to be not called anymore, it's now playPriority if I understand this correctly. Problem is that this one is merged with the Treasures, so you must inculde all the treasures in your list, too, otherwise the bot does not play Treasures.

[DStu]

Yeah, why and since when don't we call actionPriority anymor when it exists? It feels like playPriority is much more of a hassle to define costumely, as you also have to care for tje Treasures.  So why is this mixed?

[h1402686]

I ended up downloading the code and making the fix. As far as I can tell I couldn't push the fix so I created an issue instead: https://github.com/rspeer/dominiate/issues/85

[h1402686]

I made the following updates to the code:

• Fixed the Lookout bug
• Fixed another bug, this one related to trashing
• Implemented Forager

I'm new to GitHub and am not sure I submitted the patch the right way, as I can't tell if anyone has seen it. So I'm posting it here as well: https://github.com/rspeer/dominiate/pull/86.

For fun, here's my first Forager result. When running SeaHag vs. a Forager/SeaHag bot, the Forager bot dominates, 89-11 (not surprisingly). Maybe more interesting, the Forager/SeaHag bot wants three Foragers and only one SeaHag. Code for the bots is attached.

[DStu]

I made the following updates to the code:

• Fixed the Lookout bug
• Fixed another bug, this one related to trashing
• Implemented Forager

I'm new to GitHub and am not sure I submitted the patch the right way, as I can't tell if anyone has seen it. So I'm posting it here as well: https://github.com/rspeer/dominiate/pull/86.

For fun, here's my first Forager result. When running SeaHag vs. a Forager/SeaHag bot, the Forager bot dominates, 89-11 (not surprisingly). Maybe more interesting, the Forager/SeaHag bot wants three Foragers and only one SeaHag. Code for the bots is attached.

Looks fine.

[joejoe22802]

Is this Git repo dead at this point or is there a fork that's still chugging?

[Seprix]

Is this Git repo dead at this point or is there a fork that's still chugging?

It's dead, Jim

[Holger]

Is there a way to define new cards or change properties of existing cards in the web browser interface? I'd like to test Adventurer at a cheaper cost...