imo 1) military/civilian is just a part of a flavor name that gives additional functions
2) in future games a military person can retire and a civilian may enter military for all we know
that's why it's here
These are true statements, but that's why I worry about the inconsistency of application.
I am taking civilian in this game to mean "not a member of the military" and military to mean "member of the military."
There is a clear difference between a member of the military and a civilian (in general terms). Someone who retires then becomes a veteran and a civilian again. If such actions are possible over the arc of this series of games, then a player's military/civilian status should change along with the flavor character.
I get that civilian/military is a thing for the president/VP mechanic. If that's the only reason, not making it align with flavor names seems odd, but I guess okay if there's a numerical or other reason for it.
If there are more reasons for civ/mil outside of the president/VP mechanics, like powers that only affect one or the other, can't affect one or the other, etc. etc. etc., again I get it's use. The confusion comes when you have a flavor name that is clearly one or the other and an assignment of the opposite for the player themselves.
I have yet to figure out a reasons for why that might be done. To force awkward claims as an additional technical challenge? "Hey, I'm Sgt. Pepper but I'm actually a civilian, not lying, promise!" sorts of stuff?
What if it is the key to unlocking the secrets of the universe (or at least for catching mafia)?