Dominion Strategy Forum

Please login or register.

Login with username, password and session length
Pages: 1 ... 7 8 [9] 10 11 ... 23  All

Author Topic: MAKiNG MORE FUN: Mod for Dominion Online 2.0  (Read 171990 times)

0 Members and 1 Guest are viewing this topic.

SCSN

  • Mountebank
  • *****
  • Offline Offline
  • Posts: 2227
  • Respect: +7140
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #200 on: November 02, 2015, 08:51:08 pm »
+3

It's fixed thanks to Deadlock assisting me with his amazing regex skills; I'll release the patch tomorrow morning.

So Masquerade breaks it, right? With more than 2 players, at least.

Masq's passing info doesn't get into the log even for 2 players yet the point counter gets updated, so it gets feeded from at least one channel other than the log. I haven't looked into it but I wouldn't rule out that it still works for >2P.
Logged

LastFootnote

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7495
  • Shuffle iT Username: LastFootnote
  • Respect: +10722
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #201 on: November 02, 2015, 10:34:08 pm »
0

Masq's passing info doesn't get into the log even for 2 players yet the point counter gets updated, so it gets feeded from at least one channel other than the log. I haven't looked into it but I wouldn't rule out that it still works for >2P.

Is it possible that that entire function is just leftover code and not actually called?
Logged

Deadlock39

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1722
  • Respect: +1758
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #202 on: November 03, 2015, 12:30:53 am »
+3

Masq's passing info doesn't get into the log even for 2 players yet the point counter gets updated, so it gets feeded from at least one channel other than the log. I haven't looked into it but I wouldn't rule out that it still works for >2P.

Is it possible that that entire function is just leftover code and not actually called?

Oh, for sure it
Masq's passing info doesn't get into the log even for 2 players yet the point counter gets updated, so it gets feeded from at least one channel other than the log. I haven't looked into it but I wouldn't rule out that it still works for >2P.

Is it possible that that entire function is just leftover code and not actually called?

Nah, it is definitely called. We wouldn't have been able to break the counter by changing the gaining string if it didn't pass through the function that calls that one. (called parseLogLineForVPs)

I'm not sure how they correct for Masquerade passes in 3p.

Deadlock39

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1722
  • Respect: +1758
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #203 on: November 03, 2015, 01:34:31 am »
+21

    Hey all you MMF fans! I've been working with SCSN on the Graverobber plugin for MAKiNG MORE FUN.

I've just completed the first goal for the plugin and have pretty pictures to show off, so here they are.  The Graverobber plugin processes (in real time) a data log that is written out by MMF and generates a game log that is colorized in the style of our dearly departed Salvager.

Planned features include:

  • Filling in publicly known cards for actions like cards drawn from your deck (a MMF feature), passed with Masquerade, Picked up by Native Village, ect.
  • Collapsing simple buys into "X buys & gains Y" (also a MMF feature)
  • Baker token warning
  • Shelters warning on 5/2 split
  • Displaying all the public counters that hide in the crazy pop-out HUD or hide under mat cards on the MF client.
  • Option to collapse (i.e. 5 Copper, 2 Estate) cards that are revealed by deck diggers (e.g. Golem), and other places in the log.
  • Track session wins and losses (also a MMF feature)
  • Display Isotropish levels for players in game
  • Witty name such as "Transmute plugin for MMF"
  • You tell me... I'm sure you have ideas
« Last Edit: November 03, 2015, 07:29:54 pm by Deadlock39 »
Logged

SCSN

  • Mountebank
  • *****
  • Offline Offline
  • Posts: 2227
  • Respect: +7140
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #204 on: November 03, 2015, 05:06:42 am »
+2

Is it possible that that entire function is just leftover code and not actually called?

Humanity would be in a sorry state if the time spent on that work of utmost beauty did go to waste. I am happy to confirm that it did not.
Logged

Beyond Awesome

  • Global Moderator
  • *****
  • Offline Offline
  • Posts: 2941
  • Shuffle iT Username: Beyond Awesome
  • Respect: +2466
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #205 on: November 03, 2015, 05:07:35 am »
0


    Hey all you MMF fans! I've been working with SCSN on a <yet to be named after a witty Dominion card> plugin for MAKiNG MORE FUN.

I've just completed the first goal for the plugin and have pretty pictures to show off, so here they are.  This plugin processes (in real time) a data log that is written out by MMF and generates a game log that is colorized in the style of our dearly departed Salvager.

Planned features include:

  • Filling in publicly known cards for actions like cards drawn from your deck (a MMF feature) and cards passed with Masquerade
  • Collapsing simple buys into "X buys & gains Y" (also a MMF feature)
  • Baker token warning
  • Shelters warning on 5/2 split
  • Displaying all the public counters that hide in the crazy pop-out HUD or hide under mat cards on the MF client.
  • Option to collapse (i.e. 5 Copper, 2 Estate) cards that are revealed by deck diggers (e.g. Golem).
  • Witty name such as "Transmute plugin for MMF"
  • You tell me... I'm sure you have ideas

Oh man this is so awesome. I don't have any ideas, but great work.
Logged

SCSN

  • Mountebank
  • *****
  • Offline Offline
  • Posts: 2227
  • Respect: +7140
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #206 on: November 03, 2015, 07:15:03 am »
+9

MAKiNG MORE FUN 0.43c is now available for download. It consists of two files: the patched Assembly-CSharp.dll and my own MMF.dll, which was compiled using the .NET 4.0 compiler but should work on older versions of the framework (if not you know what to do). Both files should be placed in your Dominion_Data\Managed folder.

Most changes are neatly captured by this one picture:



Additionally, a gamelog of your current game is written to \Users\Public\MMF, together with the file jsonlog.txt that contains everything the server has ever wanted to tell you but didn't dare to say out loud. Unfortunately for me, this file does not contain your password, credit card information or instructions for accessing that Singaporean bank account you've been hiding for all those years, and even if it did I'd have no way of reading it anyway. You can use it to satisfy your curiosity or for debugging purposes, or even leave it completely alone. Freedom of choice is a marvelous thing.
Logged

Accatitippi

  • Saboteur
  • *****
  • Offline Offline
  • Posts: 1153
  • Shuffle iT Username: Accatitippi
  • Silver is underraided
  • Respect: +1797
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #207 on: November 03, 2015, 11:36:55 am »
+4

Awesome and impressive work, guys.  :o
I suggest Apprentice as a name. It's cute because it's kind of a reimplementation of Salvager (like the cards, in a way) and "learned" from it.
And it also gives hope that one day they'll look at him and learn.  :P
Logged

mameluke

  • Duke
  • *****
  • Offline Offline
  • Posts: 377
  • Respect: +442
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #208 on: November 03, 2015, 11:54:16 am »
+6

"Rebuild" would be an amusing poke at what MF supposedly did for the last six months.
Logged

Accatitippi

  • Saboteur
  • *****
  • Offline Offline
  • Posts: 1153
  • Shuffle iT Username: Accatitippi
  • Silver is underraided
  • Respect: +1797
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #209 on: November 03, 2015, 12:26:15 pm »
0

"Rebuild" would be an amusing poke at what MF supposedly did for the last six months.

I love it but it might become confusing, since build and rebuild have actually meaning in context. Or maybe not.
Logged

Deadlock39

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1722
  • Respect: +1758
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #210 on: November 03, 2015, 12:36:17 pm »
+3

While Rebuild is a Dominion card, and depending on perspective, might be descriptive of this plugin, it is a stupid card and I don't think I could be happy with naming a project after it.

Right now the top contenders in my mind are Transmute, Bridge, and Graverobber.

sc0UT

  • Young Witch
  • ****
  • Offline Offline
  • Posts: 133
  • Shuffle iT Username: sc0UT
  • Respect: +106
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #211 on: November 03, 2015, 12:43:01 pm »
0

Great Job SCSN! Nice improvements so far.
The starting cards 1liner is sweet. :)
Logged

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 9709
  • Respect: +10765
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #212 on: November 03, 2015, 12:44:54 pm »
+1

Wait a minute.... are they actually misspelling "Trashing" as "Thrashing"??
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 9709
  • Respect: +10765
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #213 on: November 03, 2015, 12:48:06 pm »
0

This has probably been discussed in the past, but what IS the actual "correct" behavior for a VP counter in 3+ player Masq games? The current scores are not meant to be trackable by the game rules. Should the VP counter just be interpreted as "this is what the VP would be if no VP cards were passed with Masq ever"?
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

sc0UT

  • Young Witch
  • ****
  • Offline Offline
  • Posts: 133
  • Shuffle iT Username: sc0UT
  • Respect: +106
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #214 on: November 03, 2015, 12:52:51 pm »
0

Wait a minute.... are they actually misspelling "Trashing" as "Thrashing"??

Well, there are other misspellings around...

I know that possession is consistently misspelled in the code for just such a reason.
Logged

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 9709
  • Respect: +10765
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #215 on: November 03, 2015, 01:02:24 pm »
0

Wait a minute.... are they actually misspelling "Trashing" as "Thrashing"??

Well, there are other misspellings around...

I know that possession is consistently misspelled in the code for just such a reason.

Yes but I can understand the posession one. That's not knowing how to spell a word that's not an immediately obvious spelling. Thrashing is not just a misspelling of Trashing, it seems more like they were under the impression that "Thrash" is a Dominion term instead of "Trash".
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

Awaclus

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 11817
  • Shuffle iT Username: Awaclus
  • (´。• ω •。`)
  • Respect: +12870
    • View Profile
    • Birds of Necama
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #216 on: November 03, 2015, 01:08:06 pm »
+2

Yes but I can understand the posession one. That's not knowing how to spell a word that's not an immediately obvious spelling. Thrashing is not just a misspelling of Trashing, it seems more like they were under the impression that "Thrash" is a Dominion term instead of "Trash".

Well, considering how often English-as-a-foreign-language people talk about a genre of music called "trash metal", I really wouldn't be surprised if it was just a misspelling of trashing.
Logged
Bomb, Cannon, and many of the Gunpowder cards can strongly effect gameplay, particularly in a destructive way

The YouTube channel where I make musicDownload my band's Creative Commons albums for free

Donald X.

  • Dominion Designer
  • *****
  • Offline Offline
  • Posts: 6367
  • Respect: +25712
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #217 on: November 03, 2015, 01:32:34 pm »
+3

Wait a minute.... are they actually misspelling "Trashing" as "Thrashing"??
It's decompiled code, so you can only guess as to the word they have there. Whereas stuff in quotes, they actually have.
Logged

Accatitippi

  • Saboteur
  • *****
  • Offline Offline
  • Posts: 1153
  • Shuffle iT Username: Accatitippi
  • Silver is underraided
  • Respect: +1797
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #218 on: November 03, 2015, 01:36:44 pm »
+1

Wait a minute.... are they actually misspelling "Trashing" as "Thrashing"??

Well, there are other misspellings around...

I know that possession is consistently misspelled in the code for just such a reason.

Yes but I can understand the posession one. That's not knowing how to spell a word that's not an immediately obvious spelling. Thrashing is not just a misspelling of Trashing, it seems more like they were under the impression that "Thrash" is a Dominion term instead of "Trash".
I think it might be. The "th" sounds are not native for many of us foreigners, and non-proficient speakers may associate/substitute them with sounds that are used in their language, like some form of "T" or "F" in this case. Once you've done that, you'll have trouble remembering which words contained "t" and which "th".
This is a wild guess, as I don't know much about linguistics.
« Last Edit: November 03, 2015, 01:38:48 pm by Accatitippi »
Logged

Donald X.

  • Dominion Designer
  • *****
  • Offline Offline
  • Posts: 6367
  • Respect: +25712
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #219 on: November 03, 2015, 02:00:01 pm »
+3

Most changes are neatly captured by this one picture:
A few obvious things you could do:

- When there's a list of cards, group them, e.g. "4 COPPER, HOVEL."
- Add missing color-coding, e.g. Beggar in blue.
- When the player's name is so long that the Turn line will go to two lines (happens a lot in the campaigns), cut out some dashes. If it's still too long, hack off the name where needed so that it isn't.
- Change the background color to a very dark gray for your own turns.
Logged

ehunt

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1528
  • Shuffle iT Username: ehunt
  • Respect: +1856
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #220 on: November 03, 2015, 06:09:51 pm »
0

Wait a minute.... are they actually misspelling "Trashing" as "Thrashing"??

i saw that earlier and figured Thrashing was a programming term of art I didn't know!
Logged

Deadlock39

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1722
  • Respect: +1758
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #221 on: November 03, 2015, 07:25:41 pm »
+3

On the inconsequential news front, We've picked Graverobber for the name of the plugin. Scratch one thing off the ToDo list.

Nakamura

  • Navigator
  • ****
  • Offline Offline
  • Posts: 71
  • Shuffle iT Username: Nakamura
  • Respect: +37
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #222 on: November 03, 2015, 09:43:00 pm »
0

Any chance the font of MMF can change to not being all caps? It's so hard to read.
Logged

Deadlock39

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1722
  • Respect: +1758
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #223 on: November 03, 2015, 10:54:47 pm »
0

Any chance the font of MMF can change to not being all caps? It's so hard to read.

I believe SCSN tried to find a way to change the font and was not successful. Fortunately the base client moved to a different font with the first 2.0.44 patch that came out, so I assume the change was kept with the recent re-release. MMF version 0.44 should pick up the better font for free.

SCSN

  • Mountebank
  • *****
  • Offline Offline
  • Posts: 2227
  • Respect: +7140
    • View Profile
Re: MAKiNG MORE FUN: Patch for Dominion Online 2.0 (Windows)
« Reply #224 on: November 04, 2015, 02:45:03 am »
+2

Releasing MMF 0.44.1.a, now compatible with Dominion Online 2.0.44.1 and featuring session statistics (towards which games that don't make it past T1 don't count).



Edit: because the high-speed settings are now part of the official release, as of now there's just one patch again.

Edit2: some debug code made it into the release (some variables got dumped to chat at the end of the game); people who downloaded before 8:39 UTC should download again.
« Last Edit: November 04, 2015, 03:39:51 am by SheCantSayNo »
Logged
Pages: 1 ... 7 8 [9] 10 11 ... 23  All
 

Page created in 1.868 seconds with 21 queries.