Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[GendoIkari]

I posted a kingdom here, using the card image button to show images, and the images wouldn't show for any card that has a space in its name.
EDIT: I found a workaround which may help you to find the bug: When I capitalized Hunting_Party, Horn_of_Plenty, and Hunting_Grounds, then the images showed correctly. (It took me two tries for Horn of plenty because I tried 'Horn_Of_Plenty' first.)

Also, how do you use the kingdom button in the fds plugin?

It's set up for capitalization to matter, though that's probably not ideal; because why should it? I think I can change that easily. Can't say why capitalization only mattered for multi-word cards; thought it would be the same for all.

For the Kingdom button, just list out all the cards with a comma (and a space after the comma) between each one. Like this (should stay as a list because the extension isn't installed where I'm posting from):

[kingdom]Hunting Party, Chapel, Scout, Laboratory[/kingdom]

[ThetaSigma12]

I'd like if this could be updated ASAP for the new cards! 

[GendoIkari]

I'd like if this could be updated ASAP for the new cards! 

Oh man I was just thinking about that yesterday at work, planning on doing it when I got home. Then by the time I got home, I forgot. Should be done tonight. I'll also update it so that capitalization doesn't matter for the auto-linking.

[GendoIkari]

I'd like if this could be updated ASAP for the new cards! 

Done! All 16 new cards have been added to auto-link. It will now auto-link cards that have incorrect casing, as well as allow you to use the link/image/kingdom tags on cards that have incorrect casing.

[Kirian]

Aw man, still wanting this for FF

[GendoIkari]

Aw man, still wanting this for FF

Not to spoil anything, or raise false hopes in case things don't go as expected, but check back in a few days. 

[Doom_Shark]

So will the new cards for the 2nd editions work already, or do you have to wait to be able to implement them?

[Seprix]

Aw man, still wanting this for FF

Not to spoil anything, or raise false hopes in case things don't go as expected, but check back in a few days. 

[heron]

Aw man, still wanting this for FF

Not to spoil anything, or raise false hopes in case things don't go as expected, but check back in a few days. 

[hopes deleted]

Uh maybe I am just confused about what this image means but Seprix have you seen this thread?
http://forum.dominionstrategy.com/index.php?topic=16305.0

[GendoIkari]

So will the new cards for the 2nd editions work already, or do you have to wait to be able to implement them?

I added them a few days ago in the 1.14 update.

As a general rule, whenever new cards are created, as soon as they are added to the Wiki, the [card ] and [cardImage ] and [kingdom ] tags will automatically work the same without me needing to update anything. But the "Autolink cards" feature requires me to update to add the new cards to the list of all cards.

[Seprix]

Aw man, still wanting this for FF

Not to spoil anything, or raise false hopes in case things don't go as expected, but check back in a few days. 

[hopes deleted]

Uh maybe I am just confused about what this image means but Seprix have you seen this thread?
http://forum.dominionstrategy.com/index.php?topic=16305.0

Hopes reuploaded.

[Doom_Shark]

So will the new cards for the 2nd editions work already, or do you have to wait to be able to implement them?

I added them a few days ago in the 1.14 update.

As a general rule, whenever new cards are created, as soon as they are added to the Wiki, the [card ] and [cardImage ] and [kingdom ] tags will automatically work the same without me needing to update anything. But the "Autolink cards" feature requires me to update to add the new cards to the list of all cards.

I kinda thought it would work that way, but I wasn't sure, and didn't want to look stupid by using a card that doesn't work, so I thought I might as well ask.

[GendoIkari]

I'll try to get around to adding Nocturne cards (and other card-shaped things) to the list for auto-linking sometime within the next week. I know at least for me, it's when there's new cards that it helps the most.

*Edit* I really should find a way to have the list pull dynamically from some web service or something; so that I don't need an update every time there's a new card.

[GendoIkari]

Testing my Nocturne update, don't mind me.

Miserable
Palace Skulk Will-o'-Wisp, Zombie Spy, Wish, Wishing Well

Horn of Plenty

Lost in the Woods
Salt the Earth

Inherited Baron.

[GendoIkari]

Version 1.15 published! You can now read the Secret History of Nocturne, and use auto-link to actually see what card is being talked about! (For those of us who haven't memorized all the new cards yet).

[GendoIkari]

Not a version update; but I'm adding Renaissance cards to the card list for Auto Link purposes as they're revealed. Finally added Dismantle also.

[GendoIkari]

Is there interest in having "Auto-Link" be something that's saved in cookies, so that it remembers if you have it turned on? I find myself generally just clicking it every time a page is loaded.

[sudgy]

Is there interest in having "Auto-Link" be something that's saved in cookies, so that it remembers if you have it turned on? I find myself generally just clicking it every time a page is loaded.

Yes, please!  I always am having to scroll up to click that button.

[GendoIkari]

Done!

As always, could take a while until the update updates. For Chrome, at least. Firefox seems to have updated immediately and is working just the same.

[vishwathg]

Suggestion: Search for "haven't" and disable autolink for Haven.

[GendoIkari]

My last update broke the new post page; the buttons and icons aren't there anymore. New version should be available soon.

Yeah, I'll try to fix "haven't". I need to figure out my own regex; I'm not actually sure what it's doing anymore. Always comment your code!

[vishwathg]

Or maybe just don't autolink anything that is not capitalized.

[GendoIkari]

Or maybe just don't autolink anything that is not capitalized.

I think I went back and forth on capitalization before. Or maybe it was just spacing. But so many people mis-capitalize multi-word cards, or just don't bother capitalizing it. Yeah it would be nice if things like "page" weren't affected in the wrong context.

For haven't, I just need to figure out why I made my current regex as complex as I did before messing with it to exclude that one.

*Edit* And of course if I exclude haven followed by a single quote, we'd lose things like "haven's effect". So I need to be more specific to "haven't".

[GendoIkari]

After reading through some more various threads that weren't actually talking about Dominion cards, I think the solution is to consider capitalization for matching card names. Way too many uses of words like "fair" and "page" and "haven't" that shouldn't be matched. Probably better to err on the side of a Dominion card being not matched than a non-Dominion card being matched.

Will update tonight probably.

[LibraryAdventurer]

After reading through some more various threads that weren't actually talking about Dominion cards, I think the solution is to consider capitalization for matching card names. Way too many uses of words like "fair" and "page" and "haven't" that shouldn't be matched. Probably better to err on the side of a Dominion card being not matched than a non-Dominion card being matched.

Haven't we had enough of Dominion cards not being linked? Is this Fair to the card names we forget to capitalize? I say there's nothing nothing wrong with linking words to Dominion cards when they're not being used to name the cards. These Pages are on the Dominion forums, after all.