Dominion Strategy Forum

Please login or register.

Login with username, password and session length
Pages: [1]

Author Topic: extension undercounting bishop points by 1 ?  (Read 1755 times)

0 Members and 1 Guest are viewing this topic.

ehunt

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1528
  • Shuffle iT Username: ehunt
  • Respect: +1856
    • View Profile
extension undercounting bishop points by 1 ?
« on: March 16, 2014, 04:14:37 am »
0

I just noticed the problem in this link.

http://forum.dominionstrategy.com/index.php?topic=10670.0
Logged

ragingduckd

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1059
  • Respect: +3527
    • View Profile
Re: extension undercounting bishop points by 1 ?
« Reply #1 on: March 16, 2014, 04:19:38 am »
0

I just noticed the problem in this link.

http://forum.dominionstrategy.com/index.php?topic=10670.0

Please clarify.  Also note that the extension and the log prettifier use different code.
Logged
Salvager Extension | Isotropish Leaderboard | Game Data | Log Search & other toys | Salvager Bug Reports

Salvager not working for me at all today. ... Please help! I can't go back to playing without it like an animal!

ehunt

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1528
  • Shuffle iT Username: ehunt
  • Respect: +1856
    • View Profile
Re: extension undercounting bishop points by 1 ?
« Reply #2 on: March 16, 2014, 04:51:27 am »
0

Oops, should have copied the log directly.
http://www.gokosalvager.com/static/logprettifier.html?/20140315/log.514cd37de4b0fe3236619906.1394944960000.txt

Each time bishop is played, the vp recorded is 1 less than the proper total.
Logged

ragingduckd

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1059
  • Respect: +3527
    • View Profile
Re: extension undercounting bishop points by 1 ?
« Reply #3 on: March 16, 2014, 06:35:27 am »
0

Oops, should have copied the log directly.
http://www.gokosalvager.com/static/logprettifier.html?/20140315/log.514cd37de4b0fe3236619906.1394944960000.txt

Each time bishop is played, the vp recorded is 1 less than the proper total.

I still don't see it.

The raw log (i.e. Goko) fails to include the Bishop's inherent 1 VP in the total VP tokens gained.  For example, here's the raw log for T6:

HvBoedefeld - plays Bishop
HvBoedefeld - trashes Estate
HvBoedefeld - receives 1 victory point chips

However, the log prettifier and the extension's VP counter both correctly adjust for this in the VP total. Here's the logprettifier status after T6:

1   Bishop
1   Tournament
7   Copper
1   Silver
3   Gold
2   Estate
1   Curse
16   cards in deck
2   VP chips
3   victory points
Logged
Salvager Extension | Isotropish Leaderboard | Game Data | Log Search & other toys | Salvager Bug Reports

Salvager not working for me at all today. ... Please help! I can't go back to playing without it like an animal!

ehunt

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1528
  • Shuffle iT Username: ehunt
  • Respect: +1856
    • View Profile
Re: extension undercounting bishop points by 1 ?
« Reply #4 on: March 16, 2014, 06:43:39 am »
+1

I see, so it's Goko that doesn't include the point? Sorry, I should have guessed.

Logged

ragingduckd

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1059
  • Respect: +3527
    • View Profile
Re: extension undercounting bishop points by 1 ?
« Reply #5 on: March 16, 2014, 06:51:47 am »
0

I see, so it's Goko that doesn't include the point? Sorry, I should have guessed.

No worries.  There just isn't much more I can (read "want to") do about it.  ;)
Logged
Salvager Extension | Isotropish Leaderboard | Game Data | Log Search & other toys | Salvager Bug Reports

Salvager not working for me at all today. ... Please help! I can't go back to playing without it like an animal!

Kirian

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7096
  • Shuffle iT Username: Kirian
  • An Unbalanced Equation
  • Respect: +9413
    • View Profile
Re: extension undercounting bishop points by 1 ?
« Reply #6 on: March 16, 2014, 10:39:35 am »
0

I see, so it's Goko that doesn't include the point? Sorry, I should have guessed.



The good news at least is that they award the point even if they don't show it.
Logged
Kirian's Law of f.DS jokes:  Any sufficiently unexplained joke is indistinguishable from serious conversation.
Pages: [1]
 

Page created in 1.509 seconds with 21 queries.