Dominion Strategy Forum

Meta => Feedback => Council Room Feedback => Topic started by: DStu on June 15, 2011, 11:54:21 am

Title: Bugs
Post by: DStu on June 15, 2011, 11:54:21 am
As far as I can tell  the Game Search does not seem to work with "Horn of Plenty". Have no clue why, the only difference to the other cards I see it that it is the only(?) one whose name consists of three words.
Title: Re: Bugs
Post by: rrenaud on June 15, 2011, 12:58:48 pm
Thanks, I'll probably take a look at it tonight.
Title: Re: Bugs
Post by: painted_cow on June 15, 2011, 01:10:00 pm
Remember the outpost-bug, when both players have same points and rounds :-)

Or doesnt councilroom reread older logs and the bug is gone?
Title: Re: Bugs
Post by: rrenaud on June 15, 2011, 01:59:32 pm
There is a parsing process that converts the raw game logs into a useable format (it's by far the nastiest part of all the code) that gets imported into the database, but I only run the new parsing code on new data.  Every once in awhile I update the parser to extract more info from logs or fix a bug, and then I re-run the whole thing.
Title: Re: Bugs
Post by: rrenaud on June 18, 2011, 12:03:37 am
http://councilroom.com/search_result?p1_name=rrenaud&p2_name=&kingdom=horn+of+plenty

I still don't know what is going on with the outpost bug :(
Title: Re: Bugs
Post by: rrenaud on June 18, 2011, 02:12:18 pm
Outpost bug dead, I think.  The bug was probably gone when I said it was, just that it required a lot of work to purge the old data from the database.


http://councilroom.com/search_result?p1_name=theory&p2_name=painted_cow&kingdom=laboratory%2Cgrand+market
Title: Re: Bugs
Post by: painted_cow on June 22, 2011, 12:29:16 pm
Nice work!
Title: Re: Bugs
Post by: painted_cow on July 07, 2011, 08:07:05 am
Lately I saw, that CR somehow doesnt take 3-pl-games as logs/stats, where one player dropped at the very beginning (like first 5 turn, I dont know excactly).

I cant give you the link to the games (cause it is not there). As hints I played one yesterday vs Purposeful1 and another player (which dropped very early) and I lost.
Title: Re: Bugs
Post by: WanderingWinder on July 09, 2011, 04:25:30 pm
This is probably intentional (and therefore not a bug), but whenever you gain a prize, in the running log at the bottom of the screen, it says that there are -1 of that prize in the supply.
Title: Re: Bugs
Post by: rrenaud on July 09, 2011, 04:56:34 pm
It's definitely not something I did on purpose, but the -1 in supply for prizes seems fairly harmless.
Title: Re: Bugs
Post by: ShuffleNCut on July 09, 2011, 11:15:58 pm
The running logs also don't work well with Masquerade as the logs don't show what was passed.  If I use Masq and get passed a curse (which I had zero of in my deck before) and then trash the curse the total will show my opponent with the same number of curses and me with negative one.

The end score is still correct as the decks are revealed in the logs at that point.

I don't think there's a way to fix this as the logs don't contain the necessary data.  It just exists.
Title: Re: Bugs
Post by: mith on October 07, 2011, 09:19:04 am
There seems to be a bug in counting Fairgrounds points; councilroom is giving me 7 for each in this game (http://councilroom.com/game?game_id=game-20111005-112544-e04f1dfd.html). (Same problem here (http://councilroom.com/game?game_id=game-20110811-161156-218824a7.html), for another example; allfail's Fairgrounds are counted as 11.)
Title: Re: Bugs
Post by: Elyv on October 07, 2011, 10:03:43 am
Both those games seem fine to me. In the first one, you have 6*6+2*6+3+3*1+5*-1=36+12+3+3-5=49, and allfail has 5*12+6*1+3*2+2*1+1*2-1=60+6+6+2+2+1-1=76 points in the second one.
Title: Re: Bugs
Post by: DStu on October 07, 2011, 10:32:59 am
Both those games seem fine to me. In the first one, you have 6*6+2*6+3+3*1+5*-1=36+12+3+3-5=49, and allfail has 5*12+6*1+3*2+2*1+1*2-1=60+6+6+2+2+1-1=76 points in the second one.

Don't know if this it what mith meant, but in the first game, the mith's graph for score clearly exceeds 50, and in the code you have
Code: [Select]
"scores": {
        "Noquar": 43,
        "mith": 49
      },
      "label": "mith-turn-27"
    },
for the last turn, and
Code: [Select]
   "scores": {
        "Noquar": 43,
        "mith": 55
      },
      "label": "end-game"
    }
for game-end.

Edit: Also, in the second one there is an achievement for 55VP from Fairgrounds with 5 Fairgrounds á 10 VP, and again 81VP in the html-code instead of the 76 that is written in the beginning (of course also in the html...)
Title: Re: Bugs
Post by: Elyv on October 07, 2011, 10:37:41 am
Both those games seem fine to me. In the first one, you have 6*6+2*6+3+3*1+5*-1=36+12+3+3-5=49, and allfail has 5*12+6*1+3*2+2*1+1*2-1=60+6+6+2+2+1-1=76 points in the second one.

Don't know if this it what mith meant, but in the first game, the mith's graph for score clearly exceeds 50, and in the code you have
Code: [Select]
"scores": {
        "Noquar": 43,
        "mith": 49
      },
      "label": "mith-turn-27"
    },
for the last turn, and
Code: [Select]
   "scores": {
        "Noquar": 43,
        "mith": 55
      },
      "label": "end-game"
    }
for game-end.
Oh. I didn't look at the graphs at all, just at the scores at the top.
Title: Re: Bugs
Post by: mith on October 07, 2011, 10:51:02 am
Yeah, the scores at the top are from the isotropic log itself; this is just a councilroom bug.
Title: Re: Bugs
Post by: DStu on October 07, 2011, 10:57:43 am
Yeah, the scores at the top are from the isotropic log itself; this is just a councilroom bug.

But a rather strange one, as it calculates the score correctly as long as the game is running, and only after the game changes the value of the fairgrounds.
Title: Re: Bugs
Post by: Buggz on October 31, 2011, 02:54:14 pm
I did a search on my isotropic name and got my page, all fine. But then I tried using "search for another player" which leads to localhost:8080 instead of the proper domain. Small bug, but also a small fix. :)
Title: Re: Bugs
Post by: rrenaud on November 13, 2011, 03:58:27 pm
I guess the fairgrounds bug is fixed?