Dominion Strategy Forum

Dominion => Dominion Online at Shuffle iT => Dominion General Discussion => Goko Dominion Online => Topic started by: SCSN on November 08, 2015, 02:51:57 pm

Title: Be careful when installing Dominion Online
Post by: SCSN on November 08, 2015, 02:51:57 pm
From the MF forums (http://forum.makingfun.com/showthread.php?8138-WTF-Installer-removing-my-files!):

Quote from: Idan Zeierman;42147
Pardon my french, but really, WTF.

So, I've uninstalled the game and downloaded the new version (2.0.44.2) (speaking of which - when are you going to upgrade to the wonderful world of Automatic Updates?). It asked me for the install location. I wrote, as usual for the last few installs (really, when ARE you going to support automatic updates?) "D:\Games". It usually adds "\Dominion" to the path. I pressed "Enter", Next-Next-Next, and moved away from the computer.

I came back several minutes later to find the installer still hard at work. Wondering what's taking so long, I've checked the installer window, and saw that it was removing files at "D:\Games\Steam\...\left 4 dead 2\...". I clicked "Cancel" in panic.

The installer removed most of the contents of my D:\Games folder.


Putting aside the damage to my games (most of them support cloud saves, but I had several GOG games and several Steam games which simply do not) - seriously - how on earth do you abuse administrator privileges like that?! I'm now not only expected to manually upgrade after each small update - but also babysit to make sure I didn't write something wrong and end up removing the contents of my "Program Files" folder?!

The saddest thing is that I'm not even surprised.
Title: Re: Be careful when installing Dominion Online
Post by: Awaclus on November 08, 2015, 03:48:29 pm
Well, you should be careful when installing everything.
Title: Re: Be careful when installing Dominion Online
Post by: SCSN on November 08, 2015, 04:00:05 pm
Except when installing Dominion Online; it makes sure you no longer have to care about anything else.
Title: Re: Be careful when installing Dominion Online
Post by: DStu on November 08, 2015, 04:07:00 pm
rm -rf $STEAMROOT/*
Title: Re: Be careful when installing Dominion Online
Post by: Deadlock39 on November 08, 2015, 04:08:17 pm
hopefully no one accidentally points the Dominion Online installer at C:\Windows\System32
Title: Re: Be careful when installing Dominion Online
Post by: DStu on November 08, 2015, 04:09:35 pm
hopefully no one accidentally points the Dominion Online installer at C:\Windows\System32

or C:\
Title: Re: Be careful when installing Dominion Online
Post by: DG on November 08, 2015, 04:16:58 pm
I hope Steam don't see that. I doubt they want to list a game that deletes all their products.
Title: Re: Be careful when installing Dominion Online
Post by: Kirian on November 08, 2015, 04:32:17 pm
Holy shit.  That's just... holy shit man.
Title: Re: Be careful when installing Dominion Online
Post by: popsofctown on November 08, 2015, 05:20:38 pm
I don't know what to say..
Title: Re: Be careful when installing Dominion Online
Post by: Kirian on November 08, 2015, 05:49:08 pm
Seriously, who thought we'd be sad to see Goko die?
Title: Re: Be careful when installing Dominion Online
Post by: Accatitippi on November 08, 2015, 05:54:31 pm
That's definitely a very literal implementation of Mint.  :o

(this sucks badly)
Title: Re: Be careful when installing Dominion Online
Post by: Awaclus on November 08, 2015, 05:57:03 pm
That's definitely a very literal implementation of Mint.  :o

Why did you implement it that way then?
Title: Re: Be careful when installing Dominion Online
Post by: Accatitippi on November 08, 2015, 06:00:05 pm
That's definitely a very literal implementation of Mint.  :o

Why did you implement it that way then?

Oh, you know, I just wanted to delete the old version to give you the updated one, like, right into your hands, but then I got confused...
Title: Re: Be careful when installing Dominion Online
Post by: Cave-o-sapien on November 08, 2015, 06:34:19 pm
This is pretty awful.
Title: Re: Be careful when installing Dominion Online
Post by: popsofctown on November 08, 2015, 07:06:38 pm
They should at least shut off your ability to specificy the directory you want to install dominion to?
Title: Re: Be careful when installing Dominion Online
Post by: Davio on November 09, 2015, 05:46:21 am
The horror!

Oh man, I feel for you. I would feel terrible if my Broken Age save game was deleted, even if I'm only like 2 hours into act 2.
Title: Re: Be careful when installing Dominion Online
Post by: Accatitippi on November 09, 2015, 06:45:09 am
They should at least shut off your ability to specificy the directory you want to install dominion to?
Or maybe just check what they're deleting before they delete it?
Title: Re: Be careful when installing Dominion Online
Post by: Kirian on November 09, 2015, 11:47:13 am
They should at least shut off your ability to specificy the directory you want to install dominion to?
Or maybe just check what they're deleting before they delete it?

Or just... not delete things at all that aren't already Dominion files?
Title: Re: Be careful when installing Dominion Online
Post by: Accatitippi on November 09, 2015, 11:52:40 am
They should at least shut off your ability to specificy the directory you want to install dominion to?
Or maybe just check what they're deleting before they delete it?

Or just... not delete things at all that aren't already Dominion files?

That's what I said.  ;)
Title: Re: Be careful when installing Dominion Online
Post by: Cave-o-sapien on November 09, 2015, 11:56:23 am
From the MF forums (http://forum.makingfun.com/showthread.php?8138-WTF-Installer-removing-my-files!):

Quote from: Idan Zeierman;42147
Pardon my french, but really, WTF.

So, I've uninstalled the game and downloaded the new version (2.0.44.2) (speaking of which - when are you going to upgrade to the wonderful world of Automatic Updates?). It asked me for the install location. I wrote, as usual for the last few installs (really, when ARE you going to support automatic updates?) "D:\Games". It usually adds "\Dominion" to the path. I pressed "Enter", Next-Next-Next, and moved away from the computer.

I came back several minutes later to find the installer still hard at work. Wondering what's taking so long, I've checked the installer window, and saw that it was removing files at "D:\Games\Steam\...\left 4 dead 2\...". I clicked "Cancel" in panic.

The installer removed most of the contents of my D:\Games folder.


Putting aside the damage to my games (most of them support cloud saves, but I had several GOG games and several Steam games which simply do not) - seriously - how on earth do you abuse administrator privileges like that?! I'm now not only expected to manually upgrade after each small update - but also babysit to make sure I didn't write something wrong and end up removing the contents of my "Program Files" folder?!

The saddest thing is that I'm not even surprised.

I think the saddest thing is that there is no response yet from Making Fun.
Title: Re: Be careful when installing Dominion Online
Post by: Deadlock39 on November 09, 2015, 12:01:43 pm
Certainly an updater should overwrite updated files, and maybe delete files that were removed from the program in the update.  An Installer should just copy the files to the target.  Running 'rm -rf *' on the directory you are writing to first is just...
Title: Re: Be careful when installing Dominion Online
Post by: GendoIkari on November 09, 2015, 01:41:05 pm
Until now there was probably a 5-10% chance that I was going to someday install the new client to play a few games of Dominion once in a while. Now it's around .00001% chance. Not 0, because maybe someone will report a bug where upon installing, the installer transfers a bunch of money into your bank account by accident.
Title: Re: Be careful when installing Dominion Online
Post by: popsofctown on November 09, 2015, 01:53:24 pm
They should at least shut off your ability to specificy the directory you want to install dominion to?
Or maybe just check what they're deleting before they delete it?
Yeah.  My suggestion was even easier than that, though.  Trying to assume minimal ability from the devs.
Title: Re: Be careful when installing Dominion Online
Post by: GendoIkari on November 09, 2015, 01:54:01 pm
Also, I find it a bit funny now that some people expressed concern over installing unknown third party software like Salvager or MAKiNG MORE FUN because of possible unknown effects or damage to their system.
Title: Re: Be careful when installing Dominion Online
Post by: Mic Qsenoch on November 09, 2015, 01:56:05 pm
Also, I find it a bit funny now that some people expressed concern over installing unknown third party software like Salvager or MAKiNG MORE FUN because of possible unknown effects or damage to their system.

Well to be fair, SCSN just hasn't gotten around to revealing his nefarious plans yet. Just wait!
Title: Re: Be careful when installing Dominion Online
Post by: Witherweaver on November 09, 2015, 02:12:32 pm
Also, I find it a bit funny now that some people expressed concern over installing unknown third party software like Salvager or MAKiNG MORE FUN because of possible unknown effects or damage to their system.

Well to be fair, SCSN just hasn't gotten around to revealing his nefarious plans yet. Just wait!

MAKiNG MORE FUN goes through your all subdirectories of your root directory and replaces all directory and file names with a random-capitalized version. 
Title: Re: Be careful when installing Dominion Online
Post by: Cave-o-sapien on November 09, 2015, 02:41:12 pm
Also, I find it a bit funny now that some people expressed concern over installing unknown third party software like Salvager or MAKiNG MORE FUN because of possible unknown effects or damage to their system.

Well to be fair, SCSN just hasn't gotten around to revealing his nefarious plans yet. Just wait!

MAKiNG MORE FUN goes through your all subdirectories of your root directory and replaces all directory and file names with a random-capitalized version.

This is a great feature!
Title: Re: Be careful when installing Dominion Online
Post by: SCSN on November 09, 2015, 05:25:37 pm
Also, I find it a bit funny now that some people expressed concern over installing unknown third party software like Salvager or MAKiNG MORE FUN because of possible unknown effects or damage to their system.

Well to be fair, SCSN just hasn't gotten around to revealing his nefarious plans yet. Just wait!

Confession time: the whole Blitz thing is just a Trojan Horse to get Mic to install my kill switch. From soon onwards, whenever you play him all you have to do is type #killmic into the chat and the man will never win another game.

And the best part is that he'll think I'm joking and install it anyway.
Title: Re: Be careful when installing Dominion Online
Post by: Deadlock39 on November 09, 2015, 05:28:51 pm
#jedimindtrick you would like to resign now
Title: Re: Be careful when installing Dominion Online
Post by: Mic Qsenoch on November 09, 2015, 05:43:55 pm
Also, I find it a bit funny now that some people expressed concern over installing unknown third party software like Salvager or MAKiNG MORE FUN because of possible unknown effects or damage to their system.

Well to be fair, SCSN just hasn't gotten around to revealing his nefarious plans yet. Just wait!

Confession time: the whole Blitz thing is just a Trojan Horse to get Mic to install my kill switch. From soon onwards, whenever you play him all you have to do is type #killmic into the chat and the man will never win another game.

And the best part is that he'll think I'm joking and install it anyway.

I won't consider the mod feature complete until it literally kills me.
Title: Re: Be careful when installing Dominion Online
Post by: Roadrunner7671 on November 09, 2015, 09:01:45 pm
If Goko goes down, I'm going down with it.
😭🔫
Title: Re: Be careful when installing Dominion Online
Post by: XerxesPraelor on November 09, 2015, 11:42:28 pm
The developers' response: "As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones."

I am beginning to not take them very seriously.
Title: Re: Be careful when installing Dominion Online
Post by: Beyond Awesome on November 09, 2015, 11:44:31 pm
If Goko goes down, I'm going down with it.
😭🔫

Well, that has already happened.
Title: Re: Be careful when installing Dominion Online
Post by: Roadrunner7671 on November 09, 2015, 11:49:20 pm
If Goko goes down, I'm going down with it.
😭🔫

Well, that has already happened.
😲💥🔫
Title: Re: Be careful when installing Dominion Online
Post by: Cave-o-sapien on November 09, 2015, 11:54:32 pm
The developers' response: "As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones."

Where's the bang-head-against-wall emoticon?
Title: Re: Be careful when installing Dominion Online
Post by: Kirian on November 10, 2015, 12:18:42 am
The developers' response: "As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones."

I am beginning to not take them very seriously.

Beginning?
Title: Re: Be careful when installing Dominion Online
Post by: popsofctown on November 10, 2015, 12:22:40 am
The developers' response: "As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones."

I am beginning to not take them very seriously.
LOLOLOLOL

You have to laugh to keep from crying.

Title: Re: Be careful when installing Dominion Online
Post by: Kirian on November 10, 2015, 12:29:38 am
(http://static1.squarespace.com/static/4ea1868dd09aa9e3f329aa8d/t/5390d943e4b09656693eda0b/1402001749721/)
Title: Re: Be careful when installing Dominion Online
Post by: Donald X. on November 10, 2015, 12:32:25 am
The developers' response: "As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones."

I am beginning to not take them very seriously.
This is very misleading! What was actually posted was Travis saying:

Quote
I saw the dev response to Dave's urgent email, so I'll relay the message. From the devs:
As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones.
So, since you tried to put the file directly in the 'games' folder, it was working on cleaning everything out. I'm glad you caught it before any real damage was done. The team has disabled this clean-out "feature" in Unity. We'll have to see how that affects future updates. If only we had an automatic updater, right...? :P
By taking that one line out of context, you dodge the annoying reality of Travis acknowledging that this was an urgent problem, and a problem they're fixing.

Travis also quoted a line out of context. You don't know what the rest of what these "devs" had to say was. They were, after all, not talking to customers.

I mean really guys. Focus your anger on real things, not imagined detachment. We already knew they were deleting the files, and that quote doesn't say anything new or interesting.
Title: Re: Be careful when installing Dominion Online
Post by: Kirian on November 10, 2015, 12:40:40 am
The developers' response: "As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones."

I am beginning to not take them very seriously.
This is very misleading! What was actually posted was Travis saying:

Quote
I saw the dev response to Dave's urgent email, so I'll relay the message. From the devs:
As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones.
So, since you tried to put the file directly in the 'games' folder, it was working on cleaning everything out. I'm glad you caught it before any real damage was done. The team has disabled this clean-out "feature" in Unity. We'll have to see how that affects future updates. If only we had an automatic updater, right...? :P
By taking that one line out of context, you dodge the annoying reality of Travis acknowledging that this was an urgent problem, and a problem they're fixing.

Travis also quoted a line out of context. You don't know what the rest of what these "devs" had to say was. They were, after all, not talking to customers.

I mean really guys. Focus your anger on real things, not imagined detachment. We already knew they were deleting the files, and that quote doesn't say anything new or interesting.


Oh man, a retroactive -1 for XP.

I'm still not having much difficulty not taking MF seriously, though.
Title: Re: Be careful when installing Dominion Online
Post by: XerxesPraelor on November 10, 2015, 12:42:21 am
I'm not really sure that context shows him acknowledging it was a problem: the closest I can see is "I'm glad you caught it before any real damage was done." but that doesn't seem like a very explicit acknowledgment.

David's response below that one is definitely good though:

Quote
Jeff has addressed the automatic update in another thread. It's in his main list of priorities, though I don't know an exact date. And apologies for the stress and the fright of losing that much game data. They are making a change with this.
Title: Re: Be careful when installing Dominion Online
Post by: Titandrake on November 10, 2015, 06:04:08 am
I'm not really sure that context shows him acknowledging it was a problem: the closest I can see is "I'm glad you caught it before any real damage was done." but that doesn't seem like a very explicit acknowledgment.

In context, the dev is explaining why the installer acted the way it did, and emphasizes this is obviously super terrible and they're working on it. They aren't saying it explicitly, but it's definitely implied.

Out of context, the dev is stating what the installer does, with no hint that the dev knows why this might be a bad idea.
Title: Re: Be careful when installing Dominion Online
Post by: Cave-o-sapien on November 10, 2015, 01:13:04 pm
The developers' response: "As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones."

I am beginning to not take them very seriously.
This is very misleading! What was actually posted was Travis saying:

Quote
I saw the dev response to Dave's urgent email, so I'll relay the message. From the devs:
As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones.
So, since you tried to put the file directly in the 'games' folder, it was working on cleaning everything out. I'm glad you caught it before any real damage was done. The team has disabled this clean-out "feature" in Unity. We'll have to see how that affects future updates. If only we had an automatic updater, right...? :P
By taking that one line out of context, you dodge the annoying reality of Travis acknowledging that this was an urgent problem, and a problem they're fixing.

Travis also quoted a line out of context. You don't know what the rest of what these "devs" had to say was. They were, after all, not talking to customers.

I mean really guys. Focus your anger on real things, not imagined detachment. We already knew they were deleting the files, and that quote doesn't say anything new or interesting.

I actually went to the MF forum and read the full response before posting anything here. I don't feel like this quote was taken egregiously out of context.

While he didn't quote the MF Forum staff person, he quoted the developer in full. And I think the developer's response is pretty bad, not because of what it says, but what it doesn't say: it just restates the (obvious) problem. You're right that lack of developer context is bad here, but I guess that's on Travis as much as anyone here. He kinda throws the dev under the bus.

Anyway, here's the reproduced nested quotes:

Quote from: Travis (MF forum admin guy)
I saw the dev response to Dave's urgent email, so I'll relay the message. From the devs:
Quote from: Some Developer
As a way to ensure that the installation is a clean one the installer removes the contents of the install directory before writing the new ones.
So, since you tried to put the file directly in the 'games' folder, it was working on cleaning everything out. I'm glad you caught it before any real damage was done. The team has disabled this clean-out "feature" in Unity. We'll have to see how that affects future updates. If only we had an automatic updater, right...? :P