Dominion Strategy Forum

Please login or register.

Login with username, password and session length
Pages: 1 ... 7 8 [9] 10 11 ... 72  All

Author Topic: Goko Dominion Salvager Discussion  (Read 598640 times)

0 Members and 3 Guests are viewing this topic.

Jacob marley

  • Moneylender
  • ****
  • Offline Offline
  • Posts: 154
  • Shuffle iT Username: Jacob Marley
  • Respect: +139
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #200 on: June 23, 2013, 12:59:27 am »
0

Is there documentation somewhere all in one place?

Thanks
Logged

tempman

  • Pawn
  • **
  • Offline Offline
  • Posts: 1
  • Respect: +5
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #201 on: June 23, 2013, 12:40:33 pm »
+5

I just downloaded/installed the fire fox version from the first and post and noticed that the card randomizer was not recognizing Worker's Village or any variant I could think of.  I tried searching through the code and noticed that in one place it shows up in the code (line 767) it shows up as "workervillage" with no "s".  I edited this line to "workersvillage" and now it seems to work.
Logged

Rabid

  • Jester
  • *****
  • Offline Offline
  • Posts: 840
  • Shuffle iT Username: Rabid
  • Respect: +643
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #202 on: June 24, 2013, 08:19:32 am »
0

Version 13 released
What is new:
- fixed problem with staring pro ranked table at the session start
- added a 'ping' sound when a properly ranked player joins the table when using the auto kick mode

Sometimes, when returning home from a multiplayer lobby, the "user settings" link isn't there. I haven't been able to reliably duplicate it yet, so I'm not sure what exactly is causing it.
That I haven't seen. Is it disappearing from the DOM or it just invisible (you can check that with 'inspect element')?

Unsuitable custom avatars.
A player is using a naked picture as an avatar, would it be possible to remove it do you think? 
And if it is possible is this something we want to do?
Yeah, I spotted that when doing backup of my site, I think I will remove it and black list that guy if he does that again. This is exactly why many services do not have completely custom avatars option, you need a moderator then.
Looks like its time for a blacklist.
http://forum.dominionstrategy.com/index.php?topic=8163.msg248775#msg248775
Logged
Twitch
1 Day Cup #1:Ednever

ftl

  • Mountebank
  • *****
  • Offline Offline
  • Posts: 2056
  • Shuffle iT Username: ftl
  • Respect: +1345
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #203 on: June 24, 2013, 05:24:38 pm »
0

Yeah, looks like it's time to deal with that before Goko has to. It's only a matter of time before somebody reports "Goko is showing me porn!" on their official site instead of here, and if they set their minds to fixing that problem, that's not gonna end well for this extension.


Logged

LastFootnote

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7495
  • Shuffle iT Username: LastFootnote
  • Respect: +10721
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #204 on: June 26, 2013, 02:46:29 pm »
0

I just downloaded/installed the fire fox version from the first and post and noticed that the card randomizer was not recognizing Worker's Village or any variant I could think of.  I tried searching through the code and noticed that in one place it shows up in the code (line 767) it shows up as "workervillage" with no "s".  I edited this line to "workersvillage" and now it seems to work.

Could we get this fixed, please? When I randomize Prosperity sets, Worker's Village never shows up.

EDIT: For what it's worth, I've confirmed that Worker's Village is the only card with this issue.
« Last Edit: June 26, 2013, 02:58:35 pm by LastFootnote »
Logged

ragingduckd

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1059
  • Respect: +3527
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #205 on: June 26, 2013, 04:03:18 pm »
0

I just downloaded/installed the fire fox version from the first and post and noticed that the card randomizer was not recognizing Worker's Village or any variant I could think of.  I tried searching through the code and noticed that in one place it shows up in the code (line 767) it shows up as "workervillage" with no "s".  I edited this line to "workersvillage" and now it seems to work.

Could we get this fixed, please? When I randomize Prosperity sets, Worker's Village never shows up.

The polite way to echo an existing bug report is just to upvote it and wait. Adding information about the bug is always valuable, and bumping an old inactive issue is okay too, but this one's only three days old. I consider myself lucky if a small software company even answers my e-mail in three days.

I'm sure you don't really mean to tell nutki and michaeljb that they're doing a shitty job of fixing Goko for free, but I'd feel a little slighted in their shoes.

PS: The fix that tempman suggests is actually quite easy to implement yourself. In Firefox, just click the GreaseMonkey icon, "Manage User Scripts," "Preferences" for the Log Viewer extension, and "Edit this User Script." Then just change line 767 as he describes.

Edit: This post came out pretty nasty-sounding. That really wasn't my intention. LF is a very polite fellow, and I didn't/don't mean to criticize him personally at all. I really only wanted to make a point of etiquette for the sake of the sanity of nutki and michaeljb and ok, maybe myself too.
« Last Edit: June 29, 2013, 12:08:02 am by ragingduckd »
Logged
Salvager Extension | Isotropish Leaderboard | Game Data | Log Search & other toys | Salvager Bug Reports

Salvager not working for me at all today. ... Please help! I can't go back to playing without it like an animal!

michaeljb

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1422
  • Shuffle iT Username: michaeljb
  • Respect: +2113
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #206 on: June 26, 2013, 04:17:06 pm »
+14

Version 1.15.3
- fix the Worker's Village bug
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

Always stacking is something I've wanted pretty much since Goko had stacking for big hands, and last night I stumbled upon the way to do it. so yay.

- published in the Chrome store
- Safari download from my github is updated
- My firefox-new branch is updated
« Last Edit: June 26, 2013, 04:27:14 pm by michaeljb »
Logged
🚂 Give 18xx games a chance 🚂

jonts26

  • Margrave
  • *****
  • Offline Offline
  • Posts: 2746
  • Shuffle iT Username: jonts
  • Respect: +3668
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #207 on: June 26, 2013, 04:18:09 pm »
+2

- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

This makes me happier than you can possibly imagine.
Logged

michaeljb

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1422
  • Shuffle iT Username: michaeljb
  • Respect: +2113
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #208 on: June 26, 2013, 04:20:57 pm »
+1

- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

This makes me happier than you can possibly imagine.

Well, at least I know it was happy enough to give me my 1000th respect ;D
Logged
🚂 Give 18xx games a chance 🚂

LastFootnote

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7495
  • Shuffle iT Username: LastFootnote
  • Respect: +10721
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #209 on: June 26, 2013, 04:29:34 pm »
+1

I just downloaded/installed the fire fox version from the first and post and noticed that the card randomizer was not recognizing Worker's Village or any variant I could think of.  I tried searching through the code and noticed that in one place it shows up in the code (line 767) it shows up as "workervillage" with no "s".  I edited this line to "workersvillage" and now it seems to work.

Could we get this fixed, please? When I randomize Prosperity sets, Worker's Village never shows up.

The polite way to echo an existing bug report is just to upvote it and wait. Adding information about the bug is always valuable, and bumping an old inactive issue is okay too, but this one's only three days old. I consider myself lucky if a small software company even answers my e-mail in three days.

I'm sure you don't really mean to tell nutki and michaeljb that they're doing a shitty job of fixing Goko for free, but I'd feel a little slighted in their shoes.

PS: The fix that tempman suggests is actually quite easy to implement yourself. In Firefox, just click the GreaseMonkey icon, "Manage User Scripts," "Preferences" for the Log Viewer extension, and "Edit this User Script." Then just change line 767 as he describes.

Yes, this is a very good call. I didn't mean to be rude but I certainly could have phrased it more politely. I did upvote the post with the bug report, but for some strange reason known not even to me I thought it might have slipped through the cracks. Sorry for coming off as a jerk, guys!

Thanks for fixing the bug, michaeljb, and thanks again to you and Nutki for this most excellent extension!

EDIT: Oh, and I did try to fix the Chrome version myself (which is what I use), but although I managed to download the .crx file (which was itself not trivial), my Mac was unable to successfully unpack it with any of my currently installed software. I'm guessing some of the frustration I felt from that inadvertently made my post sound nastier than I meant it.
« Last Edit: June 26, 2013, 04:32:27 pm by LastFootnote »
Logged

Voltaire

  • Jester
  • *****
  • Offline Offline
  • Posts: 957
  • flavor text
  • Respect: +1097
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #210 on: June 26, 2013, 04:33:15 pm »
0

Version 1.15.3
- fix the Worker's Village bug
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

Always stacking is something I've wanted pretty much since Goko had stacking for big hands, and last night I stumbled upon the way to do it. so yay.

- published in the Chrome store
- Safari download from my github is updated
- My firefox-new branch is updated
Very silly question - how do I update the firefox extension?
Logged

LastFootnote

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7495
  • Shuffle iT Username: LastFootnote
  • Respect: +10721
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #211 on: June 26, 2013, 04:35:21 pm »
0

- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

Wow, that's awesome! I don't think I'll be using it myself, but that's a sweet feature to have available.
Logged

michaeljb

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1422
  • Shuffle iT Username: michaeljb
  • Respect: +2113
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #212 on: June 26, 2013, 04:37:27 pm »
0

I...don't know. If I understand it correctly, whenever nutki updates the script at his github page, it will auto-update for everyone using the script with Grease Monkey.

If you manually download the script for Firefox from my github page, there might be a way to use that instead. I don't know though.
Logged
🚂 Give 18xx games a chance 🚂

Voltaire

  • Jester
  • *****
  • Offline Offline
  • Posts: 957
  • flavor text
  • Respect: +1097
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #213 on: June 26, 2013, 04:38:39 pm »
0

I...don't know. If I understand it correctly, whenever nutki updates the script at his github page, it will auto-update for everyone using the script with Grease Monkey.
OK, cool...guess I'll just see if the option to stack cards shows up.  :)
Logged

michaeljb

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1422
  • Shuffle iT Username: michaeljb
  • Respect: +2113
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #214 on: June 26, 2013, 04:40:47 pm »
0

If you host an unrated game with a rating requirement, then even people above that rating get kicked.

Dominion Online User Extension 1.15.1
Chrome 27.0.1453.116
Mac OSX 10.8.4

Seems I overlooked this. Is it still happening?
Logged
🚂 Give 18xx games a chance 🚂

ragingduckd

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1059
  • Respect: +3527
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #215 on: June 26, 2013, 05:08:53 pm »
0

If you host an unrated game with a rating requirement, then even people above that rating get kicked.

Dominion Online User Extension 1.15.1
Chrome 27.0.1453.116
Mac OSX 10.8.4

Seems I overlooked this. Is it still happening?

Yes, but I just discovered why it's happening. I usually use the rating criterion for pro games, but when the game is unrated the extension is using the casual rating instead. So it's not really a bug, just not the behavior I had expected.

Very silly question - how do I update the firefox extension?
If you manually download the script for Firefox from my github page, there might be a way to use that instead. I don't know though.

The easy-but-inelegant solution is to copy/paste the script michaeljb linked over the existing nutki script. Greasemonkey Icon -> Manage -> Preferences -> Edit opens up the currently installed version of nutki's script, so just replace that code with michaeljb's.
Logged
Salvager Extension | Isotropish Leaderboard | Game Data | Log Search & other toys | Salvager Bug Reports

Salvager not working for me at all today. ... Please help! I can't go back to playing without it like an animal!

Kirian

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7096
  • Shuffle iT Username: Kirian
  • An Unbalanced Equation
  • Respect: +9411
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #216 on: June 26, 2013, 05:16:17 pm »
+1

- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

This makes me happier than you can possibly imagine.

I just want to echo this sentiment.  Good job!

Goko Dominion, brought to you by nutki and michaeljb.
Logged
Kirian's Law of f.DS jokes:  Any sufficiently unexplained joke is indistinguishable from serious conversation.

Obi Wan Bonogi

  • Apprentice
  • *****
  • Offline Offline
  • Posts: 254
  • Respect: +344
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #217 on: June 26, 2013, 05:58:03 pm »
0

Ah, I got the script right when I bought the cards I didn't realize the extension was making the noise when someone joins my game.  Is there any way I can adjust the volume of the notification? (other than lowering the volume on my browser preferably) 
Logged

sudgy

  • Cartographer
  • *****
  • Offline Offline
  • Posts: 3431
  • Shuffle iT Username: sudgy
  • It's pronounced "SOO-jee"
  • Respect: +2706
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #218 on: June 26, 2013, 07:01:42 pm »
0

I know this might not be possible, but is there any way to fix the issue of when you have too many unique cards in hand?  You can't tell what cards are what, and if someone chats you can't close the chat window.
Logged
If you're wondering what my avatar is, watch this.

Check out my logic puzzle blog!

   Quote from: sudgy on June 31, 2011, 11:47:46 pm

Schneau

  • Saboteur
  • *****
  • Offline Offline
  • Posts: 1174
  • Shuffle iT Username: Schneau
  • Respect: +1461
    • View Profile
    • Rainwave
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #219 on: June 26, 2013, 08:31:52 pm »
+1

- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

This is awesome.

Would it be possible to also sort the cards? Something like Actions always on right, Treasures next, and Victories (and Curses and Reaction-Shelters) on left? If not, no biggie, but it would definitely make things easier.
Logged

florrat

  • Minion
  • *****
  • Offline Offline
  • Posts: 542
  • Shuffle iT Username: florrat
  • Respect: +748
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #220 on: June 27, 2013, 09:35:13 am »
0

I'd love to see a option enabling the Victory Point Tracker when playing against bots. Just like the option that the VP tracker is enabled when playing adventures.

The option to always stack cards in your hand is very nice!
Logged

() | (_) ^/

  • Minion
  • *****
  • Offline Offline
  • Posts: 632
  • Shuffle iT Username: p4ddy0d00rs
  • Nemo dat quod non habet.
  • Respect: +526
    • View Profile
    • BGG profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #221 on: June 27, 2013, 09:41:27 am »
0

I'd love to see a option enabling the Victory Point Tracker when playing against bots. Just like the option that the VP tracker is enabled when playing adventures.

The option to always stack cards in your hand is very nice!

Create a new multiplayer game and add a bot, that works.
Logged

michaeljb

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1422
  • Shuffle iT Username: michaeljb
  • Respect: +2113
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #222 on: June 28, 2013, 04:56:34 am »
+4

Technical Update

My branches were an ugly mess, and I believe I have improved the situation :)

My master branch now includes nutki's two scripts, plus a Rakefile and directories with files needed specifically for Chrome and Safari. Rake tasks generate the .zip to publish in the Chrome store and the .safariextz to install in Safari (since there was an issue for some with loading the set_parser externally, the rake tasks take care of inserting the contents of set_parser.js into the main script). There is also a task to turn the base directory into an "unpacked extension" for development in Chrome.

The develop branch includes features that I've worked on myself; at this point, the blacklist, the Worker's Village fix, and the stacking option. I haven't updated the extension in the Chrome store, since it is still functionally the same.

« Last Edit: June 28, 2013, 05:00:09 am by michaeljb »
Logged
🚂 Give 18xx games a chance 🚂

D Bo

  • Conspirator
  • ****
  • Offline Offline
  • Posts: 213
  • Respect: +93
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #223 on: June 28, 2013, 02:59:13 pm »
+1

Sorry if this is mentioned elsewhere, but I didn't see it. Most times when I'm playing a bot and go to turn on the VP counter it tells me that it's locked. But this doesn't happen every time and I don't remember it happening when I first got the extension. Is there something I'm doing wrong? I'm using Chrome - let me know if you need more details.

Really appreciate all the work that you guys have put into this!
Logged

michaeljb

  • Board Moderator
  • *
  • Offline Offline
  • Posts: 1422
  • Shuffle iT Username: michaeljb
  • Respect: +2113
    • View Profile
Re: Dominion Online User Extension for Firefox and Chrome
« Reply #224 on: June 28, 2013, 03:04:55 pm »
+1

The vp setting gets locked around turn 5 (on turn 5/after turn 5, I don't remember for sure). This prevents someone from starting a game without the point counter turned on, then turning it on late at a crucial moment when their opponent might have wanted the counter off for the whole game.

This was an issue for players who prefer #vpoff, but didn't always type it in, so at the start of the game it seemed like it was going to be a no point counter game.

I can look into lifting the restriction if all the opponents in the game are bots.
Logged
🚂 Give 18xx games a chance 🚂
Pages: 1 ... 7 8 [9] 10 11 ... 72  All
 

Page created in 0.072 seconds with 22 queries.