Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[rrenaud]

Thanks for the excellent bug report.

This commit is for you

https://github.com/rrenaud/dominionstats/commit/b9ed2dfcdfbb3905fae0b2b8dac47d0cf2d8af5d

I also fixed the spaces between commas problem.

[Razzishi]

I think the reason your previous code didn't work is because there's discrepancies between how the cards are numbered and actual alphabetical order.  Asking for conditionals for the set of all cards that give 0 or more actions (ie, all cards), shows a list that is somewhat alphabetical but there are differences and they're somewhat related to where there were issues before.  If there was an implicit assumption that the cards were numbered in alphabetical order, that would explain it.

If you get over 1000 results, it will be trimmed and "NaN" will appear in the "Delta Qual" column for all rows.

[rrenaud]

I could definitely see >1k results screwing things up.  The server won't send back more than 1k stat objects, and then the client side quality delta code breaks.  Do you have any more concrete examples of the card combo stuff being broken?

[theory]

I am a little confused by some of these results, but I can't tell if I'm just missing out on some awesome synergies here: Tournament and Sea Hag best with Pirate Ship?

Come to think of it, I can explain this.  Pirate Ship happens to be really high because whoever buys Pirate Ship loses extra hard against someone going Tournament/Sea Hag.  So that basically means, Tournament works best w/ Pirate Ship only because a bunch of bad people go Pirate Ship and they were going to lose anyway.  Maybe this is also why most of the Villages tend to show up on top of the delta Quality ratings column.

I wonder if there is some way to filter this out in the Quality ratings.

[rrenaud]

I thought about the "bad play" confounding problem in the data.

I guess there are two approaches:

Do skill normalization, so losses by the weak players count less.  This should offset the problem a bit, but not totally eliminate it.

Do a level based filtering, and hope (not a strategy!) good players don't screw up that badly, polluting the data.

[^_^_^_^]

Skill normalization gets my vote. More accurate the better!

[Insomniac]

What about only using delta from the same deck IE The guy who wins with tournament probably didnt have a pirate ship in his deck and thus pirate ship doesnt get a boost from the tournament player winning with pirate ship on board?

[rrenaud]

The deltas are just differences in quality.

I guess what you really want is conditions to be not based on the supply, but rather based on co-occurrence inside a single deck?

[ecq]

The deltas are just differences in quality.

I guess what you really want is conditions to be not based on the supply, but rather based on co-occurrence inside a single deck?

I'd really like this.  Given two cards, A and B available in a kingdom, how have players historically fared buying both, just one, or neither?  If there's enough data, it'd be nice to be able to see it broken down by opponent purchases, too.  So, buying A against an opponent who buys B, or buying A + B against an opponent who buys only A.

It seems like that alleviates the confusing results theory mentioned before.  Just now I was looking for interactions between Philosopher's Stone and Ill-Gotten Gains.  The delta is near-0, but I realized that doesn't mean much because people rarely gain P. Stone when it's available.

[Insomniac]

The deltas are just differences in quality.

I guess what you really want is conditions to be not based on the supply, but rather based on co-occurrence inside a single deck?

I'd really like this.  Given two cards, A and B available in a kingdom, how have players historically fared buying both, just one, or neither?  If there's enough data, it'd be nice to be able to see it broken down by opponent purchases, too.  So, buying A against an opponent who buys B, or buying A + B against an opponent who buys only A.

It seems like that alleviates the confusing results theory mentioned before.  Just now I was looking for interactions between Philosopher's Stone and Ill-Gotten Gains.  The delta is near-0, but I realized that doesn't mean much because people rarely gain P. Stone when it's available.

rrenaud: Yea that'd be pretty sweet. Sorry I didn't see your reply sooner

ecq:  I do also like the Opponent purchase idea too but could see that making some difficulties in the back end