Dominion Strategy Forum

Please login or register.

Login with username, password and session length
Pages: 1 ... 5 6 [7] 8  All

Author Topic: Chrome Extension for f.ds!  (Read 28831 times)

0 Members and 1 Guest are viewing this topic.

vishwathg

  • Salvager
  • ****
  • Offline Offline
  • Posts: 68
  • Respect: +86
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #150 on: October 24, 2018, 03:00:39 pm »
0

Everything autolinks except the boons (possibly only the boons where the "The" is dropped)

The Mountain's Gift
the Mountain's Gift
Mountain's Gift

Only the first one autolinks...and it apparently tries to autolink to a page called "The The Mountain's Gift."

The issue with the double-The is indeed a bug; I should have that fixed hopefully later today. Thanks for finding it!

But I have no idea why the other ones aren't working for you. Do me a favor and go to http://pittersplace.com/dominion/cardlist.txt (that's the page that lists everything it tries to autolink). If you scroll to the very bottom, do you see "Mountain's Gift" (with no "the"), etc?

I see them, but there seems to be an unindented block before it. Maybe that's causing the problem? I updated to 1.26 and the double-the issue seems to be fixed but I don't see the other autolinks.

I see that... it shouldn't be causing any issues, but I updated the list to fix it anyway.

I wonder if this is a localization thing... what country are you in; is your browser set to show things in a language other than English? Could also possibly be a line-ending encoding thing; are you on Linux or Mac by any chance?

English, Windows 10 and a chromebook. Doesn't work on either.
Logged

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #151 on: October 24, 2018, 03:48:49 pm »
0

Everything autolinks except the boons (possibly only the boons where the "The" is dropped)

The Mountain's Gift
the Mountain's Gift
Mountain's Gift

Only the first one autolinks...and it apparently tries to autolink to a page called "The The Mountain's Gift."

The issue with the double-The is indeed a bug; I should have that fixed hopefully later today. Thanks for finding it!

But I have no idea why the other ones aren't working for you. Do me a favor and go to http://pittersplace.com/dominion/cardlist.txt (that's the page that lists everything it tries to autolink). If you scroll to the very bottom, do you see "Mountain's Gift" (with no "the"), etc?

I see them, but there seems to be an unindented block before it. Maybe that's causing the problem? I updated to 1.26 and the double-the issue seems to be fixed but I don't see the other autolinks.

I see that... it shouldn't be causing any issues, but I updated the list to fix it anyway.

I wonder if this is a localization thing... what country are you in; is your browser set to show things in a language other than English? Could also possibly be a line-ending encoding thing; are you on Linux or Mac by any chance?

English, Windows 10 and a chromebook. Doesn't work on either.

Can you open the console (hitting F12) and see if there are any errors shown? To make sure this page has stuff to check:

Mountain's Gift
The Mountain's Gift

Also would be good to know if the other "shortcuts" are working:

IGG, Farmer's Market, JoaT, CotR, Inherited
« Last Edit: October 24, 2018, 03:52:50 pm by GendoIkari »
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #152 on: November 01, 2018, 12:41:18 pm »
0

Any update, vishwathg?

I'm going to add BoM to the shortcut list. Also, Ill-Gotten Gains currently is messed up, though IGG works. Will hopefully fix soon.
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

vishwathg

  • Salvager
  • ****
  • Offline Offline
  • Posts: 68
  • Respect: +86
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #153 on: November 01, 2018, 01:37:22 pm »
+1

Oh, sorry. Everything works perfectly. Thanks!
Logged

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #154 on: November 05, 2018, 04:45:07 pm »
0

Version 1.27 posted. Fixes the Ill-Gotten Gains link, and adds BoM to the shortcuts for autolink.
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

LibraryAdventurer

  • Saboteur
  • *****
  • Offline Offline
  • Posts: 1177
  • Shuffle iT Username: LibraryAdventurer
  • Respect: +903
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #155 on: November 05, 2018, 11:41:42 pm »
0

I just noticed that pluralized card names don't autolink (as in Grand Market but not Grand Markets). Why?
I still think lowercase card names should autolink too.

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #156 on: November 06, 2018, 09:24:29 am »
0

There was a time that both of those would have worked; but plural was changed a long time ago, and capitalization was changed recently. Both because there were far too many false positives. People didn't like "haven't" auto linking, for example.

Fixed the Dave Goldthorpe / LibraryAdventurer issue by using \b word matches (their names were showing up as cards). I tried matching case-insensitive, but it was bad; way too many false positives. Version 1.13 is published. Thanks again Deadlock!

It might be possible to allow plurals to work without the Goldthorpe problem; if I just look for "s" specifically.
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

Asper

  • Governor
  • *****
  • Offline Offline
  • Posts: 4795
  • Respect: +5119
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #157 on: November 06, 2018, 09:38:06 am »
+3

I demand "Pot" to autolink to either the Wikipedia page on cannabis, or a Rickrolling video.

chipperMDW

  • Apprentice
  • *****
  • Offline Offline
  • Posts: 259
  • Respect: +558
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #158 on: November 06, 2018, 09:48:17 am »
0

It might be possible to allow plurals to work without the Goldthorpe problem; if I just look for "s" specifically.

What's a Goldthorpe problem? Did you mean Scunthorpe problem? ('Cuz there's an easy way to remember how to spell that.)
Logged

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #159 on: November 06, 2018, 09:57:35 am »
+1

It might be possible to allow plurals to work without the Goldthorpe problem; if I just look for "s" specifically.

What's a Goldthorpe problem? Did you mean Scunthorpe problem? ('Cuz there's an easy way to remember how to spell that.)

The Goldthorpe problem was that the first half of that guy's name was getting autolinked to Gold, and it was annoying. I don't remember who he was; but people were posting about him back then.
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

chipperMDW

  • Apprentice
  • *****
  • Offline Offline
  • Posts: 259
  • Respect: +558
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #160 on: November 06, 2018, 10:24:03 am »
+1

It might be possible to allow plurals to work without the Goldthorpe problem; if I just look for "s" specifically.

What's a Goldthorpe problem? Did you mean Scunthorpe problem? ('Cuz there's an easy way to remember how to spell that.)

The Goldthorpe problem was that the first half of that guy's name was getting autolinked to Gold, and it was annoying. I don't remember who he was; but people were posting about him back then.

Oh, wow. I was going to guess that was a made-up name referencing the Scunthorpe Problem in a Dominion-specific context, but there's actually a playtester for Nocturne (mentioned in the secret history but not the credits) named David Goldthorpe. That's a little bit hilarious.
Logged

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #161 on: November 06, 2018, 10:28:34 am »
+1

I think I've fixed it, need to use this space to do some tests before I deploy.

Random card name time: Gold! Plural cards like Silvers and stuff too. Goldthorpe. Bold cards like Moat. Haven't seen an issue yet. . Buying lots of Raids could be a thing.

Non-autolink stuff: Moat, Gold, Capitalism.






Shortcuts: IGG, CotR, BoM. some people annoyingly write "Farmer's Market". It's "Farmers' Market", get it right!

Capitalism makes Inherited Estates also count as Treasures sometimes. Woah.

Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #162 on: November 06, 2018, 10:39:42 am »
+2

Version 1.28 published. Plurals work now. Also fixed "Haven't" (annoyingly, by specifically looking for that word and excluding it).
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

LibraryAdventurer

  • Saboteur
  • *****
  • Offline Offline
  • Posts: 1177
  • Shuffle iT Username: LibraryAdventurer
  • Respect: +903
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #163 on: November 06, 2018, 07:18:07 pm »
0

I want my name to link to the cards!  That was never a problem for me (can't speak for Goldthorpe).
« Last Edit: November 06, 2018, 07:20:03 pm by LibraryAdventurer »
Logged

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #164 on: November 06, 2018, 07:21:28 pm »
+1

I want my name to link to the cards!  That was never a problem.

I know, I know... and it wasn't a problem for your username. The problem was for other common words and names. False positives make the forum harder to read. Actually, I can't remember how it worked back when your username did auto-link... was not possible to click on your name to get to your user profile? That seems like an issue in general.

I mean, a possibly good solution would be to treat a capital letter as the start of a new word; so "LibraryAdventurer"  would act like 2 separate autolinked words, but "Libraryadventurer" wouldn't. But that's a lot of work for basically just this one specific use case.
« Last Edit: November 06, 2018, 07:22:37 pm by GendoIkari »
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #165 on: November 06, 2018, 07:29:03 pm »
0

I wonder if the stuff I have to make it not break when card names are used inside links makes card names not work when they just happen to be between brackets... So like if I wanted to say that Duchy < Province, but Colony > Province...

*Edit* Apparently it still works, though I don't know why, lol.

*Edit2* Ah, the < and > are html encoded to show up properly; of course.
« Last Edit: November 06, 2018, 07:38:32 pm by GendoIkari »
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

LibraryAdventurer

  • Saboteur
  • *****
  • Offline Offline
  • Posts: 1177
  • Shuffle iT Username: LibraryAdventurer
  • Respect: +903
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #166 on: November 06, 2018, 07:31:23 pm »
0

I want my name to link to the cards!  That was never a problem.

I know, I know... and it wasn't a problem for your username. The problem was for other common words and names. False positives make the forum harder to read. Actually, I can't remember how it worked back when your username did auto-link... was not possible to click on your name to get to your user profile? That seems like an issue in general.
I don't remember.

I mean, a possibly good solution would be to treat a capital letter as the start of a new word; so "LibraryAdventurer"  would act like 2 separate autolinked words, but "Libraryadventurer" wouldn't. But that's a lot of work for basically just this one specific use case.
I'd only expect that kind of treatment if I donated to the cause, but I think I'd rather spend my money on ShIt.  (which I hope you don't take the wrong way...)

werothegreat

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 8079
  • Shuffle iT Username: werothegreat
  • Prepare to be boarded!
  • Respect: +9413
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #167 on: November 06, 2018, 10:01:54 pm »
+1

Capitalism makes Inherited Estates also count as Treasures sometimes. Woah.

An Inherited Capitalized Caravan Guard is an Action-Duration-Reaction-Treasure-Victory.  Seprix made a custom banner template for it, and a few other combinations.
Logged
Contrary to popular belief, I do not run the wiki all on my own.  There are plenty of other people who are actively editing.  Go bother them!

Check out this fantasy epic adventure novel I wrote, the Broken Globe!  http://www.amazon.com/Broken-Globe-Tyr-Chronicles-Book-ebook/dp/B00LR1SZAS/

sudgy

  • Cartographer
  • *****
  • Offline Offline
  • Posts: 3321
  • Shuffle iT Username: sudgy
  • It's pronounced "SOO-jee"
  • Respect: +2560
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #168 on: December 10, 2018, 11:14:48 pm »
+5

A really stupid feature request: don't autolink      Moat       .  The joke is never funny when I see the card name before I look at the spoiler.

(in before everybody says "the joke was never funny")
Logged
If you're wondering what my avatar is, watch this.

Check out my logic puzzle blog!

   Quote from: sudgy on June 31, 2011, 11:47:46 pm

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #169 on: December 11, 2018, 01:49:40 pm »
0

Latest version will not autolink anything inside spoiler tags. Moat jokes or not; having hyperlinks under spoilers looks bad. So it won't show things like Page after the update.

Just to test some more stuff too:

I played a game with a bunch of secret cards such as Moat, Champion, and Donate.
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0

LittleFish

  • Alchemist
  • ***
  • Offline Offline
  • Posts: 38
  • Respect: +20
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #170 on: December 12, 2018, 07:53:03 am »
+1

What does the kingdom button do?
Logged

LittleFish

  • Alchemist
  • ***
  • Offline Offline
  • Posts: 38
  • Respect: +20
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #171 on: December 12, 2018, 07:56:01 am »
0

I'm just going to type something random to see what it does [kingdom]Moat[/kingdom]
Logged

LittleFish

  • Alchemist
  • ***
  • Offline Offline
  • Posts: 38
  • Respect: +20
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #172 on: December 12, 2018, 07:56:37 am »
0

It didn't work :'(
Logged

ThetaSigma12

  • Torturer
  • *****
  • Offline Offline
  • Posts: 1632
  • Shuffle iT Username: ThetaSigma12
  • Respect: +1706
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #173 on: December 12, 2018, 08:41:28 am »
0



I think it requires multiple cards.
Logged
If you have a fan card you want to be created, just post about it here! I'd love to take a look at it.

GendoIkari

  • Adventurer
  • ******
  • Offline Offline
  • Posts: 7369
  • Respect: +8190
    • View Profile
Re: Chrome Extension for f.ds!
« Reply #174 on: December 12, 2018, 10:57:58 am »
0

Right, Kingdom button is for generated images of an entire kingdom. You write out the card names, separated by a comma. Surround the whole thing with the [kingdom ] tag. It will turn all cards into images, with a newline after every 5 cards.

I don't see why it wouldn't work with just a single card... but using it on just one card should be the same as using the [card ] tag.



*Edit* Yes, you can use it on just one card... LittleFish; not sure why your post didn't seem to work....
« Last Edit: December 12, 2018, 10:59:11 am by GendoIkari »
Logged
Check out my F.DS extension for Chrome! Card links; Dominion icons, and maybe more! http://forum.dominionstrategy.com/index.php?topic=13363.0

Thread for Firefox version:
http://forum.dominionstrategy.com/index.php?topic=16305.0
Pages: 1 ... 5 6 [7] 8  All
 

Page created in 0.115 seconds with 22 queries.