Dominion Strategy Forum

Please login or register.

Login with username, password and session length

Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Shard of Honor

Filter to certain boards:

Pages: [1] 2 3 4
1
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: December 20, 2022, 03:56:14 am »
I think a bug was introduced in the most recent update. I noticed that the Traveller arrow is added whether or not traveller=true or false in the URL.
[...]
Notice that traveller=false in the URL yet the traveller renders. This happens every time you save a URL (so even if you uncheck it, which updates it to traveller=false, it will be true next time you load the same URL.) I suspect it's because the code checks for the existence of traveller query param but not whether it is true/false: https://github.com/shardofhonor/dominion-card-generator/commit/947d1ef24cf43dc47822861b605686309b8ada1d#diff-471eee65442e7559b8238612ee2d63fccce7757d0f9c4165ff6222ed82134ef5R1225

Thanks! Yes, that was the case. Fixed the issue.

2
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: December 13, 2022, 03:53:10 pm »
Basic Support for Traits is here. For example "Shy".

I'm not yet happy with the card resource images and the color, but at least it is working.
This is implemented using a new checkbox above the types, to switch on the Traits layout for landscape cards.
I did the same for the traveller arrow - so no need to include the actual type any more. But I kept that logic for backwards compatibility.

3
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: December 12, 2022, 01:16:09 pm »
The Shard of Honor fork seems to have broken for me. It's hard to describe what's going on, but all of the buttons, text fields, etc. are spaced super far apart and don't work, and no images are being loaded. I've tried deleting Cache and Cookies, but that didn't work.

New info edit: It works in other browsers besides Firefox. When I right-click and select "Inspect" on Firefox, I see a JS error that says
Quote
Uncaught ReferenceError: initCardImageGenerator is not defined
    initialize https://shardofhonor.github.io/dominion-card-generator/index.html:38
    <anonymous> https://shardofhonor.github.io/dominion-card-generator/index.html:45

    initialize https://shardofhonor.github.io/dominion-card-generator/index.html:38
    <anonymous> https://shardofhonor.github.io/dominion-card-generator/index.html:45

I just retried it in Firefox 107.0.1 and it did work fine.
You may want to delete not only the Cookies but also the Local Storage files of the site (attention: this also clears the favorites and any other stored settings).

4
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 09, 2022, 12:38:45 pm »
[...]
However, the font of cost or the numbers displayed on the icon are thinner than when I used it before. It seems that the fonts on the cards are loaded correctly, but only the weight of those letters is different. Repeated reloading and tried various things, but it was not going well.
[...]
The previous font is more similar to the original, so I would like to create using the bolder font. Is there a solution?
I am also having this issue with incorrect coin font on my Windows machine, regardless of browser (Firefox, Chrome, Internet Explorer), where I was not previously.  I have the Minion Pro font that is used officially.
I believe my Android phone loads the coin font correctly (maybe it is simply cached), but it does not load "Times New Roman" for the body text.
The problem with the first one is that currently the generator is using Minion Pro instead of Minion Std Black. Regarding the Times New Roman problem, that font is also a proprietary font, so in android is using another Sans Serif font

To tackle the ongoing font issues, I've added a feature today that allows changing the fonts used in the card.

Open the new font settings menu on the bottom left, type in the font name and the generator should prefer this font over the default font selection chain. Your font settings are remembered on your device. The entered font name has to be installed on your device locally with the exact same name.
On a computer, you can check available fonts in a text editor like Word or in the system settings. Android has system settings for fonts, too.

5
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 02, 2022, 01:54:30 am »
Does the card image generator start to fail to load when you have too many cards saved or something? I have around 30-40 saved I think and it's not loading for me. However, I used a different browser with no cards saved and it loaded fine.
You can try exporting your saved cards and then clearing all website data and cookies for the site.

6
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 02, 2022, 01:50:07 am »
Best I've been able to get so far at mimicking the Ally color.
Thank you very much! I've added the color directly to the dropdowns and also added support for the Favor keyword.
For example Plateau Shepherds do now work in the generator.

7
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: October 13, 2021, 12:16:21 pm »
Am I CRAZY?

 ??? Is the Name and Type text on this Times New Roman, and not the official Dominion Font?
 :o Its not happening anymore, but I exported this yesterday without noticing.
 ??? :o Its happening sometimes, do I just have to reload the generator?

It looks like one of the slightly different fallback-fonts, when loading the original font fails.
Normally reloading does the trick.



Random complaint: The Potion symbol for cost doesn't mix well with the overpay +.
It's a very specific interaction of course.

Never tried that corner case myself. Yeah, white text is hard to read there, but actually numbers on the potion icon always look weird.
If you really need things like multiple potion costs and overpay for them, I'd suggest you do that in the picture editing software of your choice.

8
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: September 23, 2021, 05:15:46 pm »
add a space between the number and the symbol
so, indeed it's better and thank for the tips but it's obviously still a bug...

As said before, I suggest using invisible characters to trick the generator. It's a hack, but it's working.

... you can trick the generator into thinking, that there is other text in the line by using invisible special characters like the non-breaking-space ...



Please tell me how to change the Russian font in the name and types? Can I make the font bold?

Also only two hacky solutions for now:
You can either use your browsers developer tools (F12), navigate to the style.css and there to the @font-face rule for TrajanPro. It first tries to load that from your local computer, where it says src: local("Trajan Pro Bold"). You can change that to any font name that you have installed and the next time the image is redrawn your browser should fetch that font from your local computer. Such changes are lost, when you refresh the webpage.
Alternatively, you can install any font on your computer with the name "Trajan Pro Bold", so it is used instead.

Is there a way to put an arrow on the traveller if I indicate the type in Russian?
Russian Page

Currently, there is no option to tick to have the traveller arrow, but I've added all current translations from the wiki as well as your translation. Russian should work now, too.

If you need to create a base card, the image is positioned incorrectly.
It is necessary to extend the picture vertically so that it is displayed correctly in the generator.

You've got your solution there  ;)

9
Variants and Fan Cards / Re: Dominion Card Image Generator v1.5
« on: April 29, 2021, 04:36:14 pm »
Has custom control over boldness ever been implemented? I've CTRL+F'd the thread and it has been suggested several times.
No, I have not implemented it.

Relatedly, I have never been able to affect any change in my text with the 'additional bolded keywords' feature
You can look at the example here:
Dumb example to showcase some of the new features

10
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: April 23, 2021, 01:00:33 pm »
Howdy !
As you'll probably notice; I had fun with the generator (it's verry cool, I'll probably never create all of my card without you, for the best and the worst) and that's when I nocie somthing: I haven't made a lot of progarmation but it seem like there is probably a litle differenc between the size of the textbox in the generator and the one in the actual game. An example with Royal Seal (I let you guess witch one is fan made)

Hi, thanks. Actually, the textbox is the same size, if you resize the images.
1st is remade with the generator, second the original from the wiki (only given a border), and last is yours - I like the seal  ;D
Arguably, there are some minor differences with coloring and font thickness, but it is quite similar.






If you try to have a card with multiple costs, even just and a , the type gets over-indented, as shown above.

so
it looks like it's centering the text on the bar where there isn't prices, set expansion symbols, etc;
A suggestion for fixing it is: when including a price, include a transparent spacer of equal width on the opposite side. It'll force font sizes a little smaller (boo) but will avoid the largely off-center issue (yay).

In the meantime, you can manually force centering by adding spaces to the card types.

Thanks. I've noted the issue. As long as it's not fixed, some spaces here and there always help to improve centering and spacing.  ;)

11
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 31, 2021, 04:06:18 pm »
Hi Folks, sorry for the issues.
The reason was indeed because of the cors-anywhere server I've used, which allows the generator to load and embed arbitrary resources from external websites, like the images and the fonts.
I have now set up my own server for this and it should run more reliably now.

Thanks to DunnoItAll for the temporary solution in the meantime!

Font issues are back again, and since the cors-anywhere server is no longer being used, DunnoItAll's temporary solution no longer fixes it.

Got the mail today from heroku, that the monthly free server capacity is used up. Tomorrow it should work again.
For the next month, I try to implement some improvements to reduce web-request and save server capacity so it lasts the whole month...

12
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: February 18, 2021, 04:34:36 pm »
Hi Folks, sorry for the issues.
The reason was indeed because of the cors-anywhere server I've used, which allows the generator to load and embed arbitrary resources from external websites, like the images and the fonts.
I have now set up my own server for this and it should run more reliably now.

Thanks to DunnoItAll for the temporary solution in the meantime!

13
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: February 05, 2021, 03:51:48 pm »
In lieu of account functionality, what do you think about adding an import / export functionality* for favorites? People would still have to manually do this, but it would effectively be like an account for which the user themselves manage storage.

* export clearly being easier to save all links to a text file; import would likely want some sort of validation

I've added a simple export/import functionality. It just takes the favorite-urls as they are out of the browsers local storage and stores them in a file.
I've skipped the validation part during import for now, so if you want to mess with it: everything stays on your own computer  ;D

14
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: January 30, 2021, 11:08:34 am »
Hi !
Since the last update, I've lost my favorites. Do you know if there is a way to regain them or if they are lost forever.

There is no account functionality behind it. Means if you delete your cookies an local browser storage, it is gone. Sorry.

15
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: December 11, 2020, 06:04:42 pm »
Depending on the security settings, modern browsers prevent direct inclusion and use of external link resources in websites.
I am using https://cors-anywhere.herokuapp.com/ to overcome this and prevent a tainted canvas. Unfortunately, this service was unavailable today but does work again.

Additionally, I've now added buttons for direct image usage. This allows to use local files within the generator. These images are never uploaded to any server and stay on your local computer.
But because of that, the limitations mentioned by Violet CLM apply: Bookmarking and sharing does not work in these cases, as the images are not included.

16
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: September 28, 2020, 10:44:56 am »
while we're tossing in feature requests, would it be possible to do a "swap colors" button? the number of times i've put the colors in in the wrong order has been... idk probably approaching triple digits now.

The button is there now  ;)
And sorry for the late reply. I'm currently not so active...

17
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: September 28, 2020, 08:57:08 am »
It would also be nice if there was a button that generates an URL of the generator with the changes you've made being preserved. This would be very useful for the Card Updating Contest that has began recently.
Bookmarking the URL should do the trick. Or copy and pasting it.
All settings are just appended to the URL as additional parameters. So if you open the link again, they are still there.
Using the same method, you can also build your own templates  ;)

18
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: July 20, 2020, 04:03:37 pm »
Could you please add an option to the Second Color drop down split?
I really like how the Werewolf and Ghost Town looks on other type combinations.

Great idea! Also useful for custom types. I've added it right away  ;)

19
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: April 17, 2020, 02:33:27 am »
I’m on mobile and can't read what to separate multiple keywords with in Shardofhonor's fork. What do I separate multiple keywords with?

Yeah, sorry - adjusting the generator for mobile devices is still on my list...

The additional keywords are separated by semicolon ;

20
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 25, 2020, 04:35:30 pm »
With the precedent of Snowy Village and Capitalism, I think it would be nice to be able to bold text in our cards, or at least make it so that +bonus is bold instead of just +[amount] bonus.

Good addition. Missed that while checking for new things in Menagerie.
Snowy Village is now supported, too.

21
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 20, 2020, 05:48:42 pm »
When making images for treasures, the amount is always so huge that it makes any text on the card tiny.
Then if I put + to make the coin smaller so the text will be a reasonable size, the plus sign looks like a minus sign.
Can this be fixed?

This has been bugging me too. It's not that big of a deal, but it does break the similarity between made-up cards and official ones. You need to put a space between the '+' and for it to appear small. If the space isn't present, then the will turn into its huge variant. But it shouldn't be that way, imo.

Another issue is how bolded words (such as "+1 Card") will automatically make following punctuation bold as well. This includes ',', '.', ';', ':' and other symbols. For instance, writing "Choose one: +1 Card; or +1 Action." will both put the semicolon and the period in bold font, as demonstrated here. It'd be great if they could be in normal font instead, just like official cards are.

Anyway, these small fixes would be greatly appreciated!

The issue about punctuation should now be solved.

The + is not that easy to fix, unfortunately. There is a little bit more complicated regex involved. I'll try again, when I've got more time...

could you change it so when there's a zero width space following the +$\d+ it does the small version? should be the easiest, most invisible version of this tweak.

I hope I've fixed it now and haven't introduced any new bugs.
Programmed the rule +<icon><number> manually to not be drawn bigger. Spaces might still be needed to fix alignment.
Imitation of Market

22
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 19, 2020, 06:28:57 pm »
When making images for treasures, the amount is always so huge that it makes any text on the card tiny.
Then if I put + to make the coin smaller so the text will be a reasonable size, the plus sign looks like a minus sign.
Can this be fixed?

This has been bugging me too. It's not that big of a deal, but it does break the similarity between made-up cards and official ones. You need to put a space between the '+' and for it to appear small. If the space isn't present, then the will turn into its huge variant. But it shouldn't be that way, imo.

Another issue is how bolded words (such as "+1 Card") will automatically make following punctuation bold as well. This includes ',', '.', ';', ':' and other symbols. For instance, writing "Choose one: +1 Card; or +1 Action." will both put the semicolon and the period in bold font, as demonstrated here. It'd be great if they could be in normal font instead, just like official cards are.

Anyway, these small fixes would be greatly appreciated!

The issue about punctuation should now be solved.

The + is not that easy to fix, unfortunately. There is a little bit more complicated regex involved. I'll try again, when I've got more time...

23
Another nice trick is to set the min and max relative rating in the advanced options of a new table both to zero.
Friends can join your table regardless of their rating, but for random players it is very unlikely that they have exactly the same rating as you  ;)

24
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 05, 2020, 12:37:17 pm »
That's a rough match for the printed images, but I generally prefer the digital colors, since people are more accustomed to seeing those on screens and they're often more legible. Try this.

Much better. Thanks!

25
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: March 05, 2020, 12:04:39 pm »
Update: Added support for the color scheme of Ways. Example
(you might need to clear the website cache to get the changes)

Pages: [1] 2 3 4

Page created in 2.098 seconds with 19 queries.