1
Variants and Fan Cards / Re: Dominion Card Image Generator
« on: December 20, 2022, 03:56:14 am »I think a bug was introduced in the most recent update. I noticed that the Traveller arrow is added whether or not traveller=true or false in the URL.
[...]
Notice that traveller=false in the URL yet the traveller renders. This happens every time you save a URL (so even if you uncheck it, which updates it to traveller=false, it will be true next time you load the same URL.) I suspect it's because the code checks for the existence of traveller query param but not whether it is true/false: https://github.com/shardofhonor/dominion-card-generator/commit/947d1ef24cf43dc47822861b605686309b8ada1d#diff-471eee65442e7559b8238612ee2d63fccce7757d0f9c4165ff6222ed82134ef5R1225
Thanks! Yes, that was the case. Fixed the issue.