Dominion Strategy Forum

Meta => News and Announcements => Topic started by: theory on November 01, 2011, 09:24:36 pm

Title: Good post / Bad post mod installed
Post by: theory on November 01, 2011, 09:24:36 pm
The feature I (and most of you) have wanted the most has finally been installed.  You can now see how popular posts are, and how much "respect" people have.  Let me know about any bugs here.
Title: Re: Good post / Bad post mod installed
Post by: WallyNate on November 01, 2011, 09:28:38 pm
I really liked that "Theory has played remodel on the forum" message you put there while the forum was down :)
Title: Re: Good post / Bad post mod installed
Post by: Diving Pikachu on November 01, 2011, 09:54:11 pm
I've often had the urge to upvote things here like in Reddit, so it's nice to be able to leave feedback in such a manner, as comments of simple agreement usually don't add much to the discussion.
Title: Re: Good post / Bad post mod installed
Post by: theory on November 01, 2011, 10:09:55 pm
So there is indeed a problem with this: at the end of each page of posts, there's a big ugly chunk of inexplicable gray.  Moreover, everyone's signature and "post last edit" text is weirdly offset from the left.

I've spent quite a while working on this and can't figure it out.  If someone here who knows anything about web design and SimpleMachines Forums could give me a hand, I would appreciate it so so so much.

Here's my current Display.template.php: http://pastebin.com/s9baDE1P


And here's what it should be: http://www.phpkode.com/source/p/simple-machines-forum/Themes/core/Display.template.php
Title: Re: Good post / Bad post mod installed
Post by: jonts26 on November 01, 2011, 10:15:46 pm
Now I'm probably going to end up going through old posts and show some respect to the ones I like. So much for going to bed early.

Thanks Theory.  :P
Title: Re: Good post / Bad post mod installed
Post by: Jimmmmm on November 01, 2011, 10:23:32 pm
I see the Good Post button, is there supposed to be a Bad Post one as well? Not that I plan on using it much. :P Or are bad posts just supposed to stay on 0?
Title: Re: Good post / Bad post mod installed
Post by: danshep on November 02, 2011, 05:39:00 am
So there is indeed a problem with this: at the end of each page of posts, there's a big ugly chunk of inexplicable gray.  Moreover, everyone's signature and "post last edit" text is weirdly offset from the left.

I've spent quite a while working on this and can't figure it out.  If someone here who knows anything about web design and SimpleMachines Forums could give me a hand, I would appreciate it so so so much.

Here's my current Display.template.php: http://pastebin.com/s9baDE1P


And here's what it should be: http://www.phpkode.com/source/p/simple-machines-forum/Themes/core/Display.template.php

The problem is that there's unclosed divs on each post, so the browser doesn't know what's what.

I think the problem might be around line 478 - there should be a close div before the gpbp_enabled if statement (or perhaps after it, but I'm pretty sure before).
Title: Re: Good post / Bad post mod installed
Post by: theory on November 02, 2011, 07:36:43 am
I should hack the mod and give you +30 for that post.  You fixed it!
Title: Re: Good post / Bad post mod installed
Post by: theory on November 02, 2011, 07:37:16 am
I see the Good Post button, is there supposed to be a Bad Post one as well? Not that I plan on using it much. :P Or are bad posts just supposed to stay on 0?
I decided that in the interest of maintaining a more civil atmosphere to disable voting down.  If you have a real problem with a post, you can always report it.
Title: Re: Good post / Bad post mod installed
Post by: theory on November 02, 2011, 09:37:54 am
Gah, the day after I do all these manual hacks and changes to force this mod to install, I find out that this (http://custom.simplemachines.org/mods/index.php?mod=710) got updated to support SMF 2.0.1.

Now debating whether or not to switch over.
Title: Re: Good post / Bad post mod installed
Post by: Thisisnotasmile on November 11, 2011, 11:14:12 am
Is there any way to find out which of your posts have been given respect? I got one a few days ago and I though "cool, what did I get it for?". I had only made a few recent posts at that point so I checked them and found it. Now I've got another respect (check me out I have 2 COUNT THEM TWO respects) and I have no idea where it's come from =[

Edit: Obviously it's not vital that I know where it's come from. I'm just curious.
Title: Re: Good post / Bad post mod installed
Post by: theory on November 11, 2011, 11:20:25 am
Chalk it up to how terribly out of date this mod is.  The answer is no you cannot.  I can use the admin tools page to search, and tell you that the messages are this (http://forum.dominionstrategy.com/index.php?topic=929.msg14538#msg14538) and this (http://forum.dominionstrategy.com/index.php?topic=934.msg14369#msg14369), but this is clearly a feature that should be implemented but for whatever reason is not ...
Title: Re: Good post / Bad post mod installed
Post by: guided on November 11, 2011, 11:49:48 am
Yeah, you can't tell where your thumbs came from on BGG either (as far as I know?), which drives me a little batty :o
Title: Re: Good post / Bad post mod installed
Post by: Thisisnotasmile on November 11, 2011, 11:53:52 am
http://www.boardgamegeek.com/user/<yourusername>/contributions

About half way down on the right. You can click on the numbers for a list of all thumbs for contributions in that category, e.g. http://www.boardgamegeek.com/user/<yourusername>/thumbs/received/article
Title: Re: Good post / Bad post mod installed
Post by: guided on November 11, 2011, 12:05:23 pm
http://www.boardgamegeek.com/user/<yourusername>/contributions

About half way down on the right. You can click on the numbers for a list of all thumbs for contributions in that category, e.g. http://www.boardgamegeek.com/user/<yourusername>/thumbs/received/article
Haha, though I've seen this before I forgot about it, because it was never especially useful to me :) What I want is a chronological list.
Title: Re: Good post / Bad post mod installed
Post by: theory on November 11, 2011, 09:42:36 pm
Fixed some things, so now the arrow should be green when you've already voted on a post.