Dominion Strategy Forum

Dominion => Dominion Online at Shuffle iT => Dominion General Discussion => Goko Dominion Online => Topic started by: nutki on May 17, 2013, 04:40:40 am

Title: Goko Dominion Salvager Discussion
Post by: nutki on May 17, 2013, 04:40:40 am
Mod note: status of the extension will now be kept up to date in the Online Dominion Resources thread (http://forum.dominionstrategy.com/index.php?topic=9198.msg283465#msg283465). Continue to discuss it here. I now return you to your regularly scheduled OP.

----------

From now on I will keep the current state of the extension in this post. Please report any issues or ideas below.

Features:
Installation:
Title: Re: Dominion Online User Extension for Firefox and Chrome [sticky, please]
Post by: RTT on May 17, 2013, 05:28:05 am
Quote
Saving the name of the table of the previous game (normally it is changed to "X's game" each time you open the create game dialog, since version 6).
That is nice I thought goko finaly did that but hey its the script good work =).
One thing about it. It even saves the gamename of the game I previously joined and adds it to the game I create next. Is that intended?
Title: Re: Dominion Online User Extension for Firefox and Chrome [sticky, please]
Post by: nutki on May 17, 2013, 05:33:18 am
Quote
Saving the name of the table of the previous game (normally it is changed to "X's game" each time you open the create game dialog, since version 6).
That is nice I thought goko finaly did that but hey its the script good work =).
One thing about it. It even saves the gamename of the game I previously joined and adds it to the game I create next. Is that intended?
That is a bug in the original version of this feature (I realized this would happen soon after I published it). It is fixed in version 10.
Title: Re: Dominion Online User Extension for Firefox and Chrome [sticky, please]
Post by: florrat on May 18, 2013, 06:21:42 pm
This topic should really be stickied instead of the other (currently stickied) topic. Maybe you should PM theory (http://forum.dominionstrategy.com/index.php?action=profile;u=1)?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: heron on May 19, 2013, 01:32:20 pm
How do you see the score if you do not have the extension?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: hsiale on May 21, 2013, 04:24:58 am
Point tracking. Makes current victory points for each player visible throughout the game. To enable it you have to type '#vpon' in the chat window or include it in the table name. Any player, even not having the extension installed can force the tracking off by typing '#vpoff' in the chat or by including it in the table name. After this the tracking cannot be reenabled. (since version 5)
Could you also make including "#vpon" in table name start the game with point tracking on, of course possible to turn off in chat if the opponent chooses so?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lashof on May 21, 2013, 10:41:34 am
This is freakin' great!  What's the type of schedule where the chrome web store version will get updates?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: rrenaud on May 21, 2013, 10:54:17 am
Maybe someone else should take 1wheel's offer to maintain the chrome extension?  Or maybe nutki can email 1wheel when he has new versions.

See 1wheel's post here.

http://forum.dominionstrategy.com/index.php?topic=6788.msg234749#msg234749
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on May 21, 2013, 03:05:47 pm
How do you make a part of an avatar transparent?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on May 21, 2013, 03:23:35 pm
How do you make a part of an avatar transparent?
Transparent PNG Image layer.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on May 21, 2013, 03:40:22 pm
How do you make a part of an avatar transparent?
Transparent PNG Image layer.

And, how do I do that?

Also, the log has less than an inch to display itself.  I can't read it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on May 22, 2013, 02:26:14 am
Maybe someone else should take 1wheel's offer to maintain the chrome extension?  Or maybe nutki can email 1wheel when he has new versions.

See 1wheel's post here.

http://forum.dominionstrategy.com/index.php?topic=6788.msg234749#msg234749

Looks like it's been a while since he's been online.

Anyway, I've got nutki's script mostly working on Chrome. All the features except for the Kingdom Generator look like they're working, except possibly the score tracker. With a guest user in an incognito browser, the chat did not seem to work at all, so I couldn't test whether typing #vpoff in the chat would work, but it definitely works from the side with the extension installed.

I'm planning to break up the script into separate files for each feature, using RequireJS and a cool project I found specifically for making Chrome extensions with Require. While I haven't broken down the main script yet, I have added my own feature--in the player list on the right of the lobby, each player's pro rating will be listed instead of their casual rating, if they have one. If they haven't played any pro games, it will still display their casual rating, and I hope to fix that soon.

Eventually I'll try to make things configurable through an actual options page.

I'll get my version into the Chrome store before long, but until then there are manual installation instructions on github.

https://github.com/michaeljb/Dominion-Online-User-Extension
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on May 22, 2013, 03:49:29 am
Could you also add the option to auto-kick people from your games if they have a pro rating less than what's mentioned in the name of the game?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: qmech on May 22, 2013, 04:10:06 am
How do you make a part of an avatar transparent?
Transparent PNG Image layer.

And, how do I do that?

Also, the log has less than an inch to display itself.  I can't read it.

Any image editor above the Paint level should be able to handle transparency.  I like the GIMP (http://www.gimp.org/).

Are you on a 4:3 aspect ratio screen?  The extension allows the game to be full height then shifts it to the side and uses the spare room for the log, so as a workaround you could try reducing the height of your browser.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: kn1tt3r on May 22, 2013, 07:08:37 am
Could you please give a short explanation how to deactivate the Kingdom Generator extension (i.e. what lines to comment in the source code)?

I never use it (always play all random) and so I'd just like to avoid the popup window.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on May 22, 2013, 07:55:26 am
Could you please give a short explanation how to deactivate the Kingdom Generator extension (i.e. what lines to comment in the source code)?

I never use it (always play all random) and so I'd just like to avoid the popup window.
Add
return;
line after
document.addEventListener ('DOMContentLoaded', function() {
line;
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: florrat on May 22, 2013, 08:43:19 am
How do you make a part of an avatar transparent?
Transparent PNG Image layer.

And, how do I do that?

Also, the log has less than an inch to display itself.  I can't read it.

In Chrome (and probably also in Firefox), you can press Ctrl and - to "zoom out", i.e. make everything on the page smaller. This also works with Goko, and the extension will automatically use the remaining part of the screen for the log. This way you can make the log readable. You can use Ctrl and + to zoom back in or Ctrl+0 to go to the default zoom level.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on May 22, 2013, 09:41:10 am
Could you also add the option to auto-kick people from your games if they have a pro rating less than what's mentioned in the name of the game?

Should be :)

I have a bunch of features I've thought up that should be possible, it'll just take time. That one is definitely on the list.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Schneau on May 22, 2013, 10:35:52 am
If we're requesting features, I'd love to see the opponent's rating and number of games played on the game screen. I often join a game very fast, and then have it started, without being able to check my opponent's rating. Maybe it could be included at the top of the log?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Beyond Awesome on May 22, 2013, 03:53:36 pm
If we're requesting features, I'd love to see the opponent's rating and number of games played on the game screen. I often join a game very fast, and then have it started, without being able to check my opponent's rating. Maybe it could be included at the top of the log?

Love this idea!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on May 22, 2013, 07:33:57 pm
I'm planning to break up the script into separate files for each feature, using RequireJS and a cool project I found specifically for making Chrome extensions with Require. While I haven't broken down the main script yet, I have added my own feature--in the player list on the right of the lobby, each player's pro rating will be listed instead of their casual rating, if they have one. If they haven't played any pro games, it will still display their casual rating, and I hope to fix that soon.
I appreciate your contribution and have no problem with you adding new features, but I don't think that what you doing now is the way to go. Splitting into separate files after branching will definitely make the merges more difficult and may result in two different subsets of features supported.
My goal currently is to make the code in the single file to a state where it can be used with no modifications in chrome (I mentioned that in an earlier post). From that point it would be trivial to keep both versions up to date.

I'll get my version into the Chrome store before long, but until then there are manual installation instructions on github.
https://github.com/michaeljb/Dominion-Online-User-Extension
I would also discourage releasing a new Chrome plugin in the store, especially without adding checks in the code for existence of the old extension. It would be much better to get the maintenance rights for the old extension from 1wheel, as he offered, and update.

Could you also add the option to auto-kick people from your games if they have a pro rating less than what's mentioned in the name of the game?
I have this feature already implemented, it should be in version 11 (edit: just pushed to the repository).


Could you please give a short explanation how to deactivate the Kingdom Generator extension (i.e. what lines to comment in the source code)?

I never use it (always play all random) and so I'd just like to avoid the popup window.
Of course you can simply play pro games, but I understand you may not want your pro rank affected in some situations. I may add a disable option for that feature if I find the time.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on May 22, 2013, 10:12:10 pm
I appreciate your contribution and have no problem with you adding new features, but I don't think that what you doing now is the way to go. Splitting into separate files after branching will definitely make the merges more difficult and may result in two different subsets of features supported.
My goal currently is to make the code in the single file to a state where it can be used with no modifications in chrome (I mentioned that in an earlier post). From that point it would be trivial to keep both versions up to date.

I guess this part is mostly just personal preference; I'd rather work with different files for each feature than having one big file. I also think there are some features that would be nice to be configurable in an options screen, and I don't know how I'd do that to work with both at once.


Quote
I would also discourage releasing a new Chrome plugin in the store, especially without adding checks in the code for existence of the old extension. It would be much better to get the maintenance rights for the old extension from 1wheel, as he offered, and update.

I'll PM him about that.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: -Stef- on May 23, 2013, 10:13:59 am
Since it's freaking impossible to copy/paste in the goko chat, and a lot of people ask what #vpon is / where to get it, I created a shorter url that refers to this thread.

http://goo.gl/4muRB
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Awaclus on May 23, 2013, 10:19:10 am
Would be awesome if this was available for Opera.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on May 23, 2013, 11:00:55 am
Would be awesome if this was available for Opera.
Maybe it works there too, just nobody tested it yet.
http://my.opera.com/operafan2006/blog/2007/02/13/how-to-install-user-java-script-in-opera
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on May 23, 2013, 11:09:56 am
Any ETA on when the Chrome version will be updated to version 9? The Kingdom Generator feature is the one I care most about. Once that's supported, I'll try the script out.

Thanks for all your hard work, by the way. It's awesome that someone has taken it upon themselves to make the game more playable.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Beyond Awesome on May 23, 2013, 12:35:32 pm
I appreciate your contribution and have no problem with you adding new features, but I don't think that what you doing now is the way to go. Splitting into separate files after branching will definitely make the merges more difficult and may result in two different subsets of features supported.
My goal currently is to make the code in the single file to a state where it can be used with no modifications in chrome (I mentioned that in an earlier post). From that point it would be trivial to keep both versions up to date.

I guess this part is mostly just personal preference; I'd rather work with different files for each feature than having one big file. I also think there are some features that would be nice to be configurable in an options screen, and I don't know how I'd do that to work with both at once.


Quote
I would also discourage releasing a new Chrome plugin in the store, especially without adding checks in the code for existence of the old extension. It would be much better to get the maintenance rights for the old extension from 1wheel, as he offered, and update.

I'll PM him about that.

I agree with Nutki. I think we need one universal version of the extension and not many versions flying around. That will avoid confusion and just make everything easier as a whole, I think.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: florrat on May 23, 2013, 03:27:40 pm
What message do players without the extension get when you type #vpon? Is it the same as which you get: "Victory Point tracker enables (type #vpoff to disallow)"? Wasn't there an command for them to check the current score via chat?

If it is the same message, then I think it should be expanded. Suppose you are a player who has never heard of a VP tracker, then he doesn't know what this means, and he'll probably just ignore it. At least: that was how it worked for me when I played games back on isotropic against people with a VP tracker.

Maybe you should change it to something like "Your opponent is using a Victory Point tracker. This means he can see the scores of every player at every time. You can request the scores by typing <command> in chat, or get the tracker here <url>".

Also, when I tried to play a game against myself Chrome (with extension) vs Firefox (without extension) with a game with #vpon in the game title, I didn't receive any message at all in the Firefox screen. This might have happened because the game was still loading in firefox, but this should not be the case right?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: D Bo on May 23, 2013, 03:34:39 pm
I just tried this same thing and the message appeared in my chat window in both, and it also brought the score up for both people. So not only is it available for the person who sets it up, it is automatically available for the other party as well. Although I have the extension on both so maybe that is not 100% accurate if they don't have it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on May 23, 2013, 03:41:31 pm
I just tried this same thing and the message appeared in my chat window in both, and it also brought the score up for both people. So not only is it available for the person who sets it up, it is automatically available for the other party as well. Although I have the extension on both so maybe that is not 100% accurate if they don't have it.
There is a code in the extension which checks for #vpon in chat and then enables VP counting. It doesn't matter who typed that. So you were checking completely different scenario.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on May 23, 2013, 06:46:36 pm
What message do players without the extension get when you type #vpon? Is it the same as which you get: "Victory Point tracker enables (type #vpoff to disallow)"? Wasn't there an command for them to check the current score via chat?
I planned such option, but currently there is none, I may go back to it. The reasoning was that it is easier to just install the extensions as well. I may go back to it.

Maybe you should change it to something like "Your opponent is using a Victory Point tracker. This means he can see the scores of every player at every time. You can request the scores by typing <command> in chat, or get the tracker here <url>".
I would need to come up with some short text, otherwise it would be annoying to have it all the time. Plus you cannot copy from the chat so some tinyurl should be used.

Also, when I tried to play a game against myself Chrome (with extension) vs Firefox (without extension) with a game with #vpon in the game title, I didn't receive any message at all in the Firefox screen. This might have happened because the game was still loading in firefox, but this should not be the case right?
Maybe you were playing as a guest in one of the windows. Guests cannot send chat, not sure if receiving is disabled as well.



Since it's freaking impossible to copy/paste in the goko chat, and a lot of people ask what #vpon is / where to get it, I created a shorter url that refers to this thread.

http://goo.gl/4muRB
Thanks, I will probably include such information in a future version.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: qmech on May 24, 2013, 04:45:32 am
Could you please give a short explanation how to deactivate the Kingdom Generator extension (i.e. what lines to comment in the source code)?

I never use it (always play all random) and so I'd just like to avoid the popup window.
Of course you can simply play pro games, but I understand you may not want your pro rank affected in some situations. I may add a disable option for that feature if I find the time.

The game defaults to Casual, so you get the pop-up once per session even if you play only Pro games.

We're well into "this free pizza does not have truffle shavings and gold leaf" territory now though. :)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: -Stef- on May 24, 2013, 06:37:40 am
Features:
  • Auto kick. You can prevent lower ranked players from joining your table by specifying 'XXXX+' or 'Xk+' in the game title. With the extension present the players ranked lower than X will be automatically kicked out of the table. (since version 11)

Although not too friendly this one is great. And I don't see any options for making it more friendly, since Goko doesn't give you a chance to specify a reason for kicking.
I think it imposes a pretty steep learning curve on the rest of the community about the meaning of '5000+' ;)

A suggestion for an improvement: maybe it could notify me when someone is accepted, probably by playing some kind of 'ping' sound.
That would allow me to do something else while waiting for a match.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on May 25, 2013, 05:36:28 am
Auto-kick truly is a godsend. Gone are the days of kicking again and again those assclowns who make it a game to insta-rejoin. I second Stef's suggestion for some sort of 'ping' notification.

To make it slightly friendlier I also suggest to kick only those with a rating less than 0.99*ratingThreshold, as it's especially dickish to kick someone who's one win away from meeting the requirements. I've already had someone get pissed at this in public chat, and I just don't like to evoke negative emotions for no reason.

I switched from Chrome to Firefox specifically for the auto-kick feature, but Goko seems to be way slower and less responsive in Firefox. Fortunately, I found a way to run greasemonkey scripts in Chrome, via the tampermonkey extension (https://chrome.google.com/webstore/detail/tampermonkey/dhdgffkkebhmkfjojejmpbldmpobfkfo?hl=en). So far it's working well.

Also, would it be possible to filter the player list in each room such that it only displays players with a high enough rating (without you having to first host a game perse)? I like to check out different rooms for familiar faces, but scrolling through the list is quite a hassle.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: qmech on May 25, 2013, 09:38:22 am
There are enough features in this extension now that it would be great to have some way to enable or disable them individually.  I hadn't realised that there was auto-kicking and that's not something I want to do, although I do want to indicate the strength of games I'm looking for in the title.  I also find the alternative Kingdom generator more of a nuisance than anything else at the moment.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on May 25, 2013, 02:49:19 pm
There are enough features in this extension now that it would be great to have some way to enable or disable them individually.  I hadn't realised that there was auto-kicking and that's not something I want to do, although I do want to indicate the strength of games I'm looking for in the title.  I also find the alternative Kingdom generator more of a nuisance than anything else at the moment.
Before this is implemented you can prevent auto-kick by using an indicator that is not recognized by the extension, like putting an extra character for example '5.000+', '+5k', '5000plus' or '5000 +'
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on May 25, 2013, 03:53:43 pm
I think I've got everything in version 11 working in Chrome. My solution involves copying everything from set_parser.js into the main script. I bet there's probably a better solution, but for now I've pushed it to a branch so Chrome users can manually install the extension to use all of nutki's features:

https://github.com/michaeljb/Goko-Live-Log-Viewer/tree/chrome

I've PM'd 1wheel about maintaining the extension in the Chrome store, but he still hasn't been online here for a couple of weeks.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Rodafowa on May 25, 2013, 08:14:18 pm
Thanks for doing this. But when I try to "Load Unpacked Extension", I'm getting an error message "Manifest is not valid JSON. Line 4, Column 2, unexpected token". Is there something obvious I'm doing wrong?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on May 25, 2013, 09:11:27 pm
Not that I can see; I'm not getting that error message. I'm not sure what could be causing it. Is your Chrome up to date?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on May 26, 2013, 01:59:45 pm
A suggestion for an improvement: maybe it could notify me when someone is accepted, probably by playing some kind of 'ping' sound.
That would allow me to do something else while waiting for a match.

This would be awesome!

Also, I fear having chat below the log isn't possible? Any update on that?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on May 29, 2013, 04:35:27 am
I finally got an options page setup for the Chrome extension. Right now, it's only on my chrome-new branch (https://github.com/michaeljb/Goko-Live-Log-Viewer/tree/chrome-new), and it only has options for my new features for default table settings. (set a default name and number of players--trying to set default leaderboard is actually how I discovered this (http://forum.dominionstrategy.com/index.php?topic=8243.0), though I still haven't got that part figured out)

nutki, were you planning on using localStorage to allow users to switch features on and off? That's what the options page is hooked up to.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lotoreo on May 29, 2013, 09:49:26 am
So, now i finally registered to this forum, just to do one thing: Telling you guys that you are AWESOME!

What a great extension! If you really manage to set the default leaderboard type as well... well, I don't find the right words.. ;)

https://getsatisfaction.com/goko/topics/save_game_title (https://getsatisfaction.com/goko/topics/save_game_title) => that posting is 7 months old, you finally made it happen :)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on May 29, 2013, 03:44:53 pm
I now have ownership of the extension in the Chrome store (thanks to rrenaud and 1wheel), and it is up to date with nutki's Version 11 script, based on the code in my chrome branch (https://github.com/michaeljb/Goko-Live-Log-Viewer/tree/chrome).

I'll probably hold off publishing new features until they are incorporated into nutki's script. The new features will still be available by manually installing from my chrome-new branch.

Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: heron on May 29, 2013, 05:53:32 pm
So, I can't get this extension thingy to work. Probably because I know next to nothing about computers. (But I can learn)

I get a message that says could not load extension, "Manifest is not valid JSON.  Line: 4, column: 2, Unexpected token."

I was kind of proud that I could even find the load unpacked extension button though.
Any help would be appreciated!

Edit: Oh hey, you own the chrome store thingy now and it auto-updated. Duh. Thanks!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on May 30, 2013, 05:08:47 am
Nutki, could you modify the #vpon thing so that people are unable to turn it off if it's in the title of the game? If you don't want to use it yet know in advance it will be on, you should just choose a different game.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on May 30, 2013, 05:27:17 am
http://dom.retrobox.eu/?/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
is not working.
Although
http://dominionlogs.goko.com/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
works fine.

LogViewer probably don't count with redirects.
http://dominionlogs.goko.com/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
redirects to
http://archive-dominionlogs.goko.com/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on May 30, 2013, 07:19:21 am
First, let me say again what a fantastic contribution the log parser extension is.  Thank you, thank you!

Second, have you considered implementing automatch in a form that works through the Goko UI?

I'm envisioning something like this... the extension communicates with a third-party server that tracks who's online and looking for a match.  When a match is found, both players are notified and sent to an empty room.  Better still, the extension has one of the players create a game and the other join it.

I know this would be doable in a real programming language... I'm less confident about what can be done in JS in a browser extension.  :-\
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on May 30, 2013, 03:53:02 pm
http://dom.retrobox.eu/?/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
is not working.
Although
http://dominionlogs.goko.com/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
works fine.
Thanks for reporting. This is likely due to XMLHttpRequest anti cross site scripting protection. Although both the old and new goko log sites return responses with proper Allow Origin headers, the redirect response does not, so it silently fails. I think I can work around it. How did you learned about the log archive anyway?

Second, have you considered implementing automatch in a form that works through the Goko UI?
Yes, but that is not likely to happen. First that would probably more complex than what I done so far (somehow depending on the approach, but generally I was thinking along the lines you suggested). Then there is a big problem that it would only work for people actually using the extension (I don't know if that would be feasible otherwise) so there would be hard to get the critical mass of players to move to it.
On top of that I play mostly against bots, so I don't have direct interest in this.

Nutki, could you modify the #vpon thing so that people are unable to turn it off if it's in the title of the game? If you don't want to use it yet know in advance it will be on, you should just choose a different game.
Makes sense, I will consider this.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lekkit on May 30, 2013, 04:21:37 pm
Also, would there be a way to get an autokick function for quitting %? It's really annoying to sit around and wait for people with low quit % for multiplayer games.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on May 30, 2013, 04:25:33 pm
Why do you care for quitting percentage? Quits=losses now, so it doesn't matter. I think most quits by players still playing are caused by goko bugs.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on May 30, 2013, 04:32:18 pm
Version 12 released, mostly integrating ideas by michaeljb.
What's new:
- Extension settings page - click on 'User settings' below the  'Logout' button (for now you can disable some features of the extension)
- Saving table settings (name, rating type, etc) between sessions
- Pro rankings can be displayed instead of the casual in the lobby list
- Better chrome compatibility (now the user script can be used directly - just save it to a file and drag it to chrome://extensions/, using custom extension is recommended though, always make sure that you have only one copy enabled)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: jsh357 on May 30, 2013, 04:34:17 pm
Version 12 released, mostly integrating ideas by michaeljb.
What's new:
- Extension settings page - click on 'User settings' below the  'Logout' button (for now you can disable some features of the extension)
- Saving table settings (name, rating type, etc) between sessions
- Pro rankings can be displayed instead of the casual in the lobby list
- Better chrome compatibility (now the user script can be used directly - just save it to a file and drag it to chrome://extensions/, using custom extension is recommended though, always make sure that you have only one copy enabled)

Thank you based nutki
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on May 30, 2013, 04:37:25 pm
Would it also be possible to order players by ranking, so you can quickly see if there are good opponents in the room?

Thx a lot for the new update.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on May 30, 2013, 04:40:25 pm
Also, would there be a way to get an autokick function for quitting %? It's really annoying to sit around and wait for people with low quit % for multiplayer games.

How high would you set the bar on this? My Quit% is at 6%, presumably because it counts quitting against bots.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lekkit on May 30, 2013, 07:05:17 pm
Because if you play a 3p game and close to the end of the game, the player who is behind the most quit, the game ends with the quitting player losing against the other two, while the other two doesn't get or lose anything. It's really not satisfying at all. About a third of the 3p games I've played* have ended prematurely this way. And I don't like it at all.

*Just a random number I threw in there, I don't have any statistics to back it up, but it feels like it's about a third of the games.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on May 30, 2013, 07:25:52 pm
I couldn't quite catch this from what you all have been saying, I have the old Chrome extension, what do I need to do to get the new one?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: treebeardtheent on May 30, 2013, 10:06:01 pm
Quit % is not always right. Currently I have a 8% quit rating and I have NEVER quit a game. All those games are from crashes that the surver did not identify as network connection errors or programing errors.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on May 30, 2013, 10:38:02 pm
Version 12 released, mostly integrating ideas by michaeljb.
What's new:
- Extension settings page - click on 'User settings' below the  'Logout' button (for now you can disable some features of the extension)
- Saving table settings (name, rating type, etc) between sessions
- Pro rankings can be displayed instead of the casual in the lobby list
- Better chrome compatibility (now the user script can be used directly - just save it to a file and drag it to chrome://extensions/, using custom extension is recommended though, always make sure that you have only one copy enabled)


I'll work on getting the version in the Chrome store updated tomorrow night.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lekkit on May 31, 2013, 01:21:49 am
Quit % is not always right. Currently I have a 8% quit rating and I have NEVER quit a game. All those games are from crashes that the surver did not identify as network connection errors or programing errors.

I have never quit either, but had some games give up on me. But I've only ended up with a 1% quit. The thing is that with the current way of handling disconnects in games with more than two players, I would prefer not to play someone who has a 1/12 disconnect rate if there are other people with lower rates on.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on May 31, 2013, 01:25:07 am
http://dom.retrobox.eu/?/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
is not working.
Although
http://dominionlogs.goko.com/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
works fine.
Thanks for reporting. This is likely due to XMLHttpRequest anti cross site scripting protection. Although both the old and new goko log sites return responses with proper Allow Origin headers, the redirect response does not, so it silently fails. I think I can work around it. How did you learned about the log archive anyway?
From here: https://getsatisfaction.com/goko/topics/are_you_seriously_deleting_old_logs#reply_12148676

Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: treebeardtheent on May 31, 2013, 03:13:00 pm
I have never quit either, but had some games give up on me. But I've only ended up with a 1% quit. The thing is that with the current way of handling disconnects in games with more than two players, I would prefer not to play someone who has a 1/12 disconnect rate if there are other people with lower rates on.
I don't have a bad connection. I use a tablet that runs the android operating system. This is intrperted as a Mobil device by the server. Until May 10th that was not an issue, now 40%+ of my games crash. I have not played a game since my quit % topped 8. I am just frustrated with the site and being penalize for something I have no control over. I guess I just don't want salt added to the wound once I can play again.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on May 31, 2013, 03:40:40 pm
http://dom.retrobox.eu/?/20120827/log.4fec9f5b30c40b085b22e3fe.1346121458450.txt
is not working.
Fixed it. Also put in some new features to the offline viewer as well.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 01, 2013, 02:22:44 am
Extension in the Chrome store is updated.

I've noticed a few issues, I'll look into them. No clue if they're exclusive to Chrome or not.

Sometimes, when returning home from a multiplayer lobby, the "user settings" link isn't there. I haven't been able to reliably duplicate it yet, so I'm not sure what exactly is causing it.

When creating a new game for the first time in the session, if the cacheSettings include a pro game, you can't actually create the game until changing to a casual game, then back to pro. This was the same problem I encountered when working on this feature myself.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on June 01, 2013, 02:24:38 am
It (the chrome store) says I already have it, but it's the old version.  Do I have to get rid of the old version somehow then re-download it?

EDIT: I just did removed it and re-got it, but should it have a way to update it still?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 01, 2013, 02:33:37 am
When looking at your extensions page in Chrome, if you check the box next to "Developer mode", you should see a button that says "Update extensions now." That should do it, but I'm not 100% sure about it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Joseph2302 on June 01, 2013, 02:53:47 am
Interesting, for me it just automatically updated a couple of days ago on Chrome, which was nice.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on June 01, 2013, 06:14:42 am
Also put in some new features to the offline viewer as well.
Cool features!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lekkit on June 01, 2013, 06:21:36 am
I don't have a bad connection. I use a tablet that runs the android operating system. This is intrperted as a Mobil device by the server. Until May 10th that was not an issue, now 40%+ of my games crash. I have not played a game since my quit % topped 8. I am just frustrated with the site and being penalize for something I have no control over. I guess I just don't want salt added to the wound once I can play again.

The thing is, and this will probably sound much more harsh than I want it to, but I don't really care for what reason people disconnect. It doesn't matter to me or the game if it's due to device compability issues, connection or people just resigning. If one player leaves, for any reason at all, the game ends. And I don't want that. In 2p games I don't really care about quit %, but in 3p it ruins the experience for me.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Rabid on June 01, 2013, 06:29:26 am
Unsuitable custom avatars.
A player is using a naked picture as an avatar, would it be possible to remove it do you think? 
And if it is possible is this something we want to do?

Edit: My concern is not that I personally object to the image, but that goko will get complaints from other users and try to stop us using the extension.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Awaclus on June 01, 2013, 08:03:11 am
Would be awesome if this was available for Opera.
Maybe it works there too, just nobody tested it yet.
http://my.opera.com/operafan2006/blog/2007/02/13/how-to-install-user-java-script-in-opera
Maybe I'm not doing it right, but it's not working.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on June 01, 2013, 08:32:18 am
Version 13 released
What is new:
- fixed problem with staring pro ranked table at the session start
- added a 'ping' sound when a properly ranked player joins the table when using the auto kick mode

Sometimes, when returning home from a multiplayer lobby, the "user settings" link isn't there. I haven't been able to reliably duplicate it yet, so I'm not sure what exactly is causing it.
That I haven't seen. Is it disappearing from the DOM or it just invisible (you can check that with 'inspect element')?

Unsuitable custom avatars.
A player is using a naked picture as an avatar, would it be possible to remove it do you think? 
And if it is possible is this something we want to do?
Yeah, I spotted that when doing backup of my site, I think I will remove it and black list that guy if he does that again. This is exactly why many services do not have completely custom avatars option, you need a moderator then.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: treebeardtheent on June 01, 2013, 08:48:43 am
The thing is, and this will probably sound much more harsh than I want it to, but I don't really care for what reason people disconnect. It doesn't matter to me or the game if it's due to device compability issues, connection or people just resigning. If one player leaves, for any reason at all, the game ends. And I don't want that. In 2p games I don't really care about quit %, but in 3p it ruins the experience for me.
Believe me, if anyone understands I do. That is the reason I stopped playing people. I just don't want to see a number assigned to all games and not be able to play members of this community.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lekkit on June 01, 2013, 09:06:54 am
I don't think the community will stop playing each other. I mean, people are still playing each other even with the rating auto-kick. If the 3p+ issue would be fixed by Goko, I'd happily play people even if they had something like a 40-50% quit rate. I'm not entirely sure about that one, though.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 01, 2013, 09:59:26 am
Version 13 released
What is new:
- fixed problem with staring pro ranked table at the session start
- added a 'ping' sound when a properly ranked player joins the table when using the auto kick mode
AWESOME!
No more keeping people waiting.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 01, 2013, 10:57:42 am
When I try to use the Kingdom Generator, it gives, after inputting the kingdom and clicking ok, the error "ReferenceError: set_parser not defined".

I'm using version 13 of the script via Tampermonkey in Chrome. Version 12 worked fine and so far I'm not experiencing any other problems.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 01, 2013, 12:49:57 pm
Sometimes, when returning home from a multiplayer lobby, the "user settings" link isn't there. I haven't been able to reliably duplicate it yet, so I'm not sure what exactly is causing it.
That I haven't seen. Is it disappearing from the DOM or it just invisible (you can check that with 'inspect element')?

I forgot to check it when I saw it was gone, but I will if I see it happen again.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 01, 2013, 09:48:46 pm
Version 1.13.1 for Chrome is published.

- If the the pro rankings option is selected, the rating next to your name and avatar in the top right now shows  your pro rating
- The player list in the lobby is sorted by the displayed rating (alphabetical for same ratings)
- Option to hide the full body avatar at the launch screen
- Option to hide the ad/tutorial/tips box at the launch screen

Additionally, these features are in a feature branch on github, submitted in a pull request to nutki.




Version 1.13.2 published.

- nutki pointed out hiding the ad at the launch screen might be something Goko would frown upon, and they're not really that intrusive anyway, so that's gone.
- fixed a bug where unchecking the pro ratings box would still display your pro rating in the top right of the lobby
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lekkit on June 02, 2013, 05:56:58 pm
http://dom.retrobox.eu/?/20130602/log.512ba416e4b022198f05f8e2.1370210003553.txt

That just happened to me. Where did my cards go? Also, for some reason, my opponent managed to block Bazaar when hitting Possession. Weird stuff.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 02, 2013, 06:01:30 pm
I think the Contraband thing is because there's a button that says "See All Cards" or something that lets you scroll through all the Dominion cards, rather than just those in the Supply/BM Deck.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on June 02, 2013, 08:19:07 pm
This of course just keeps getting better and better and better.  Quick question:  the addon displays Pro ratings for other players, but still displays my casual rating with my avatar... any chance that's likely to change?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lekkit on June 03, 2013, 01:08:51 am
I think the Contraband thing is because there's a button that says "See All Cards" or something that lets you scroll through all the Dominion cards, rather than just those in the Supply/BM Deck.

I know that. But he said he clicked on Possession. I'll have to take his word for it. But yeah, that is a possibility.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lotoreo on June 03, 2013, 09:01:37 am
I am currently at work, so I can not test this, but I am curious: How does the point tracker handle 3 player masquerade? ;)

The extension is getting better and better, great work there :)
But I would still have 2 suggestions:

Could you add the "live log" to the Options page? When I am watching videos on the same screen, I would rather not have it activated, to save space.

Also, how hard would it be to add a personal "blacklist"? From time to time I encounter players who I definitely never want to meet again. It would be a nice feature if I could save their name in the Options page, and they would be auto kicked ;)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 03, 2013, 09:07:02 am
Masquerade didn't work properly a while ago in 2p games even, but in recent games I think it has always been right.
Was that just coincidence or have you maged to track what is passed and received, nutki?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Lotoreo on June 03, 2013, 09:15:31 am
Well, in 2p games I think one has the full information, you know which card you pass and which card you gain. So actually that should work. 3 player sounds like far more fun to implement ;)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 03, 2013, 09:22:25 am
Yeah, but it takes information from the text log, which doesn't show what is passed.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 03, 2013, 12:32:02 pm
This of course just keeps getting better and better and better.  Quick question:  the addon displays Pro ratings for other players, but still displays my casual rating with my avatar... any chance that's likely to change?

This is fixed in the latest version for Chrome, and I'm certain it will be included when nutki releases Version 14.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: hsiale on June 03, 2013, 02:46:50 pm
A nice addition would be a big red "X" appearing over any empty Supply pile (or somewhere on the screen if the empty pile is Ruins or 11th Kingdom pile in a Young Witch game). Iso had those and it warned you about 3-pile ending possibility very well. Probably some people may not like it so it should be optional feature.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mameluke on June 03, 2013, 10:40:43 pm
any chance for a flashing "your turn!!" in case we tab out of goko?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Beyond Awesome on June 03, 2013, 11:09:07 pm
any chance for a flashing "your turn!!" in case we tab out of goko?
Awesome idea. I love how iso let you go from tab to tab, especially if your opponent had a long megaturn going on or they took a long time with their turns.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mameluke on June 04, 2013, 08:38:18 am
Probably could be done based on the last line of the log, right? If it's your name, then flash the text?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 04, 2013, 08:41:07 am
any chance for a flashing "your turn!!" in case we tab out of goko?

Or better yet, the ping sound? (Only if you've tabbed out, of course)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Schneau on June 04, 2013, 11:32:21 am
any chance for a flashing "your turn!!" in case we tab out of goko?

Or better yet, the ping sound? (Only if you've tabbed out, of course)

This is how Goko's sound effects should work in the first place, but they're (http://forum.dominionstrategy.com/index.php?topic=7908.0) broken (https://getsatisfaction.com/goko/topics/sound_effect_plays_at_the_start_of_my_opponents_turn_but_not_at_the_start_of_my_turn).
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: qmech on June 04, 2013, 02:21:29 pm
Does Goko even run if you're tabbed out?  I know it holds the animations in a queue until you tab back as you get a rush of activity if you were away long enough.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 04, 2013, 02:22:49 pm
Yeah, i noticed that as well.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mameluke on June 04, 2013, 03:01:44 pm
That's true, but I would imagine that the log file is still created while you're tabbed out--although that may not be the case.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mameluke on June 04, 2013, 03:02:49 pm
while we're requesting things, any chance at the end of the log file we can get a list of what's in the trash and what's left in the supply, a la isotropic?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: BBL on June 05, 2013, 04:07:05 pm
First of all, many thanks to the creators of this awesome extension! :)

This might be a minority opinion here, but would it be possible to add an option to hide the Game Log after start? I am more of a casual gamer and most of the time I do not need the exact tracking, as I am playing duels against bots. Still, I love the option to have some control over the chosen cards in these Quick Matches. So I was wondering, if it would be possible to get the best of both worlds. ;D


Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 05, 2013, 05:05:37 pm
Just popping in to say that I love the randomizer customizer. I've been playing a whole slew of games using 2 randomly determined sets and having a blast.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Dubdubdubdub on June 06, 2013, 07:36:01 am
I can't seem to change my avatar a second time. The prompt tells me 'avatar saved', but the image doesn't change.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Beyond Awesome on June 06, 2013, 03:18:01 pm
This is for theory really if he reads this thread, but I think this should be posted on the main page. I am sure there are a few players who never go to the forums or who only casually check it out, and I think having this on the front page one day will raise awareness of this awesome extension and improve the game playing experience for many more players on Goko.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Dubdubdubdub on June 07, 2013, 06:50:14 am
I can't seem to change my avatar a second time. The prompt tells me 'avatar saved', but the image doesn't change.

I logged in a day later, and the new image is up. i'm happy!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: evan-b on June 07, 2013, 02:27:13 pm
When I try to use the Kingdom Generator, it gives, after inputting the kingdom and clicking ok, the error "ReferenceError: set_parser not defined".

I'm getting the same issue when I try to use the Kingdom Generator. I'm using Chrome 27.0.1453.110 and  1.13.2 of the chrome plugin from the extension page https://chrome.google.com/webstore/detail/dominion-online-live-log/kaignighoceeemhinbbophdeogpnedjn/related .

My javascript console has this error "[blocked] The page at https://play.goko.com/Dominion/gameClient.html ran insecure content from http://dom.retrobox.eu/js/1.0.0/set_parser.js.
 gameClient.html:1"

I'm not sure why.  I thought it might have been a DoNotTrack extension, but I turned that off and it still happens.  If I pasted the javascript form that page into the console, it works. 

Anything I can do to help fix this issue?

And how does this Kingdom Generator even work?  I'm just curious how it interacts with goko.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 08, 2013, 05:31:24 am
Quote
Auto kick. You can prevent lower ranked players from joining your table by specifying 'XXXX+' or 'Xk+' in the game title. With the extension present the players ranked lower than X will be automatically kicked out of the table. (since version 11)

Putting "5.5k+" in the title only kicks people below 5k.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Warfreak2 on June 08, 2013, 05:42:20 am
Try 5500+?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: qmech on June 08, 2013, 06:32:21 am
Quote
Auto kick. You can prevent lower ranked players from joining your table by specifying 'XXXX+' or 'Xk+' in the game title. With the extension present the players ranked lower than X will be automatically kicked out of the table. (since version 11)

Putting "5.5k+" in the title only kicks people below 5k.

I've been having trouble with "2^2^2^2/pi^2+".
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 08, 2013, 07:47:10 am
Try 5500+?

That works, but it forces me to either abbreviate my name or remove the "#vpon" from the title, both of which I'd prefer not to have to do!

Quote
Auto kick. You can prevent lower ranked players from joining your table by specifying 'XXXX+' or 'Xk+' in the game title. With the extension present the players ranked lower than X will be automatically kicked out of the table. (since version 11)

Putting "5.5k+" in the title only kicks people below 5k.

I've been having trouble with "2^2^2^2/pi^2+".

That's because only 5 ppl are able to enter such a game.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: WanderingWinder on June 08, 2013, 07:52:31 am
Try 5500+?

That works, but it forces me to either abbreviate my name or remove the "#vpon" from the title, both of which I'd prefer not to have to do!

Quote
Auto kick. You can prevent lower ranked players from joining your table by specifying 'XXXX+' or 'Xk+' in the game title. With the extension present the players ranked lower than X will be automatically kicked out of the table. (since version 11)

Putting "5.5k+" in the title only kicks people below 5k.

I've been having trouble with "2^2^2^2/pi^2+".

That's because only 5 ppl are able to enter such a game.
Actually, I think almost everyone can enter this. It's really confusing without parentheses, but iirc, convention is that exponents like this go left to right (or bottom to top), which makes this 256 divided by pi^2, or just under 26. Of course, the programmer in me wants to make a joke about bitwise operations, but as I'm not that much of a programmer, I can't recall which one ^ stands for.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Warfreak2 on June 08, 2013, 08:00:02 am
As far as I know, a^b^c by convention means a^(b^c), since (a^b)^c is easier written as a^bc.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: WanderingWinder on June 08, 2013, 08:44:05 am
As far as I know, a^b^c by convention means a^(b^c), since (a^b)^c is easier written as a^bc.
If this is the case, every calculator I have ever used does it wrong. I mean, your way is how I would *like* it to be, it's just not the way I think it actually is.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 08, 2013, 08:54:44 am
Try 5500+?

That works, but it forces me to either abbreviate my name or remove the "#vpon" from the title, both of which I'd prefer not to have to do!

Quote
Auto kick. You can prevent lower ranked players from joining your table by specifying 'XXXX+' or 'Xk+' in the game title. With the extension present the players ranked lower than X will be automatically kicked out of the table. (since version 11)

Putting "5.5k+" in the title only kicks people below 5k.

I've been having trouble with "2^2^2^2/pi^2+".

That's because only 5 ppl are able to enter such a game.
Actually, I think almost everyone can enter this. It's really confusing without parentheses, but iirc, convention is that exponents like this go left to right (or bottom to top), which makes this 256 divided by pi^2, or just under 26. Of course, the programmer in me wants to make a joke about bitwise operations, but as I'm not that much of a programmer, I can't recall which one ^ stands for.

Interesting, I had always assumed it should be read from right to left.

Having checked it: Matlab returns indeed 256 upon entering 2^2^2^2, but both Mathematica, Wolfram Alpha and Google return 65536. So I do think parenthesis are required in order to make it an unambiguous statement, as any convention stops being a convention when it's not adhered to by at least a significant majority of the major players.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: StrongRhino on June 08, 2013, 10:03:57 am
Quote
Auto kick. You can prevent lower ranked players from joining your table by specifying 'XXXX+' or 'Xk+' in the game title. With the extension present the players ranked lower than X will be automatically kicked out of the table. (since version 11)

Putting "5.5k+" in the title only kicks people below 5k.
It does. I was 5000 and didn't get auto-kicked, then after being crushed a few times, was under 5000, then I couldn't join.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on June 08, 2013, 11:11:36 pm
Try 5500+?
That works, but it forces me to either abbreviate my name or remove the "#vpon" from the title, both of which I'd prefer not to have to do!
5500+ and 5.5k+ has both 5 characrters.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on June 08, 2013, 11:16:01 pm
I can't seem to change my avatar a second time. The prompt tells me 'avatar saved', but the image doesn't change.

I logged in a day later, and the new image is up. i'm happy!
It was cached in your browser. Next time clear browser cache and restart browser and you will have it changed right away.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Polk5440 on June 09, 2013, 12:48:20 am
Can the point counter be made so that it cannot be turned on after a certain number of turns? I have run into quite a few people who are waiting until critical moments late in the game to turn it on and get the point count. This defeats the purpose of an opponent's ability to turn it off a lot of times.

In addition, I just had a game a couple of days ago against a non-f.ds member who was complaining about this to me before the game began and said he would quit if I turned it on late. Luckily for him, I don't like the idea of having a VP counter, anyway, and never turn it on.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on June 09, 2013, 12:54:42 am
Can the point counter be made so that it cannot be turned on after a certain number of turns? I have run into quite a few people who are waiting until critical moments late in the game to turn it on and get the point count. This defeats the purpose of an opponent's ability to turn it off a lot of times.

In addition, I just had a game a couple of days ago against a non-f.ds member who was complaining about this to me before the game began and said he would quit if I turned it on late. Luckily for him, I don't like the idea of having a VP counter, anyway, and never turn it on.

Oh, I don't like VP counters either!  I've never seen this happen before, I just never join games that say #VPon (or whatever it says).
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: StrongRhino on June 09, 2013, 01:05:00 am
Can the point counter be made so that it cannot be turned on after a certain number of turns? I have run into quite a few people who are waiting until critical moments late in the game to turn it on and get the point count. This defeats the purpose of an opponent's ability to turn it off a lot of times.

In addition, I just had a game a couple of days ago against a non-f.ds member who was complaining about this to me before the game began and said he would quit if I turned it on late. Luckily for him, I don't like the idea of having a VP counter, anyway, and never turn it on.

Oh, I don't like VP counters either!  I've never seen this happen before, I just never join games that say #VPon (or whatever it says).
Or you could just, you know, type #vpoff in the chat.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on June 09, 2013, 01:06:58 am
Can the point counter be made so that it cannot be turned on after a certain number of turns? I have run into quite a few people who are waiting until critical moments late in the game to turn it on and get the point count. This defeats the purpose of an opponent's ability to turn it off a lot of times.

In addition, I just had a game a couple of days ago against a non-f.ds member who was complaining about this to me before the game began and said he would quit if I turned it on late. Luckily for him, I don't like the idea of having a VP counter, anyway, and never turn it on.

Oh, I don't like VP counters either!  I've never seen this happen before, I just never join games that say #VPon (or whatever it says).
Or you could just, you know, type #vpoff in the chat.

I feel like that would be mean, I knew it would be there.  Also, I heard that people don't like that anyway, someone asked that they make it a feature that they can't turn it off if it was in the name.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Polk5440 on June 09, 2013, 01:59:53 am
Can the point counter be made so that it cannot be turned on after a certain number of turns? I have run into quite a few people who are waiting until critical moments late in the game to turn it on and get the point count. This defeats the purpose of an opponent's ability to turn it off a lot of times.

In addition, I just had a game a couple of days ago against a non-f.ds member who was complaining about this to me before the game began and said he would quit if I turned it on late. Luckily for him, I don't like the idea of having a VP counter, anyway, and never turn it on.

Oh, I don't like VP counters either!  I've never seen this happen before, I just never join games that say #VPon (or whatever it says).
Or you could just, you know, type #vpoff in the chat.

The point is that they turn it on at a crucial time to get the score. Yes, I can turn it off at that time, but it's too late because he's seen the score.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Polk5440 on June 09, 2013, 02:00:42 am
Didn't the Iso extension have a 5 turn limit where it couldn't be turned on or off after that time? Wouldn't something like that work here, too?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 09, 2013, 11:48:51 am
I've started just including #vpoff in my game names.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 09, 2013, 01:14:41 pm
I have a small request. When the dialog box pops up to allow you to specify kingdom parameters, I would like the text in the text field to already be selected. That way I can type or paste immediately without selecting the text that's already there.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 09, 2013, 04:42:13 pm
Some small changes...

Version 1.13.3 published
- kingdom generator dialog selects the text
- the live log viewer may be turned off
- duplicate entries in the lobby player list will not be displayed (essentially masking a Goko bug)
- improved the sorting algorithm's performance
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 09, 2013, 06:04:23 pm
Duplicate entries in the player list is not a bug, it means that one player is logged-in two times, e.g. in different tabs.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 09, 2013, 06:07:47 pm
- kingdom generator dialog selects the text

Woohoo! Thanks!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 09, 2013, 06:32:50 pm
Duplicate entries in the player list is not a bug, it means that one player is logged-in two times, e.g. in different tabs.

It can also happen when you reload the page. I forgot about the fact that Goko allows multiple tabs, so I just thought it was a bug.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: WanderingWinder on June 09, 2013, 07:55:55 pm
Can the point counter be made so that it cannot be turned on after a certain number of turns? I have run into quite a few people who are waiting until critical moments late in the game to turn it on and get the point count. This defeats the purpose of an opponent's ability to turn it off a lot of times.

In addition, I just had a game a couple of days ago against a non-f.ds member who was complaining about this to me before the game began and said he would quit if I turned it on late. Luckily for him, I don't like the idea of having a VP counter, anyway, and never turn it on.

Thisthisthis. VERY annoying.

Edit: At the very very least, when it's turned on, it should give a printout in the public chat, so that person using it can't get unblockable information which the opponent *has no access to*.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 09, 2013, 08:22:41 pm
Version 1.13.4
- bug fix: players join your table, but it appears no one has joined your table (opts.$el was undefined, throwing an error; see the commit (https://github.com/michaeljb/Goko-Live-Log-Viewer/commit/75d6a07f7edb4c9a73ac67f1cc4192a9fca65980) for the small code change)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: jsh357 on June 09, 2013, 09:52:19 pm
The extension stopped working for me today (in Chrome).  Am I alone or has it been shut down somehow?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mameluke on June 10, 2013, 01:43:53 am
not working for me either.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mameluke on June 10, 2013, 10:55:56 am
ah. it's by default off--so go to the user settings on the main screen.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Schneau on June 12, 2013, 10:57:03 am
Isotropic's logs had something at the top that summarized the end of the game, which included the final scores and why the game ended. It would say something like "Duchies, Mountebanks, and Quarries are all gone" or "Provinces are all gone", etc. I find this helpful when glancing through a log, instead of having to try to piece together what 3 piles emptied. Could this be added to the game log prettifier?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on June 13, 2013, 05:39:51 am
Version 14 released
What's new:
- merged michaeljb's changes
-- sorting of the player list
-- selecting kingdom generator rule
- improved VP tracker interface
-- #vpon in the game title cannot be overruled
-- setting is locked after turn 4
-- adventures always use VP tracker by default (can be changed in the options screen)
-- #vp? in the chat will show the current score for the players not using the extension
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: WanderingWinder on June 13, 2013, 07:34:40 am
-- setting is locked after turn 4
The only thing I worry about with this is someone being able to sneak in turning it on right before the locking switches in, effectively making it un-turn-off-able.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on June 13, 2013, 07:58:17 am
-- setting is locked after turn 4
The only thing I worry about with this is someone being able to sneak in turning it on right before the locking switches in, effectively making it un-turn-off-able.
You can always type '#vpoff' preemptively, if you suspect the opponent may want to do this. But agreed, that is not a perfect solution. Maybe I should make the window for '#vpoff' one turn longer?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: WanderingWinder on June 13, 2013, 01:01:50 pm
Wait - if I #vpoff, does that *stop* them from being able to #vpon in the first place?

This was not something I had considered.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 13, 2013, 01:06:20 pm
It does.
nutki, can you predict already wether the extension will work with guilds?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 13, 2013, 01:24:48 pm
Now the extension hides most of the player list, I think only people who are not seated are displayed. This is terrible. Can this be reversed, or at least made optional? (I do like the sorting, but I want to see all players in the room, not only those who don't happen to be playing a game).
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 13, 2013, 01:43:47 pm
Wait - if I #vpoff, does that *stop* them from being able to #vpon in the first place?

This was not something I had considered.

Indeed. I create all of my games with "#vpoff" in the name.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: jonts26 on June 13, 2013, 01:49:46 pm
Now the extension hides most of the player list, I think only people who are not seated are displayed. This is terrible. Can this be reversed, or at least made optional? (I do like the sorting, but I want to see all players in the room, not only those who don't happen to be playing a game).

The best solution would be to grey out people in games, instead of removing them completely. Though I'm not sure if that's easy to implement.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 13, 2013, 01:51:19 pm
Now the extension hides most of the player list, I think only people who are not seated are displayed. This is terrible. Can this be reversed, or at least made optional? (I do like the sorting, but I want to see all players in the room, not only those who don't happen to be playing a game).

The best solution would be to grey out people in games, instead of removing them completely. Though I'm not sure if that's easy to implement.
Yeah, taht would be pretty cool.
Maybe also sort the people not in the game to the top?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 13, 2013, 02:01:45 pm
Now the extension hides most of the player list, I think only people who are not seated are displayed. This is terrible. Can this be reversed, or at least made optional? (I do like the sorting, but I want to see all players in the room, not only those who don't happen to be playing a game).

The best solution would be to grey out people in games, instead of removing them completely. Though I'm not sure if that's easy to implement.
Yeah, taht would be pretty cool.
Maybe also sort the people not in the game to the top?

Please no. Or at least make it optional.

My reasoning is that I often have to wait a couple of minutes for someone with a high enough rating to join my game. This works really great with the ping sound and stuff, so that's no big deal. However, I want to be waiting in a room with at least a few qualified people. I don't care whether they are currently playing a game or not, all I care about is to quickly judge whether a room is worth waiting in, or whether I'll probably have better luck by switching to another.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on June 13, 2013, 05:14:35 pm
There could be different sorting options, ranking, if they're playing, etc.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nutki on June 13, 2013, 05:57:46 pm
Version 15 released
Changes:
- fixed disappearing players if pro ratings used with sorting
- added cards from Guilds

Now the extension hides most of the player list, I think only people who are not seated are displayed. This is terrible. Can this be reversed, or at least made optional? (I do like the sorting, but I want to see all players in the room, not only those who don't happen to be playing a game).
That was a bug actually, sorry.

nutki, can you predict already wether the extension will work with guilds?
I added the cards names and types to the formatter and the kingdom generator, so as long as Goko uses the same names that should work. However some problems may occur due some other changes to the client code that will come with the site update, so no guarantees.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 13, 2013, 08:42:14 pm
Version 1.15 is in the Chrome store. Just nutki's version 15 plus the needed Chrome extension files.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 14, 2013, 12:40:58 am
I've pushed a first pass at a blacklist to a branch (https://github.com/michaeljb/Goko-Live-Log-Viewer/tree/chrome-new), you can install it manually if you like (just make sure you disable the version from the store first). In the user settings popup, there's a little textarea for putting in usernames, one per line (and it is case-sensitive). Blacklisted players will not be visible to you in the player list in the lobby, and will be auto-booted when joining games you host.

I've thought it would also be nice to hide games hosted/joined by blacklisted players, and to hide chatroom messages from them, or maybe make these different things configurable. Thoughts?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: rrenaud on June 14, 2013, 12:52:11 am
Hide it all.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 14, 2013, 12:57:04 am
Hide it all.

When you put it that way, I feel like I should already have it done, and I should just need to flip a switch   :P

Will work on that, something to keep me awake until Guilds is up on Goko (http://forum.dominionstrategy.com/index.php?topic=8325.msg256068#msg256068)...

update: chat from blacklisted players in the lobby will not be displayed, and fixed a bug where a player would be hidden in the list even after removing them from the blacklist. Still working on hiding tables where blacklisted players are playing.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 14, 2013, 04:18:25 am
I think the Deck Builder doesn't support Guilds yet (there's no keyword for the expansion, or it isn't "Guilds", nor even the individual cards)

Thx for the update btw.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on June 14, 2013, 04:51:43 am
Typing "Guilds" gives me an all Guilds kingdom!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 14, 2013, 05:37:48 am
Strange, I get "Error: Unknown card or set: Guilds". It says its version 15 though.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 14, 2013, 06:11:19 am
Not sure what was wrong, but it works now.
Small request: Can you add the notification sound when someone joins to games without access limitation as well?

Edit: Also, the vp counter should tell your opponent about the command to check his score when it announces itself.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on June 14, 2013, 07:21:56 am
Please add link to this thread to http://dom.retrobox.eu/vp.html so that people without extension can get it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 14, 2013, 10:02:18 pm
I don't think putting #vpoff into my game titles is working anymore. Is that intentional?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: joel88s on June 17, 2013, 12:30:31 pm
Wow, thanks so much, this is sensational!

I can't get the Kindgom Generator to work though. The window comes up, but whatever I type in it says Reference Error:set_parcer is not defined. Have only tried this playing againsts Bots so far. Any ideas what my problem is?


[EDIT: And now suddenly it works. Perhaps asking for help fixes the error? Pretty cool code if so.]

[RE-EDIT: And now same problem again. Perhaps announcing the error is fixed re-triggers the error? OK, I'm stumped.]
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Jdaki on June 17, 2013, 05:54:14 pm
I had the same error. I worked out how to fix it- assuming you're on Chrome too. I clicked the little button to the right in the address bar- it says "run unsafe script" or something. It then crosses through the https bit of the address- but it makes the kingdom generator work...
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: joel88s on June 17, 2013, 06:48:50 pm
Wow, that totally works! (And yes it's also Chrome.) Great fix, many thanks.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 17, 2013, 08:47:46 pm
Yes, in the Chrome version, the set parser script is loaded from http://dom.retrobox.eu/js/1.0.0/set_parser.js rather than being part of the extension itself (weird issues with how Chrome extension js files are executed compared to Firefox). Just make sure that if you're agreeing to run an "unsafe" script, it's the right unsafe script  :P
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on June 18, 2013, 04:55:21 am
Why don't you make this script part of the GM Firefox Script and Chrome Extension?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 18, 2013, 08:20:43 pm
It already is part of the GM Firefox Script. It's not part of the Chrome Extension because of difficulties with how Chrome extensions deal with content scripts...basically the most straightforward way to do that would just be to throw the set parser code right into the main script, which is kind of unwieldy, but since loading it externally is causing problems, it might be worth it anyway.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 19, 2013, 03:24:02 am
Version 1.15.1 published
- the contents of set_parser have been added to the main script to avoid issues some users were having with loading potentially unsafe scripts from other sites
- personal blacklist
-- there is a textarea in the user settings window now; to add players to your personal blacklist, just type in one username per line (case-sensitive)
-- blacklisted players will be auto-booted when joining games you host
-- blacklisted players will not be visible in the player list in the lobbies
-- you will not see chat messages in the lobby from blacklisted players
-- tables/games in the lobby will be hidden if any blacklisted players have joined, unless you have already joined that game. For instance, if someone else is hosting a 3 player game that you have joined, and someone on your blacklist takes the last spot, it will be possible to actually start the game with them. I don't know the best way to handle this case so I figured I'd leave it open and ask the forum. Maybe autoboot yourself in that scenario? Please let me know how you think we should deal with this.

Firefox users who would like to try out the blacklist can get it from my firefox-new branch (https://github.com/michaeljb/Goko-Live-Log-Viewer/tree/firefox-new). No idea what you need to do set it up with Grease Monkey, and it's completely untested on Firefox. Just took all the blacklist-related commits and squashed them down to one.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on June 19, 2013, 04:59:25 am
It already is part of the GM Firefox Script.
It is not part of it. It loads external script like this:
// @require     http://dom.retrobox.eu/js/1.0.0/set_parser.js
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Tombolo on June 19, 2013, 07:54:43 am
The point tracker/log seems to have suddenly stopped displaying.  I'm not sure if I did something or what, but I'm on Chrome, and the extension is still working to some extent because it displays the automated message when I type #vpon, and the kingdom generator still pops up.

Also, this is awesome, thanks for doing it!

Also, would it be possible to have some sort of auto-on thing for the point tracker when playing bots?  I'm playing with bots a lot and I keep forgetting and it's kinda annoying to type it every time anyway.  :P
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: shark_bait on June 19, 2013, 07:57:37 am
The log has disappeared for me too, don't know what's going on.  If anyone could help that'd be great.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on June 19, 2013, 08:02:47 am
Did you check in the options screen wether it's turned on (user settings on the main menu)?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: EgorK on June 19, 2013, 08:24:45 am
Log stoped working for me as well. I do not see any errors in js console
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: shark_bait on June 19, 2013, 09:20:30 am
Did you check in the options screen wether it's turned on (user settings on the main menu)?

There is no check box for the in game log from the user settings menu.  So I dunno how to fix it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: jsh357 on June 19, 2013, 09:21:51 am
Cool, now I can blacklist Serf Bot!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 19, 2013, 10:31:59 am
hmmm, the log seems to be working fine for me. First you should make sure you only have one version of the extension enabled (if you only ever got it from the store, this shouldn't apply, but if you ever installed one through "Load unpacked extension" it might).

If that doesn't fix it, maybe this could help?
- go to Chrome's Settings
- click "Clear browsing data"
- check "Delete cookies and other site and plug-in data"
- reload playdominion.com

This will delete your cookies for other sites too, so you'll lose auto-login info and stuff like that, and since I'm not getting the same problem I'm not sure this will actually fix it...would be easier to help if I was having the same issue... :/
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 19, 2013, 10:33:14 am
It already is part of the GM Firefox Script.
It is not part of it. It loads external script like this:
// @require     http://dom.retrobox.eu/js/1.0.0/set_parser.js

Oh. Probably this then:

basically the most straightforward way to do that would just be to throw the set parser code right into the main script, which is kind of unwieldy

Also if you look at the jison documentation, they recommend keeping the generated parser in a separate script.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: EgorK on June 19, 2013, 12:17:51 pm
Purging goko cookies had not helped, I do not see how removing all can
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: HiveMindEmulator on June 19, 2013, 12:39:23 pm
Yeah, I have the same no log problem. The latest update must have broken something...
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 19, 2013, 12:58:15 pm
Hmm, I can still see the log fine. Weird. I'm on OSX 10.7.5 and running Chrome 27.0.1453.116.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Rabid on June 19, 2013, 01:04:45 pm
Mine wasn't working about a week ago.
User setting something like "show in game log" fixed it.
But that user setting no longer seems to be available.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 19, 2013, 01:12:12 pm
Yeah, that user setting didn't work right, so I took it out after nutki published Version 15. Maybe there's an issue with your user settings because of that? When you're on Goko's site, opening up the Chrome Developer Tools console and typing in "delete localStorage.userOptions" will clear all the options you have saved with the extension, so you'll have to go into the settings window again and rename your created games and whatever else there is. Once again, don't know if that will fix it, I'm kind of just taking shots in the dark here...

Hmm, I can still see the log fine. Weird. I'm on OSX 10.7.5 and running Chrome 27.0.1453.116.

Same.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: HiveMindEmulator on June 19, 2013, 01:14:10 pm
Hmm, I can still see the log fine. Weird. I'm on OSX 10.7.5 and running Chrome 27.0.1453.116.
Mine doesn't work for Chrome 27.0.1453.116 in Windows 7, but it was working yesterday, if that helps.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Tombolo on June 19, 2013, 01:37:15 pm
I'm on Chrome 27.0.1453.110 m and Windows 8, and I was also working fine as of last night.  I haven't tried deleting cookies or the developer console yet, though.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Davio on June 19, 2013, 02:23:58 pm
Seemed to have stopped working for me as well.

Chrome latest and Win 8.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 19, 2013, 02:31:33 pm
Is it just the log that's not working, or other parts of the extension too? Like custom avatar, kingdom generator, lobby pro ranks and player list sorting, etc.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Awaclus on June 19, 2013, 02:56:00 pm
Works for Chrome 27.0.1453.110 m and Windows 7.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Tombolo on June 19, 2013, 03:02:47 pm
Kingdom generator is working fine, log and VP are not.  Haven't looked at the other features yet.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: loppo on June 19, 2013, 03:22:02 pm
Kingdom generator is working fine, log and VP are not.  Haven't looked at the other features yet.
same here. Is it possible to reactivate the button for the log in the user settings? This should take care of everything
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Robz888 on June 19, 2013, 06:19:26 pm
I'm having trouble changing my picture. I have a PNG of the appropriate size, but when I click submit it tells me "No File Chosen."
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Tombolo on June 19, 2013, 08:10:21 pm
Picture works for me.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 19, 2013, 10:38:51 pm
Found the problem, will update with fix tonight.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on June 19, 2013, 10:40:42 pm
If you host an unrated game with a rating requirement, then even people above that rating get kicked.

Dominion Online User Extension 1.15.1
Chrome 27.0.1453.116
Mac OSX 10.8.4
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 20, 2013, 02:04:07 am
Version 1.15.2 published
- hopefully fix missing log/vp tracker
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Robz888 on June 20, 2013, 02:13:28 am
Version 1.15.2 published
- fix missing log/vp tracker

How do I, like, update it to that version.

Explain it like you would to a small child.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 20, 2013, 02:19:52 am
1. Open Chrome
2. Go to your Chrome extensions page (you can type "chrome://extensions" in your address bar)
3. In the top right of the page, it should say "Developer mode" with a checkbox; check the checkbox
4. Now a button should be visible that says "Update extensions now"; click that button
5. Somewhere in your extensions list you should see "Dominion Online User Extension"; next to this, it should say "1.15.2" after updating
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Twistedarcher on June 20, 2013, 02:20:43 am
Alright, so I just downloaded this. Everything's working except I don't have the log on the right. I have autokick, I can see the avatars, and I can generate kingdoms. When I join a game with #vpon in my title, it says the log is enabled -- yet I can't see it.

Anyone have any idea what could be causing this?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 20, 2013, 02:22:26 am
Does your version say 1.15.2, or 1.15.1?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Twistedarcher on June 20, 2013, 02:25:16 am
Ha, I literally downloaded this an hour ago, and 20 minutes later I didn't have the newest version anymore!

I just downloaded the new one, I'll see if that fixes it. Also had cookies disabled and enabled them, although would that affect it?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 20, 2013, 02:26:13 am
Haha, nice timing ;)

I don't think the cookies will affect it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Twistedarcher on June 20, 2013, 02:29:27 am
Got it!! Thanks :)

I do miss the black space though, it looked nicer than this does :P
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 20, 2013, 02:35:44 am
Feel free to contribute to the styling!  ;D
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 20, 2013, 03:21:36 am
So in order to help keep track of suggestions/feature requests/bugs/etc, I've gone through the thread again and thrown a bunch of stuff in to github's issue tracker on my repo. As more issues are raised here, I'll try to update there...or if you want, you could always post it there...

https://github.com/michaeljb/Goko-Live-Log-Viewer/issues
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Tombolo on June 20, 2013, 07:46:03 am
You're a quality individual, thanks!  ;D
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: rrwoods on June 21, 2013, 06:47:53 pm
I hosted a game named "All sets 3600+ #vpon".  My opponent chatted "#vpoff" at the beginning of the game.  The extension responded with "Victory Point tracker setting locked" and the tracker did not disappear, and it updated throughout the game.  Is this normal?  If I want to allow my opponent to turn off the VP tracker, do I need to chat "#vpon" at the beginning of the game rather than putting it in the name of the game?

Thanks for the extension!  I love the log and the custom avatars (and of course the VP tracker).
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 21, 2013, 07:39:29 pm
Yes, that is normal.

Nutki, could you modify the #vpon thing so that people are unable to turn it off if it's in the title of the game? If you don't want to use it yet know in advance it will be on, you should just choose a different game.
Makes sense, I will consider this.


Version 14 released
What's new:
- merged michaeljb's changes
-- sorting of the player list
-- selecting kingdom generator rule
- improved VP tracker interface
-- #vpon in the game title cannot be overruled
-- setting is locked after turn 4
-- adventures always use VP tracker by default (can be changed in the options screen)
-- #vp? in the chat will show the current score for the players not using the extension

Title: Re: Dominion Online User Extension for Firefox, Chrome, and Safari
Post by: michaeljb on June 22, 2013, 01:48:35 pm
Any Safari users here?

Version 1.15.2 now available.

Installation instructions:

1. Download the extension (link in my sig)
2. Double click the downloaded .safariextz file
3. When Safari asks if you would for sure like to install it, click "Install" (note: Safari will move the file away from where you originally downloaded it)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: rrwoods on June 22, 2013, 03:18:50 pm
Yes, that is normal.

Nutki, could you modify the #vpon thing so that people are unable to turn it off if it's in the title of the game? If you don't want to use it yet know in advance it will be on, you should just choose a different game.
Makes sense, I will consider this.


Version 14 released
What's new:
- merged michaeljb's changes
-- sorting of the player list
-- selecting kingdom generator rule
- improved VP tracker interface
-- #vpon in the game title cannot be overruled
-- setting is locked after turn 4
-- adventures always use VP tracker by default (can be changed in the options screen)
-- #vp? in the chat will show the current score for the players not using the extension

That's what I figured; problem is that folks who don't know about the extension (they exist! I've gotten a few "What is that?" when the extension chats about the tracker) don't know that #VPON in the title means anything.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Jacob marley on June 23, 2013, 12:59:27 am
Is there documentation somewhere all in one place?

Thanks
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: tempman on June 23, 2013, 12:40:33 pm
I just downloaded/installed the fire fox version from the first and post and noticed that the card randomizer was not recognizing Worker's Village or any variant I could think of.  I tried searching through the code and noticed that in one place it shows up in the code (line 767) it shows up as "workervillage" with no "s".  I edited this line to "workersvillage" and now it seems to work.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Rabid on June 24, 2013, 08:19:32 am
Version 13 released
What is new:
- fixed problem with staring pro ranked table at the session start
- added a 'ping' sound when a properly ranked player joins the table when using the auto kick mode

Sometimes, when returning home from a multiplayer lobby, the "user settings" link isn't there. I haven't been able to reliably duplicate it yet, so I'm not sure what exactly is causing it.
That I haven't seen. Is it disappearing from the DOM or it just invisible (you can check that with 'inspect element')?

Unsuitable custom avatars.
A player is using a naked picture as an avatar, would it be possible to remove it do you think? 
And if it is possible is this something we want to do?
Yeah, I spotted that when doing backup of my site, I think I will remove it and black list that guy if he does that again. This is exactly why many services do not have completely custom avatars option, you need a moderator then.
Looks like its time for a blacklist.
http://forum.dominionstrategy.com/index.php?topic=8163.msg248775#msg248775
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ftl on June 24, 2013, 05:24:38 pm
Yeah, looks like it's time to deal with that before Goko has to. It's only a matter of time before somebody reports "Goko is showing me porn!" on their official site instead of here, and if they set their minds to fixing that problem, that's not gonna end well for this extension.


Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 26, 2013, 02:46:29 pm
I just downloaded/installed the fire fox version from the first and post and noticed that the card randomizer was not recognizing Worker's Village or any variant I could think of.  I tried searching through the code and noticed that in one place it shows up in the code (line 767) it shows up as "workervillage" with no "s".  I edited this line to "workersvillage" and now it seems to work.

Could we get this fixed, please? When I randomize Prosperity sets, Worker's Village never shows up.

EDIT: For what it's worth, I've confirmed that Worker's Village is the only card with this issue.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on June 26, 2013, 04:03:18 pm
I just downloaded/installed the fire fox version from the first and post and noticed that the card randomizer was not recognizing Worker's Village or any variant I could think of.  I tried searching through the code and noticed that in one place it shows up in the code (line 767) it shows up as "workervillage" with no "s".  I edited this line to "workersvillage" and now it seems to work.

Could we get this fixed, please? When I randomize Prosperity sets, Worker's Village never shows up.

The polite way to echo an existing bug report is just to upvote it and wait. Adding information about the bug is always valuable, and bumping an old inactive issue is okay too, but this one's only three days old. I consider myself lucky if a small software company even answers my e-mail in three days.

I'm sure you don't really mean to tell nutki and michaeljb that they're doing a shitty job of fixing Goko for free, but I'd feel a little slighted in their shoes.

PS: The fix that tempman suggests is actually quite easy to implement yourself. In Firefox, just click the GreaseMonkey icon, "Manage User Scripts," "Preferences" for the Log Viewer extension, and "Edit this User Script." Then just change line 767 as he describes.

Edit: This post came out pretty nasty-sounding. That really wasn't my intention. LF is a very polite fellow, and I didn't/don't mean to criticize him personally at all. I really only wanted to make a point of etiquette for the sake of the sanity of nutki and michaeljb and ok, maybe myself too.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 26, 2013, 04:17:06 pm
Version 1.15.3
- fix the Worker's Village bug
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

Always stacking is something I've wanted pretty much since Goko had stacking for big hands, and last night I stumbled upon the way to do it. so yay.

- published in the Chrome store
- Safari download from my github is updated
- My firefox-new branch is updated
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: jonts26 on June 26, 2013, 04:18:09 pm
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

This makes me happier than you can possibly imagine.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 26, 2013, 04:20:57 pm
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

This makes me happier than you can possibly imagine.

Well, at least I know it was happy enough to give me my 1000th respect ;D
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 26, 2013, 04:29:34 pm
I just downloaded/installed the fire fox version from the first and post and noticed that the card randomizer was not recognizing Worker's Village or any variant I could think of.  I tried searching through the code and noticed that in one place it shows up in the code (line 767) it shows up as "workervillage" with no "s".  I edited this line to "workersvillage" and now it seems to work.

Could we get this fixed, please? When I randomize Prosperity sets, Worker's Village never shows up.

The polite way to echo an existing bug report is just to upvote it and wait. Adding information about the bug is always valuable, and bumping an old inactive issue is okay too, but this one's only three days old. I consider myself lucky if a small software company even answers my e-mail in three days.

I'm sure you don't really mean to tell nutki and michaeljb that they're doing a shitty job of fixing Goko for free, but I'd feel a little slighted in their shoes.

PS: The fix that tempman suggests is actually quite easy to implement yourself. In Firefox, just click the GreaseMonkey icon, "Manage User Scripts," "Preferences" for the Log Viewer extension, and "Edit this User Script." Then just change line 767 as he describes.

Yes, this is a very good call. I didn't mean to be rude but I certainly could have phrased it more politely. I did upvote the post with the bug report, but for some strange reason known not even to me I thought it might have slipped through the cracks. Sorry for coming off as a jerk, guys!

Thanks for fixing the bug, michaeljb, and thanks again to you and Nutki for this most excellent extension!

EDIT: Oh, and I did try to fix the Chrome version myself (which is what I use), but although I managed to download the .crx file (which was itself not trivial), my Mac was unable to successfully unpack it with any of my currently installed software. I'm guessing some of the frustration I felt from that inadvertently made my post sound nastier than I meant it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Voltaire on June 26, 2013, 04:33:15 pm
Version 1.15.3
- fix the Worker's Village bug
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

Always stacking is something I've wanted pretty much since Goko had stacking for big hands, and last night I stumbled upon the way to do it. so yay.

- published in the Chrome store
- Safari download from my github is updated
- My firefox-new branch is updated
Very silly question - how do I update the firefox extension?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on June 26, 2013, 04:35:21 pm
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

Wow, that's awesome! I don't think I'll be using it myself, but that's a sweet feature to have available.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 26, 2013, 04:37:27 pm
I...don't know. If I understand it correctly, whenever nutki updates the script at his github page, it will auto-update for everyone using the script with Grease Monkey.

If you manually download the script for Firefox from my github page (https://github.com/michaeljb/Goko-Live-Log-Viewer/raw/firefox-new/Goko_Live_Log_Viewer.user.js), there might be a way to use that instead. I don't know though.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Voltaire on June 26, 2013, 04:38:39 pm
I...don't know. If I understand it correctly, whenever nutki updates the script at his github page, it will auto-update for everyone using the script with Grease Monkey.
OK, cool...guess I'll just see if the option to stack cards shows up.  :)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 26, 2013, 04:40:47 pm
If you host an unrated game with a rating requirement, then even people above that rating get kicked.

Dominion Online User Extension 1.15.1
Chrome 27.0.1453.116
Mac OSX 10.8.4

Seems I overlooked this. Is it still happening?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on June 26, 2013, 05:08:53 pm
If you host an unrated game with a rating requirement, then even people above that rating get kicked.

Dominion Online User Extension 1.15.1
Chrome 27.0.1453.116
Mac OSX 10.8.4

Seems I overlooked this. Is it still happening?

Yes, but I just discovered why it's happening. I usually use the rating criterion for pro games, but when the game is unrated the extension is using the casual rating instead. So it's not really a bug, just not the behavior I had expected.

Very silly question - how do I update the firefox extension?
If you manually download the script for Firefox from my github page (https://github.com/michaeljb/Goko-Live-Log-Viewer/raw/firefox-new/Goko_Live_Log_Viewer.user.js), there might be a way to use that instead. I don't know though.

The easy-but-inelegant solution is to copy/paste the script michaeljb linked over the existing nutki script. Greasemonkey Icon -> Manage -> Preferences -> Edit opens up the currently installed version of nutki's script, so just replace that code with michaeljb's.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on June 26, 2013, 05:16:17 pm
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

This makes me happier than you can possibly imagine.

I just want to echo this sentiment.  Good job!

Goko Dominion, brought to you by nutki and michaeljb.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Obi Wan Bonogi on June 26, 2013, 05:58:03 pm
Ah, I got the script right when I bought the cards I didn't realize the extension was making the noise when someone joins my game.  Is there any way I can adjust the volume of the notification? (other than lowering the volume on my browser preferably) 
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on June 26, 2013, 07:01:42 pm
I know this might not be possible, but is there any way to fix the issue of when you have too many unique cards in hand?  You can't tell what cards are what, and if someone chats you can't close the chat window.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Schneau on June 26, 2013, 08:31:52 pm
- new option to always stack the cards in your hand (normally only happens when you have 10 or more cards in hand)

This is awesome.

Would it be possible to also sort the cards? Something like Actions always on right, Treasures next, and Victories (and Curses and Reaction-Shelters) on left? If not, no biggie, but it would definitely make things easier.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: florrat on June 27, 2013, 09:35:13 am
I'd love to see a option enabling the Victory Point Tracker when playing against bots. Just like the option that the VP tracker is enabled when playing adventures.

The option to always stack cards in your hand is very nice!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: () | (_) ^/ on June 27, 2013, 09:41:27 am
I'd love to see a option enabling the Victory Point Tracker when playing against bots. Just like the option that the VP tracker is enabled when playing adventures.

The option to always stack cards in your hand is very nice!

Create a new multiplayer game and add a bot, that works.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 28, 2013, 04:56:34 am
Technical Update

My branches were an ugly mess, and I believe I have improved the situation :)

My master branch now includes nutki's two scripts, plus a Rakefile and directories with files needed specifically for Chrome and Safari. Rake tasks generate the .zip to publish in the Chrome store and the .safariextz to install in Safari (since there was an issue for some with loading the set_parser externally, the rake tasks take care of inserting the contents of set_parser.js into the main script). There is also a task to turn the base directory into an "unpacked extension" for development in Chrome.

The develop branch includes features that I've worked on myself; at this point, the blacklist, the Worker's Village fix, and the stacking option. I haven't updated the extension in the Chrome store, since it is still functionally the same.

Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: D Bo on June 28, 2013, 02:59:13 pm
Sorry if this is mentioned elsewhere, but I didn't see it. Most times when I'm playing a bot and go to turn on the VP counter it tells me that it's locked. But this doesn't happen every time and I don't remember it happening when I first got the extension. Is there something I'm doing wrong? I'm using Chrome - let me know if you need more details.

Really appreciate all the work that you guys have put into this!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 28, 2013, 03:04:55 pm
The vp setting gets locked around turn 5 (on turn 5/after turn 5, I don't remember for sure). This prevents someone from starting a game without the point counter turned on, then turning it on late at a crucial moment when their opponent might have wanted the counter off for the whole game.

This was an issue for players who prefer #vpoff, but didn't always type it in, so at the start of the game it seemed like it was going to be a no point counter game.

I can look into lifting the restriction if all the opponents in the game are bots.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: D Bo on June 28, 2013, 03:07:37 pm
The vp setting gets locked around turn 5 (on turn 5/after turn 5, I don't remember for sure). This prevents someone from starting a game without the point counter turned on, then turning it on late at a crucial moment when their opponent might have wanted the counter off for the whole game.

This was an issue for players who prefer #vpoff, but didn't always type it in, so at the start of the game it seemed like it was going to be a no point counter game.

I can look into lifting the restriction if all the opponents in the game are bots.


Ahhhh that makes sense! I'm sure it's because I forgot to turn it on. I really don't need you to worry about finding a work-around for bots - if I can't remember to turn it on by turn five then that's my own fault. And really, it's a game against a bot. So it's not a big deal.

Thanks!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: joel88s on June 28, 2013, 04:14:07 pm
This extension is awesome.

One question, more out of puzzlement than anything: I still can't seem to change my avatar with the latest Chrome version, though I changed it a couple of times before. The page comes up, I select and submit the .png, it says Avatar Saved, but keeps the same (custom) one as before.

I can live with my little Sage, he's not half bad at all, just wondered about it. Does it get sick of you if you try to change too many times?!
Title: Re: Dominion Online User Extension for Firefox, Chrome, Safari, and Opera 15
Post by: michaeljb on June 28, 2013, 08:01:23 pm
Would be awesome if this was available for Opera.

So I got an Opera account and tried uploading it to their store, but it rejected the .zip file, saying "No config file in the package. Please include one and try again." My quick searching didn't turn anything up, and I don't want to spend a bunch of time researching this at the moment.

But there is good news! You can download the .zip from my github page (https://github.com/michaeljb/Goko-Live-Log-Viewer/blob/develop/Dominion-Online-User-Extension-1.15.3.zip?raw=true) and unzip it. Then, in Opera Next 15*, go to the Extensions page (menu bar > Window > Extensions), click "Developer Mode", click "Load unpacked Extension", navigate to the unzipped directory, when you're in the directory where you can see the manifest.json file, click "Select", and then "Dominion Online User Extension" should appear in your list of Extensions. (and yes this is exactly the same thing you can do for Chrome, but since it's in the Chrome store without any problem you don't need to do it in Chrome)

*According to http://dev.opera.com/addons/extensions/ the format for extensions in Opera 11 and 12 will not be supported in Opera 15. Also, Opera 15 happens to be using Chromium extensions, which happily means less work for me :)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SirPeebles on June 29, 2013, 07:32:44 pm
Is it OK to request features in this thread?  It would be really handy if the righthand side of the log -- where deck contents and current points are tracked -- tracked current coin token totals.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on June 30, 2013, 01:23:05 am
Is it OK to request features in this thread?  It would be really handy if the righthand side of the log -- where deck contents and current points are tracked -- tracked current coin token totals.

They have that at the bottom left of the screen already...
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: StrongRhino on June 30, 2013, 01:28:35 am
Is it OK to request features in this thread?  It would be really handy if the righthand side of the log -- where deck contents and current points are tracked -- tracked current coin token totals.

They have that at the bottom left of the screen already...
He means on the log prettyfier thing (I think?)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on June 30, 2013, 06:54:37 pm
small update...

Version 1.15.4
- Stef's shorter URL for this thread (http://goo.gl/4muRB, from this post (http://forum.dominionstrategy.com/index.php?topic=8163.msg245350#msg245350)) is displayed in chat at the beginning of the game
- more info about the VP tracker is displayed in chat at the beginning of the game (typing "#vp?" to display scores, typing #vpon/off before turn 5)

and another technical change in regards to the branches of my github repo...
- features: changes to the actual extension script(s)
- browsers: files dealing with creating the extension packages for other browsers
- master: a merge of features and browsers together
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: liopoil on June 30, 2013, 09:20:00 pm
my extension has disappeared... I have version 1.15.4, and it is enabled and everything in my chrome web store.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: blueblimp on June 30, 2013, 10:02:45 pm
my extension has disappeared... I have version 1.15.4, and it is enabled and everything in my chrome web store.
Yeah I get a syntax error:

Uncaught SyntaxError: Unexpected token } chrome-extension://kaignighoceeemhinbbophdeogpnedjn/Goko_Live_Log_Viewer.user.js:1468

Seems like some kind of broken version of this file, because there is a stray parentheses in this code block:

//
// Always Stack module
//
// Goko dependencies:
// - addView API (setting stackCards in that function, value of autoStackCards)
// Internal dependencies:
// - options.alwaysStack
//
FS.Cards.CardStackPanel.prototype.old_addView =
FS.Cards.CardStackPanel.prototype.addView;
FS.Cards.CardStackPanel.prototype.addView = function(view, index) {
    }
    return ret;
};
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: blueblimp on June 30, 2013, 10:07:29 pm
I've attached the complete version of the Goko_Live_Log_Viewer.user.js that my Chrome has, if that helps.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Tombolo on June 30, 2013, 10:49:16 pm
It's gone for me as well.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on July 01, 2013, 12:01:52 am
It seems to be working fine for me on FF, so this is likely a Chrome-specific issue.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Eevee on July 01, 2013, 12:18:18 am
Heh, it's gotten to the point where I just completely stop playing on goko until it's fixed when something like this happens..

Thanks for making such a great extension! You truly are making my goko experience more enjoyable.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: clb on July 01, 2013, 01:25:33 am
I played a few games with it just fine, then it disappeared on me when I clicked on my avatar, didn't have a custom one to upload, then clicked "back to Dominion online". Chrome store says that I have it installed, but it doesn't show in my list of applications.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on July 01, 2013, 01:49:20 am
Found the problem, should have the fix uploaded within an hour, plus however long it takes to publish in the Chrome store. Sorry guys.

And thanks blueblimp, that was in fact very helpful!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on July 01, 2013, 02:53:09 am
Version 1.15.5
- fix Rakefile bug

In the package that is created for the extension, set_parser.js is inserted into the main script as some users were experiencing problems due to importing the script from dom.retrobox.eu. Additionally, the lines in the main script that did the importing of set_parser.js were being skpped; however, the skipping was based on line number, and the line numbers that were coded in corresponded to the lines in nutki's Version 15 rather than my latest version.
Now, instead of counting on specific line numbers, it looks for the actual contents of the line to know when to start and stop skipping lines.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ednever on July 01, 2013, 10:38:05 am
A question and a small request:

First the question:
Can someone walk me thorough how to chane my avatar? (Not sure if that's related to the extension or not, but it seems to be mentions in this thread)

Second, the request:
Right now chat is a pain. You have to click to open a new window. When you do, it covers your cards. So I pop the open up and down depending on when I want to use it. It means I use it less. A lot less than I did on iso.
Right now the extension gives you a great look at the log on the right. What if that right-hand-space was split into two sections. One the same as it is now, the other (either on top or on bottom) was a chat box. It would not need to be very big as long as you could scroll.

Would that work?

Ed
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on July 01, 2013, 10:46:06 am
To change yourr avatar:
Go to the Main menu screen (where it says adventures, multiplayer, play against bots..)
Click your avatar face in the very top right corner of the screen.
Rest should be clear when yxou're there.

Regarding chat: That has been suggested before, and I think it turned out there is no (easy) way to do it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: liopoil on July 01, 2013, 10:52:23 am
it's working for me now.

This thing is amazing. When I got the extension, I thought all it did was count points and make a pretty log (which is great by itself). I thought all the other stuff, the avatars, card stacking, displaying pro ratings, etc. was just goko improving!

A suggestion:

I don't own any sets on goko, but my pro rating hovers around 5000-5500. So I can join the "4500+" type games, and those usually have cards. So I never host, just join games. I also join pro games that just say "username's game". Most of these have the expansions, but many times I've joined it to see it was all base set, which I don't really enjoy all too much. Would there be a way to display what expansions the player hosting the game has?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ednever on July 02, 2013, 03:47:12 pm
To change yourr avatar:
Go to the Main menu screen (where it says adventures, multiplayer, play against bots..)
Click your avatar face in the very top right corner of the screen.
Rest should be clear when yxou're there.

Regarding chat: That has been suggested before, and I think it turned out there is no (easy) way to do it.

Thanks!
I now have my first avatar. I am Sir Vander!

Ed
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on July 02, 2013, 08:45:31 pm
Out of interest, the always-stack-cards option doesn't seem to work on Firefox--and a blacklist feature was mentioned somewhere, but I'm not sure if that was still pre-alpha.  Are these things both on Chrome and not FF?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: liopoil on July 02, 2013, 08:47:03 pm
Out of interest, the always-stack-cards option doesn't seem to work on Firefox--and a blacklist feature was mentioned somewhere, but I'm not sure if that was still pre-alpha.  Are these things both on Chrome and not FF?
it's set off on default, you have to turn it on under settings on the main menu
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on July 02, 2013, 09:23:51 pm
Out of interest, the always-stack-cards option doesn't seem to work on Firefox--and a blacklist feature was mentioned somewhere, but I'm not sure if that was still pre-alpha.  Are these things both on Chrome and not FF?
it's set off on default, you have to turn it on under settings on the main menu

I don't even have a setting for it... have tried reinstalling a couple times.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Voltaire on July 03, 2013, 11:03:38 am
Out of interest, the always-stack-cards option doesn't seem to work on Firefox--and a blacklist feature was mentioned somewhere, but I'm not sure if that was still pre-alpha.  Are these things both on Chrome and not FF?
it's set off on default, you have to turn it on under settings on the main menu

I don't even have a setting for it... have tried reinstalling a couple times.
Same here.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on July 03, 2013, 11:21:04 am
I think the Firefox version simply hasn't been updated yet.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: D Bo on July 04, 2013, 02:27:27 pm
Haven't played in a couple days but now when I go to play a game, the extension has disappeared (no kingdom select or point counter). I use Chrome and I went to get the app again but it says I already have it. Any thoughts on what I'm missing?

Also I'm kind of an idiot with computers so as much detail as possible to fix is appreciated!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on July 04, 2013, 02:28:57 pm
Version 1.15.4 is broken, fixed in Version 1.15.5. If you're not sure how to update it, follow the instructions in this post (http://forum.dominionstrategy.com/index.php?topic=8163.msg259175#msg259175).
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: D Bo on July 04, 2013, 02:34:28 pm
Version 1.15.4 is broken, fixed in Version 1.15.5. If you're not sure how to update it, follow the instructions in this post (http://forum.dominionstrategy.com/index.php?topic=8163.msg259175#msg259175).

You the man, thanks!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: StrongRhino on July 05, 2013, 12:28:59 am
I'm no programmer, but would it be somehow possible to have a "text mode" like iso?
Thanks.

Edit: also on Chrome, the log is way too big. Maybe that's something on my side. Anyone else have it?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: kn1tt3r on July 05, 2013, 02:59:24 am
the log is way too big. Maybe that's something on my side. Anyone else have it?

You mean too wide? This depends on your screen resolution and the size of the Goko window on your screen. The log width is always the difference of your screen to the Goko window. I think.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on July 05, 2013, 05:16:36 am
I sometimes have that all of a sudden the log takes up half my screen and the Goko interface is reduced in size. It used to happen quite regularly, but I've encountered it only once (yesterday) during the last few weeks.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: StrongRhino on July 05, 2013, 11:21:22 am
I sometimes have that all of a sudden the log takes up half my screen and the Goko interface is reduced in size. It used to happen quite regularly, but I've encountered it only once (yesterday) during the last few weeks.
This is what was happening to me. I've yet to try it today though.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on July 05, 2013, 11:50:40 am
I think this happens to me on Firefoix occassionally. Reloadinbg the page fixes it though.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on July 05, 2013, 03:52:11 pm
I sometimes have that all of a sudden the log takes up half my screen and the Goko interface is reduced in size. It used to happen quite regularly, but I've encountered it only once (yesterday) during the last few weeks.

This is something that happens with Goko, with or without the extension. I have no idea why.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on July 06, 2013, 05:04:50 pm
I know why:

Because Goko sucks
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: blueblimp on July 06, 2013, 10:08:05 pm
Feature request: one of the nice features of Iso is that it would beep whenever you had to do something. On Goko it only beeps at the start of your turn. It would really nice if it beeped whenever you need to take action, so that it's fine to look away when, for example, your opponent is taking awhile to decide what to discard to Militia.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: nomnomnom on July 07, 2013, 11:36:34 am
Another feature request: Would it be possible to move the chat window thing so that it does not stop you from playing cards? Also this would allow you to have it open all the time.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on July 07, 2013, 02:38:20 pm
Another feature request: Would it be possible to move the chat window thing so that it does not stop you from playing cards? Also this would allow you to have it open all the time.

This would be nice, and there are a number of other UI elements that ought to be relocated. The current layout makes some horrible compromises for the sake of 6 player games, and displaying avatars, and keeping the whole thing in a 1024x768 footprint.

IMO, it would be a lot better to:

1. Increase the default size for the 90% of web users with resolutions larger than 1024x768 (http://www.w3schools.com/browsers/browsers_display.asp).
2. Take advantage of the extra space in 2-player games to display the 11th & 12th cards.
3. Display VP/coin/TR/Pirate tokens and discard piles by default, and show avatars only when clicked, rather than the other way around.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Narz on July 07, 2013, 02:52:03 pm
Sorry if this has been explained before but I don't see how to create a custom av.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Narz on July 07, 2013, 02:52:37 pm
Feature request: one of the nice features of Iso is that it would beep whenever you had to do something. On Goko it only beeps at the start of your turn. It would really nice if it beeped whenever you need to take action, so that it's fine to look away when, for example, your opponent is taking awhile to decide what to discard to Militia.
Seconded!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on July 07, 2013, 02:58:54 pm
  • Custom avatars. By clicking on the avatar picture in the top right corner of the main dominion page (where you can choose between Adventure, Multiplayer, etc.) you can upload your custom avatar. It will be visible only to other users of the extension script. The uploaded file has to be a png up to 20KB. (since version 3)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Narz on July 07, 2013, 06:30:52 pm
Thank you sir!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ashersky on July 07, 2013, 09:50:33 pm
1. Open Chrome
2. Go to your Chrome extensions page
  -- in the place where you would normally type "forum.dominionstrategy.com" you can type "chrome://extensions" to take you there
3. In the top right of the page, it should say "Developer mode" with a checkbox; check the checkbox
4. Now a button should be visible that says "Update extensions now"; click that button
5. Somewhere in your extensions list you should see "Dominion Online User Extension"; next to this, it should say "1.15.2" after updating

Might add this to the OP to stave off a few questions.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: GwinnR on July 09, 2013, 04:39:28 am
I posted this in the wrong thread. Maybe someone can help me here:

Did you change something with the size or the resolution of the log? Because now the normal game window is zoomed in, so i don't see all of it. And if i zoom out manually the log is very small.
Or does someone know, how to change this?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Vermillion on July 10, 2013, 04:43:07 pm
Every game it prompts me to turn vpon or vpoff. I'd rather not have this dialogue at all.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on July 10, 2013, 08:28:50 pm
There are a whole lot of CORS errors popping up in the JS console. They seem to be from loading avatar images from dom.retrobox.eu, which I don't really understand since the custom avatars do get loaded eventually.

From my JS console:
Code: [Select]
GET http://dom.retrobox.eu/avatars/50c727dde4b063fd72cb9a8a.png 404 (Not Found) gameClient.html:940
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1

I'm guessing this could be fixed with a "Access-Control-Allow-Origin: *" on retrobox, but maybe there's a better solution.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: blueblimp on July 15, 2013, 03:22:45 am
Feature request: replace base card art with the art from Base Cards. (Seems a little silly that Goko hasn't yet done this themselves. There is a getsatisfaction thread (https://getsatisfaction.com/goko/topics/new_base_cards_implementation) on the topic but it's been 7 months since it got a response.)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on July 15, 2013, 10:40:10 am
Feature request: replace base card art with the art from Base Cards. (Seems a little silly that Goko hasn't yet done this themselves. There is a getsatisfaction thread (https://getsatisfaction.com/goko/topics/new_base_cards_implementation) on the topic but it's been 7 months since it got a response.)

Hmm, this brings up the question of what would happen if the extension implemented features that Goko is charging money for?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: GwinnR on July 15, 2013, 10:54:26 am
Feature request: replace base card art with the art from Base Cards. (Seems a little silly that Goko hasn't yet done this themselves. There is a getsatisfaction thread (https://getsatisfaction.com/goko/topics/new_base_cards_implementation) on the topic but it's been 7 months since it got a response.)

Hmm, this brings up the question of what would happen if the extension implemented features that Goko is charging money for?
I REALLY don't know the american(?) law, so only some thoughts of it:

I think it can't really matter whicht art you see on your screen. I think if we want curses to be blue they couldn't do anything.
Something different can be because of the copyright (but is it forbitten to save proprietary pictures on your computer) or if goko says you may not change the interface (so the whole extension would be illegal).
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: RTT on July 19, 2013, 08:39:05 am
how is the blacklist supposed to work ?
just added a name there but the played could still join my table. ?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on July 19, 2013, 09:04:29 am
how is the blacklist supposed to work ?
just added a name there but the played could still join my table. ?

Sounds like you're using it right; you just need to add a name there. I just tested it with two accounts on my computer and it seems to work. (I also learned that if you have the game set to "request to join," the blacklisted player is not automatically denied, but even if you accept, they will be auto-booted then.)

My first guess is that you're entering the name incorrectly; Goko player names are case-sensitive, so I left the blacklist case-sensitive as well. The problem with this, of course, is that sometimes it's hard to tell when a username has capital letters...I might be able to add a 'blacklist' button to the little popup that shows the player's record, casual rating, pro rating, and quit percentage (and the 'Kick' button when they're sitting at your table in the lobby) so that it doesn't rely on you typing it just right.

Even though it is pretty unlikely to happen, I ('michaeljb') wouldn't want to be autobooted from someone's game because they didn't want to play with 'Michaeljb,' and I don't want that to happen to other people either, so I'd like to keep it case-sensitive.

I think I'll try to add a button; that way if you do type in the name wrong, you can just click on their avatar in the lobby and blacklist them there.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: RTT on July 19, 2013, 09:15:46 am
that sounds nice with the button. but im pretty sure i spelled the name right. the name had a number in it but that shouldnt be a problem right?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on July 19, 2013, 09:19:09 am
Shouldn't be.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: pst on July 19, 2013, 10:06:09 am
Another feature request:

When there's an empty spot in a game that you're not qualified for, grey out the "Join" (or maybe don't show that game at all).
Just to avoid joining games where you will be (auto-)kicked-out anyway.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: GwinnR on July 19, 2013, 10:28:59 am
Where can I write someone in the blacklist?
And does this also prevents me from joining the "wrong" games?

Thanks.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: pst on July 20, 2013, 09:24:19 am
Feature request: replace base card art with the art from Base Cards.

Replace all art with the prototype art we know from Isotropic!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Joseph2302 on July 20, 2013, 10:27:43 am
Where can I write someone in the blacklist?

On the first screen (the one that says adventures, multiplayer etc..), click the words "User Settings". On there is a box that says "Personal Blacklist".
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: GwinnR on July 20, 2013, 10:31:35 am
Where can I write someone in the blacklist?

On the first screen (the one that says adventures, multiplayer etc..), click the words "User Settings". On there is a box that says "Personal Blacklist".
Not at my extension. I have the one for Firefox. Do I have to update it or something?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on July 20, 2013, 01:37:51 pm
Where can I write someone in the blacklist?

On the first screen (the one that says adventures, multiplayer etc..), click the words "User Settings". On there is a box that says "Personal Blacklist".
Not at my extension. I have the one for Firefox. Do I have to update it or something?

FF extension is a few versions behind the Chrome version.  It doesn't have blacklist or auto stacking yet.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on July 20, 2013, 04:26:37 pm
FF extension is a few versions behind the Chrome version.  It doesn't have blacklist or auto stacking yet.

FF users can download michaeljb's latest script here (https://github.com/michaeljb/Goko-Live-Log-Viewer/raw/master/Goko_Live_Log_Viewer.user.js). As usual, you need to have GreaseMonkey installed.

The problem is that we've lost nutki. :'( All the recent features have been developed by michaeljb alone. His signature has links to his up-to-date Chrome and Safari versions, but his FF link is nutki's old version.

If nutki ever signs on to github again he'll be able to accept all or part of michaeljb's update and still retain creative control of the FF version of the script. That's very polite and probably proper github etiquitte. I'm less polite than michaeljb.

PS: If you find this useful and feel like upvoting, upvote one of michaeljb's posts instead.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: () | (_) ^/ on July 20, 2013, 04:42:29 pm
PS: If you find this useful and feel like upvoting, upvote one of michaeljb's posts instead.

HOW DARE YOU TELL ME WHO TO UPVOTE...

+1

TRY AND STOP ME.

(also, thanks for the info -- as a FF user, I was wondering if we were being left behind...)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on July 20, 2013, 05:37:10 pm
That's very polite and probably proper github etiquitte. I'm less polite than michaeljb.
In before decline of civility on github.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on July 21, 2013, 02:56:20 am
The problem is that we've lost nutki. :'( All the recent features have been developed by michaeljb alone. His signature has links to his up-to-date Chrome and Safari versions, but his FF link is nutki's old version.

Updated the link to my current script, until nutki updates his again. I'll also keep my 'features' branch live to enable easy merging into nutki's repo unless he reappears and 'officially' announces that he won't be maintaining it any more.

(also, thanks for the info -- as a FF user, I was wondering if we were being left behind...)

sorry for not being more clear about what was going on here



Shouldn't be.

Quote from: Respect on above post
+4

wat
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on July 21, 2013, 07:14:48 am
My github repo finally has a README.md. It's very basic for now and I plan to spruce it up later.

Feature-wise there's not much exciting yet. The next update will have (hopefully) less-obnoxious messaging at the beginning of the game; instead of sending like 3 or 4 chats about how the point tracker works, it's combined into one.

I'm also adding an option to effectively turn off the point tracker. If your opponent still has the tracker enabled, you will still be able to access the score by typing "#vp?" the same way a non-extension user would.

For more tracker fun, I'm also going to include an option to basically always type "#vpon" or "#vpoff" when you join a game.

The only thing that's holding me up is the menu stuff; as it is now there are 3 checkboxes: 1 to enable/disable the point tracker, 1 to always send "#vpon" and 1 to always send "#vpoff." Clearly, allowing them all to be selected (and some other combinations) doesn't make much sense, so the menu interface should be set up to only allow the sensical choices.

Anyhow I've just pushed that to a dev branch (https://github.com/michaeljb/Goko-Live-Log-Viewer/tree/dev) in case anyone wants to take a look at it*. Forking the repo and sending a pull request back to dev should probably work fine.

*relevant commits
https://github.com/michaeljb/Goko-Live-Log-Viewer/commit/5d64b0927cdd221045da645f8e85c77e621d27ea
https://github.com/michaeljb/Goko-Live-Log-Viewer/commit/83197b8f2f10cce2f24eae26c9912327cb84f40e
https://github.com/michaeljb/Goko-Live-Log-Viewer/commit/9faf6da1848f4dce89a563cc567bce420b16b8b1
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mail-mi on July 21, 2013, 01:30:40 pm
Shouldn't be.

Quote from: Respect on above post
+4

wat


PS: If you find this useful and feel like upvoting, upvote one of michaeljb's posts instead.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: AdamH on July 22, 2013, 10:11:25 am
For Casual/unrated games, maybe someone could add the feature to specify start player (by seat?) This would be very useful for the upcoming GokoDom II tournament.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: shraeye on July 22, 2013, 01:17:18 pm
Hear hear!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: qmech on July 23, 2013, 04:30:47 am
For Casual/unrated games, maybe someone could add the feature to specify start player (by seat?) This would be very useful for the upcoming GokoDom II tournament.

That might have to be Goko.  I'd have hoped by now that they've learnt to do this stuff on the server side (at least for Pro games, and I can't imagine them doing Casual games differently).
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on July 23, 2013, 04:35:27 am
For Casual/unrated games, maybe someone could add the feature to specify start player (by seat?) This would be very useful for the upcoming GokoDom II tournament.

That might have to be Goko.  I'd have hoped by now that they've learnt to do this stuff on the server side (at least for Pro games, and I can't imagine them doing Casual games differently).

They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: soulnet on July 23, 2013, 04:53:26 am
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.

Obvious feature request: Give an option to enable all sets, including the ones not owned by the user.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Warfreak2 on July 23, 2013, 05:00:54 am
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.
How did these clowns ever secure a contract with anybody?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on July 23, 2013, 05:07:31 am
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.

Obvious feature request: Give an option to enable all sets, including the ones not owned by the user.

Um... no. And have fun deciphering their "code."
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on July 23, 2013, 05:10:46 am
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.
So this is that other way how to to get Promos without Adventures ;)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Titandrake on July 23, 2013, 12:32:15 pm
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.
How did these clowns ever secure a contract with anybody?

IIRC Goko outsourced their HTML5 coding to Agility, because they realized they weren't really an HTML company. The problem is that if you have to outsource the key component of your software, it's a Bad Idea.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on July 23, 2013, 12:38:48 pm
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.
How did these clowns ever secure a contract with anybody?

IIRC Goko outsourced their HTML5 coding to Agility, because they realized they weren't really an HTML company. The problem is that if you have to outsource the key component of your software, it's a Bad Idea.

Which implies the question, if Goko isn't doing the coding any longer, and they aren't creating new games... why do they exist?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: blueblimp on July 23, 2013, 04:56:47 pm
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.
So this is that other way how to to get Promos without Adventures ;)
Seriously, as tedious as reverse engineering the Goko code can be, it's less tedious than playing through all the adventures. I'm tempted. (Just a bit.)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Schneau on July 23, 2013, 04:58:18 pm
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.
So this is that other way how to to get Promos without Adventures ;)
Seriously, as tedious as reverse engineering the Goko code can be, it's less tedious than playing through all the adventures. I'm tempted. (Just a bit.)

While you're at it, can you reverse engineer their rating system so we can write it down in an equation?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: blueblimp on July 23, 2013, 04:59:23 pm
Feature request: replace base card art with the art from Base Cards. (Seems a little silly that Goko hasn't yet done this themselves. There is a getsatisfaction thread (https://getsatisfaction.com/goko/topics/new_base_cards_implementation) on the topic but it's been 7 months since it got a response.)

Hmm, this brings up the question of what would happen if the extension implemented features that Goko is charging money for?
As far as base card art goes, it's a hypothetical question only at this point, as the only info from Goko is that 7 months ago a community rep said that maybe someday they might charge for it.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ashersky on July 23, 2013, 06:44:57 pm
Which implies the question, if Goko isn't doing the coding any longer, and they aren't creating new games... why do they exist?

Thank you for not saying "begs."
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on July 23, 2013, 06:48:06 pm
Which implies the question, if Goko isn't doing the coding any longer, and they aren't creating new games... why do they exist?

Poof! Goko just disappeared.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: florrat on July 23, 2013, 07:23:33 pm
in a puff of logic
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: eHalcyon on July 23, 2013, 08:56:06 pm
They have learned nothing. I recently discovered that even verification of the sets you own happens client-side.
So this is that other way how to to get Promos without Adventures ;)
Seriously, as tedious as reverse engineering the Goko code can be, it's less tedious than playing through all the adventures. I'm tempted. (Just a bit.)

While you're at it, can you reverse engineer their rating system so we can write it down in an equation?

But it's too complicated to just plop into a formula!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mail-mi on July 29, 2013, 03:53:51 pm
It stopped working!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on July 29, 2013, 04:24:52 pm
Which implies the question, if Goko isn't doing the coding any longer, and they aren't creating new games... why do they exist?

Poof! Goko just disappeared.

in a puff of logic

Watno made a joke
florrat dumbed it down
Watno got +1 respect
florrat got +4

Seriously folks... what sort of message are we sending to our kids? All is well.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: mail-mi on July 29, 2013, 04:26:54 pm
It stopped working!
!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: jonts26 on July 29, 2013, 04:34:43 pm
Which implies the question, if Goko isn't doing the coding any longer, and they aren't creating new games... why do they exist?

Poof! Goko just disappeared.

in a puff of logic

Watno made a joke
florrat dumbed it down
Watno got +1 respect
florrat got +4

Seriously folks... what sort of message are we sending to our kids?

I think florrat got the respect for making a reference to Hitchhiker's Guide. It doesn't seem like watno was making that reference, just a more general logic joke. And people love their hitchhiker's here.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on July 29, 2013, 04:43:30 pm
Which implies the question, if Goko isn't doing the coding any longer, and they aren't creating new games... why do they exist?

Poof! Goko just disappeared.

in a puff of logic

Watno made a joke
florrat dumbed it down
Watno got +1 respect
florrat got +4

Seriously folks... what sort of message are we sending to our kids?

I think florrat got the respect for making a reference to Hitchhiker's Guide. It doesn't seem like watno was making that reference, just a more general logic joke. And people love their hitchhiker's here.

Hmm... good point. I redirect my criticism to Watno for either failing to make the HG reference or for failing to word it properly.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Watno on July 30, 2013, 08:52:32 am
42
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on July 31, 2013, 12:42:19 am
Version 1.15.6
- Option to turn off point tracker entirely (so the extension on your end acts as if you don't have a point tracker)
- Options to always send "#vpon" or "#vpoff" messages in the chat (these messages won't send if #vpon/off is in the game title)
- The obnoxious messages at the beginning of the game about the point tracker and about the extension in general have been made slightly less obnoxious by being combined into just 1 message when possible. Note that if you have the point tracker disabled, the messages about typing in #vpon/#vpoff will not appear

All the other commits since the last release is mainly README and Rakefile stuff, which is still far from where I want them to be, but fortunately nothing any of you fine folks need to worry abou.

I've been busier* than normal lately, so I haven't done in terms of automatch, but I might have more time the next few days.

As usual, links are in my signature, and the Chrome store might take a bit of time to update.


*a small but not wholly insignificant amount of this busy-ness may be related to me occasionally playing Dominion instead of programming for it :)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on July 31, 2013, 12:46:54 am
Version 1.15.6
- Option to turn off point tracker entirely (so the extension on your end acts as if you don't have a point tracker)
- Options to always send "#vpon" or "#vpoff" messages in the chat (these messages won't send if #vpon/off is in the game title)
- The obnoxious messages at the beginning of the game about the point tracker and about the extension in general have been made slightly less obnoxious by being combined into just 1 message when possible. Note that if you have the point tracker disabled, the messages about typing in #vpon/#vpoff will not appear

All the other commits since the last release is mainly README and Rakefile stuff, which is still far from where I want them to be, but fortunately nothing any of you fine folks need to worry abou.

I've been busier* than normal lately, so I haven't done in terms of automatch, but I might have more time the next few days.

As usual, links are in my signature, and the Chrome store might take a bit of time to update.


*a small but not wholly insignificant amount of this busy-ness may be related to me occasionally playing Dominion instead of programming for it :)

Here's my money.  Now make automatch.

(Take your time, just know I'm looking forward to it)
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ashersky on July 31, 2013, 12:49:47 am
Here's my money.

Wait, there's a place where we can send money to these guys?  How did I miss this?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: sudgy on July 31, 2013, 12:52:51 am
Here's my money.

Wait, there's a place where we can send money to these guys?  How did I miss this?

Here it is, [gives a link to a site that gives me money instead of them].
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Polk5440 on July 31, 2013, 10:01:36 am
Here's my money.

Wait, there's a place where we can send money to these guys?  How did I miss this?

If you are serious about this, PayPal accounts/transfers can be set up. Dougz refused this for some time then finally caved to the throngs of people bugging to send him cash as a thank you for Iso.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: GeoLib on August 02, 2013, 12:52:40 am
Feature Request: I don't really know how feasible this is, but it seems like goko has no intention of fixing its atrocious lobby system. Would it be possible to display all the current open games in all lobbies and then allow you to click on the game to move to the lobby and join the game? If this is feasible, then extra options that would be nice are the ability to filter by # of players, rating, available sets, etc. Really this is just how the goko lobby system should work.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on August 02, 2013, 01:33:25 am
Feature Request: I don't really know how feasible this is, but it seems like goko has no intention of fixing its atrocious lobby system. Would it be possible to display all the current open games in all lobbies and then allow you to click on the game to move to the lobby and join the game? If this is feasible, then extra options that would be nice are the ability to filter by # of players, rating, available sets, etc. Really this is just how the goko lobby system should work.

Definitely a valuable idea.

It's harder than it should be because of how the Goko architecture is designed. You can't explicitly query rooms and you only get table/player updates for the rooms you've joined. Further, a single connection can't join more than one room, even though many of the data structures and methods are clearly meant to handle multiple rooms. I'm not sure what went wrong during the Goko development process, but there's not much that would surprise me at this point.

So far the best workaround I've found is creating additional connections on login, much like logging in with additional tabs, and sending each of these connections to watch a different room. This still leaves the problem of actually displaying the games in other rooms and/or automatically joining games that match your preferences. It's not easy, but it's doable.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on August 02, 2013, 12:24:33 pm
I'm not sure what went wrong during the Goko development process...

...it involved Goko personnel.  That's the main thing that went wrong, I think.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: GeoLib on August 02, 2013, 01:54:49 pm
Feature Request: I don't really know how feasible this is, but it seems like goko has no intention of fixing its atrocious lobby system. Would it be possible to display all the current open games in all lobbies and then allow you to click on the game to move to the lobby and join the game? If this is feasible, then extra options that would be nice are the ability to filter by # of players, rating, available sets, etc. Really this is just how the goko lobby system should work.

Definitely a valuable idea.

It's harder than it should be because of how the Goko architecture is designed. You can't explicitly query rooms and you only get table/player updates for the rooms you've joined. Further, a single connection can't join more than one room, even though many of the data structures and methods are clearly meant to handle multiple rooms. I'm not sure what went wrong during the Goko development process, but there's not much that would surprise me at this point.

So far the best workaround I've found is creating additional connections on login, much like logging in with additional tabs, and sending each of these connections to watch a different room. This still leaves the problem of actually displaying the games in other rooms and/or automatically joining games that match your preferences. It's not easy, but it's doable.

I look forward to any solution you come up with. Thank you (and nutki, and michaeljb) for all of your work on this. You guys should really be getting money from goko because you've turned their product into something that's actually playable.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: gunslinger on August 04, 2013, 09:54:17 pm
It seems like the VP counter in Adventure mode has stopped working for me. Anyone else notice this? Or is it something the devs wanted to change? I tried uninstalling and reinstalling the extension and it's still not working. Everything in multiplayer is just fine though.

I've just started playing Dominion a couple months ago, and online about 3 weeks ago, but this extension makes everything about Goko more enjoyable, so thanks!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on August 05, 2013, 02:32:48 am
Introducing Goko Salvager 2.0

The extension now includes Andrew's work on automatch, a new name, and is available as a full Firefox extension instead of just a GreaseMonkey script.

I believe it should update automatically for Chrome users, Firefox users will need to remove the GreaseMonkey script version and get the new version from the Firefox Add-on store, and Safari users will need to manually download and reinstall it. Links for all that nonsense are in my signature.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ashersky on August 05, 2013, 08:00:52 am
FYI, the Automatch button works in Chrome, but the "Submit" button within that does not.  Everything else is clickable.  Am I doing it wrong?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: yed on August 05, 2013, 08:56:44 am
Automatch is currently not working, not sure why, probably server issue.

michaeljb, ragingduckd: I've just send pull request, which fixes missing reconnect automatch URL.
https://github.com/michaeljb/Goko-Salvager/pull/22
Is this all right?
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: shark_bait on August 05, 2013, 09:13:29 am
The user settings button has also disappeared for us chrome users.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on August 05, 2013, 09:18:40 am
FYI, the Automatch button works in Chrome, but the "Submit" button within that does not.  Everything else is clickable.  Am I doing it wrong?

It's not you. It's me. I switched to secure websocket protocol, which is necessary when you log onto the default https goko site, but I screwed up my server SSL certificate. I'm working on it, but it turns out to be a lot more nuisance than I'd thought.

michaeljb, ragingduckd: I've just send pull request, which fixes missing reconnect automatch URL.
https://github.com/michaeljb/Goko-Salvager/pull/22
Is this all right?

Yes, good catch. Thanks.

The user settings button has also disappeared for us chrome users.

This is a separate issue. Ihad to change the original log viewer JS file to make it work with the Firefox Add-on SDK, and I may have broken the Chrome build in the process. I'll look into it unless michaeljb tracks it down first.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Kirian on August 05, 2013, 09:26:07 am
Introducing Goko Salvager 2.0

If I play Goko Salvager and trash Goko from my hand, do I get its cost in Gokoins back?

Edit: anyone who decides to upvote my joke post had better go upvote michaeljb's post as well, or even instead!!
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: michaeljb on August 05, 2013, 09:45:16 am
Introducing Goko Salvager 2.0

If I play Goko Salvager and trash Goko from my hand, do I get its cost in Gokoins back?

Edit: anyone who decides to upvote my joke post had better go upvote michaeljb's post as well, or even instead!!

Also one of ragingduckd's, he came up with the name.

The user settings button has also disappeared for us chrome users.

It is showing up for me, so that sucks... What if you refresh after you're logged in?

Automatch is currently not working, not sure why, probably server issue.

michaeljb, ragingduckd: I've just send pull request, which fixes missing reconnect automatch URL.
https://github.com/michaeljb/Goko-Salvager/pull/22
Is this all right?

It's pulled, but I definitely don't have time to do a release right now.

For the more tech-savvy who just can't wait...

To build the latest code yourself, clone the repository, and run "rake build:$browser" where $browser is 'chrome' or 'firefox' or 'safari'. This will create a build/ directory and drop the appropriate package there. I think for Chrome you might have to use the unpacked extension method instead of clicking-and-dragging the zip file...for Firefox, I think you need to be running something with the add-on SDK before you do the rake task, and for Safari you need to follow the instructions here (http://blog.streak.com/2013/01/how-to-build-safari-extension.html) for doing the certificate setup (my project assumes you'll have your certificates stored in ~/.safari-certs).

Also I need to update the README, like a lot :P
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: ragingduckd on August 05, 2013, 10:04:37 am
The user settings button has also disappeared for us chrome users.

It is showing up for me, so that sucks... What if you refresh after you're logged in?

shark_bait, please use "Inspect Element" and copy the console output here. I'm thinking it may be a race condition where the Goko objects we're relying on aren't getting instantiated in time (and we're not explicitly checking for them). That could explain why it's happening on your machine but not michaeljb's.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: shark_bait on August 05, 2013, 10:48:02 am
The user settings button has also disappeared for us chrome users.

It is showing up for me, so that sucks... What if you refresh after you're logged in?

shark_bait, please use "Inspect Element" and copy the console output here. I'm thinking it may be a race condition where the Goko objects we're relying on aren't getting instantiated in time (and we're not explicitly checking for them). That could explain why it's happening on your machine but not michaeljb's.

I logged back on and it's back, so everything seems to be fine.  You guys are awesome with how awesome you're making Goko, just wanted to let you know that.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Nitsuj on August 05, 2013, 12:10:56 pm
I have a couple questions about the chrome extension:

I just installed it today, and I couldn't get the #vp? to work even though my opponent had it #vpon enabled.  There was no where I could see what the current score was.  Where would I see the score with the extension enabled?

Followup - the next game I played, I could see my score. 

Is it possible to hack the extension so your opponent cannot see score?  My opponent says he was playing on an iPad, could that be it?

Additional Followup - the 3rd game I played had the same problem - #vp? returns nothing and the victory point tracker does not show in the upper right corner.  I think it happens when I am the one enabling victory points, but I'm joining the tables. 

Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: SCSN on August 05, 2013, 12:38:39 pm

Is it possible to hack the extension so your opponent cannot see score?

Yes, but only if your opponent doesn't have the extension himself (and in that case you might as well just use an older version, where the "#vp?" thing wasn't yet implemented). If you're running the extension yourself, it can compute the score for you regardless of what code your opponent is running on his computer.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on August 05, 2013, 01:00:18 pm
Is it possible to hack the extension so your opponent cannot see score?  My opponent says he was playing on an iPad, could that be it?

If your opponent was on an iPad, how could he tell you anything? Last I checked, chat doesn't work on the iPad.
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: Nitsuj on August 05, 2013, 01:17:29 pm
Is it possible to hack the extension so your opponent cannot see score?  My opponent says he was playing on an iPad, could that be it?

If your opponent was on an iPad, how could he tell you anything? Last I checked, chat doesn't work on the iPad.

He told me in the lobby chat after the game
Title: Re: Dominion Online User Extension for Firefox and Chrome
Post by: LastFootnote on August 05, 2013, 01:19:17 pm
Is it possible to hack the extension so your opponent cannot see score?  My opponent says he was playing on an iPad, could that be it?

If your opponent was on an iPad, how could he tell you anything? Last I checked, chat doesn't work on the iPad.

He told me in the lobby chat after the game

Gotcha. That's a shame. I was hoping they fixed that bug. Not that I've played on iPad since the user extension was released.
Title: Re: Goko Salvager Discussion
Post by: GeoLib on August 06, 2013, 01:02:26 am
Feature requests:

Is it possible to sort cards in your hand like iso did, so actions and then treasures and then victory cards. The goko ordering seems to have cards just pop up somewhere randomly in your hand, which is a little irritating.

Is there a way to have it display people's deck, discard and mats by default without covering the actions, buys, and coins counters. This would be preferable to seeing their avatars.

Thanks!
Title: Re: Goko Salvager Discussion
Post by: SCSN on August 06, 2013, 02:02:29 am
Feature request: a way to sneak into rooms that are "full".
Title: Re: Goko Salvager Discussion
Post by: ashersky on August 06, 2013, 02:14:41 am
Feature request:  Text Mode.



Edit: I wasn't joking, insofar as I think maybe you could replace the cartoony interface with the log itself with card purchase buttons?  Like, just lay the log screen on top of the cartoon?
Title: Re: Goko Salvager Discussion
Post by: sudgy on August 06, 2013, 02:15:56 am
Feature request: Fix automatch ;)
Title: Re: Goko Salvager Discussion
Post by: ragingduckd on August 06, 2013, 02:51:13 am
Feature request: a way to sneak into rooms that are "full".

While it isn't possible to do exactly this, there are three reasonable alternatives. In decreasing order of gokosuck(c), they are:

3. The enterRoom function can be altered to keep hammering away at a full room. You won't get in right away, but you'll be the first person they let in when the total falls below 50.
2. Programmatically request entry to all rooms while they're not full. Save the entry "token" that Goko gives you, but don't actually enter the room. Use the token later to enter when the room is full. To the user, it would look like being able to "sneak in" except that there would be a delay after signing on or ending a game before you'd get a token for each room.
1. Lobby unification. It turns out to be possible to trick the server into letting you join multiple lobbies without opening multiple tabs. It's a little harder to actually display all the tables simultaneously as though they were all from a single lobby, but I think it's doable.

Feature request:  Text Mode.

I think this is a really big job. Goko doesn't reveal much of the actual game logic on the client side, so this would require implementing the rules of all the cards, or at least enough of it for it to offer you the right options. And then you'd have to make that UI interact with the existing Goko widgets in the way that Goko expects, including doing messy stuff like dragging cards revealed by Cartographer.

I'd be happy to help anyone who's interested get started, but it's not on my agenda.

Feature request: Fix automatch ;)

You say that as though it actually worked before. :P I need to figure out this secure websocket SSL nonsense and then we'll bring it back in the next update. I actually think lobby unification is more important though, since there are so many Goko users who aren't using the extension.
Title: Re: Goko Salvager Discussion
Post by: rrenaud on August 06, 2013, 11:05:18 am
I don't want to bikeshed too much, just avoid potential future drama.  Maybe Goko Expand is a nicer name for the extension?  You don't really want to make enemies out of Goko..
Title: Re: Goko Salvager Discussion
Post by: LastFootnote on August 06, 2013, 11:06:02 am
Maybe Goko Expand is a nicer name for the extension?  You don't really want to make enemies out of Goko..

Strongly agree. Also, the game isn't called "Goko", it's called "Dominion Online". Calling it "Goko X" implies that it works with Goko in general, including all future Goko games.

How about "Dominion Online Upgrade" or something?

EDIT: Your tagline is "Making Goko almost tolerable"!? Are you TRYING to get shut down?
Title: Re: Goko Salvager Discussion
Post by: Mic Qsenoch on August 06, 2013, 12:14:42 pm
It is a great name and tagline. Crappy things should be called crap as often and in as many ways as possible until they no longer suck. Without regard for backlash from the people making the thing.
Title: Re: Goko Salvager Discussion
Post by: LastFootnote on August 06, 2013, 12:24:51 pm
It is a great name and tagline. Crappy things should be called crap as often and in as many ways as possible until they no longer suck. Without regard for backlash from the people making the thing.

Hmm, I can't agree with that. There are many ways to tell Goko they need to improve which don't involve risking the loss of this fantastic extension. I think you need to learn to pick your battles, or at least your battlefields.
Title: Re: Goko Salvager Discussion
Post by: SCSN on August 06, 2013, 12:32:19 pm
It is a great name and tagline. Crappy things should be called crap as often and in as many ways as possible until they no longer suck. Without regard for backlash from the people making the thing.

Hmm, I can't agree with that. There are many ways to tell Goko they need to improve which don't involve risking the loss of this fantastic extension. I think you need to learn to pick your battles, or at least your battlefields.

lol, no way they are going to shut this down based on a tagline, that would be as retarded as a friend punching me in the face after I call him an idiot. And even if they did try it, 1) they would be very unlikely to succeed, given their track record, 2) it would be absolutely frigging hilarious.
Title: Re: Goko Salvager Discussion
Post by: Kirian on August 06, 2013, 01:11:51 pm
I don't think they could shut it down if they wanted to.  It's a browser extension; they can't stop you from installing it.  If I'm not mistaken, they likely can't even detect that you're running it.

Now, sure, they could try completely rewriting their code so the extension didn't work at all, but (1) that probably means a relatively simple rewrite of the extension and (2) Haha no way in hell do they have it together enough to rewrite the code to break the extension while not breaking the game entirely.

And that's all without even discussion of alienating the player base entirely.
Title: Re: Goko Salvager Discussion
Post by: blueblimp on August 06, 2013, 01:32:04 pm
If Goko put resources into an arms race with extension developers, I'm sure they'd win, as they have full-time programmers. It's hard to make the extension impossible, but there are plenty of easy things that can make it difficult, such as running the javascript through an obfuscator.
Title: Re: Goko Salvager Discussion
Post by: Watno on August 06, 2013, 01:36:19 pm
If Goko put resources into an arms race with extension developers, I'm sure they'd lose, since they don't seem to have any idea about programming.
Title: Re: Goko Salvager Discussion
Post by: AdamH on August 06, 2013, 01:38:53 pm
If Goko put resources into an arms race with extension developers, I'm sure they'd win, as they have full-time programmers.

You would think that, but look at all of the features our awesome people have made that they couldn't be bothered to do. There is no doubt in my mind that these people are much more competent programmers than those at Goko.

That being said, I think they would have legal grounds to stop the extension if they wanted.
Title: Re: Goko Salvager Discussion
Post by: StrongRhino on August 06, 2013, 05:00:45 pm
If Goko decided to be in an arms race, that would be stupid, because they could just put those resources into actually making the game better so we wouldn't need the extension.
Title: Re: Goko Salvager Discussion
Post by: WanderingWinder on August 06, 2013, 05:02:13 pm
Goko has programmers? Seriously, I thought their stuff was all contracted out now to that Vietnamese (do I remember that right?) company.

Anyhow, IANAL, but I imagine they could deny you service for developing/using extension (though I doubt they would), but they can't really stop you from making it.
Title: Re: Goko Salvager Discussion
Post by: GeoLib on August 06, 2013, 05:05:37 pm
If Goko put resources into an arms race with extension developers, they've already lost (perspective). Block an extension that people are making for free that turns your crap product into a playable one just because those people came out and said your product was crap? That sounds ludicrous. I know I wouldn't be using goko if the extension didn't work.
Title: Re: Goko Salvager Discussion
Post by: ragingduckd on August 06, 2013, 06:34:05 pm
Goko can thwart the extension any time they want to. It's running in their JavaScript namespace and they can even download the source code. We couldn't "win" an arms race with Goko while keeping the extension public, nor would I personally be interested in that fight. They can also deny you service for using the extension or for pretty much any other reason, according to their TOS. I don't think they're likely to get too aggressive on that front, though. Even ooksoo still has his account.

Other than the tag line (and yeah, that was probably a bit over the top), I can't really think of any reason for Goko to resent the extension. It doesn't provide an unfair advantage, nor does it draw additional server resources. Most of its features have been suggested on getsatisfaction and gotten responses like "yeah, that sounds nice and we might do it someday." If Goko started worrying about game mods, they'd do better to target unofficial ones, like a point counter that doesn't offer #vpoff or an exploit of the kingdom-fixing vulnerability michaeljb reported.
Title: Re: Goko Salvager Discussion
Post by: shraeye on August 06, 2013, 07:03:25 pm

1. Lobby unification. It turns out to be possible to trick the server into letting you join multiple lobbies without opening multiple tabs. It's a little harder to actually display all the tables simultaneously as though they were all from a single lobby, but I think it's doable.

In this case, wouldn't 50 users using this extension make ALL the rooms 'full', preventing regular users from entering?
Title: Re: Goko Salvager Discussion
Post by: Polk5440 on August 06, 2013, 07:08:40 pm

1. Lobby unification. It turns out to be possible to trick the server into letting you join multiple lobbies without opening multiple tabs. It's a little harder to actually display all the tables simultaneously as though they were all from a single lobby, but I think it's doable.

In this case, wouldn't 50 users using this extension make ALL the rooms 'full', preventing regular users from entering?

I am wondering this, too.
Title: Re: Goko Salvager Discussion
Post by: Kirian on August 06, 2013, 07:23:32 pm

1. Lobby unification. It turns out to be possible to trick the server into letting you join multiple lobbies without opening multiple tabs. It's a little harder to actually display all the tables simultaneously as though they were all from a single lobby, but I think it's doable.

In this case, wouldn't 50 users using this extension make ALL the rooms 'full', preventing regular users from entering?

We'll just all have to start meeting in Throne Room XIII.
Title: Re: Goko Salvager Discussion
Post by: ragingduckd on August 06, 2013, 07:27:09 pm

1. Lobby unification. It turns out to be possible to trick the server into letting you join multiple lobbies without opening multiple tabs. It's a little harder to actually display all the tables simultaneously as though they were all from a single lobby, but I think it's doable.

In this case, wouldn't 50 users using this extension make ALL the rooms 'full', preventing regular users from entering?

Only if they're all seeking games simultaneously. Once you start a game, you can leave all the lobbies except the one your game was created in.
Title: Re: Goko Salvager Discussion
Post by: GwinnR on August 07, 2013, 12:57:56 pm
Feature request: Let me search for a person. As goko puts you in different rooms after a game, when the previous room is full, it is hard to find your opponent again. And sometimes you see someone you want to play against and then he disappears and you don't know where he went.
Title: Re: Goko Salvager Discussion
Post by: GeoLib on August 07, 2013, 01:48:22 pm

1. Lobby unification. It turns out to be possible to trick the server into letting you join multiple lobbies without opening multiple tabs. It's a little harder to actually display all the tables simultaneously as though they were all from a single lobby, but I think it's doable.

In this case, wouldn't 50 users using this extension make ALL the rooms 'full', preventing regular users from entering?

Only if they're all seeking games simultaneously. Once you start a game, you can leave all the lobbies except the one your game was created in.

This seems like the kind of thing that could potentially cause problems for goko and make them want to shut down the extension. How implausible is it that there are 50 extension users all trying to find a game at the same time. That doesn't seem like that many.
Title: Re: Goko Salvager Discussion
Post by: eHalcyon on August 07, 2013, 02:34:34 pm
This seems like the kind of thing that could potentially cause problems for goko and make them want to shut down the extension. How implausible is it that there are 50 extension users all trying to find a game at the same time. That doesn't seem like that many.

If there are 50 extension users all trying to find a game, shouldn't most of them get matched up with each other fairly quickly?
Title: Re: Goko Salvager Discussion
Post by: rrwoods on August 07, 2013, 02:45:01 pm
Since you're storing the automatch data outside goko, wouldn't it be possible to not even have to look into the rooms?  Unless I'm missing something, couldn't you have matched users automatically enter a lobby with no one in it and begin their game?
Title: Re: Goko Salvager Discussion
Post by: GeoLib on August 07, 2013, 03:05:14 pm
Since you're storing the automatch data outside goko, wouldn't it be possible to not even have to look into the rooms?  Unless I'm missing something, couldn't you have matched users automatically enter a lobby with no one in it and begin their game?

This isn't about automatch though, it's about being able to see all of the open games at once, not just the few in the lobby you're currently in.
Title: Re: Goko Salvager Discussion
Post by: ragingduckd on August 07, 2013, 03:09:11 pm
Since you're storing the automatch data outside goko, wouldn't it be possible to not even have to look into the rooms?  Unless I'm missing something, couldn't you have matched users automatically enter a lobby with no one in it and begin their game?

This isn't about automatch though, it's about being able to see all of the open games at once, not just the few in the lobby you're currently in.

Ninja'd.

This seems like the kind of thing that could potentially cause problems for goko and make them want to shut down the extension. How implausible is it that there are 50 extension users all trying to find a game at the same time. That doesn't seem like that many.

If there are 50 extension users all trying to find a game, shouldn't most of them get matched up with each other fairly quickly?

I think so. I don't really expect to run into the 50-user problem to happen, but I'll be cautious about the implementation anyway (e.g. set it up to join just one extra lobby, then see how that goes, etc). I could even make it throttle the number of extra lobbies you can join in accordance with the number of active extension users. For what it's worth, you can already do the same thing manually... just open up extra tabs and log in to every room. Goko doesn't seem to care.

If lobby unification really would end up filling up the lobbies, then one alternative is to have my server send a single observer to each room and report the available games and players to all the extension users. The disadvantages are that you'd be dependent on my server being up and that you might  be unable to join the already-full lobby where someone is offering the game you want. With client-side lobby unification, you'd already be in.
Title: Re: Goko Salvager Discussion
Post by: Twistedarcher on August 07, 2013, 11:59:41 pm
There's actually a good reason why Goko would not want this extension implemented, and in my eyes, it's a pretty legitimate one.

The existence of the automatch function means that it's easier for players to find matches, and consistently play, without purchasing the card.

The 50 player lobbies are frustrating, but they're MUCH more frustrating to someone who has to find a game, rather than simply creating one. An automatch function makes it easier for players to skate by without purchasing the sets, thus potentially hurting Goko's profits. For a business, that's a pretty big issue.


Title: Re: Goko Salvager Discussion
Post by: pst on August 08, 2013, 02:32:31 am
There's actually a good reason why Goko would not want this extension implemented, and in my eyes, it's a pretty legitimate one.

The existence of the automatch function means that it's easier for players to find matches, and consistently play, without purchasing the card.

The 50 player lobbies are frustrating, but they're MUCH more frustrating to someone who has to find a game, rather than simply creating one. An automatch function makes it easier for players to skate by without purchasing the sets, thus potentially hurting Goko's profits. For a business, that's a pretty big issue.

If this was the only way to have fun on the Internet that might work. "This is frustrating! I'll pay some money to take away the frustration." But since it's not I think it makes better business sense to try to make it fun to begin with: "This is fun! I'll keep using it -- Hm, will it get even more fun if I pay some money?"

As for me I thought I would stop playing Dominion online earlier, but now, with several improvements, both in Goko itself, and with the extension, I am playing it and have for the first time considered buying some cards. If I knew they were thinking "oh no, he is having too much fun with our site. Let's take away some of that fun, because then we will surely pay us money" that would go away again.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 08, 2013, 03:43:07 am
2.1

New tagline, the title now includes "Dominion," and some less interesting backend code change stuff. There were some changes to the automatch, I don't believe it's all working yet, but wanted to do a release to settle down the tagline controversy at least :P

Also, something's probably broken, but I won't know that until tomorrow morning.
At least, that's how this release-late-at-night thing has usually worked out for me.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 08, 2013, 04:37:02 am
2.1

New tagline, the title now includes "Dominion," and some less interesting backend code change stuff. There were some changes to the automatch, I don't believe it's all working yet, but wanted to do a release to settle down the tagline controversy at least :P

Also, something's probably broken, but I won't know that until tomorrow morning.
At least, that's how this release-late-at-night thing has usually worked out for me.

I don't think this went through. The Firefox version is unchanged anyway.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 08, 2013, 05:50:31 am
2.1

New tagline, the title now includes "Dominion," and some less interesting backend code change stuff. There were some changes to the automatch, I don't believe it's all working yet, but wanted to do a release to settle down the tagline controversy at least :P

Also, something's probably broken, but I won't know that until tomorrow morning.
At least, that's how this release-late-at-night thing has usually worked out for me.

I don't think this went through. The Firefox version is unchanged anyway.

Chrome updated to 2.1, so it works there.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 08, 2013, 05:51:06 am
Feature request: pull out any and all code/circuits/wires that allow that horrendous theme song to play.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 08, 2013, 06:10:09 am
Automatch submit button works in Chrome.  Haven't found a match, though.
Title: Re: Goko Dominion Salvager Discussion
Post by: jsh357 on August 08, 2013, 09:13:09 am
Question about Automatch.  When I specify the sets to play with, does that mean it's looking for users with those sets bought?  I own all the cards, so I'd prefer the randomizer to just choose from mine.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 08, 2013, 09:20:34 am
OK, I think I got 2.1 into the Firefox store, not sure what I did wrong with that last night.
Title: Re: Goko Salvager Discussion
Post by: DStu on August 08, 2013, 09:26:31 am
Since you're storing the automatch data outside goko, wouldn't it be possible to not even have to look into the rooms?  Unless I'm missing something, couldn't you have matched users automatically enter a lobby with no one in it and begin their game?

This isn't about automatch though, it's about being able to see all of the open games at once, not just the few in the lobby you're currently in.

Ninja'd.

I don't know how much load this would be for your server (and for your code), but couldn't the users of the extensions not just communicate on who is in which room? I mean, if there is only 1 user, they might enter 50 rooms, but if there are more, they could each enter different rooms and tell each other on what the lobbies look like?
Title: Re: Goko Dominion Salvager Discussion
Post by: Cloud on August 08, 2013, 10:36:35 am
Salvager 2.0/2.1 (Firefox): Victory point tracker in adventures doesn't work anymore.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 08, 2013, 10:37:04 am
Question about Automatch.  When I specify the sets to play with, does that mean it's looking for users with those sets bought?  I own all the cards, so I'd prefer the randomizer to just choose from mine.

Automatch doesn't care which player owns the cards as long as someone owns them. It'll choose that player to be the host.

Most people prefer more cards to less, so these are the typical situations:

Example 1:
Alice owns all cards, seeks an all-cards game
Chad owns all cards, seeks an all-cards game
--> Alice and Chad match, host is chosen randomly, game is all-cards

Example 2:
Alice owns all cards, seeks an all-cards game
Bob owns no cards, seeks an all-cards game
--> Alice and Bob match, Alice hosts, game is all-cards

If you're actually looking for a game with fewer cards than you own, then things get trickier. Goko always uses all of the host's cards, so the only way to make that happen is to match you with a player who owns fewer cards and have that player host.

Example 3:
Alice owns all cards, seeks a Base-only game
Bob owns no cards, seeks a game without restrictions
--> Alice and Bob match, Bob hosts, game is Base-only

Example 4:
Alice owns all cards, seeks a Base-only game
Chad owns all cards, seeks a game without restrictions
--> No match

The fourth example is the one that makes me want to throw things at the Goko devs. Alice is effectively being punished for having bought the cards. Anyway, Automatch recognizes the limitation and won't create the match because Alice wouldn't get the Base-only game that she asked for.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on August 08, 2013, 11:23:22 am
Just got my first successul automatch. AWESOME! Thanks a lot.

Some ideas to make it even more amazing:
1) Option to search for a match with vp counter on/off/don't care
2) Notification sound when a match is found

And an idea the game name gave me:
Possibility to host a game that only one specific person can join (others will be autokicked), by including "FOR player" or something similar in the name.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on August 08, 2013, 12:08:11 pm
Also, could the automatch parameters be saved from one session to the next?
Title: Re: Goko Dominion Salvager Discussion
Post by: () | (_) ^/ on August 08, 2013, 01:15:01 pm
My automatch eternally says "Lost Automatch Connection"

 :'(  :'(  :'(

Firefox, updated to 2.1 earlier.
Title: Re: Goko Dominion Salvager Discussion
Post by: gunslinger on August 08, 2013, 07:41:49 pm
Also, could the automatch parameters be saved from one session to the next?

The kingdom generator parameters being saved would be sweet. As someone who owns all the cards online but not irl, the kingdom generator is the only way I can learn the cards slowly.

Also, the VP tracking in Adventure mode only seems to work if you type in #vpon.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 09, 2013, 07:18:47 am
My automatch eternally says "Lost Automatch Connection"

 :'(  :'(  :'(

Firefox, updated to 2.1 earlier.

Hmm. That means you're not getting connected to my server, or possibly that you got disconnected. Automatch will try reconnecting several times, but eventually it just gives up on the assumption that my server is down. I should probably add a way to manually force it to try again, but I've tried to avoid cluttering up Goko's beautiful lobby GUI too much. ;)

Please try the following:
1. Make sure the old greasemonkey Automatch script is removed or disabled. Ditto for other versions of the log extension.
2. Reload the page.
3. Click "inspect element", then the "Web Console" tab, then click to disable the NET and CSS output, and then copy everything there and post it here.

Step 3 will give me the output of the JavaScript that's being run (all of Goko's stuff, plus the extension's). It may have information I can use to diagnose the problem.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 09, 2013, 07:21:33 am
Just got my first successul automatch. AWESOME! Thanks a lot.

Some ideas to make it even more amazing:
1) Option to search for a match with vp counter on/off/don't care
2) Notification sound when a match is found

And an idea the game name gave me:
Possibility to host a game that only one specific person can join (others will be autokicked), by including "FOR player" or something similar in the name.

I had auto match success today, as well.  Thanks Geronimoo, for hosting multiple times.  We must have been the only two using it.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on August 09, 2013, 08:25:49 am
gg [VM] gameClient.html (143):870
destroying  fan: hand DominionUI.js:6862
destroying flat: reveal DominionUI.js:6871
destroying deck: deck DominionUI.js:6866
destroying deck: discard DominionUI.js:6866
destroying  fan: hand DominionUI.js:6862
destroying flat: reveal DominionUI.js:6871
destroying deck: deck DominionUI.js:6866
destroying deck: discard DominionUI.js:6866
destroyed PlayerController DominionUI.js:13284
exception :SyntaxError: Unexpected end of input [VM] gameClient.html (143):928
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 09, 2013, 08:59:25 am
gg [VM] gameClient.html (143):870
destroying  fan: hand DominionUI.js:6862
destroying flat: reveal DominionUI.js:6871
destroying deck: deck DominionUI.js:6866
destroying deck: discard DominionUI.js:6866
destroying  fan: hand DominionUI.js:6862
destroying flat: reveal DominionUI.js:6871
destroying deck: deck DominionUI.js:6866
destroying deck: discard DominionUI.js:6866
destroyed PlayerController DominionUI.js:13284
exception :SyntaxError: Unexpected end of input [VM] gameClient.html (143):928

Need... more... data... ;)

When did this happen, which browser are you using, and what were the symptoms? The full log is sometimes helpful too, excessive though it may be

This log chunk would probably be enough to locate an error in a real programming language. But since we're inserting our JS code into the existing Goko page, it's actually pretty tough to make sense out of the line numbers and figure out what source code generated the error.
Title: Re: Goko Dominion Salvager Discussion
Post by: () | (_) ^/ on August 09, 2013, 09:00:24 am
My automatch eternally says "Lost Automatch Connection"

 :'(  :'(  :'(

Firefox, updated to 2.1 earlier.

Hmm. That means you're not getting connected to my server, or possibly that you got disconnected. Automatch will try reconnecting several times, but eventually it just gives up on the assumption that my server is down. I should probably add a way to manually force it to try again, but I've tried to avoid cluttering up Goko's beautiful lobby GUI too much. ;)

Please try the following:
1. Make sure the old greasemonkey Automatch script is removed or disabled. Ditto for other versions of the log extension.
2. Reload the page.
3. Click "inspect element", then the "Web Console" tab, then click to disable the NET and CSS output, and then copy everything there and post it here.

Step 3 will give me the output of the JavaScript that's being run (all of Goko's stuff, plus the extension's). It may have information I can use to diagnose the problem.

1 already done
2 I've even closed the browser and reopened
3 here you go...


[08:58:07.817] gatherUrlCookieParams found the following URL params: [""]
[08:58:07.818] ConnectionMaker found the following cookie params: ({0:"", id:"funsocketsplayercookie", cookieid:null, httpUrl:"https://prod-webapps.goko.com/WebApps/bus/", connectionInfo:{httpUrl:"https://prod-webapps.goko.com/WebApps/bus/", gatewayUrl:"ws://prod-wsg02.goko.com:80", sessionId:"5204e755e4b027d9487762e6", kind:"player", playerName:"p4ddy0d00rs", playerId:"506eda0d0cf204dd6b15928a", playerPoolId:"4f4120146071b0e4dada0f66", expires:1378645067701, gatewayURLHTTP:"//prod-comet.goko.com/comet/", hmacSecret:"73A0E78DA9E8C918CAF7F5418B6E4B96"}, last_agent:"local", vers:"1.3", playerPoolId:"4f4120146071b0e4dada0f66"})
[08:58:07.818] ConnectionMaker merged the following cookie params: [""]
[08:58:07.823] FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg02.goko.com:80
[08:58:08.125] FSSDK: webSocket: onopen: top: url:ws://prod-wsg02.goko.com:80
[08:58:08.240] Setting up GA connection heartbeat every: 60000 milliseconds
[08:58:08.392] initMeetingRoom
[08:58:08.478] This element isn't a canvas - TypeError: this.elem.getContext is not a function
[08:58:08.478] This is a HTML Element
[08:58:08.479] Dimension: W0px H0px @L692.5px T0px
[08:58:08.502] Successfully subscribed to player notifications
[08:58:08.671] Use of getAttributeNode() is deprecated. Use getAttribute() instead. @ http://play.goko.com/FSSDK/3plibs/jquery-1.7.1.js:2628
[08:58:08.671] Use of attributes' specified attribute is deprecated. It always returns true. @ http://play.goko.com/FSSDK/3plibs/jquery-1.7.1.js:2630
[08:58:11.199] Personal
[08:58:11.204] Avatar Inventory
--
[08:58:16.383] Create achievements response:  ({message:"Status", source:"Object", tag:"-FSMsgWSTag22", sqA:22, data:{responseMessage:"CreatePlayerAchievements", achievementIds:[], code:0}, sqN:22, version:1, destination:"user:4f4120146071b0e4dada0f66.506eda0d0cf204dd6b15928a.5204e75de4b0faf2985c78a4"})
[08:58:20.593] Firefox can't establish a connection to the server at wss://andrewiannaccone.com/automatch?pname=p4ddy0d00rs. @ http://play.goko.com/Dominion/gameClient.html:212
--
[08:58:26.973] Firefox can't establish a connection to the server at wss://andrewiannaccone.com/automatch?pname=p4ddy0d00rs. @ http://play.goko.com/Dominion/gameClient.html:212
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 09, 2013, 09:41:46 am
@p4ddy0d00rs / syntax-man:

It looks like you're never getting connected at all. Either my server is refusing your websocket connection or your browser is rejecting my server. And you're successfully creating a websocket connection to Goko, so that rules out a lot of possible issues.

Maybe your browser/network has some sort of issue with secure websockets? Seems unlikely, but try testing both secure and insecure here: http://www.websocket.org/echo.html. It also might be a problem with my SSL certificate, but lots of other people are connecting successfully from Firefox, so I'm puzzled there too. I'll try setting up an insecure websocket server this evening, just in case.

What Firefox are you using and do you have any security-related add-ons or security settings you've manually changed in your firefox "about:config"? Finally check your Firefox Preferences/Advanced/Encryption and also the View Certificates dialog within that. You should be looking at something like the attached image. Specifically, the checkboxes should be the same and there should be a COMODO CA Limited certificate for the andrewiannaccone.com server.

Have you tried from any other computer/network/browser?

Sorry for so many tests and questions. I'm pretty much in the dark here.

Edit: Oh, and also check if you can see anything here: http://gokologs.drunkensailor.org/static/automatch_testserver.html. I'm guessing you'll see all the text areas as empty.
Title: Re: Goko Dominion Salvager Discussion
Post by: () | (_) ^/ on August 09, 2013, 11:08:42 am
@p4ddy0d00rs / syntax-man:

It looks like you're never getting connected at all. Either my server is refusing your websocket connection or your browser is rejecting my server. And you're successfully creating a websocket connection to Goko, so that rules out a lot of possible issues.

Maybe your browser/network has some sort of issue with secure websockets? Seems unlikely, but try testing both secure and insecure here: http://www.websocket.org/echo.html. It also might be a problem with my SSL certificate, but lots of other people are connecting successfully from Firefox, so I'm puzzled there too. I'll try setting up an insecure websocket server this evening, just in case.

see "socket.jpg" below

What Firefox are you using and do you have any security-related add-ons or security settings you've manually changed in your firefox "about:config"?

see "changes to ff.jpg" below
Also, no manual changes to firefox's about:config.

Finally check your Firefox Preferences/Advanced/Encryption and also the View Certificates dialog within that. You should be looking at something like the attached image. Specifically, the checkboxes should be the same and there should be a COMODO CA Limited certificate for the andrewiannaccone.com server.

see "certificate.jpg" below

Have you tried from any other computer/network/browser?

Yes other computer.  No other network.  No other browser.

Sorry for so many tests and questions. I'm pretty much in the dark here.

Yes yes because the man trying to help me should be sorry for trying to help me?  Pfft.  Thanks for taking the time and effort, man!  ;D ;D ;D

Edit: Oh, and also check if you can see anything here: http://gokologs.drunkensailor.org/static/automatch_testserver.html. I'm guessing you'll see all the text areas as empty.

Correct.  All empty.  In fact, just a tad bit more empty than my bank account.  Not by much though. :-\
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 09, 2013, 12:14:52 pm
Definitely start by trying it with NoScript turned off. That's just crazy, man.

Maybe your browser/network has some sort of issue with secure websockets? Seems unlikely, but try testing both secure and insecure here: http://www.websocket.org/echo.html. It also might be a problem with my SSL certificate, but lots of other people are connecting successfully from Firefox, so I'm puzzled there too. I'll try setting up an insecure websocket server this evening, just in case.

see "socket.jpg" below

Repeat but with clicking Use secure WebSocket (TLS). The Location should start with "wss:" before you press "Connect." No screenshot needed unless it breaks.

Have you tried from any other computer/network/browser?

Yes other computer.  No other network.  No other browser.

Try it on Chrome. You shouldn't have to switch browsers permanently, but this will help us diagnose.

Correct.  All empty.  In fact, just a tad bit more empty than my bank account.  Not by much though. :-\

Your bank account is full of html widgets?
Title: Re: Goko Dominion Salvager Discussion
Post by: Avin on August 09, 2013, 12:22:30 pm
Is there any way to specify what's present in the Black Market when using the Kingdom Generator?

If not, can that feature be added? It would be critical for solo challenges and puzzles ;)
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 09, 2013, 12:28:10 pm
Haven't looked at the Black Market stuff at all yet, but I bet there's a way (http://forum.dominionstrategy.com/index.php?topic=8243.0).
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on August 09, 2013, 01:00:30 pm
exception :SyntaxError: Unexpected end of input [VM] gameClient.html (143):928
Need... more... data... ;)

When did this happen, which browser are you using, and what were the symptoms? The full log is sometimes helpful too, excessive though it may be

This log chunk would probably be enough to locate an error in a real programming language. But since we're inserting our JS code into the existing Goko page, it's actually pretty tough to make sense out of the line numbers and figure out what source code generated the error.
Chrome 28.0.1500.71 (Official Build 209842). It works ok, just this error log is in console. I don't know a game, don't have log. I have seen that few hours later. I will try to find out more tomorrow.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on August 10, 2013, 10:29:24 am
Rakefile:
Quote
task :default => ['build:firefox', 'chrome:build', 'build:safari']
Is there some reason for different order of words separated by ":"?

EDIT: Sorry for confusion, still valid.
Probably error from here:
https://github.com/michaeljb/Goko-Salvager/commit/650c246eb4d4e2526817dcd3e609b544c0862c5a#L0L55
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on August 10, 2013, 11:22:36 am
exception :SyntaxError: Unexpected end of input [VM] gameClient.html (143):928
Need... more... data... ;)
I will try to find out more tomorrow.
I've fixed it here: https://github.com/michaeljb/Goko-Salvager/pull/25

How should whitespace be used? Tabs or spaces?
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 10, 2013, 01:07:55 pm
Rakefile:
Quote
task :default => ['build:firefox', 'chrome:build', 'build:safari']
Is there some reason for different order of words separated by ":"?

EDIT: Sorry for confusion, still valid.
Probably error from here:
https://github.com/michaeljb/Goko-Salvager/commit/650c246eb4d4e2526817dcd3e609b544c0862c5a#L0L55

I originally used "dev" and "build" as namespaces, but then decided to change it to browser names as namespaces...the real mistake was probably pushing before that was actually done all the way. At the same time, I'm also changing the tasks to use rake's file dependencies correctly.

For whitespace, indent with 4 spaces. Andrew's been checking his automatch scripts with JSLint, and the plan is to eventually break the big log viewer script down into separate scripts, and at that time fix its indentation and stuff. So for now, indentation/whatever isn't very important in the log viewer.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 10, 2013, 04:46:36 pm
Rakefile:
Quote
task :default => ['build:firefox', 'chrome:build', 'build:safari']
Is there some reason for different order of words separated by ":"?

EDIT: Sorry for confusion, still valid.
Probably error from here:
https://github.com/michaeljb/Goko-Salvager/commit/650c246eb4d4e2526817dcd3e609b544c0862c5a#L0L55

I originally used "dev" and "build" as namespaces, but then decided to change it to browser names as namespaces...the real mistake was probably pushing before that was actually done all the way. At the same time, I'm also changing the tasks to use rake's file dependencies correctly.

For whitespace, indent with 4 spaces. Andrew's been checking his automatch scripts with JSLint, and the plan is to eventually break the big log viewer script down into separate scripts, and at that time fix its indentation and stuff. So for now, indentation/whatever isn't very important in the log viewer.

I'm working on the log viewer breakup right now. It's a big refactor and it'll be quite a nuisance to merge any concurrent changes, so please hold off on any non-trivial modifications to that script for now if you can.

Incidentally, can anyone explain the set_parser.js script? It's machine-generated and I can't decipher what it's doing. Edit: Aha! This is what it's doing (http://dom.retrobox.eu/kingdomgenerator.html). I had never even looked.

Edit: Finished the breakup refactor and merged it into my github fork. There are conflicting changes and I'm still to new to git to handle the merge.

I'm quite certain that my changes break the chrome build. They may break the safari build too. But the firefox build works and I want to get the logviewer refactor out asap, rather than wait until I figure out how to fix the rake files.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on August 11, 2013, 05:16:45 am
My user settings get reset to default between sessions. Specifically: the "always turn VP on" thing gets unchecked, the "always stack cards" thing gets unchecked, and the blacklist gets emptied.
Title: Re: Goko Dominion Salvager Discussion
Post by: Beyond Awesome on August 13, 2013, 10:33:11 pm
My user settings get reset to default between sessions. Specifically: the "always turn VP on" thing gets unchecked, the "always stack cards" thing gets unchecked, and the blacklist gets emptied.

There's a way to always turn vpon. I did not even realize that.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 14, 2013, 12:43:24 am
My user settings get reset to default between sessions. Specifically: the "always turn VP on" thing gets unchecked, the "always stack cards" thing gets unchecked, and the blacklist gets emptied.

I'll take a look at this if I have time tomorrow, I think I know what caused this. (storing info in the window.GokoSalvager object instead of localStorage; localStorage persists if you close your browser. Haven't looked closely enough to be sure though)
Title: Re: Goko Salvager Discussion
Post by: ragingduckd on August 14, 2013, 11:51:25 pm
Feature request:  Text Mode.

I think this is a really big job. Goko doesn't reveal much of the actual game logic on the client side, so this would require implementing the rules of all the cards, or at least enough of it for it to offer you the right options. And then you'd have to make that UI interact with the existing Goko widgets in the way that Goko expects, including doing messy stuff like dragging cards revealed by Cartographer.

On further investigation, I think I overstated this difficulty. You wouldn't really need to mimic dragging cards around, only to spoof the message that dragging cards eventually sends.

I'm still up to the task of a full text-only interface, but it might not be hard to add some of the conspicuously missing buttons and options. It would be nice to have a button to "Discard one Alchemist" or an option to "For the love of God, stop asking me what order to put two identical cards back on my deck in!"

Edit: Ack! "NOT!" I'm still not up to the task of a full text-only interface. :P
Title: Re: Goko Salvager Discussion
Post by: sudgy on August 15, 2013, 01:11:49 am
Actually, another useful feature, would be asking if you're sure you want to do something that seems weird (like pressing "end turn" when you have treasures in hand).  Iso did that, and it was fine.
Title: Re: Goko Dominion Salvager Discussion
Post by: Robz888 on August 15, 2013, 02:13:53 am
Why did it stop showing my correct image in the lobby and giving my options? I can still see other people's images and I have the counter and tracker when I actually play the game (and my image is corrct, then.)
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 15, 2013, 02:16:26 am
Feature Request: Allow Salvager to Trash my Goko, providing +1 buy and Goko's value in coins for me to spend on something else.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 15, 2013, 02:21:21 am
If I play Goko Salvager and trash Goko from my hand, do I get its cost in Gokoins back?
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 15, 2013, 02:27:49 am
If I play Goko Salvager and trash Goko from my hand, do I get its cost in Gokoins back?

Looks like a question, not a feature request. ;)
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 15, 2013, 02:29:03 am
Why did it stop showing my correct image in the lobby and giving my options? I can still see other people's images and I have the counter and tracker when I actually play the game (and my image is corrct, then.)

I do not know why this happened, but based on personal experience I can say that refreshing/reloading the page after you're logged in might fix it...
Title: Re: Goko Dominion Salvager Discussion
Post by: Robz888 on August 15, 2013, 02:44:39 am
Yup, thanks!
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 15, 2013, 02:49:34 am
Why did it stop showing my correct image in the lobby and giving my options? I can still see other people's images and I have the counter and tracker when I actually play the game (and my image is corrct, then.)

I do not know why this happened, but based on personal experience I can say that refreshing/reloading the page after you're logged in might fix it...

This is true for a handful of features. The problem is that the extension is loading at the same time that Goko is building itself, so things get confused if/when the extension tries to use a Goko resource that isn't available yet (e.g. adding the Options link before there's an intro page to add it to).

Basically, if it doesn't work, try reloading. If it works after that, please post so here. It's easy for developers to overlook race conditions that only break things occasionally.

Edit: We fixed a whole class of these bugs in v2.2. It's hard to get rid of them entirely while working within Goko's framework, but they should be pretty rare now.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 21, 2013, 01:49:29 pm
Salvager version 2.2.3 released. :)

New Features:
Bug Fixes:
New Bugs:
Getting it:

* Auto-Automatch is the option to send out an automatch request whenever you create a game table. It's a checkbox in the create game dialog.

It respects your game preferences -- that is, if you have 4000+ in your game title, then you won't be matched with anyone below 4000; if you had three seats at your table then you'll only be matched for a 3-person game. You'll also never get a game with fewer card sets than you would've had in the game you originally created.

** Previously you only got a ding sound when someone joined your game if you you had a threshold like 4500+ in your game title. Now it'll always ding whenever someone joins and doesn't get auto-kicked. Between this and the automatch ding, you can completely ignore the Goko tab once you create your game and/or automatch request.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on August 21, 2013, 02:44:26 pm
Thx for the great extension once more.

Some issues:
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 21, 2013, 05:32:54 pm
  • Card-coloring in the log at the side doesn't work any more.
  • The explanation window that pops up when you click the blue (?) next to "Use Automatch" on the create game screen appears behind the create game screen, so you can't see it.
  • The popup menus from the extension don't have an X in the button to close them

Many thanks. You're a far better beta tester than I am. :P

The explanation popup is fixed in v2.2.1 (releasing now).

The card-coloring may take a little longer to fix. It uses exactly the coding mechanism that got v2.1 kicked from the Firefox store, so we need to rewrite the feature rather than just fix a bug.

The missing "X" is one of the little annoyances of working in the extension framework. We're using a third-party CSS file that can't find its images because it expects them to be on the website itself. Maddening, but hopefully not an issue for the actual functionality.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on August 21, 2013, 07:03:40 pm
If your auto-automatch-offer gets declined, your automatch status changes to idle. However, when you click on "automatch: idle", you get a popup saying "Automatch is looking for players whose search criteria match your table." This message still appears after leaving said game, and prevents you from using automatch until you host a new game.
From what I see, I was actually removed from the automatch pool.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 21, 2013, 07:45:37 pm
If your auto-automatch-offer gets declined, your automatch status changes to idle. However, when you click on "automatch: idle", you get a popup saying "Automatch is looking for players whose search criteria match your table." This message still appears after leaving said game, and prevents you from using automatch until you host a new game.
From what I see, I was actually removed from the automatch pool.

Fixed in 2.2.2

I'm still not sure about how quickly Firefox and Chrome will update these for you. The new versions are in the stores at the previous links though, so you can always download manually.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on August 21, 2013, 07:48:49 pm
It's not like any of these problems were critical and needed immediate fixing, so i guess I can wait for the automatic update. thanks anyway.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on August 21, 2013, 10:14:01 pm
What if they're making this extension just for the respect... (forum respect)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 21, 2013, 10:30:23 pm
What if they're making this extension just for the respect... (forum respect)

Posting memes would be an easier way...
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on August 21, 2013, 11:13:54 pm
Hm.

This extension seems to be invading other pages for me (FF 23.0.1).  I have the grey rounded-rectangle highlights that are at the top of the log viewer, except I have them at the top of the forum... and Facebook... and the Weather Channel... um.

Yeah.
Title: Re: Goko Dominion Salvager Discussion
Post by: blueblimp on August 21, 2013, 11:38:49 pm
Auto-automatch is brilliant. Very elegant solution to getting critical mass of automatch. Only annoyance so far is that if somebody sits in the automatch pool and doesn't accept matches, there's nothing I can do about it apart from cancel the match.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 21, 2013, 11:39:08 pm
Hm.

This extension seems to be invading other pages for me (FF 23.0.1).  I have the grey rounded-rectangle highlights that are at the top of the log viewer, except I have them at the top of the forum... and Facebook... and the Weather Channel... um.

Yeah.

I can't seem to reproduce it... or maybe I'm just not recognizing it. Could you post a screenshot and your JS console log?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 21, 2013, 11:45:36 pm
Auto-automatch is brilliant. Very elegant solution to getting critical mass of automatch. Only annoyance so far is that if somebody sits in the automatch pool and doesn't accept matches, there's nothing I can do about it apart from cancel the match.

Thanks. :)

Yeah, that's definitely annoying.  The good news is that you can cancel whenever you want and they're out of the pool after that, at least until they submit another match request.

There's probably a better solution. Maybe tracking repeat offenders and reducing their match rate or something. Right now the blacklist doesn't have any effect on automatch, but maybe it would be good if players could say they don't want to automatch with so-and-so.

I dunno... did you have any specific fix in mind?
Title: Re: Goko Dominion Salvager Discussion
Post by: blueblimp on August 21, 2013, 11:47:20 pm
Huh, didn't know they'd drop out of the pool after a cancel. That ought to do it. I guess my absent match must have reclicked the button after I cancelled.  ???
Title: Re: Goko Dominion Salvager Discussion
Post by: Beyond Awesome on August 22, 2013, 12:21:04 am
I had an auto-Automatch game where it wanted to pair me with someone that had 6 sets and make them the host while I own all sets.
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on August 22, 2013, 12:22:45 am
Hm.

This extension seems to be invading other pages for me (FF 23.0.1).  I have the grey rounded-rectangle highlights that are at the top of the log viewer, except I have them at the top of the forum... and Facebook... and the Weather Channel... um.

Yeah.

I can't seem to reproduce it... or maybe I'm just not recognizing it. Could you post a screenshot and your JS console log?

(http://www.invirtuo.cc/img/Screencaps.png)

For FB and TWC, on the left is with the extension running, on the right is without.

Nothing interesting is showing in the JS console, but I can tell you that (1) this only happens after loading Goko's site, and (2) it's affecting anything in <h1> tags, and only those things.  I find it amusing that FB's main menu button is in an h1 tag, despite being just an icon...
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 22, 2013, 12:30:30 am
For FB and TWC, on the left is with the extension running, on the right is without.

Nothing interesting is showing in the JS console, but I can tell you that (1) this only happens after loading Goko's site, and (2) it's affecting anything in <h1> tags, and only those things.  I find it amusing that FB's main menu button is in an h1 tag, despite being just an icon...

Got it. Thanks, I'll track it down. .
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on August 22, 2013, 12:47:33 am
There's probably a better solution. Maybe tracking repeat offenders and reducing their match rate or something. Right now the blacklist doesn't have any effect on automatch, but maybe it would be good if players could say they don't want to automatch with so-and-so.

Making the blacklist affect who you match with would be a very good thing to do.  Without it, the blacklist could be pointless.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 22, 2013, 12:57:12 am
What if they're making this extension just for the respect... (forum respect)

Posting memes would be an easier way...

To be fair, that is where most of my respect came from before I did anything with the extension.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on August 22, 2013, 01:18:11 am
Automatch seems to be a lot better now, first I played a game with Andrew (which was actually an interesting game, I ended up losing by one point...) almost right away, then another game almost right away.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on August 22, 2013, 01:23:54 am
And, looking in Outpost, it seems to work well now too.  Three automatched games?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 22, 2013, 01:28:43 am
There's probably a better solution. Maybe tracking repeat offenders and reducing their match rate or something. Right now the blacklist doesn't have any effect on automatch, but maybe it would be good if players could say they don't want to automatch with so-and-so.

Making the blacklist affect who you match with would be a very good thing to do.  Without it, the blacklist could be pointless.

Agreed. Anyone who you'd ordinarily want to blacklist should definitely be on your automatch blacklist. But the reverse might not necessarily be true. That is, you might want to only "automatch blacklist" someone who you'd be happy to play with, but who has a habit of turning on automatch and then wandering off.

I haven't quite decided how to implement it.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 22, 2013, 01:37:51 am
I had an auto-Automatch game where it wanted to pair me with someone that had 6 sets and make them the host while I own all sets.

Argh. I thought I'd already fixed that bug.

Ok, thanks. It's a server issue, so I should be able to fix it without re-releasing the extension.

Edit: Found it again. Persistent little bugger. Should be fixed for real now.
Title: Re: Goko Dominion Salvager Discussion
Post by: pst on August 22, 2013, 02:17:17 am
Agreed. Anyone who you'd ordinarily want to blacklist should definitely be on your automatch blacklist. But the reverse might not necessarily be true. That is, you might want to only "automatch blacklist" someone who you'd be happy to play with, but who has a habit of turning on automatch and then wandering off.

I haven't quite decided how to implement it.

I'd like to be able to have a temporary blacklist, so if I say no to a game, that no sticks for some time. That could be like for an hour or two. For the wandering-off player that means you just have to say no once when you notice they don't answer. But also otherwise your preference to not play a particular game might be more or less temporary. Say, you just want a relaxing game before bedtime, and think that if you play against a particular player it will instead be a prestiguous death match with no relaxing qualities.

I would like the ordinary "no" to be this function. When you say no to a particular game that otherwise fits your automatch criteria, it's probably because you don't fancy playing that particular player right now, so avoid suggesting the same matchup again soon.

(This may sound like I'm cherrypicking a lot with automatch, but I don't. In fact I don't think I have said no except for people who didn't answer for a long time. But I did refuse sometimes on Isotropic's automatch, mostly when I had just played that player and I didn't like that for some reason. I didn't learn the names of those, and wouldn't have bothered with a permanent blacklist, but a temporary no-thanks would have suited me fine then.)
Title: Re: Goko Dominion Salvager Discussion
Post by: hsiale on August 22, 2013, 06:38:05 am
if you have 4000+ in your game title, then you won't be matched with anyone below 4000
Is there a way to introduce an upper bound in your game title (so that for example I'm not matched with anyone over 6000) or (which would be IMO the best solution) introduce a ranking interval centered at your current rank score so that for example everyone who is further than let's say 1200 from my current rank score is autokicked, no matter if ranked higher or lower than me?

it'll always ding whenever someone joins and doesn't get auto-kicked
Isotropic had also the text at the top of the tab change when you had a game waiting. Is it possible to add this? I often play at night with my girfriend already asleep in the same room, so usually my computer has sound turned off when I'm on Goko.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on August 22, 2013, 08:45:07 am
Hm.

This extension seems to be invading other pages for me (FF 23.0.1).  I have the grey rounded-rectangle highlights that are at the top of the log viewer, except I have them at the top of the forum... and Facebook... and the Weather Channel... um.

Yeah.
I have this as well, but didn't immediately make the connection to the extension.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 22, 2013, 11:10:19 am
Hm.

This extension seems to be invading other pages for me (FF 23.0.1).  I have the grey rounded-rectangle highlights that are at the top of the log viewer, except I have them at the top of the forum... and Facebook... and the Weather Channel... um.

Yeah.
I have this as well, but didn't immediately make the connection to the extension.

Sorry about that, guys. It turns out that Firefox extensions inject CSS globally, not just into the page they're applied to! So basically the extension is trying to format the rest of the web like the log viewer. :D

I just wrote a quick fix, so we'll get v2.2.3 with that fix out soon. For now, just know that it's not doing any real harm. In particular, none of the JavaScript is running on any non-Goko sites. It's just changing the display format of some headers and tables.

For the curious, here's the entire section of offending CSS. There's some other stuff that's getting applied too, but it's all very Dominion-specific, so unless the other sites you visit use <vp-token> tags, you'll probably never notice. ;)

Code: [Select]
table {
  margin: 1px 1px;
}

td {
  padding: 1px 4px;
}

h1 {
  margin: 0px 0px;
  padding: 0px 5px;
  font-size:14px;
  background-color: lightgray;
  border: 2px solid gray;
  border-radius: 5px;
}
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on August 22, 2013, 11:31:31 am
I don't know, if you can do this, but it would be great, if you don't have do rewrite your blacklist after re-downloading the extension (Firefox).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 22, 2013, 11:37:03 am
I don't know, if you can do this, but it would be great, if you don't have do rewrite your blacklist after re-downloading the extension (Firefox).

This is beyond my powers at present. Perhaps someone else around here knows more. We're using the html5 localStorage object and I don't understand it at all really.
Title: Re: Goko Dominion Salvager Discussion
Post by: rrenaud on August 22, 2013, 11:50:19 am
Maybe goko should just hire ragingduckd?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 22, 2013, 11:54:39 am
Maybe goko should just hire ragingduckd?

As a developer... I'd quit.
As a project manager... I'd scrap the Dominion project and start over.
As a CEO... I'd try to sell the company.
As PR or customer support... I'd kill myself.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on August 22, 2013, 12:21:50 pm
Maybe goko should just hire ragingduckd?

As a developer... I'd quit.
As a project manager... I'd scrap the Dominion project and start over.
As a CEO... I'd try to sell the company.
As PR or customer support... I'd kill myself.

I'm sure you'd make a lovely cleaning lady!
Title: Re: Goko Dominion Salvager Discussion
Post by: jsh357 on August 22, 2013, 12:47:45 pm
Maybe you could do like, temp work?  Get paid a premium to make the interface not-terrible and then walk.  I don't think they'd go for it, but it's a thought.  I would not be playing on Goko without this extension, I'll tell you that much.
Title: Re: Goko Dominion Salvager Discussion
Post by: Polk5440 on August 22, 2013, 01:28:26 pm
Quote from: ragingduckd link=topic=8163.msg283985#msg283985

As a developer... I'd quit.

It seems like Goko already has you working for them... for free.  ;)

Get paid a premium to make the interface not-terrible and then walk. 

The interface is already not-terrible. You must have forgotten what it was like a year ago. That was pretty bad.
Title: Re: Goko Dominion Salvager Discussion
Post by: jsh357 on August 22, 2013, 01:32:48 pm
Quote from: ragingduckd link=topic=8163.msg283985#msg283985

As a developer... I'd quit.

It seems like Goko already has you working for them... for free.  ;)

Get paid a premium to make the interface not-terrible and then walk. 
The interface is already not-terrible. You must have forgotten what it was like a year ago. That was pretty bad.


I am exaggerating, but the built-in log is awful and several cards have weird interfaces that could use some work. (Navigator, for one)  That's not even to mention the Lobby system, lack of features they promised ages ago like Friend lists and tournaments, or missing and improved Adventures.  Bring in a guy who cares about the game.  Let him make tweaks.  That's what I'd do.
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on August 22, 2013, 06:48:41 pm
Maybe goko should just hire ragingduckd?

There was an episode of something, I think Simpsons but maybe South Park, where one of the characters gets hired by a Silicon Valley startup, complete with the standard "zany atmosphere" of the stereotypical early 2000s startup.  There's a scene where pay is discussed; all pay is in the form of stock options... which are printed on rolls and hung on the wall like toilet paper.  The character is basically told to help themselves.

I imagine that's what the pay is like at Goko right now.
Title: Re: Goko Dominion Salvager Discussion
Post by: WanderingWinder on August 22, 2013, 06:54:10 pm
Maybe goko should just hire ragingduckd?

There was an episode of something, I think Simpsons but maybe South Park, where one of the characters gets hired by a Silicon Valley startup, complete with the standard "zany atmosphere" of the stereotypical early 2000s startup.  There's a scene where pay is discussed; all pay is in the form of stock options... which are printed on rolls and hung on the wall like toilet paper.  The character is basically told to help themselves.

I imagine that's what the pay is like at Goko right now.
It's the Simpsons. And remember, Bart, it's not about how much worthless stock you have, it's about how much copper wire you can pull out of the walls before they tear the building down.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 22, 2013, 08:49:05 pm
if you have 4000+ in your game title, then you won't be matched with anyone below 4000
Is there a way to introduce an upper bound in your game title (so that for example I'm not matched with anyone over 6000) or (which would be IMO the best solution) introduce a ranking interval centered at your current rank score so that for example everyone who is further than let's say 1200 from my current rank score is autokicked, no matter if ranked higher or lower than me?

Maybe like "All cards #VPON 4000+ 6000-" would be a way to do it.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 22, 2013, 09:25:42 pm
Version 2.2.3 released, just fixing the CSS bug that was introduced in 2.2.2. (http://forum.dominionstrategy.com/index.php?topic=8163.msg283490#msg283490)
Title: Re: Goko Dominion Salvager Discussion
Post by: GeoLib on August 26, 2013, 12:28:18 pm
The link to the firefox download appears to be dead and I also can't find it by searching in add-on manager.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 26, 2013, 12:55:42 pm
Got rejected from the Mozilla gallery again, here's a temporary link for v2.2.3, manual install required (ragingduck, could you add this link to the main description post and whatnot?)

https://s3-us-west-2.amazonaws.com/dominionextension/gokosalvager.xpi
Title: Re: Goko Dominion Salvager Discussion
Post by: theory on August 26, 2013, 01:04:04 pm
You're a moderator on this board, you can edit posts as you please :-)
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on August 26, 2013, 01:06:42 pm
Got rejected from the Mozilla gallery again, here's a temporary link for v2.2.3, manual install required (ragingduck, could you add this link to the main description post and whatnot?

What causes the rejection?  Just somebody's whim?
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on August 26, 2013, 02:01:58 pm
Would be cool if you could see the rating of your opponent, when a automatch-game is proposed. Now I only see my own rating.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 26, 2013, 02:08:53 pm
You're a moderator on this board, you can edit posts as you please :-)

Was just about to start class when I posted that, thought ragingduck might have a chance before me. I've taken care of it now.

Got rejected from the Mozilla gallery again, here's a temporary link for v2.2.3, manual install required (ragingduck, could you add this link to the main description post and whatnot?

What causes the rejection?  Just somebody's whim?

This was in the rejection message:
Quote
1) Your add-on creates DOM nodes from HTML strings containing unsanitized data, by assigning to innerHTML or through similar means.

It looks like the way we set up the in-game log viewer can be insecure or something.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on August 26, 2013, 02:40:56 pm
This was in the rejection message:
Quote
1) Your add-on creates DOM nodes from HTML strings containing unsanitized data, by assigning to innerHTML or through similar means.

It looks like the way we set up the in-game log viewer can be insecure or something.

I haven't looked at the code, so maybe you're already doing this, but perhaps if you escaped all of the text elements before inserting them into the DOM, including card names that you pull, etc?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 26, 2013, 06:39:29 pm
This was in the rejection message:
Quote
1) Your add-on creates DOM nodes from HTML strings containing unsanitized data, by assigning to innerHTML or through similar means.

It looks like the way we set up the in-game log viewer can be insecure or something.

I haven't looked at the code, so maybe you're already doing this, but perhaps if you escaped all of the text elements before inserting them into the DOM, including card names that you pull, etc?

Yes, that would address the problem, though Mozilla isn't very happy with that solution either (https://developer.mozilla.org/en-US/docs/XUL/School_tutorial/DOM_Building_and_HTML_Insertion?redirectlocale=en-US&redirectslug=XUL_School%2FDOM_Building_and_HTML_Insertion#innerHTML_with_HTML_Escaping) and might reject us again anyway. I've been gradually removing (https://github.com/aiannacc/Goko-Salvager/tree/logviewer-overhaul) the offending code, but that's basically meant rewriting the log viewer and vp counter. I wasn't very familiar with either of these at first, so it's been slow going.

FYI, I'm pretty sure there's no actual security risk here. I think the only way it could be done in the current version is with a particularly clever and very short script that someone put in their Goko username. Like registering with Goko as "<td/></table></div><script>/*DO BAD THINGS*/</script>"

That's not terribly plausible, but Mozilla doesn't actually try to figure out whether or how your code might be exploited. They just identify the vulnerable constructs and disallow them. That's a good policy, IMO.
Title: Re: Goko Dominion Salvager Discussion
Post by: WanderingWinder on August 26, 2013, 06:50:45 pm
This was in the rejection message:
Quote
1) Your add-on creates DOM nodes from HTML strings containing unsanitized data, by assigning to innerHTML or through similar means.

It looks like the way we set up the in-game log viewer can be insecure or something.

I haven't looked at the code, so maybe you're already doing this, but perhaps if you escaped all of the text elements before inserting them into the DOM, including card names that you pull, etc?

Yes, that would address the problem, though Mozilla isn't very happy with that solution either (https://developer.mozilla.org/en-US/docs/XUL/School_tutorial/DOM_Building_and_HTML_Insertion?redirectlocale=en-US&redirectslug=XUL_School%2FDOM_Building_and_HTML_Insertion#innerHTML_with_HTML_Escaping) and might reject us again anyway. I've been gradually removing (https://github.com/aiannacc/Goko-Salvager/tree/logviewer-overhaul) the offending code, but that's basically meant rewriting the log viewer and vp counter. I wasn't very familiar with either of these at first, so it's been slow going.

FYI, I'm pretty sure there's no actual security risk here. I think the only way it could be done in the current version is with a particularly clever and very short script that someone put in their Goko username. Like registering with Goko as "<td/></table></div><script>/*DO BAD THINGS*/</script>"

That's not terribly plausible, but Mozilla doesn't actually try to figure out whether or how your code might be exploited. They just identify the vulnerable constructs and disallow them. That's a good policy, IMO.
http://xkcd.com/327/
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 26, 2013, 07:06:43 pm
http://xkcd.com/327/

Yup! :)
Title: Re: Goko Dominion Salvager Discussion
Post by: GendoIkari on August 26, 2013, 07:20:49 pm
What if they're making this extension just for the respect... (forum respect)

Posting memes would be an easier way...

(http://i.qkme.me/3vlvgg.jpg)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 26, 2013, 08:07:21 pm
What if they're making this extension just for the respect... (forum respect)

Posting memes would be an easier way...

(http://i.qkme.me/3vlvgg.jpg)

(http://i.qkme.me/3vlvx7.jpg)
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on August 26, 2013, 08:16:25 pm
You're a moderator on this board, you can edit posts as you please :-)

Was just about to start class when I posted that, thought ragingduck might have a chance before me. I've taken care of it now.

Got rejected from the Mozilla gallery again, here's a temporary link for v2.2.3, manual install required (ragingduck, could you add this link to the main description post and whatnot?

What causes the rejection?  Just somebody's whim?

This was in the rejection message:
Quote
1) Your add-on creates DOM nodes from HTML strings containing unsanitized data, by assigning to innerHTML or through similar means.

It looks like the way we set up the in-game log viewer can be insecure or something.

I imagine it's almost as insecure as Goko's site itself!
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on August 26, 2013, 08:21:30 pm
What if they're making this extension just for the respect... (forum respect)

Posting memes would be an easier way...

(http://i.qkme.me/3vlvgg.jpg)

(http://i.qkme.me/3vlvx7.jpg)

Hey, that's actually good advice!
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 26, 2013, 08:22:44 pm
What if they're making this extension just for the respect... (forum respect)

Posting memes would be an easier way...

http://i.qkme.me/3vlvgg.jpg

http://i.qkme.me/3vlvx7.jpg


Hey, that's actually good advice!

For certain values of "easy", anyway.
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on August 26, 2013, 10:13:56 pm
What happened to me twice today, is that I was hosting a game with auto-automatch turned on, and just after somebody joined my game, automatch found someone. In fact, I was one of the decliners of sudgy (see this post (http://forum.dominionstrategy.com/index.php?topic=6607.msg286071#msg286071))

Suggestion: cancel automatch search when somebody joins your game (and start searching when the spot becomes empty again).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 26, 2013, 11:11:44 pm
Would be cool if you could see the rating of your opponent, when a automatch-game is proposed. Now I only see my own rating.

Good idea. I thought it already did this, but it's actually only being shown when the game is announced.

What happened to me twice today, is that I was hosting a game with auto-automatch turned on, and just after somebody joined my game, automatch found someone. In fact, I was one of the decliners of sudgy (see this post (http://forum.dominionstrategy.com/index.php?topic=6607.msg286071#msg286071))

Suggestion: cancel automatch search when somebody joins your game (and start searching when the spot becomes empty again).

I'm a little nervous about the race conditions that this solution might produce. We've got five agents communicating asynchronously (Goko, my server, you, your automatch opponent, and the guy who just joined your table).

Help me understand the problem a little better. Is it that you're not sure which opponent you'd rather play against? Or you want to avoid giving offense to either opponent?

What if the UI let you see both offers and told your automatch opponent why he was being declined?
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on August 27, 2013, 12:05:01 am
Hmm... Okay, maybe my suggestion wasn't very good, because I can see some timing issues with five agents... It's not a big problem, but my problem was indeed to avoid giving offense to either opponent. Both hosting a game and using automatch suggest I look for a game, and I feel bad for then turning either opponent down.

I don't see a good solution for it, so maybe you should change nothing at all. Telling automatch opponent why he was being declined may be good, but might also be annoying (if you let them know via a pop-up). Maybe it should be something I have to live with if I use two methods of finding an opponent.

PS: I see I had two (non-ragingduck) upvotes for the suggestion, so maybe I'm not the only one with this problem (or I'm interpreting upvotes wrongly).
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 27, 2013, 01:46:23 am
I had the opposite issue, where I had automatch searching, then joined a table someone was hosting, and then was matched with someone by automatch after my game had started.  I think it may have been Turn 3 or 4, so it wasn't just as I was connecting.

I believe automatch doesn't disengage when I join a different game.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 27, 2013, 01:54:19 am
I had the opposite issue, where I had automatch searching, then joined a table someone was hosting, and then was matched with someone by automatch after my game had started.  I think it may have been Turn 3 or 4, so it wasn't just as I was connecting.

I believe automatch doesn't disengage when I join a different game.

It's supposed to. It gets confused when if you log in from multiple tabs though. Was that the case for you, or is this a different bug? Did it crash the game?
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 27, 2013, 02:08:16 am
I had the opposite issue, where I had automatch searching, then joined a table someone was hosting, and then was matched with someone by automatch after my game had started.  I think it may have been Turn 3 or 4, so it wasn't just as I was connecting.

I believe automatch doesn't disengage when I join a different game.

It's supposed to. It gets confused when if you log in from multiple tabs though. Was that the case for you, or is this a different bug? Did it crash the game?

I only do one tab when I play.  Here's the sequence:

Click Multiplayer button
Screen Loads
Click Automatch, Submit (it goes green: searching)
Start room jumping, see one I meet the reqs for
Sit at the seat
Game accepted, wait for long loading screen
Game starts, open Scout - Scout if Baker board, Scout - Estate if not
A few turns in, Automatch pops up with a game offer, I decline
Continue game, buy 10 Scouts
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 27, 2013, 02:17:14 am
I had the opposite issue, where I had automatch searching, then joined a table someone was hosting, and then was matched with someone by automatch after my game had started.  I think it may have been Turn 3 or 4, so it wasn't just as I was connecting.

I believe automatch doesn't disengage when I join a different game.

It's supposed to. It gets confused when if you log in from multiple tabs though. Was that the case for you, or is this a different bug? Did it crash the game?

I only do one tab when I play.  Here's the sequence:

Click Multiplayer button
Screen Loads
Click Automatch, Submit (it goes green: searching)
Start room jumping, see one I meet the reqs for
Sit at the seat
Game accepted, wait for long loading screen
Game starts, open Scout - Scout if Baker board, Scout - Estate if not
A few turns in, Automatch pops up with a game offer, I decline
Continue game, buy 10 Scouts

Yup. That's a new one. Thanks for the detail. I'll try to track it down. About what time did it happen?
Title: Re: Goko Dominion Salvager Discussion
Post by: Young Nick on August 27, 2013, 03:13:42 am
This probably has been asked before, but...

Feature Request: A noise of sorts when you have been called upon by Goko to do something related to the game. I know for a fact I'm not the only one who wishes to be alt-tabbing while playing online.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 27, 2013, 03:22:22 am
I had the opposite issue, where I had automatch searching, then joined a table someone was hosting, and then was matched with someone by automatch after my game had started.  I think it may have been Turn 3 or 4, so it wasn't just as I was connecting.

I believe automatch doesn't disengage when I join a different game.

It's supposed to. It gets confused when if you log in from multiple tabs though. Was that the case for you, or is this a different bug? Did it crash the game?

I only do one tab when I play.  Here's the sequence:

Click Multiplayer button
Screen Loads
Click Automatch, Submit (it goes green: searching)
Start room jumping, see one I meet the reqs for
Sit at the seat
Game accepted, wait for long loading screen
Game starts, open Scout - Scout if Baker board, Scout - Estate if not
A few turns in, Automatch pops up with a game offer, I decline
Continue game, buy 10 Scouts

Yup. That's a new one. Thanks for the detail. I'll try to track it down. About what time did it happen?

Maybe 24 hours ago?  It was yesterday evening my time, so maybe 5 am forum time?
Title: Re: Goko Dominion Salvager Discussion
Post by: fprefect on August 27, 2013, 05:31:33 am
Dear Ragingduckd,

I just wanted to say, that in its current form Automatch just works great. Yesterday I had consistently a match right away like 8 times in a row. Thank you so much for doing the work others are payed for.

fprefect
Title: Re: Goko Dominion Salvager Discussion
Post by: pst on August 27, 2013, 10:52:53 am
I like automatch a lot! I wonder if it works with multiplayer though. I usually have it set on 2-4 players, but have never got a match for more than two players. When I started wondering about this I set it to 3-4 players, and then I never got a match. Maybe everyone else is asking only for 2-player games, and that's why?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 27, 2013, 11:21:07 am
I like automatch a lot! I wonder if it works with multiplayer though. I usually have it set on 2-4 players, but have never got a match for more than two players. When I started wondering about this I set it to 3-4 players, and then I never got a match. Maybe everyone else is asking only for 2-player games, and that's why?

Everyone is asking for 2-X player gsmes and there's no delay when a match is found. It didnt seem make much sense when there were 10 matches a day, but I could try it now.
Title: Re: Goko Dominion Salvager Discussion
Post by: shark_bait on August 27, 2013, 01:47:46 pm
Any chance the automatch extension could not reset your game name?  Whenever I host I put certain restrictions in the name that I want if people without automatch join.  (i.e.  #vpoff and 5000+)  Having the name default to "For X" means resetting the game name after each match.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 27, 2013, 02:43:21 pm
Any chance the automatch extension could not reset your game name?  Whenever I host I put certain restrictions in the name that I want if people without automatch join.  (i.e.  #vpoff and 5000+)  Having the name default to "For X" means resetting the game name after each match.

Good call. Yes, that's no problem.
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on August 27, 2013, 06:56:20 pm
I think I found a small bug. It happened when I just completed a game (which was not found via automatch, but I had auto-automatch on when hosting the game). It said "Automatch: Idle" as it should, but when I clicked on it, I got the "Looking for a match"-message, see below.

No matter what button I clicked on the pop-up (Stop Looking, Keep Looking or the top-right button), the button disappeared, but the state remained the same (i.e. "Automatch: Idle", but "Looking for match" on click). I could "solve" the problem by creating a game with auto-automatch (the text became the usual green "Automatch: Searching"-message), and after that everything worked as normal (i.e. I could stop searching with automatch when clicking on "Stop Looking").

Maybe it's related to the bug report of ashersky.

(http://i.imgur.com/QWTIXKB.png)
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 28, 2013, 12:45:42 am
Automatch is completely down now.  Red text.  No connection.  I'm guessing the server is down.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on August 28, 2013, 01:15:12 am
Automatch is completely down now.  Red text.  No connection.  I'm guessing the server is down.

It seems to be running, and I just got matched. Is anyone else having trouble?
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on August 28, 2013, 01:20:24 am
Automatch is completely down now.  Red text.  No connection.  I'm guessing the server is down.

It seems to be running, and I just got matched. Is anyone else having trouble?

It worked for me about 20 minutes later, and after I had played a normal game.
Title: Re: Goko Dominion Salvager Discussion
Post by: shraeye on August 30, 2013, 09:24:39 am
Feature request:

When I leave a gameroom and return to the lobby, the lobby chatbox is always scrolled up to the very top...where the first message sent since I entered the room was.


Can we get that to automatically move down to the most RECENT message like any sane person would do?
Title: Re: Goko Dominion Salvager Discussion
Post by: GeoLib on August 30, 2013, 01:12:54 pm
Where did the "automatically turn vpon in adventures" option go? I liked that. Not a big deal, I just always forget to do it until after turn 5 in those games.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on August 30, 2013, 01:16:39 pm
I think I broke it when I changed the messages that the extension puts in chat at the beginning of the game, but the option still showed up in the settings menu even though it didn't work.

ragingduckd made a plan to fix this option and the messages issue: https://github.com/aiannacc/Goko-Salvager/issues/29

Contributions welcome :)
Title: Re: Goko Dominion Salvager Discussion
Post by: Eevee on September 01, 2013, 08:08:25 am
Would it be possible to make #vpon or #vpoff one of the filters for the automatch so you wouldn't have to specify which one do you want after the game starts?
Title: Re: Goko Dominion Salvager Discussion
Post by: jsh357 on September 01, 2013, 08:43:01 am
Is it possible to make #vpon always be on when using the "Play Bots" button?  That's the main time I use it, personally.
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on September 01, 2013, 09:54:15 am
Not the most important thing, but it would be cool, if the "5000+" in the game-name would not kick bots. If i chose a bot to play with, I don't want to kick him, because he isn't good enough ;-) And so I won't have to change the game-name.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 01, 2013, 04:54:06 pm
Would it be possible to make #vpon or #vpoff one of the filters for the automatch so you wouldn't have to specify which one do you want after the game starts?
Is it possible to make #vpon always be on when using the "Play Bots" button?  That's the main time I use it, personally.

Both in progress in this branch (https://github.com/aiannacc/Goko-Salvager/tree/logviewer-overhaul), along with the Firefox security issues and restoration of vp counter for adventures and colors in the log viewer.

Not the most important thing, but it would be cool, if the "5000+" in the game-name would not kick bots. If i chose a bot to play with, I don't want to kick him, because he isn't good enough ;-) And so I won't have to change the game-name.

Ok, makes sense.

Just a heads-up: my schedule has gotten busier recently. My Dominion coding priorities right now are:
1. Fix the "too many open files" issue that keeps crashing drunkensailor
2. Finish the overhaul of the log-viewer in the branch I linked above
3. Fix the leaderboard issues and implement Isotropic's version of TrueSkill

It may be a while before I get to the Automatch feature requests and many other good lobby improvements that people have suggested. That's not to discourage these requests, but rather to encourage github contributions.

We have a list of outstanding bugs and requests here (https://github.com/aiannacc/Goko-Salvager/issues?state=open). Many of them are small issues that would make a good introduction to the code. We also have some brief instructions explaining how to get started developing the extension (https://github.com/aiannacc/Goko-Salvager/blob/logviewer-overhaul/README.md), and I'd be happy to provide more detail to anyone who's interested.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 03, 2013, 11:13:09 am
I think I've finally figured out the "Too many open files" problem that has been crashing automatch and drunkensailor. Unfortunately, my workaround is going to screw with the extension until I find a cleaner server-side fix. Specifically, automatch may produce unexpected behavior in multiple tabs.

This workaround seems to be working. The old connections are getting closed properly now. 30 hours without excessive drunkenness and counting...
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on September 04, 2013, 11:25:26 am
Bug report: When you get automatched in the middle of a "Create Game", and accept the automatch, you get into the game playing screen, but everything is disabled, so you can't do anything. The screen is even darkened to show this.  The only way out, apparently, was to disconnect and leave my opponent hanging (and eventually lose some rating, I guess).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 04, 2013, 01:06:20 pm
Bug report: When you get automatched in the middle of a "Create Game", and accept the automatch, you get into the game playing screen, but everything is disabled, so you can't do anything. The screen is even darkened to show this.  The only way out, apparently, was to disconnect and leave my opponent hanging (and eventually lose some rating, I guess).

My apologies. Can you clarify what you mean by "in the middle of a "Create Game"" and "the game playing screen"? I'm guessing you mean that you or your opponent has already clicked "Start Game" and the lobby has been replaced by the black screen or the progress bar?
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on September 04, 2013, 01:26:13 pm
Bug report: When you get automatched in the middle of a "Create Game", and accept the automatch, you get into the game playing screen, but everything is disabled, so you can't do anything.
This is not entirely true; clicking doesn't do anything, but you can still chat.
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on September 04, 2013, 02:50:28 pm
Bug report: When you get automatched in the middle of a "Create Game", and accept the automatch, you get into the game playing screen, but everything is disabled, so you can't do anything.
This is not entirely true; clicking doesn't do anything, but you can still chat.

I tried and could not.
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on September 04, 2013, 09:08:04 pm
I got this bug (http://forum.dominionstrategy.com/index.php?topic=8163.msg286439#msg286439) again. It happened this time right after I was succesfully automatched. When the game finished (and Goko gave me another +0 rating change), and I returned to the lobby, I had exactly the same symptoms as before. (I tested one more thing: going back to main menu and then to multiplayer again didn't get me out of the "buggy" state). I had just 1 tab open with Goko. If there is something I should do/test/note when I get it again, please let me know
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 04, 2013, 10:26:45 pm
I got this bug (http://forum.dominionstrategy.com/index.php?topic=8163.msg286439#msg286439) again. It happened this time right after I was succesfully automatched. When the game finished (and Goko gave me another +0 rating change), and I returned to the lobby, I had exactly the same symptoms as before. (I tested one more thing: going back to main menu and then to multiplayer again didn't get me out of the "buggy" state). I had just 1 tab open with Goko. If there is something I should do/test/note when I get it again, please let me know

No, though I appreciate your very polite way of bringing it to my attention again. ;)

That was actually a really clear and helpful bug report. I'm almost certain that I know what's going on and how to fix it (https://github.com/aiannacc/Goko-Salvager/issues/74). There's one other thing you could do to make me certain my diagnosis and fix is correct, but it's a bit technical. See the github issue and don't bother unless it's immediately clear what I'm asking for.

I don't think this issue could be related to Goko's +0 rating change bug, though it would be great to find a way to reproduce that bug with client-side behavior. Did it happen both times?

Bug report: When you get automatched in the middle of a "Create Game", and accept the automatch, you get into the game playing screen, but everything is disabled, so you can't do anything. The screen is even darkened to show this.  The only way out, apparently, was to disconnect and leave my opponent hanging (and eventually lose some rating, I guess).

My apologies. Can you clarify what you mean by "in the middle of a "Create Game"" and "the game playing screen"? I'm guessing you mean that you or your opponent has already clicked "Start Game" and the lobby has been replaced by the black screen or the progress bar?

@soulnet: I'm guessing you missed this response. Can you give me more detail about when this bug happens and what you see? Has it happened more than once?
@Awaclus: Your response suggests that this has happened to you too, yes?
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on September 05, 2013, 05:08:27 am
@Awaclus: Your response suggests that this has happened to you too, yes?
Yeah.

soulnet: How did you try chatting? You can't open the chat with mouse, but if you open it by hitting Enter, it worked for me.
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on September 05, 2013, 02:14:12 pm
My apologies. Can you clarify what you mean by "in the middle of a "Create Game"" and "the game playing screen"? I'm guessing you mean that you or your opponent has already clicked "Start Game" and the lobby has been replaced by the black screen or the progress bar?

I did not missed this, I was just away from a computer until just now. I click on "Create a Game", and whilst on the "Create a Game" dialog (where you choose Pro/Casual/Unrated, set the number of seats, etc.) the automatch pops up and says it found a game. I accept the game and after a while I'm taken to the game screen by the automatch, but the disabling of the background (which is not the background anymore) the "Create a Game" did does not go away. Basically, the "Create a Game" dialog disappears/closes but it does not enable the background back.

soulnet: How did you try chatting? You can't open the chat with mouse, but if you open it by hitting Enter, it worked for me.

I tried every key in my keyboard and nothing happened. If it happens again, I will try Enter again, maybe I missed it working in the middle of the "try everything and fail" fiasco.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 05, 2013, 06:13:49 pm
My apologies. Can you clarify what you mean by "in the middle of a "Create Game"" and "the game playing screen"? I'm guessing you mean that you or your opponent has already clicked "Start Game" and the lobby has been replaced by the black screen or the progress bar?

I did not missed this, I was just away from a computer until just now. I click on "Create a Game", and whilst on the "Create a Game" dialog (where you choose Pro/Casual/Unrated, set the number of seats, etc.) the automatch pops up and says it found a game. I accept the game and after a while I'm taken to the game screen by the automatch, but the disabling of the background (which is not the background anymore) the "Create a Game" did does not go away. Basically, the "Create a Game" dialog disappears/closes but it does not enable the background back.

Got it. The problem is that automatch is putting the Goko UI into a state that it never expected to see: a game is starting even though the Create Game dialog is visible. Having never been tested and fixed to handle that particular state, the inherent madness of the Goko code is taking control.

I think I can fix this pretty easily. Automatch just needs to mimic closing the Create Game dialog before sending you to Outpost. I'm also making the automatch dialogs non-modal in case other similar UI interaction issues arise. If the dialog was non-modal you'd at least be able to close the Create Game dialog manually before accepting the automatch -- not ideal, but better than having to decline the match or crash the game.

I plan to do a release this weekend that includes a few new features and a lot of small fixes I've been coding. Anyone feel like doing some beta testing? :)
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 06, 2013, 08:06:23 am
I have two bug reports, first the minor:

(http://img12.imageshack.us/img12/11/msry.jpg)

(http://img594.imageshack.us/img594/8687/lw4n.jpg)

I cannot reproduce this in any way. It seems to be working now.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 06, 2013, 10:47:26 am
I have two bug reports, first the minor:

(http://img12.imageshack.us/img12/11/msry.jpg)

Is this (http://forum.dominionstrategy.com/index.php?topic=8163.msg286439#msg286439) the bug you're reporting? If so, it's already fixed. It'll be in the version I'll release this weekend.

Quote
(http://img594.imageshack.us/img594/8687/lw4n.jpg)

I cannot reproduce this in any way. It seems to be working now.

Is this just a supplement to the first picture? What's your second bug report?
Title: Re: Goko Dominion Salvager Discussion
Post by: GeoLib on September 06, 2013, 12:16:14 pm
I have two bug reports, first the minor:

(http://img12.imageshack.us/img12/11/msry.jpg)

Is this (http://forum.dominionstrategy.com/index.php?topic=8163.msg286439#msg286439) the bug you're reporting? If so, it's already fixed. It'll be in the version I'll release this weekend.

Quote
(http://img594.imageshack.us/img594/8687/lw4n.jpg)

I cannot reproduce this in any way. It seems to be working now.

Is this just a supplement to the first picture? What's your second bug report?

It looks like the bug is that he can type in the "seeks" area. I just tried and can do it too.

Edit: Or I'm completely wrong. I just assumed that PpFtw were nonsense characters. I can type in the seeks area though. Not sure if that's a problem.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 06, 2013, 12:25:10 pm
Sorry for not being more clear.

The reported bug was that while I had my automatch activated, I did not appear in the Seekers list and my automatch said it was idle.

The other bug is that yesterday I got assigned two games: automatch had assigned me to SM.SM and I was waiting for confirmation. It took a really long time so I went to another tab to check f.ds (I had Goko open only in one tab, fwiw), when I got back that "waiting for opponent to confirm" window had disappeared. I then did some random clicking on that automatch status thing and possibly updated my game by untick-ticking the automatch option, and eventually I got automatched to Mic Qsenoch.

So far so good...

However, just after the game loaded, I got a message that SM.SM had accepted my game, and before I could click "Abort" the window was gone. Nothing happened for 20 seconds or so, and then suddenly I got the "You quit" end of game screen from Goko, and right after that the game with SM.SM began to load. Halfway through that game I again got that "You quit" screen out of nowhere, and I was brought back to Outpost where I found the entire interface unresponsive (chat messages from others showed up, but I could not do anything myself until I had logged in from a new tab).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 06, 2013, 02:07:57 pm
The other bug is that yesterday I got assigned two games: automatch had assigned me to SM.SM and I was waiting for confirmation. It took a really long time so I went to another tab to check f.ds (I had Goko open only in one tab, fwiw), when I got back that "waiting for opponent to confirm" window had disappeared. I then did some random clicking on that automatch status thing and possibly updated my game by untick-ticking the automatch option, and eventually I got automatched to Mic Qsenoch.

So far so good...

However, just after the game loaded, I got a message that SM.SM had accepted my game, and before I could click "Abort" the window was gone. Nothing happened for 20 seconds or so, and then suddenly I got the "You quit" end of game screen from Goko, and right after that the game with SM.SM began to load. Halfway through that game I again got that "You quit" screen out of nowhere, and I was brought back to Outpost where I found the entire interface unresponsive (chat messages from others showed up, but I could not do anything myself until I had logged in from a new tab).

Yikes! Has this happened to anyone else?

I think I've managed to work out how this happened. It looks like you accepted the match with SM.SM, but it didn't start because he was afk. Then you got briefly disconnected from automatch, which made your offer dialog disappear. Somehow SM.SM's dialog didn't disappear, however, and when he accepted the game, automatch tried to start it. The rest was Goko's reaction to an impossible condition: starting a game while already in one.

So the bugs were:
1. Your getting disconnected from automatch. That really shouldn't happen unless your connection is terrible and/or you're logging in to multiple tabs.
2. SM.SM's offer dialog not going away when you got disconnected. It's possible for this to happen by messages crossing each other, but the timing in the log suggests that this isn't what happened.
3. Automatch let you join a table with SM.SM even though you were already in a game.

Bug #1 is probably a hangover from my shoddy way of dealing with logins from multiple tabs. It's going to take some real work for me to get this completely right. Allowing multiple logins is just such a horrible, horrible thing.

Bug #2 is quite mysterious. I'll look into it but it may be hard to find.

Bug #3 is because Automatch isn't doing any error-checking. It's trusting my server, Goko, and the rest of the extension to give it a sane environment to work in. So it's not responding well to insane requests like "go start a game even though you're already in one."

It would be much better to fix the causes of the insane requests (bugs #1 & #2) than to make automatch responsible for verifying that the rest of the system isn't talking madness to it. But realistically, insane requests are going to happen... the extension is amateur software under active development written in a horrible language and running on an utterly unreliable game server. And the stakes are relatively high, as making players forfeit games is a really, really bad thing.

So even though it's sort of the wrong solution, I'm going to start adding some error-checking to automatch anyway. Hopefully this bug and the next similar one will both go away.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 06, 2013, 02:08:50 pm
It looks like the bug is that he can type in the "seeks" area. I just tried and can do it too.

Edit: Or I'm completely wrong. I just assumed that PpFtw were nonsense characters. I can type in the seeks area though. Not sure if that's a problem.

If you type in the seek area and then get confused by what you've typed, the Dominion might not be the right game for you. Maybe try Snakes & Ladders. ;)
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on September 06, 2013, 02:13:18 pm
Quote from: ragingduckd
It's trusting Goko
I see the problem.
Title: Re: Goko Dominion Salvager Discussion
Post by: GeoLib on September 06, 2013, 03:31:03 pm
It looks like the bug is that he can type in the "seeks" area. I just tried and can do it too.

Edit: Or I'm completely wrong. I just assumed that PpFtw were nonsense characters. I can type in the seeks area though. Not sure if that's a problem.

If you type in the seek area and then get confused by what you've typed, the Dominion might not be the right game for you. Maybe try Snakes & Ladders. ;)

??
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 06, 2013, 03:42:57 pm
It looks like the bug is that he can type in the "seeks" area. I just tried and can do it too.

Edit: Or I'm completely wrong. I just assumed that PpFtw were nonsense characters. I can type in the seeks area though. Not sure if that's a problem.

If you type in the seek area and then get confused by what you've typed, the Dominion might not be the right game for you. Maybe try Snakes & Ladders. ;)

??

Just a joke. I don't think it's a serious problem. I'll fix it when I get around to making that interface actually informative and useful.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 09, 2013, 11:51:44 am
This happened to me yesterday:

(http://img7.imageshack.us/img7/5480/jrw8.jpg)
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 09, 2013, 11:59:55 am
And right now I seem to be looking for 3 games:

(http://img62.imageshack.us/img62/1904/81m7.jpg)

Actually, 4 as we speak. I also found out what causes it: when I see my automatch status say it's Idle, I open the game settings and untick-tick the use automatch option and update my game, after which it starts searching again, but it doesn't seem to close the other requests. And why does it go Idle in the first place?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 09, 2013, 12:13:35 pm
And right now I seem to be looking for 3 games:

(http://img62.imageshack.us/img62/1904/81m7.jpg)

Actually, 4 as we speak. I also found out what causes it: when I see my automatch status say it's Idle, I open the game settings and untick-tick the use automatch option and update my game, after which it starts searching again, but it doesn't seem to close the other requests. And why does it go Idle in the first place?

There's something wrong with the code I introduced to stop the "too many open files" problem from crashing the server. It's closing connections it shouldn't and then it's handling the auto-reconnects wrong. See my comments (http://forum.dominionstrategy.com/index.php?topic=8163.msg289789#msg289789) on your previous bug report. Basically, weird things are going to keep happening with automatch until I sort it out.

Edit: On further examination, I think my server code is fine. Not great, but not what's been causing the problems either. The problem was the timeout detection and auto-connecting behavior of the client (extension). I didn't allow nearly enough margin for lag, so the client was incorrectly concluding that it had lagged out. Even worse, there was a subtle way for the client to accidentally initiate multiple connections (dozens, even). I believe I have that all fixed in v2.3.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 09, 2013, 03:46:20 pm
New release of Goko Dominion Salvager (v2.3 beta v2.3.1)
Edit: v2.3.1 fixes the VP counter and log viewer bugs posted below.

Permalink link to latest release (http://forum.dominionstrategy.com/index.php?topic=9198.msg283465#msg283465)

These changes should address the strange automatch behavior of the past week. I've also introduced some new features (in bold below) and fixed some small bugs.

Please report any new bugs or old bugs that weren't fixed after all. Many thanks to yed for doing a great deal of beta testing already. For bonus credit, enable "Extra Logging" and send the console log too (F12 in Chrome; Tools/Web Developer/Browser Console in Firefox).

VP Counter:
Autokick:
Automatch:
Misc:
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 09, 2013, 08:23:48 pm
Clarifications for v2.3:

Updating:
Only Chrome will auto-update, and that won't happen for a couple days -- not until I publish the new version to their webstore. To get the spiffy new features and bugfixes now, you have to install v2.3 manually.

Overriding the VP counter lock with #vpx:
#vpx can change the VP counter even when it is locked, but only by mutual consent. This is meant for situations where neither player remembered to type #vpon before T5.

Here's an example:
(http://i.imgur.com/E55aKB9.png)

If rgduck had said nothing in response to AI's #vpx, the counter would have remained off.
Title: Re: Goko Dominion Salvager Discussion
Post by: pst on September 10, 2013, 02:02:32 am
Overriding the VP counter lock with #vpx:
#vpx can change the VP counter even when it is locked, but only by mutual consent. This is meant for situations where neither player remembered to type #vpon before T5.

Nice, but is a new command really necessary? Couldn't it just be so that if all players do the same #vpon/#vpoff command that takes effect?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 10, 2013, 02:40:54 am
Overriding the VP counter lock with #vpx:
#vpx can change the VP counter even when it is locked, but only by mutual consent. This is meant for situations where neither player remembered to type #vpon before T5.

Nice, but is a new command really necessary? Couldn't it just be so that if all players do the same #vpon/#vpoff command that takes effect?

Possibly, but there are already way too many scenarios for the extension to handle when it receives a #vpon/#vpoff message. It would be easier if all the users had the same extension version, or had the extension at all, or knew how to use it, or could communicate by a channel other than chat.

As it is, it's challenging enough just to make the thing backwards compatible and have it inform users of its usage without flooding them with redundant chat messages. I figured it was better to introduce a new, unambiguous command than to overload the #vpon/#vpoff logic still further.
Title: Re: Goko Dominion Salvager Discussion
Post by: pst on September 10, 2013, 02:57:08 am
New release of Goko Dominion Salvager (v2.3)

Great! If I'm not mistaken the score is shown in a bigger font than before as well, which I appreciate!
There are some other things that have been lost in the point counter though. Here is a recent example where it didn't see any points for the Vineyards!
(http://starback.se/spel/point-counter-0pt-vineyards.png)

The players aren't reordered in score order anymore. (Intentional?) And in one (multiplayer) game the colors were mixed up so that the score list didn't use the same colors as in the game log.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 10, 2013, 03:21:01 am
There are some other things that have been lost in the point counter though. Here is a recent example where it didn't see any points for the Vineyards!

Gotcha. Yes, I seem to have broken the aggregation. Easy fix.

Quote
The players aren't reordered in score order anymore. (Intentional?) And in one (multiplayer) game the colors were mixed up so that the score list didn't use the same colors as in the game log.

Not intentional, will fix both. Thanks!
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 10, 2013, 05:37:28 am
I updated to the latest version and the random disconnects seem to be gone.

The automatch blacklist doesn't seem to be working though, I added johovall_goko to it after he disabled the point counter (I did not add him to the other blacklist, as I don't mind him joining my regular #vpon games), but I still got matched to him. And we both got removed from the automatch que.

As I was writing this, I got 2 matches with Loschikitos, he declined both but as a consequence I had to restart automatch. That is obviously not what I want :)
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 10, 2013, 06:35:00 am
New release of Goko Dominion Salvager (v2.3 beta)

Autokick:
  • Support more complex rating ranges (e.g. 4000+, 5k-, 3.8k-5.2k, +/-500)
  • Support limiting table to named individual(s) (e.g. "For Bob, Joe" kicks anyone else)

Can you support autokick with "f.ds" in the game title to only let regular f.dsers into your table?  (Note: you might make it work by autokicking folks without the extension running...)
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on September 10, 2013, 06:58:16 am
New release of Goko Dominion Salvager (v2.3 beta)

Autokick:
  • Support more complex rating ranges (e.g. 4000+, 5k-, 3.8k-5.2k, +/-500)
  • Support limiting table to named individual(s) (e.g. "For Bob, Joe" kicks anyone else)

Can you support autokick with "f.ds" in the game title to only let regular f.dsers into your table?  (Note: you might make it work by autokicking folks without the extension running...)

Not everyone here has extension. For example Wandering Winder.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 10, 2013, 07:27:39 am
New release of Goko Dominion Salvager (v2.3 beta)

Autokick:
  • Support more complex rating ranges (e.g. 4000+, 5k-, 3.8k-5.2k, +/-500)
  • Support limiting table to named individual(s) (e.g. "For Bob, Joe" kicks anyone else)

Can you support autokick with "f.ds" in the game title to only let regular f.dsers into your table?  (Note: you might make it work by autokicking folks without the extension running...)

Not everyone here has extension. For example Wandering Winder.

Good point.  Well, "+f.ds" might work, if there was a way to scan usernames?  It's probably easier to have a friends list, I guess.
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on September 10, 2013, 08:01:16 am
Good point.  Well, "+f.ds" might work, if there was a way to scan usernames?  It's probably easier to have a friends list, I guess.

That seems difficult but doable, especially if Theory cooperates by giving the list of Goko usernames. Autokicking people without the extension seems simple enough.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 10, 2013, 08:57:25 am
The automatch blacklist doesn't seem to be working though, I added johovall_goko to it after he disabled the point counter (I did not add him to the other blacklist, as I don't mind him joining my regular #vpon games), but I still got matched to him. And we both got removed from the automatch que.

Both lists work for me. In the log, I see no entries in your blacklist, including for the game where you got matched with johovall_goko.

Forgive me if this is obvious, but your options list does look like this, right?
(http://i.imgur.com/Vkz6ROS.png)
And not like this?
(http://i.imgur.com/EGQjfKA.png)

As I was writing this, I got 2 matches with Loschikitos, he declined both but as a consequence I had to restart automatch. That is obviously not what I want :)

Please clarify. You want him to go on your automatch blacklist (or you on his) after the first decline? Or you want your automatch to keep looking after he turns your down?

Here's my pending plan for automatch blacklisting:
1. Add buttons/options to automatch_blacklist a player you decline or who has just declined you
2. Add a drop-down or text field for explaining why you're declining an automatch
3. Put your seek back into the seek pool after you get declined, BUT...
4. Take players who get declined several times in a row out of the pool until they confirm that they're not just AFK

Obviously anyone who gets declined wants to go straight back into the automatch seek pool, but I have to implement #2 before I can do that. Otherwise the person who declined you will just keep matching with you (this happens already to some degree, and it's annoying as hell). Even more important is #5, without which a single AFK seeker would basically shut down the whole service for everyone in his rating range.

Good point.  Well, "+f.ds" might work, if there was a way to scan usernames?  It's probably easier to have a friends list, I guess.

Quote
That seems difficult but doable, especially if Theory cooperates by giving the list of Goko usernames. Autokicking people without the extension seems simple enough.

The Goko names people add to their accounts are public information, though I don't feel like writing the code to parse them out and I don't want to do this unless the admins okay it. I'll add this if theory or someone else provides me a list or code to do the parsing.

Autokicking non-extension users is easier, though maybe a bit insular and unfriendly. A whitelist (match only these people) is also an option. I'll think about it.
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on September 10, 2013, 10:25:58 am
An easier option would be to have a registered list in drunkensailor. If advertised here, is a way to almost get every Goko username on f.ds there with distributed effort (as a nice side-effect, you get each person to decide weither they want to be included in such set or not). A simple form to add your goko username to the predefined whitelist, lets say.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 10, 2013, 11:11:42 am
The automatch blacklist doesn't seem to be working though, I added johovall_goko to it after he disabled the point counter (I did not add him to the other blacklist, as I don't mind him joining my regular #vpon games), but I still got matched to him. And we both got removed from the automatch que.

Both lists work for me. In the log, I see no entries in your blacklist, including for the game where you got matched with johovall_goko.

Forgive me if this is obvious, but your options list does look like this, right?
(http://i.imgur.com/Vkz6ROS.png)
And not like this?
(http://i.imgur.com/EGQjfKA.png)

Ah, that was it :) Thanks!

Quote
As I was writing this, I got 2 matches with Loschikitos, he declined both but as a consequence I had to restart automatch. That is obviously not what I want :)

Please clarify. You want him to go on your automatch blacklist (or you on his) after the first decline? Or you want your automatch to keep looking after he turns your down?

I want my automatch to keep looking for another game and not be matched against him again for a limited amount of time (say, 15 minutes).

Quote
4. Take players who get declined several times in a row out of the pool until they confirm that they're not just AFK

If he declines me, that's his decision, why should I get removed from the pool after one player declines me multiple times? I think people should be removed from the list only if they time-out, not if the other player decides to decline the offer.

Quote
Obviously anyone who gets declined wants to go straight back into the automatch seek pool, but I have to implement #2 before I can do that. Otherwise the person who declined you will just keep matching with you (this happens already to some degree, and it's annoying as hell). Even more important is #5, without which a single AFK seeker would basically shut down the whole service for everyone in his rating range.

Yeah, ok.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 10, 2013, 11:26:55 am
Please clarify. You want him to go on your automatch blacklist (or you on his) after the first decline? Or you want your automatch to keep looking after he turns your down?

I want my automatch to keep looking for another game and not be matched against him again for a limited amount of time (say, 15 minutes).

I don't get it. If he turned you down once and plans to turn you down again, why would he change his mind in 15 minutes?

Quote
4. Take players who get declined several times in a row out of the pool until they confirm that they're not just AFK

If he declines me, that's his decision, why should I get removed from the pool after one player declines me multiple times? I think people should be removed from the list only if they time-out, not if the other player decides to decline the offer.

Good call. Implementing a timeout would be better. Getting declined doesn't imply that you're AFK.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 10, 2013, 11:33:14 am
Please clarify. You want him to go on your automatch blacklist (or you on his) after the first decline? Or you want your automatch to keep looking after he turns your down?

I want my automatch to keep looking for another game and not be matched against him again for a limited amount of time (say, 15 minutes).

I don't get it. If he turned you down once and plans to turn you down again, why would he change his mind in 15 minutes?

If it's something personal he of course wouldn't, but when I decline an offer it's usually because I either have to leave or just found another game while still lingering in automatch, which shouldn't cause me to blacklist the player or him to blacklist me.
Title: Re: Goko Dominion Salvager Discussion
Post by: achmed_sender on September 10, 2013, 03:43:59 pm
So I updated on version 2.3

Here (http://dom.retrobox.eu/?/20130910/log.516d57f1e4b082c74d7bb2ba.1378840856933.txt), I played a game with Vineyard. On the viewer it seems all as it should be, but the ingame-log showed Vineyard yellow-green (like Harem) and the point counter didn't count vineyard points (I had quite more than 3 actions). Don't know what is the problem, but it was certainly right before the update 2.3

Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on September 10, 2013, 05:53:20 pm
I would like to add my 2 cents about autokicking all non-extension users: isn't that similar to just using automatch? Automatch guarantees you to play against an extension user, and every extension user has the possibility to use automatch. And I agree with AI that this is a little unfriendly.

We also don't want to make too much ways to kick nonwanted persons, otherwise new players to Goko (and possible future users of this forum) will be driven away, because they can't join any game*, or they get confused by the game names (like "all sets, #vpon, 3.4k-7.1k, +f.ds")...

*this might be the case already, but I think being kicked from a game which says "4000+" in the name will be understood (eventually) by new players
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 10, 2013, 07:34:56 pm
The point tracker wasn't counting Nobles in this game (http://dom.retrobox.eu/?/20130910/log.505d732a51c359e6597efeb8.1378856018803.txt) I just played.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 10, 2013, 10:47:42 pm
I would like to add my 2 cents about autokicking all non-extension users: isn't that similar to just using automatch? Automatch guarantees you to play against an extension user, and every extension user has the possibility to use automatch. And I agree with AI that this is a little unfriendly.

We also don't want to make too much ways to kick nonwanted persons, otherwise new players to Goko (and possible future users of this forum) will be driven away, because they can't join any game*, or they get confused by the game names (like "all sets, #vpon, 3.4k-7.1k, +f.ds")...

*this might be the case already, but I think being kicked from a game which says "4000+" in the name will be understood (eventually) by new players

I guess the point of my request was to be able to specifically target games to the people with whom I personally want to play.  You can call me an exclusionist, but it's no different than auto-kicking people you don't want to play because they aren't as good as you are or blacklisting people after a bad experience.

I'd much rather play AI or Eevee than guest0001030304020, even if guest0001030304020 is every nice and good at Dominion.

The opt-in whitelist sounds like an elegant option.  If Goko just had a Friends List that showed me online/offline friends and what lobby they are in, and let me send a game invite directly, I'd just do that.  But that is an impossible dream.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 10, 2013, 10:50:56 pm
If Goko just had a Friends List that showed me online/offline friends and what lobby they are in, and let me send a game invite directly, I'd just do that.  But that is an impossible dream.

Your dreams are feature requests?
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 11, 2013, 01:46:29 am
Your dreams are feature requests?

We do appreciate all you've done to make our dreams come true.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on September 11, 2013, 01:19:16 pm
New release of Goko Dominion Salvager (v2.3 beta)
  • For Chrome (http://gokologs.drunkensailor.org/static/gokosalvager/gokosalvager.crx) (Right-click Save, then install manually (http://www.howtogeek.com/120743/how-to-install-extensions-from-outside-the-chrome-web-store/))
  • For Firefox (http://gokologs.drunkensailor.org/static/gokosalvager/gokosalvager.xpi)
These changes should address the strange automatch behavior of the past week. I've also introduced some new features (in bold below) and fixed some small bugs.
Firefox link returns 404: File not found.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 11, 2013, 01:59:36 pm
New release of Goko Dominion Salvager (v2.3 beta)
  • For Chrome (http://gokologs.drunkensailor.org/static/gokosalvager/gokosalvager.crx) (Right-click Save, then install manually (http://www.howtogeek.com/120743/how-to-install-extensions-from-outside-the-chrome-web-store/))
  • For Firefox (http://gokologs.drunkensailor.org/static/gokosalvager/gokosalvager.xpi)
These changes should address the strange automatch behavior of the past week. I've also introduced some new features (in bold below) and fixed some small bugs.
Firefox link returns 404: File not found.

Sorry. Computers are so damn tricky.

New links (and v2.3.1 with bugfixes): http://forum.dominionstrategy.com/index.php?topic=9198.msg283465#msg283465
Title: Re: Goko Dominion Salvager Discussion
Post by: achmed_sender on September 11, 2013, 02:27:09 pm
Here (http://dom.retrobox.eu/?/20130911/log.505d72d7a2e6fa3316de089e.1378923861833.txt), Silk Roads was worth about double of it's normal value as it should be (only on the in-game viewer).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 11, 2013, 02:39:53 pm
Here (http://dom.retrobox.eu/?/20130911/log.505d72d7a2e6fa3316de089e.1378923861833.txt), Silk Roads was worth about double of it's normal value as it should be (only on the in-game viewer).

I think the VP counter issues are all fixed in v2.3.1

(http://i.imgur.com/tM4E22y.png)

(6 Silver, fyi)

Edit: I intrdoduced this and the other logviewer/VP counter bugs while rewriting the code to get Firefox security-compliant. Not that my programming errors are Mozilla's fault, but that's why I was messing with the old (working) code.
Title: Re: Goko Dominion Salvager Discussion
Post by: Tables on September 11, 2013, 07:10:10 pm
Apparently the new Chrom Salvager needs to "access my tabs and browsing activity" to function. Can someone explain why that's necessary? It sounds quite an odd thing to be requesting.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 11, 2013, 07:52:39 pm
Apparently the new Chrom Salvager needs to "access my tabs and browsing activity" to function. Can someone explain why that's necessary? It sounds quite an odd thing to be requesting.

You're getting that message because it has this privilege tag (http://developer.chrome.com/extensions/webNavigation.html) in the extension's description file (manifest.json). That means it has the power to do these things (https://support.google.com/chrome_webstore/answer/186213?hl=en). It doesn't do those things, of course, and it doesn't need to be asking for them. I think I must have included it accidentally while experimenting with the manifest options.

Sorry about that. I'll fix in the in the next version. If you're uncomfortable using the extension until then, I suggest using the Firefox version. It's running the same code but its manifest file doesn't request any unnecessary or unreasonable privileges.
Title: Re: Goko Dominion Salvager Discussion
Post by: Tables on September 11, 2013, 09:43:31 pm
Eh, that doesn't sound like a big deal, I'll just re-install it. Thanks for the simple answer.
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on September 11, 2013, 11:43:29 pm
Your dreams are feature requests?

We do appreciate all you've done to make our dreams come true.

AI is a unicorn.
Title: Re: Goko Dominion Salvager Discussion
Post by: Acher on September 12, 2013, 01:10:15 am
Apparently the new Chrom Salvager needs to "access my tabs and browsing activity" to function. Can someone explain why that's necessary? It sounds quite an odd thing to be requesting.

You're getting that message because it has this privilege tag (http://developer.chrome.com/extensions/webNavigation.html) in the extension's description file (manifest.json). That means it has the power to do these things (https://support.google.com/chrome_webstore/answer/186213?hl=en). It doesn't do those things, of course, and it doesn't need to be asking for them. I think I must have included it accidentally while experimenting with the manifest options.

Sorry about that. I'll fix in the in the next version. If you're uncomfortable using the extension until then, I suggest using the Firefox version. It's running the same code but its manifest file doesn't request any unnecessary or unreasonable privileges.

I feel a little uncomfortable with this, but don't use Firefox. About how long until you remove it from the Chrome version? Thanks btw to all involved with the extension.
Title: Re: Goko Dominion Salvager Discussion
Post by: Warfreak2 on September 12, 2013, 06:15:39 am
Feature request: In the log at the right hand side during the game, could the card names have coloured backgrounds?
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 12, 2013, 06:19:04 am
Feature (re)request: can the chat box be moved anywhere other than on top of my hand?
Title: Re: Goko Dominion Salvager Discussion
Post by: JerseyFrank on September 12, 2013, 09:49:13 am
Bug or user error?

Guests are being auto-booted, even if I don't specify a "XXXX+" value in the game name.  Tried different game names. ("For JGALG", "JGALG2", etc.)

Also, #VPON is happening by default.  Feature or bug?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 12, 2013, 10:19:04 am
Feature request: In the log at the right hand side during the game, could the card names have coloured backgrounds?

I'm confused. You're not referring to this sort of coloring are you?

(https://lh5.googleusercontent.com/WBl0jYHD0LJYL8re51OIfIy2ybr2cegAbDn9nj5eovbCgZh9JdTRyQvUZ_XRGmzAxY6NXc0_-j8=s640-h400-e365-rw)

If you are, then you need to update. I broke the colors in v2.3, but they're back in the current version.

FYI, I'm pretty close to getting auto-updating set up, so this having to download the latest version nonsense will come to an end soon.

Feature (re)request: can the chat box be moved anywhere other than on top of my hand?

Yes. It's a little tricker than I thought when it was first suggested though. The whole play area is hard to manipulated because it's not made of individual HTML elements. It's all one big Canvas that Goko's just drawing on like a bunch of web-illiterate savages. Makes it much harder to tweak than the lobby elements.

Bug or user error?

Guests are being auto-booted, even if I don't specify a "XXXX+" value in the game name.  Tried different game names. ("For JGALG", "JGALG2", etc.)

A guest should be kicked from a table named "For JGALG". Anyone other than JGALG should be. Nobody at all should be getting kicked from a table named simply "JGALG2" with no "for" or "xxxx+". Both of those options can be disabled, btw (see below).

If guests are getting kicked from tables with totally innocuous names like "my table", then something is wrong. I can't reproduce that behavior, so please send more info (version number, browser, exact table name, and maybe a screenshot).

Also, #VPON is happening by default.  Feature or bug?

Feature. There's a "always request VP counter" option and it's enabled by default. You can change that in the "User Settings" dialog: click the "User Settings" link below the "Logout" link on the main page before you enter the multiplayer lobby.
Title: Re: Goko Dominion Salvager Discussion
Post by: elahrairah13 on September 12, 2013, 10:26:59 am
I just installed. This is kinda amazing. Is it customizable at all? Like can I change the colors that display in the log on the right, or change the size of the various frames, etc?
Sorry to ask obvious questions... too lazy to read 22 pages of thread but don't see any sort of readme stuff.
No worries if there is not. Those are probably low on the priority list.
Title: Re: Goko Dominion Salvager Discussion
Post by: werothegreat on September 12, 2013, 10:38:19 am
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 12, 2013, 11:37:39 am
Feature (re)request: can the chat box be moved anywhere other than on top of my hand?

Yes. It's a little tricker than I thought when it was first suggested though. The whole play area is hard to manipulated because it's not made of individual HTML elements. It's all one big Canvas that Goko's just drawing on like a bunch of web-illiterate savages. Makes it much harder to tweak than the lobby elements.

No man, you just don't understand. Goko's product is too complicated to break down into simple HTML elements.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 12, 2013, 11:38:14 am
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

That's what my dad says about smartphones.
Title: Re: Goko Dominion Salvager Discussion
Post by: theory on September 12, 2013, 11:40:25 am
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

That's what my dad says about smartphones.

Relevant (http://www.defectiveyeti.com/archives/002539.html):

Quote
Typical Reaction to the Revelation That I Do Not Own a Cell Phone, By Year

1998: Solidarity ("Yeah, me neither--I hate those things!")

1999: Envy ("Lucky you; I had to get one for work.")

2000: Indifference ("Okay, what's your home phone number then?")

2001: Encouragement ("You should get one--you can play Tetris on them now!")

2002: Confusion ("I thought you were, like, a tech guy.")

2003: Sympathy ("They're getting pretty cheap. You'll be able to afford one soon.")

2004: Irritation ("So how am I supposed to get a hold of you?")

2005: Derision ("If we go out tonight I'll send you a fax.")

2006: Skepticism ("Are you serious?")

2007: Awe ("Wow, you're like the last one.")

2008: Incomprehension ("You don't ... how ...?")
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on September 12, 2013, 12:28:12 pm
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

It's definitely playable without the extension, but the log on the side is very convenient. Beats having to open it manually every time you want to look at your opponents' last turns.

For me the big draw is the Kingdom randomizer, though. It's the only feature I really care about and the reason I installed the extension in the first place.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on September 12, 2013, 12:39:22 pm
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

Wandering Winder doesn't use it.
Title: Re: Goko Dominion Salvager Discussion
Post by: JerseyFrank on September 12, 2013, 02:05:27 pm
A guest should be kicked from a table named "For JGALG". Anyone other than JGALG should be. Nobody at all should be getting kicked from a table named simply "JGALG2" with no "for" or "xxxx+". Both of those options can be disabled, btw (see below).
I must have had "for" in there.  Is there a user guide that I've missed?  I don't want to bother anyone with RTFM questions.  I feel like a dummy, but I don't see User Settings in the place you've described them.  I'm on the main landing page (where one chooses adventure, multiplayer, bots, store, etc.)
Title: Re: Goko Dominion Salvager Discussion
Post by: JerseyFrank on September 12, 2013, 02:07:00 pm
Weird... now the settings link is there.  Maybe something screwy on my browser.  Nevermind that question. :)
Title: Re: Goko Dominion Salvager Discussion
Post by: Eevee on September 12, 2013, 02:53:21 pm
I'm playing my gokodom match right now, and we can't seem to get the extension to work at all. Any idea what's up?
Title: Re: Goko Dominion Salvager Discussion
Post by: Rabid on September 12, 2013, 03:22:25 pm
Assuming Chrome:
In menu near settings I had a warning:
"requires more permissions"
Saying OK seems to have fixed it.
Title: Re: Goko Dominion Salvager Discussion
Post by: fizzyliftingdrink on September 12, 2013, 03:36:39 pm
Salvager not working for me at all today. I have no settings button either. I've tried Chrome and Safari.

What is going on?

Please help! I can't go back to playing without it like an animal!
Title: Re: Goko Dominion Salvager Discussion
Post by: Schneau on September 12, 2013, 04:49:04 pm
In Chome: Click the "customize and control Google Chome" button in the upper right corner > Tools > Extensions. There, the extension may be unchecked. Check it, and it will ask if it can use more info of yours than it used to. According to ragingduckd, this is ok, and he's not stealing your data. Then you should be all set.
Title: Re: Goko Dominion Salvager Discussion
Post by: Acher on September 12, 2013, 05:54:53 pm
So I just got the extension for Firefox (from the links in the first post of this thread) and it's working except for automatch. Can anyone help me fix that? Thanks. (I'm not particularly tech-literate.)

(If it makes a difference, automatch was working fine with Chrome.)
Title: Re: Goko Dominion Salvager Discussion
Post by: fizzyliftingdrink on September 12, 2013, 05:56:33 pm
Thanks Schneau. That was what I needed! Appreciate it.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 12, 2013, 06:00:59 pm
In Chome: Click the "customize and control Google Chome" button in the upper right corner > Tools > Extensions. There, the extension may be unchecked. Check it, and it will ask if it can use more info of yours than it used to. According to ragingduckd, this is ok, and he's not stealing your data. Then you should be all set.

My extension stopped working (v 2.3.2) and this doesn't do anything for me. The only permission it shows is "Access your data on *.goko.com".

Edit: reinstalling the thing made it work again. Good. I was already experiencing withdrawal symptoms. It still only shows the old permissions, though; does this mean that Andrew is NOT interested in my browsing history? >:(
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on September 12, 2013, 06:29:29 pm
downloaded the new version today and it now turns vpon by default.  can anyone tell me how to change this? (in chrome)
Title: Re: Goko Dominion Salvager Discussion
Post by: Acher on September 12, 2013, 06:40:20 pm
downloaded the new version today and it now turns vpon by default.  can anyone tell me how to change this? (in chrome)

You can change it by going to "user settings" on the right side of the homepage (where you can click multiplayer, play bots, etc.) and unchecking the relevant box. (I haven't seen the newest version, but that's how it was in the previous versions.)
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on September 12, 2013, 07:16:04 pm
thanks that did it.
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on September 12, 2013, 07:27:03 pm
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

That's what my dad says about smartphones.

Relevant (http://www.defectiveyeti.com/archives/002539.html):

Quote
Typical Reaction to the Revelation That I Do Not Own a Cell Phone, By Year

1998: Solidarity ("Yeah, me neither--I hate those things!")

1999: Envy ("Lucky you; I had to get one for work.")

2000: Indifference ("Okay, what's your home phone number then?")

2001: Encouragement ("You should get one--you can play Tetris on them now!")

2002: Confusion ("I thought you were, like, a tech guy.")

2003: Sympathy ("They're getting pretty cheap. You'll be able to afford one soon.")

2004: Irritation ("So how am I supposed to get a hold of you?")

2005: Derision ("If we go out tonight I'll send you a fax.")

2006: Skepticism ("Are you serious?")

2007: Awe ("Wow, you're like the last one.")

2008: Incomprehension ("You don't ... how ...?")

On some level this timeline is amusing, because I haven't had a landline since 2001.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 12, 2013, 07:47:46 pm
Permissions Changes:

Man. Sorry for all the permissions hullabaloo, guys. I had no idea how sensitive/idiosyncratic Chrome was about this stuff. I made two changes to the permissions settings, and apparently that makes Chrome extensions just silently disable themselves (??).

Anyway, I removed the "access your tabs and browsing activity," so I no longer know which porn sites and terrorist forums you're visiting. Only your local ISP, your government, and the 12-yr old who's hacking your wifi do.

The other change was which sites the extension runs on. It used to be "*.goko.com/Dominion/gameClient.html" and now it's "*.goko.com/Dominion/gameClient.html*". In particular, it now runs on "gameClient.html?" instead of mysteriously disappearing if you happen to trigger the bug than sends you there.

User Settings

If something has changed, check here first. If it's not a bug, then there's probably a new option for it.

The "User Settings" link should be on the main screen right under the "Logout" button. Sometimes it goes missing. This is because... well look, it's all magic, ok? Anyway, someday I'll fix it but for now the answer is to reload the page once or twice until it shows up.

In particular, "VP counter: Always request" is now ticked by default. This automatically enables the counter and sends a #vpon request. You can untick it or instead tick "VP counter: Always refuse". That will automatically send a #vpoff if/when your opponent says #vpon.

Documentation

(http://cdn.meme.li/i/ol8qw.jpg)

Yeah. Sorry. I don't like writing docs. Try experimenting a bit. Check the options. Search this thread for my posts. If you figure it out and feel like helping out your fellow f.dsers, add something to the woefully inadequate docs on the github wiki (https://github.com/aiannacc/Goko-Salvager/wiki). I think anyone can edit the wiki who has a github login, but anyone who wants to become a "collaborator" on the project is welcome too.

Bug Reports

Quote
EXTENSION BROKE PLZ HLP I M RUNNNIG THE COMPUTER VERSIN!

On rare occasions I can usefully respond to such reports, but the wise user will tell me at least his browser (e.g. Chrome) and extension version (e.g. v2.3.2). Detail like "Safari v6.0.5 build 8536.30.1" and "Windows 8, Toaster Edition" is unnecessary.

Your odds of getting help go up further if you can include a screenshot and instructions for reproducing the error. "This happened once..." is rarely enough for me to diagnose a problem.

If you're really serious about getting the problem fixed, include a copy of your Javascript console log. This is particularly valuable when the problem is that something is not happening (e.g. extension not loading at all):
1. Go to User Settings and enable "Extra logging"
2. Open the JS console (F12 in Chrome; Command-Alt-C in Safari; Tools/Web Developer/Browser Console in Firefox)
3. Reproduce the error and copy the log
4. Include the log in your post, preferably wrapped in "code" tags.

Finally, please refrain from posting "when are you going to fix XYZ?" The answer is, "Whenever I figure out how to make it work for everyone besides you." There have only been a few of these posts (you know who you are). Bumping old requests (say ~1 wk+) is just fine.
Title: Re: Goko Dominion Salvager Discussion
Post by: WanderingWinder on September 12, 2013, 07:52:59 pm
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

That's what my dad says about smartphones.
I neither use the extension nor have a smartphone.

As I proudly proclaimed to one of my friends a few months ago "I live in the twentieth century!"
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on September 12, 2013, 08:07:31 pm
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

That's what my dad says about smartphones.
I neither use the extension nor have a smartphone.

As I proudly proclaimed to one of my friends a few months ago "I live in the twentieth century!"

I believe we have forum members who were born after the twentieth century.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on September 12, 2013, 08:08:56 pm
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

That's what my dad says about smartphones.
I neither use the extension nor have a smartphone.

As I proudly proclaimed to one of my friends a few months ago "I live in the twentieth century!"

I believe we have forum members who were born after the twentieth century.

The youngest I can think of is mail-mi, and I think he was born in 1998?
Title: Re: Goko Dominion Salvager Discussion
Post by: StrongRhino on September 12, 2013, 09:05:57 pm
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

That's what my dad says about smartphones.
I neither use the extension nor have a smartphone.

As I proudly proclaimed to one of my friends a few months ago "I live in the twentieth century!"

I believe we have forum members who were born after the twentieth century.

The youngest I can think of is mail-mi, and I think he was born in 1998?
I was born in 2000, but I'm pretty sure there is one more who is younger than me, I remember discussing this somewhere.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 12, 2013, 09:57:50 pm

2005: Derision ("If we go out tonight I'll send you a fax.")


Or "I'll page you on your beeper."
Title: Re: Goko Dominion Salvager Discussion
Post by: Warfreak2 on September 13, 2013, 03:39:45 am
Pagers are dope, all the important peeps have them.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on September 13, 2013, 05:14:37 am
I must be the only person who doesn't need a log on the side in order to play Goko.  I'm perfectly fine with the interface as it is.

That's what my dad says about smartphones.
I neither use the extension nor have a smartphone.

As I proudly proclaimed to one of my friends a few months ago "I live in the twentieth century!"

I believe we have forum members who were born after the twentieth century.

The youngest I can think of is mail-mi, and I think he was born in 1998?
I was born in 2000, but I'm pretty sure there is one more who is younger than me, I remember discussing this somewhere.
That was Vermillion and I'm relatively sure he was just saying the meme (http://knowyourmeme.com/memes/im-twelve-years-old-and-what-is-this) and is not really 12 years old.
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on September 13, 2013, 08:50:40 am
As I proudly proclaimed to one of my friends a few months ago "I live in the twentieth century!"

You probably like at least one thing about the 21th.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 13, 2013, 09:22:38 am
As I proudly proclaimed to one of my friends a few months ago "I live in the twentieth century!"

You probably like at least one thing about the 21th.

Like the Twilight series.
Title: Re: Goko Dominion Salvager Discussion
Post by: Gveoniz on September 13, 2013, 09:23:47 am
As I proudly proclaimed to one of my friends a few months ago "I live in the twentieth century!"

You probably like at least one thing about the 21th.

Like the Twilight series.
What about Dominion?
Title: Re: Goko Dominion Salvager Discussion
Post by: Polk5440 on September 13, 2013, 02:43:36 pm
If Goko just had a Friends List that showed me online/offline friends and what lobby they are in, and let me send a game invite directly, I'd just do that.  But that is an impossible dream.

Your dreams are feature requests?

Here's an impossible (Dominion) dream: A "Simulate That!" button on the Game Over Screen which would 1) determine what reasonable strategies you and your opponents attempted to play, then 2) Simulates them to determine whether you won/lost because of luck, or skill, then 3) points out your errors in executing the strategy and 4) tells you what the optimal strategy would have been -- all in 3 seconds flat.

Although, now that I think about it, this is closely approximated by Stef's answers in the Help! and Game Reports threads....

A merely unlikely dream: someone who knows what they are doing updates Geronimoo's simulator.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 13, 2013, 03:41:28 pm
If Goko just had a Friends List that showed me online/offline friends and what lobby they are in, and let me send a game invite directly, I'd just do that.  But that is an impossible dream.

Your dreams are feature requests?

Here's an impossible (Dominion) dream: A "Simulate That!" button on the Game Over Screen which would 1) determine what reasonable strategies you and your opponents attempted to play, then 2) Simulates them to determine whether you won/lost because of luck, or skill, then 3) points out your errors in executing the strategy and 4) tells you what the optimal strategy would have been -- all in 3 seconds flat.

Want it to make you a sandwich too?
Title: Re: Goko Dominion Salvager Discussion
Post by: Polk5440 on September 13, 2013, 03:57:26 pm
If Goko just had a Friends List that showed me online/offline friends and what lobby they are in, and let me send a game invite directly, I'd just do that.  But that is an impossible dream.

Your dreams are feature requests?

Here's an impossible (Dominion) dream: A "Simulate That!" button on the Game Over Screen which would 1) determine what reasonable strategies you and your opponents attempted to play, then 2) Simulates them to determine whether you won/lost because of luck, or skill, then 3) points out your errors in executing the strategy and 4) tells you what the optimal strategy would have been -- all in 3 seconds flat.

Want it to make you a sandwich too?

Of course -- but I was trying to keep it reasonable.  ;)

I do really appreciate the extension. No kidding, there.  :)
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 13, 2013, 07:33:42 pm
Feature request: gluten-free option.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on September 13, 2013, 09:01:54 pm
Feature Request: A "Simulate That!" button.
Title: Re: Goko Dominion Salvager Discussion
Post by: mail-mi on September 13, 2013, 11:17:44 pm
My computer is small and I can't see the VP part of the VP tracker, only who's in first. Is there a way to change that so it can be smaller or change it back to the way it was (scrolled sideways with the log?)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 14, 2013, 12:08:16 am
My computer is small and I can't see the VP part of the VP tracker, only who's in first. Is there a way to change that so it can be smaller or change it back to the way it was (scrolled sideways with the log?)

Almost certainly. Please post a screenshot so that I can be sure I understand the problem.
Title: Point Counter seems to be counting Fool's Gold as an action for Vineyard.
Post by: Sayron on September 14, 2013, 12:54:16 am
Earlier I played  this game (http://dom.retrobox.eu/?/20130913/log.516d52d2e4b082c74d7ba12f.1379114780540.txt). The point counter seemed to be assuming that Fool's Gold counted towards Vineyard. My opponent had a turn in which all he bought were Fool's Gold and the point counter showed his points increasing ( he already had vineyards in his deck). At the end of the game his total was off by the amount one would expect for Fool's Gold being applied to Vineyard.
Title: Re: Point Counter seems to be counting Fool's Gold as an action for Vineyard.
Post by: ragingduckd on September 14, 2013, 03:49:18 am
Earlier I played  this game (http://dom.retrobox.eu/?/20130913/log.516d52d2e4b082c74d7ba12f.1379114780540.txt). The point counter seemed to be assuming that Fool's Gold counted towards Vineyard. My opponent had a turn in which all he bought were Fool's Gold and the point counter showed his points increasing ( he already had vineyards in his deck). At the end of the game his total was off by the amount one would expect for Fool's Gold being applied to Vineyard.

Yup, that's definitely a bug. Looks like it applies to both the VP counter and the log prettifier. Thanks.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 14, 2013, 03:55:41 am
Bug report: I played a game earlier today against Lespeutere and I had the extension running, and at the end of the game, it said that I won.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 14, 2013, 07:12:11 am
Okay, real bug report:

I've found that every time I go to Goko, the extension isn't loading.  This is after playing some games (with it on) then going off to do other stuff, then going back to Goko.  If I quit Chrome and reopen, then go to Goko, the extension (usually) loads.

I'm using: Version 29.0.1547.65 and version 2.3.2 of the extension.  I've done the permissions thing already.



Separately, I've found that the auto-VPON message in-game doesn't happen until Turn 1 is over.  Don't know if that delay is programmed in or not.

Also, you have too many spaces around your commas when listing Scrying Pool actions revealed in the log.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 14, 2013, 08:09:48 am
Okay, real bug report:

I've found that every time I go to Goko, the extension isn't loading.  This is after playing some games (with it on) then going off to do other stuff, then going back to Goko.  If I quit Chrome and reopen, then go to Goko, the extension (usually) loads.

This is hard to diagnose because it occurs extremely rarely on my machine. I don't know how to make my machine behave more like yours, so I'm going to need a lot of detail to pin this one down.

Here's my understanding of exactly how you reproduce the error. Please correct as necessary:
1. You open Goko, play some games
2. You leave Goko and visit a different website in the same tab
3. You go back to Goko, still in the same tab
4. The "User Settings" link is gone
5. When you join the Multiplayer lobby, the automatch button, pro ratings, and other lobby features are also abset

I'll need a copy of your console log too. First enable the "Extra Logging" option. Then when the error occurs, press F12 to open the log console. Copy/Paste the whole thing here.

Separately, I've found that the auto-VPON message in-game doesn't happen until Turn 1 is over.  Don't know if that delay is programmed in or not.

It's deliberate. If you say #vpon on game start or on your first turn, it's possible that your opponent hasn't actually entered the game room yet. If that happens, Goko never ends up delivering your #vpon message to your opponent.

FYI, the same thing can happen to "gl hf" messages if you say them too fast before an opponent with a slow computer enter the room.

Also, you have too many spaces around your commas when listing Scrying Pool actions revealed in the log.

That's intentional. The extra spaces allow for a more efficient storage of the log data, which reduces the extension's memory footprint and increases its overall flux capacitance.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 14, 2013, 09:19:43 am
Okay, real bug report:

I've found that every time I go to Goko, the extension isn't loading.  This is after playing some games (with it on) then going off to do other stuff, then going back to Goko.  If I quit Chrome and reopen, then go to Goko, the extension (usually) loads.

This is hard to diagnose because it occurs extremely rarely on my machine. I don't know how to make my machine behave more like yours, so I'm going to need a lot of detail to pin this one down.

Here's my understanding of exactly how you reproduce the error. Please correct as necessary:
1. You open Goko, play some games
2. You leave Goko and visit a different website in the same tab
3. You go back to Goko, still in the same tab
4. The "User Settings" link is gone
5. When you join the Multiplayer lobby, the automatch button, pro ratings, and other lobby features are also abset

I'll need a copy of your console log too. First enable the "Extra Logging" option. Then when the error occurs, press F12 to open the log console. Copy/Paste the whole thing here.

This is correct.  I tried to make it happen just now, but couldn't.

I generally open a Chrome tab, go to Goko.  Two possibilities now:

1)  Salvager is running (I see my custom avatar)
2)  It isn't not.

If 2), as long as I quit Chrome (Command - Q), when I visit again, Salvager is working again.

If 1), I play some games, all the Salvager greatness is there.  I then switch over to f.ds in the same tab, update some mafia games, go back in the same tab to Goko, and 1 or 2 happens from above.

I can't guarantee it is always in the same tab, though.  But generally, it is.

I'll do some logging and catch the error when possible.  I'm on a Mac, if that matters.  Thanks.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 14, 2013, 09:21:05 am
You know the "abort" button that is on the screen after you accept an automatch and the table is being created?  Any possibility to could put that in a different spot than where the "accept" button was a second beforehand?  I've almost clicked that thing multiple times thinking I hadn't hit Accept yet.

I know working with Goko stuff has probably made you think stacking things in a way to encourage misclicks is normal... ;)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 14, 2013, 09:40:46 am
You know the "abort" button that is on the screen after you accept an automatch and the table is being created?  Any possibility to could put that in a different spot than where the "accept" button was a second beforehand?  I've almost clicked that thing multiple times thinking I hadn't hit Accept yet.

I know working with Goko stuff has probably made you think stacking things in a way to encourage misclicks is normal... ;)

Good point. I hadn't even noticed.

Honestly, I'm not too eager to make incremental tweaks to the automatch UI. It was a first design, and I almost always end up scrapping my first design entirely once I've learned how I could do the whole thing better. When I next work on the automatch UI, it'll end up in a rather different form than it has now.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 14, 2013, 09:22:44 pm
Okay, real bug report:

I've found that every time I go to Goko, the extension isn't loading.  This is after playing some games (with it on) then going off to do other stuff, then going back to Goko.  If I quit Chrome and reopen, then go to Goko, the extension (usually) loads.

...


Never mind. I think I found the problem. The fix is implemented and will be in the next version.
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on September 15, 2013, 01:58:42 am
I don't know, if this is a goko-problem or caused by the extension:
I click "create game" and the window appears, but if I click the "create game"-button there, nothing happens and I have to try it several times. Not the biggest problem, but a bit enerving.
Title: Re: Goko Dominion Salvager Discussion
Post by: Lotoreo on September 15, 2013, 07:41:03 am
The point counter did not count the same as goko, in this (non-menagerie) game:

http://dom.retrobox.eu/?/20130915/log.516d31dbe4b082c74d7b3391.1379245119510.txt

Not sure where the fault lies, at Gokos or the point counter ;) Maybe it has something to do with the tunnels?
Title: Re: Goko Dominion Salvager Discussion
Post by: amalloy on September 15, 2013, 07:51:00 am
The point counter did not count the same as goko, in this (non-menagerie) game:

http://dom.retrobox.eu/?/20130915/log.516d31dbe4b082c74d7b3391.1379245119510.txt

Not sure where the fault lies, at Gokos or the point counter ;) Maybe it has something to do with the tunnels?

I was the opponent in this game; the log linked above lists the score correctly, but the in-game VP counter did not: it listed Alan Malloy as being ahead 27-25. I think the error is clearly at https://github.com/aiannacc/Goko-Salvager/blob/master/src/ext/vpcounter.js#L79, which counts reactions like Tunnel as if they were actions when scoring Vineyard. I'll put together a pull request shortly.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 15, 2013, 08:38:51 am
The point counter did not count the same as goko, in this (non-menagerie) game:

http://dom.retrobox.eu/?/20130915/log.516d31dbe4b082c74d7b3391.1379245119510.txt

Not sure where the fault lies, at Gokos or the point counter ;) Maybe it has something to do with the tunnels?

I was the opponent in this game; the log linked above lists the score correctly, but the in-game VP counter did not: it listed Alan Malloy as being ahead 27-25. I think the error is clearly at https://github.com/aiannacc/Goko-Salvager/blob/master/src/ext/vpcounter.js#L79, which counts reactions like Tunnel as if they were actions when scoring Vineyard. I'll put together a pull request shortly.

Really good catch. This explains why Vineyard counts Fool's Gold too.

Fixed (by Alan). Thanks! It'll be in the next release.

(http://i.imgur.com/HzX2ouo.png)
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on September 15, 2013, 02:38:15 pm
For some reason, this now happens (EDIT: In the chat at the beginning of a game):

Code: [Select]
awaclus: #vpon
awaclus: #vpon
jaybeez: #vpon
awaclus: #vpon
jaybeez: #vpon
Title: Re: Goko Dominion Salvager Discussion
Post by: liopoil on September 15, 2013, 02:41:45 pm
This explains why Vineyard counts Fool's Gold too.
but I wouldn't think you would have vineyard and fool's gold in the same deck very often :P
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 15, 2013, 02:51:00 pm
For some reason, this now happens (EDIT: In the chat at the beginning of a game):

Code: [Select]
awaclus: #vpon
awaclus: #vpon
jaybeez: #vpon
awaclus: #vpon
jaybeez: #vpon

Yah, this has been happening alot to me as well. Sometimes it's repeated over ten times, even. The most perplexing thing is that it doesn't happen always. Most of the time the #vpons are relatively silent, but then the next game they come rushing in like an avalanche of impatient children finally arriving with their bus at the destination of a school-trip.
Title: Re: Goko Dominion Salvager Discussion
Post by: mail-mi on September 15, 2013, 04:27:56 pm
My computer is small and I can't see the VP part of the VP tracker, only who's in first. Is there a way to change that so it can be smaller or change it back to the way it was (scrolled sideways with the log?)

Almost certainly. Please post a screenshot so that I can be sure I understand the problem.
It's too big of a file to attach.. I'll email it to you.

EDIT: nevermind, i guess you can't attach things in the forum email thing.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 15, 2013, 08:54:01 pm
For some reason, this now happens (EDIT: In the chat at the beginning of a game):

Code: [Select]
awaclus: #vpon
awaclus: #vpon
jaybeez: #vpon
awaclus: #vpon
jaybeez: #vpon

Yah, this has been happening alot to me as well. Sometimes it's repeated over ten times, even. The most perplexing thing is that it doesn't happen always. Most of the time the #vpons are relatively silent, but then the next game they come rushing in like an avalanche of impatient children finally arriving with their bus at the destination of a school-trip.

Here is an example:

(http://img545.imageshack.us/img545/7314/v0e7.jpg)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 16, 2013, 02:14:24 am
I don't know, if this is a goko-problem or caused by the extension:
I click "create game" and the window appears, but if I click the "create game"-button there, nothing happens and I have to try it several times. Not the biggest problem, but a bit enerving.

This happens because Goko looks up which sets you own every time you open the Create/Edit Table dialog. For reasons that I cannot fathom, that check can take anywhere from 1-15 seconds.

If you're creating a casual or unrated game, Goko displays a big waiting animation while this lookup is going on, so you're probably not too tempted to press the "Create" button until it's finished. In pro mode, however, the search happens but doesn't show a waiting animation, so it looks like you're ready to go. But if you press "Create" while the lookup is still going on, nothing happens.

I've been meaning to fix this for a while, but the create game logic is some of the ugliest and most infuriating spaghetti code in the whole site. I'll also probably end up breaking the table name saving or the kingdom generator when I do try to fix it.
Title: Re: Goko Dominion Salvager Discussion
Post by: loppo on September 16, 2013, 02:26:40 am
Is there a way to make goko dominion salvager work on an Android tablet. I just got myself one and goko works quite fine on the chrome browser.

I looked for a way to install the salvager extension, but it seems that you cant't. Does anybody know if/how its possible to run the salvager extension in an android enviroment?
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on September 16, 2013, 11:22:58 am
If it is possible, it will certainly require some hackery:

https://developers.google.com/chrome/mobile/docs/faq

Quote
Does Chrome for Android support apps and extensions?
Chrome apps and extensions are currently not supported on Chrom for Android. We have no plans to announce at this time.
Title: Re: Goko Dominion Salvager Discussion
Post by: loppo on September 17, 2013, 02:01:27 am
thanks for your answer. I guess i have to try out the firefox route then.
Title: Re: Goko Dominion Salvager Discussion
Post by: qmech on September 18, 2013, 05:23:30 am
I don't enable the VP tracker by default, but would like to use it if my opponent turns it on.  When my opponent types #vpon my tracker won't appear until I also type #vpon.  Am I doing it wrong?

(http://en.zimagez.com/miniature/gokosalvagerusersetting.png)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 18, 2013, 05:52:42 am
I don't enable the VP tracker by default, but would like to use it if my opponent turns it on.  When my opponent types #vpon my tracker won't appear until I also type #vpon.  Am I doing it wrong?

(http://en.zimagez.com/miniature/gokosalvagerusersetting.png)

You're doing it right. It's a bug. I've got a fix for the next release. For now you'll have to reply #vpon manually. Sorry about that.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on September 19, 2013, 03:01:42 pm
Today, when I played an automatch game on Goko, the log viewer didn't work properly - the white background was there and the point tracker was there, but the log wasn't. Using Chrome and Windows 7.

Earlier today, it worked just fine on the same computer.
Title: Re: Goko Dominion Salvager Discussion
Post by: Mr. Moneybags on September 19, 2013, 05:42:22 pm
I have to delete and reinstall Salvager almost every time I play to get it to work properly. Any ideas on why that might be? I have it enabled as an extension in Chrome.
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on September 19, 2013, 06:02:19 pm
I don't know, if this is a goko-problem or caused by the extension:
I click "create game" and the window appears, but if I click the "create game"-button there, nothing happens and I have to try it several times. Not the biggest problem, but a bit enerving.

This happens because Goko looks up which sets you own every time you open the Create/Edit Table dialog. For reasons that I cannot fathom, that check can take anywhere from 1-15 seconds.

SELECT sets.setname FROM sets INNER JOIN setsplayers USING sets.set_id = setsplayers.set_id WHERE player_id = $this_player

... takes up to 15 seconds???  WTF.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 19, 2013, 08:26:08 pm
Today, when I played an automatch game on Goko, the log viewer didn't work properly - the white background was there and the point tracker was there, but the log wasn't. Using Chrome and Windows 7.

Earlier today, it worked just fine on the same computer.

I have to delete and reinstall Salvager almost every time I play to get it to work properly. Any ideas on why that might be? I have it enabled as an extension in Chrome.

Bug Reports

Quote
EXTENSION BROKE PLZ HLP I M RUNNNIG THE COMPUTER VERSIN!

On rare occasions I can usefully respond to such reports, but the wise user will tell me at least his browser (e.g. Chrome) and extension version (e.g. v2.3.2). Detail like "Safari v6.0.5 build 8536.30.1" and "Windows 8, Toaster Edition" is unnecessary.

Your odds of getting help go up further if you can include a screenshot and instructions for reproducing the error. "This happened once..." is rarely enough for me to diagnose a problem.

If you're really serious about getting the problem fixed, include a copy of your Javascript console log. This is particularly valuable when the problem is that something is not happening (e.g. extension not loading at all):
1. Go to User Settings and enable "Extra logging"
2. Open the JS console (F12 in Chrome; Command-Alt-C in Safari; Tools/Web Developer/Browser Console in Firefox)
3. Reproduce the error and copy the log
4. Include the log in your post, preferably wrapped in "code" tags.

Seriously guys. My powers of deduction have limits.
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on September 20, 2013, 11:40:16 am
In the new Firefox-version the log does not show in which phase (A, B, C) you are.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 20, 2013, 12:17:28 pm
In the new Firefox-version the log does not show in which phase (A, B, C) you are.

Will fix. Thanks.
Title: Re: Goko Dominion Salvager Discussion
Post by: Polk5440 on September 20, 2013, 07:04:43 pm
I have to delete and reinstall Salvager almost every time I play to get it to work properly. Any ideas on why that might be? I have it enabled as an extension in Chrome.

So, actually, I have been having a related issue since the last Chrome update. I have to refresh the Dominion client every time I restart Chrome in order for the extension to work. That is, I log in to Goko, Dominion loads, but not the extension (even though it's "enabled"). I hit refresh, and everything works fine. It's a little baffling.

So maybe try refreshing rather than completely reinstalling every time?
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 20, 2013, 08:05:03 pm
I have to delete and reinstall Salvager almost every time I play to get it to work properly. Any ideas on why that might be? I have it enabled as an extension in Chrome.

So, actually, I have been having a related issue since the last Chrome update. I have to refresh the Dominion client every time I restart Chrome in order for the extension to work. That is, I log in to Goko, Dominion loads, but not the extension (even though it's "enabled"). I hit refresh, and everything works fine. It's a little baffling.

So maybe try refreshing rather than completely reinstalling every time?

I just Quit, then re-open Chrome.  It automatically goes back to the Goko page, and the Extension is loaded.  It's annoying maybe, but it only takes 12 seconds or so.
Title: Re: Goko Dominion Salvager Discussion
Post by: Robz888 on September 20, 2013, 08:51:38 pm
I have to delete and reinstall Salvager almost every time I play to get it to work properly. Any ideas on why that might be? I have it enabled as an extension in Chrome.

So, actually, I have been having a related issue since the last Chrome update. I have to refresh the Dominion client every time I restart Chrome in order for the extension to work. That is, I log in to Goko, Dominion loads, but not the extension (even though it's "enabled"). I hit refresh, and everything works fine. It's a little baffling.

So maybe try refreshing rather than completely reinstalling every time?

Same for me.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on September 24, 2013, 07:29:03 am
Today, when I played an automatch game on Goko, the log viewer didn't work properly - the white background was there and the point tracker was there, but the log wasn't. Using Chrome and Windows 7.

Earlier today, it worked just fine on the same computer.

I have to delete and reinstall Salvager almost every time I play to get it to work properly. Any ideas on why that might be? I have it enabled as an extension in Chrome.

Bug Reports

Quote
EXTENSION BROKE PLZ HLP I M RUNNNIG THE COMPUTER VERSIN!

On rare occasions I can usefully respond to such reports, but the wise user will tell me at least his browser (e.g. Chrome) and extension version (e.g. v2.3.2). Detail like "Safari v6.0.5 build 8536.30.1" and "Windows 8, Toaster Edition" is unnecessary.

Your odds of getting help go up further if you can include a screenshot and instructions for reproducing the error. "This happened once..." is rarely enough for me to diagnose a problem.

If you're really serious about getting the problem fixed, include a copy of your Javascript console log. This is particularly valuable when the problem is that something is not happening (e.g. extension not loading at all):
1. Go to User Settings and enable "Extra logging"
2. Open the JS console (F12 in Chrome; Command-Alt-C in Safari; Tools/Web Developer/Browser Console in Firefox)
3. Reproduce the error and copy the log
4. Include the log in your post, preferably wrapped in "code" tags.

Seriously guys. My powers of deduction have limits.
Is this the log?
Code: [Select]
gatherUrlCookieParams found the following URL params:
Array[1]
 FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie
 FSSDK.js:560
ConnectionMaker merged the following cookie params:
Array[1]
 FSSDK.js:566
Existing session is not a valid type DominionClient.js:1740
initMeetingRoom DominionClient.js:292
Uncaught TypeError: Cannot call method 'depWait' of undefined logviewer.js:174
Running Goko Salvager v2.3.x utils.js:8
Failed to load resource chrome-extension://kaignighoceeemhinbbophdeogpnedjn/images/ui-bg_fine-grain_10_c3c3c3_60x60.png
[GSFN.Widget.Shell.initialize] loader.js:1
[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4 loader.js:1
Blocked a frame with origin "https://www.goko.com" from accessing a frame with origin "http://play.goko.com".  The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
gatherUrlCookieParams found the following URL params:
Array[1]
 FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie
 FSSDK.js:560
ConnectionMaker merged the following cookie params:
Array[1]
 FSSDK.js:566
ConnectionMaker connectionInfo valid, trying to use it FSSDK.js:688
FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg03.goko.com:80 FSSDK.js:13427
FSSDK: webSocket: onopen: top: url:ws://prod-wsg03.goko.com:80 FSSDK.js:13482
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13525
ConnectionMaker connection established using connInfo FSSDK.js:694
This element isn't a canvas - TypeError: Object #<HTMLDivElement> has no method 'getContext' FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L640px T0px FSSDK.Notifier.js:115
Successfully subscribed to game notifications FSSDK.js:699
Successfully subscribed to player notifications FSSDK.js:704
Personal currencyClient.js:64
Avatar Inventory currencyClient.js:64
Create achievements response: 
Object
 DominionClient.js:740
Failed to load resource chrome-extension://kaignighoceeemhinbbophdeogpnedjn/images/ui-bg_fine-grain_20_cbaa6e_60x60.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/512225dae4b0b5ff61e0bac8.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d7ad4e4b082c74d7c1c7a.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d5a68e4b082c74d7bbae8.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d694ce4b082c74d7be8ed.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd3dee4b082c74d7a1efe.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/523f37dce4b09abb6e76c838.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50dac271e4b02af88e7339cb.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd012e4b082c74d7a0017.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/51562140e4b02ef6ff999eeb.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd5d8e4b082c74d7a2db6.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50d8d344e4b0a9060471eca8.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/508e74f0a2e62ebbc73fdc8a.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d7acee4b082c74d7c1c68.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d6725e4b082c74d7be248.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d51a9e4b082c74d7b9d33.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d6ddce4b082c74d7bf6af.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514503a6e4b0bef57ec85e86.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/507d4435a2e6c48a2978a940.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513e2cfce4b079bc05b06d87.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d5b48e4b082c74d7bbdca.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5159b3aae4b093d38b198a53.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/523cb1b4e4b0957d90689e21.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d4618e4b082c74d7b73c9.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d696ce4b082c74d7be94d.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d4a74e4b082c74d7b8392.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d61a2e4b082c74d7bd26d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d5f8de4b082c74d7bcbc5.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513e1523e4b079bc05b06b43.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516ccfdfe4b082c74d79fe40.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50e7554ce4b06fb23150e0cc.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50babbafe4b05a8d74969537.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/517c5548e4b01cf91ab7b821.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d263fe4b082c74d7b0ceb.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50e74fcde4b04a6ff97dc90a.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d3277e4b082c74d7b3589.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d65fae4b082c74d7bdeb2.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50fedbbce4b0a35e483de920.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5177c791e4b054fd071e7019.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/51577615e4b0ee7f08a5805f.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d51d4e4b082c74d7b9dcc.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d31f0e4b082c74d7b33d3.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/505ed92251c333114368f729.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513db428e4b079bc05b06462.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/515ee82de4b0617a5e929169.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d79d5e4b082c74d7c19b3.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d372ce4b082c74d7b4456.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513bf21be4b079bc05b043b1.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d7a6de4b082c74d7c1b5a.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d6df1e4b082c74d7bf6f1.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d068fe4b082c74d7a8b43.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d4643e4b082c74d7b746e.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cce1ce4b082c74d79ed12.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/51039a16e4b09803ddb8ce4b.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d6f76e4b082c74d7bfb7d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d51b1e4b082c74d7b9d51.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514f7adbe4b00e514a724cdf.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/507e1b8f0cf28ed55d9d85d7.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/51532c8ce4b083ccc5b0febe.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/505de22f0cf2ef979299a5d8.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50733066fca2ca7237ee9b77.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/507c77810cf28ed55d9d808e.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Time: 1.062 seconds FS.DeckBuilder.js:1293
ready player not at table? FSSDK.js:15740
sitting seat player not at table? FSSDK.js:15759
ready player not at table? FSSDK.js:15740
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516ccfd0e4b082c74d79fdad.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5136ba11e4b08cb66ebee494.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d0fbbe4b082c74d7ab609.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516ccd67e4b082c74d79e544.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febd90f7a04f40bcdecc6b8.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febdb947a04f40bcdecc6ba.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febdc247a04f40bcdecc6bb.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516b3580e4b090b9f92789f6.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/51447cc9e4b0cf33e050d3a4.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd7d8e4b082c74d7a3cf2.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d6cf0e4b082c74d7bf3f7.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/523b0db9e4b0c5295dd7ebac.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50797e04fca2ca7237eeb056.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d7acce4b082c74d7c1c62.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5143e11ae4b0434d02d0bd66.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5137927ee4b0cd4b5a40b4ea.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d085fe4b082c74d7a93a4.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50600faefca2f090db079d38.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5137438de4b0cd4b5a40ac74.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5159b4dde4b0e6511d986a2e.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513c6290e4b024827a53588c.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514b57f7e4b00e514a71f81b.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5144de4ce4b0de86766bca36.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5105671fe4b09803ddb8e2e8.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/505f02b651c333114368f787.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/51564b37e4b083ccc5b130e0.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/508574f80cf270038ff91f3c.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d41f5e4b082c74d7b64e1.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febcf827a04f40bcdecc6b7.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febdb067a04f40bcdecc6b9.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5098c51fe4b0f63e9c9939e7.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d69eae4b082c74d7beacd.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514199b8e4b08529f80f6cb4.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d4119e4b082c74d7b6259.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/523ddb53e4b0dd4207ae104a.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d33dde4b082c74d7b3a00.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50c59a94e4b0dba1d397ec1c.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/507b69520cf284b7e3429368.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd3e0e4b082c74d7a1f0d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/52408036e4b0c5295dd81b7e.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514482c1e4b0cf33e050d468.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd3e7e4b082c74d7a1f46.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/510ca59ce4b02265335fddc6.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d52d2e4b082c74d7ba12f.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/52407df1e4b0dd4207ae2752.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516ce637e4b082c74d7a5a92.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/515b24b2e4b0ee7f08a5bff0.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/524070fee4b0dd4207ae26ca.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d3380e4b082c74d7b38dd.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Time: 1.126 seconds FS.DeckBuilder.js:1293
FSSDK - called our ClientGameInstance constructor DominionGameClient.js:117
using query parameters for canvas size: 960 640 DominionUI.js:3952
calling FS.Advertising DominionGameClient.js:203
callback from FS.Advertising DominionGameClient.js:210
Using layout: layout960x640 DominionUI.js:1486
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514199b8e4b08529f80f6cb4.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
creating dominionwindow DominionUI.js:13170
using card buidler. DominionUI.js:3739
canvas size: 960 640 layoutSize: [size 960 640] DominionUI.js:11360
using requestAnimationFrame DominionUI.js:13246
Exited DominionUI.js:9392
destroying  fan: hand DominionUI.js:6864
destroying flat: reveal DominionUI.js:6873
destroying deck: deck DominionUI.js:6868
destroying deck: discard DominionUI.js:6868
destroying  fan: hand DominionUI.js:6864
destroying flat: reveal DominionUI.js:6873
destroying deck: deck DominionUI.js:6868
destroying deck: discard DominionUI.js:6868
destroyed PlayerController DominionUI.js:13286
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514b5511e4b0b79c883b5e3b.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5139ff11e4b079bc05b01982.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/51375f7ee4b0cd4b5a40aee2.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/512cc94ae4b0816301bae222.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d590ee4b082c74d7bb66b.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d4a60e4b082c74d7b834d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/515d8401e4b03c71b674d3dc.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/505d6d98a2e6fa3316de084d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50f94178e4b02b7235c32224.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Time: 0.936 seconds FS.DeckBuilder.js:1293
FSSDK - called our ClientGameInstance constructor DominionGameClient.js:117
using query parameters for canvas size: 960 640 DominionUI.js:3952
calling FS.Advertising DominionGameClient.js:203
callback from FS.Advertising DominionGameClient.js:210
Using layout: layout960x640 DominionUI.js:1486
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/505d6d98a2e6fa3316de084d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
creating dominionwindow DominionUI.js:13170
canvas size: 960 640 layoutSize: [size 960 640] DominionUI.js:11360
using requestAnimationFrame DominionUI.js:13246
destroying  fan: hand DominionUI.js:6864
destroying flat: reveal DominionUI.js:6873
destroying deck: deck DominionUI.js:6868
destroying deck: discard DominionUI.js:6868
destroying  fan: hand DominionUI.js:6864
destroying flat: reveal DominionUI.js:6873
destroying deck: deck DominionUI.js:6868
destroying deck: discard DominionUI.js:6868
destroyed PlayerController DominionUI.js:13286
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50a44d70e4b09c3f1c235128.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5240693ce4b0dd4207ae2662.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d0074e4b082c74d7a6b57.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd6a5e4b082c74d7a33d7.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/52407f66e4b0dd4207ae2764.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d5f1de4b082c74d7bca57.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cdac5e4b082c74d7a4e1d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5166e46fe4b066caa2e8b6fa.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516ccf0ee4b082c74d79f6c0.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Time: 0.75 seconds FS.DeckBuilder.js:1293
FSSDK - called our ClientGameInstance constructor DominionGameClient.js:117
using query parameters for canvas size: 960 640 DominionUI.js:3952
calling FS.Advertising DominionGameClient.js:203
callback from FS.Advertising DominionGameClient.js:210
Using layout: layout960x640 DominionUI.js:1486
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d3380e4b082c74d7b38dd.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
creating dominionwindow DominionUI.js:13170
canvas size: 960 640 layoutSize: [size 960 640] DominionUI.js:11360
using requestAnimationFrame DominionUI.js:13246
destroying  fan: hand DominionUI.js:6864
destroying flat: reveal DominionUI.js:6873
destroying deck: deck DominionUI.js:6868
destroying deck: discard DominionUI.js:6868
destroying  fan: hand DominionUI.js:6864
destroying flat: reveal DominionUI.js:6873
destroying deck: deck DominionUI.js:6868
destroying deck: discard DominionUI.js:6868
destroyed PlayerController DominionUI.js:13286
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d6b72e4b082c74d7bef74.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d7531e4b082c74d7c0c66.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514ed35ae4b0b79c883ba407.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513edfa2e4b0434d02d05fd3.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5137f48be4b02905fc729b7d.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50b543c8e4b0c9ce0cf29477.png
2
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d5ecde4b082c74d7bc955.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/506b004f0cf2c3b232a28435.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d2da8e4b082c74d7b25e1.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50ae70dbe4b0258f50b261e7.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d55d5e4b082c74d7bab97.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/51505a0ee4b0b79c883bc31b.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febdcb47a04f40bcdecc6bc.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d2929e4b082c74d7b16e4.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5142ec4de4b0434d02d0a9b3.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513a2e90e4b024827a532c2f.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50f2c0d3e4b0943021c7d786.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/512ba416e4b022198f05f8e2.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/510724f9e4b02265335fa2c0.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d2fd3e4b082c74d7b2cef.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d00efe4b082c74d7a6e81.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d771ee4b082c74d7c11fa.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d1b1ae4b082c74d7ae4c8.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514e3548e4b0b79c883b9877.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d78d3e4b082c74d7c16d7.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d058fe4b082c74d7a868a.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d52e8e4b082c74d7ba17d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50d967a3e4b06d5e7f3d0759.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d41b5e4b082c74d7b6427.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4f7f9d30b0bbb0e4f329b3b5.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d0faae4b082c74d7ab5a9.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5081df1b51c39be1fbd7e9c8.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513b1f55e4b05fa06a3132cc.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Entered lobby: 5027185e14b17abbe2065298 utils.js:13
Connecting to Automatch server at wss://andrewiannaccone.com/automatch utils.js:13
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50a240fce4b016fc15e158a1.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516ccd6de4b082c74d79e58f.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d61a4e4b082c74d7bd276.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5065ddf0a2e6f4356e5c0681.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/52408b4de4b09abb6e76d3ed.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d61c4e4b082c74d7bd2dc.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d25aee4b082c74d7b0aed.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Connected to Automatch server. utils.js:13
Creating auto-automatch request utils.js:13
Table Settings: utils.js:13
Object
 utils.js:13
tname: My Table utils.js:13
pcount: 2 utils.js:13
rSystem: pro utils.js:13
Reading rating range requirement utils.js:13
Object
 utils.js:13
Sending auto-automatch request utils.js:13
Sent SUBMIT_SEEK message to Automatch server: utils.js:13
Object
 utils.js:13
Got CONFIRM_SEEK message from Automatch server: utils.js:13
Object
 utils.js:13
Got CONFIRM_RECEIPT message from Automatch server: utils.js:13
Object
 utils.js:13
Receipt of message confirmed: awaclus1380021395112 utils.js:13
Got OFFER_MATCH message from Automatch server: utils.js:13
Object
 utils.js:13
Time: 0.762 seconds FS.DeckBuilder.js:1293
FSSDK - called our ClientGameInstance constructor DominionGameClient.js:117
using query parameters for canvas size: 960 640 DominionUI.js:3952
calling FS.Advertising DominionGameClient.js:203
callback from FS.Advertising DominionGameClient.js:210
Using layout: layout960x640 DominionUI.js:1486
Sent GAME_STARTED message to Automatch server: utils.js:13
Object
 utils.js:13
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5137f48be4b02905fc729b7d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
creating dominionwindow DominionUI.js:13170
canvas size: 960 640 layoutSize: [size 960 640] DominionUI.js:11360
using requestAnimationFrame DominionUI.js:13246
Automatch server closed websocket. utils.js:13
Automatch connection failure: 1/100 utils.js:13
Not attempting to reconnect to automatch server. utils.js:13
Copper, Copper, Copper utils.js:13
trashed card: [Copper] utils.js:13
Copper, Copper, Copper utils.js:13
trashed card: [Copper] utils.js:13
Copper, Copper, Copper utils.js:13
trashed card: [Copper] utils.js:13
Estate, Copper utils.js:13
trashed card: [Estate] utils.js:13
Estate, Copper utils.js:13
trashed card: [Copper] utils.js:13
Copper, Estate, Bureaucrat utils.js:13
trashed card: [Copper] utils.js:13
Copper, Estate, Bureaucrat utils.js:13
trashed card: [Estate] utils.js:13
Copper, Estate, Bureaucrat utils.js:13
trashed card: [Bureaucrat] utils.js:13
I have no idea how to reproduce the error. Sometimes it's like this and sometimes everything works fine.

EDIT: And I'm on XP right now, but Windows 7 had the same problem.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 24, 2013, 07:59:48 am
Is this the log?

Yes! Thank you!

I wish I could give you a dozen more upvotes for being the first person to post a complete bug report. I can't, so I'll just fix your bug instead. :D

For the curious:

The problem is that the browser loads up the extension scripts at the same time that the Goko scripts are loading. This means the extension code can never be sure that the required Goko objects exist and are ready for it to modify. Analogous issues are responsible for a lot of goko's fragility.

I wrote the "depWait" function to address this. It checks for the required objects then goes to sleep for a bit if goko hasn't created them yet. Only when those objects exist does it run the meat of the script. It's an ugly solution for an ugly programming environment. If any real coder out there knows the "right way" to address this issue, I'd definitely appreciate some advice.

Ironically, Awaculus' error happened because the depWait function itself hadn't been created yet. Just as the extension can't know which goko code will get run before it, it also can't know which of its own scripts will be run first. I have depWait defined in a separate file that almost always runs before logviewer.js does. I'll have to change that.
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on September 24, 2013, 08:43:52 am
I've just finished re-watching an old Dr House episode, and yet, these diagnosis are so much cooler.
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on September 24, 2013, 09:11:29 am
I've just finished re-watching an old Dr House episode, and yet, these diagnosis are so much cooler.

It's not lupus.
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on September 24, 2013, 10:42:28 am
I've just finished re-watching an old Dr House episode, and yet, these diagnosis are so much cooler.

It's not lupus.
nor vasculitis.
Title: Re: Goko Dominion Salvager Discussion
Post by: amalloy on September 25, 2013, 04:18:04 am
In multiplayer lobbies, players are sorted by rating, even though I have unchecked "sort players by rating".
Title: Re: Goko Dominion Salvager Discussion
Post by: gunslinger on September 26, 2013, 01:36:31 am
Was something changed to remove the introductory chat messages about the VP tracker when #vpon is in the table name? I put #vpon in my table name, but my opponents haven't been getting the info about the extension/tracking recently. I noticed that the introduction IS given if I just enable the tracker in chat once the game has begun though.

A number of my opponents have been unaware that #vpon in the table name means I can perpetually see the score, so I sorta think that chat messages should include as much pertinent info as possible. To me, it'd be worth it to clutter up the chat box just to make sure everyone's on an even playing field. Even show the score in chat automatically every few turns if both players don't have the extension.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 26, 2013, 05:50:47 am
To me, it'd be worth it to clutter up the chat box just to make sure everyone's on an even playing field.

This would of course be fine.

Quote
Even show the score in chat automatically every few turns if both players don't have the extension.

But it would be absolutely nerve-wracking to have the chat window pop up every few turns. Just give the information when a player requests it, don't try to be the good old paperclip in Microsoft Word.
Title: Re: Goko Dominion Salvager Discussion
Post by: Warfreak2 on September 26, 2013, 06:00:59 am
Oh! Clippy said to the Goko developers, "It looks like you're trying to write a Dominion server!", and they accepted its help! Case closed.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on September 26, 2013, 08:31:29 am
Oh! Clippy said to the Goko developers, "It looks like you're trying to write a Dominion server!", and they accepted its help! Case closed.
No, I think that the current Dominion Online can only be the result of the Goko devs ignoring the help.
Title: Re: Goko Dominion Salvager Discussion
Post by: pst on September 26, 2013, 08:32:38 am
Speaking of pop-ups, here is a Salvager request: I only want popups that alerts me matchups etc. if and only if the tab I'm playing in isn't already active/focused.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 26, 2013, 08:50:08 am
Oh! Clippy said to the Goko developers, "It looks like you're trying to write a Dominion server!", and they accepted its help! Case closed.
No, I think that the current Dominion Online can only be the result of the Goko devs ignoring the help.

(http://i.imgur.com/uFone9n.jpg)
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on September 26, 2013, 02:01:33 pm
Even show the score in chat automatically every few turns if both players don't have the extension.

But it would be absolutely nerve-wracking to have the chat window pop up every few turns. Just give the information when a player requests it, don't try to be the good old paperclip in Microsoft Word.

FWIW, i often play on iPad which can't type into the message field, so I have no access to the point tracker at all.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on September 26, 2013, 02:55:42 pm
Even show the score in chat automatically every few turns if both players don't have the extension.

But it would be absolutely nerve-wracking to have the chat window pop up every few turns. Just give the information when a player requests it, don't try to be the good old paperclip in Microsoft Word.

FWIW, i often play on iPad which can't type into the message field, so I have no access to the point tracker at all.

Back when I played on my iPad, I had this same issue. Now that I use the extension, I never play on my iPad.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on September 26, 2013, 04:24:47 pm
I have a couple of bug reports. I play on a MacBook Pro using Chrome Version 29.0.1547.76 and version 2.3.3 of the extension. When I load the page, it sometimes loads the extension and other times not. I believe a lot of people are having this issue. Furthermore, sometimes most of the extension loads, but the avatars do not. All I have to do to reproduce this issue is reload the Goko Dominion title screen. Sometimes the "User Settings" link doesn't appear. Sometimes it does, but the normal Goko avatar is in the upper-right corner rather than the custom avatar. Sometimes the link and the avatar appear. I assume it's some sort of race condition.

Here's the console log on a load that lacks both link and avatar:

Quote
gatherUrlCookieParams found the following URL params: [""] FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie {0: "", id: "funsocketsplayercookie", cookieid: null, connectionInfo: Object, httpUrl: "https://prod-webapps.goko.com/WebApps/bus/", vers: "1.3"…}
 FSSDK.js:560
ConnectionMaker merged the following cookie params: ["", cookieid: null] FSSDK.js:566
FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg03.goko.com:80 FSSDK.js:13427
Running Goko Salvager v2.3.x utils.js:8
FSSDK: webSocket: onopen: top: url:ws://prod-wsg03.goko.com:80 FSSDK.js:13482
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13525
15
Uncaught TypeError: Object #<Object> has no method 'get_option' utils.js:12
window.GokoSalvager.debug utils.js:12
depTry utils.js:77
[GSFN.Widget.Shell.initialize] loader.js:1
initMeetingRoom DominionClient.js:292
This element isn't a canvas - TypeError: Object #<HTMLDivElement> has no method 'getContext' FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L720px T0px FSSDK.Notifier.js:115
15
Uncaught TypeError: Object #<Object> has no method 'get_option' utils.js:12
window.GokoSalvager.debug utils.js:12
depTry utils.js:77
Successfully subscribed to player notifications FSSDK.js:20333
405
Uncaught TypeError: Object #<Object> has no method 'get_option' utils.js:12
window.GokoSalvager.debug utils.js:12
depTry utils.js:77
[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4 loader.js:1
165
Uncaught TypeError: Object #<Object> has no method 'get_option' utils.js:12
window.GokoSalvager.debug utils.js:12
depTry utils.js:77
Personal currencyClient.js:64
Avatar Inventory currencyClient.js:64
Avatar Inventory currencyClient.js:64
8355
Uncaught TypeError: Object #<Object> has no method 'get_option' utils.js:12
window.GokoSalvager.debug utils.js:12
depTry utils.js:77

By the way, that 8355 is constantly increasing. I just copied it at that point.

Here's a log when just the avatar fails to load:

Quote
gatherUrlCookieParams found the following URL params: [""] FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie {0: "", id: "funsocketsplayercookie", cookieid: null, connectionInfo: Object, httpUrl: "https://prod-webapps.goko.com/WebApps/bus/", vers: "1.3"…}
 FSSDK.js:560
ConnectionMaker merged the following cookie params: ["", cookieid: null] FSSDK.js:566
FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg03.goko.com:80 FSSDK.js:13427
FSSDK: webSocket: onopen: top: url:ws://prod-wsg03.goko.com:80 FSSDK.js:13482
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13525
Running Goko Salvager v2.3.x utils.js:8
initMeetingRoom DominionClient.js:292
This element isn't a canvas - TypeError: Object #<HTMLDivElement> has no method 'getContext' FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L720px T0px FSSDK.Notifier.js:115
Successfully subscribed to player notifications FSSDK.js:20333
GET chrome-extension://kaignighoceeemhinbbophdeogpnedjn/images/ui-bg_fine-grain_10_c3c3c3_60x60.png  jquery-1.7.1.js:6714
getComputedStyle jquery-1.7.1.js:6714
jQuery.extend.css jquery-1.7.1.js:6583
jQuery.fn.extend.show jquery-1.7.1.js:8256
$.fn.extend.show jquery.ui.js:5950
$.widget._create jquery.ui.js:9724
(anonymous function) jquery.ui.js:401
$.Widget._createWidget jquery.ui.js:560
$.(anonymous function).(anonymous function) jquery.ui.js:362
(anonymous function) jquery.ui.js:507
jQuery.extend.each jquery-1.7.1.js:658
jQuery.fn.jQuery.each jquery-1.7.1.js:271
$.fn.(anonymous function) jquery.ui.js:502
createSettingsDialog settingsDialog.js:102
depTry utils.js:85
[GSFN.Widget.Shell.initialize] loader.js:1
[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4

Second, it used to be that when I entered a faulty string into the Kingdom Generator, it would pop up an error and default to full random. Now it crashes the site and reloads the tab, kicking me back to the title screen. Is this intentional? To reproduce this, I just try to create a game with a string like "asdf".

Unfortunately I cannot get you a console log of this bug because the log is wiped out when the page crashes.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 26, 2013, 06:13:03 pm
Thanks for your bug reports folks. I'm catching up on the last week all in this one post.

Please see Awaculus' bug report (http://forum.dominionstrategy.com/index.php?topic=8163.msg296878#msg296878) for an example of what I usually need to diagnose and fix a problem. To include the console log like he did:
1. Go to User Settings and enable "Extra logging"
2. Open the JS console (F12 in Chrome; Command-Alt-C in Safari; Tools/Web Developer/Browser Console in Firefox)
3. Reproduce the error and copy the log
4. Include the log in your post, preferably wrapped in "code" tags or attached as a text file.

On to the bug reports...

I have to delete and reinstall Salvager almost every time I play to get it to work properly. Any ideas on why that might be? I have it enabled as an extension in Chrome.

So, actually, I have been having a related issue since the last Chrome update. I have to refresh the Dominion client every time I restart Chrome in order for the extension to work. That is, I log in to Goko, Dominion loads, but not the extension (even though it's "enabled"). I hit refresh, and everything works fine. It's a little baffling.

So maybe try refreshing rather than completely reinstalling every time?

I just Quit, then re-open Chrome.  It automatically goes back to the Goko page, and the Extension is loaded.  It's annoying maybe, but it only takes 12 seconds or so.

Same for me.

These are the bugs that I simply can't fix without a console log. There are just too many ways to produce the the same symptom: "sometimes feature X doesn't load." Knowing which workarounds work helps a little but not much.

Thanks to Awaclus, I'll be able to solve a whole class of these bugs. If your problem has the same cause, it'll get fixed in the next version along with his. If it has a different cause, I won't be able to fix it without a console log.


In multiplayer lobbies, players are sorted by rating, even though I have unchecked "sort players by rating".

This seems to be happening when pro ratings are on but sorting is off. Will fix.

Thanks for the testing, btw. At least I'm guessing you were testing. I can't imagine too many players use this combination of features for ordinary play.


Was something changed to remove the introductory chat messages about the VP tracker when #vpon is in the table name? I put #vpon in my table name, but my opponents haven't been getting the info about the extension/tracking recently. I noticed that the introduction IS given if I just enable the tracker in chat once the game has begun though.

Yes. My reasoning was that people would guess that #vpon in the title meant the same thing as #vpon in chat, but several users have told me otherwise. I'll make it send the #vpon message in those games too.


A number of my opponents have been unaware that #vpon in the table name means I can perpetually see the score, so I sorta think that chat messages should include as much pertinent info as possible. To me, it'd be worth it to clutter up the chat box just to make sure everyone's on an even playing field. Even show the score in chat automatically every few turns if both players don't have the extension.

I'll make the intro message clearer, but I probably won't make it chat the score every few turns. I don't really want to inconvenience extension users for the sake of users who don't want the extension but do want the point tracker but don't want to have to bother typing #vp? If I do add that feature, it'll be as an option that's disabled by default.


Speaking of pop-ups, here is a Salvager request: I only want popups that alerts me matchups etc. if and only if the tab I'm playing in isn't already active/focused.

This is a tough one. Browsers really don't like to expose tab and focus-grabbing functions. I think it's just too easy for malicious addons to abuse. The functionality that I have found is deprecated and browser specific.

Using JS popups was a clumsy hack that at least works on all three browsers, but it doesn't let me do stuff like check which tab is currently active, trigger a tab change without showing a modal popup, etc. If anyone knows a better way, please let me know. Left to my own devices, I'll probably never make the visual alerts into a very polished feature.


FWIW, i often play on iPad which can't type into the message field, so I have no access to the point tracker at all.

What happens if you enable the "always request" option? That should send an automatic chat message and enable the VP counter. If that works, then you'll be good to go when I implement the #vpon in tablename fix (see gunslinger's question).

If Goko has simply disabled chat on the iPad version as they did for guests, then I may not be able to fix this. At least, there may be no way to alert your non-extension opponents that you want to use the VP counter.


I have a couple of bug reports. I play on a MacBook Pro using Chrome Version 29.0.1547.76 and version 2.3.3 of the extension. When I load the page, it sometimes loads the extension and other times not. I believe a lot of people are having this issue. Furthermore, sometimes most of the extension loads, but the avatars do not. All I have to do to reproduce this issue is reload the Goko Dominion title screen. Sometimes the "User Settings" link doesn't appear. Sometimes it does, but the normal Goko avatar is in the upper-right corner rather than the custom avatar. Sometimes the link and the avatar appear. I assume it's some sort of race condition.

Here's the console log on a load that lacks both link and avatar:

Thanks for the log. Your assumption is correct. Will fix.


Second, it used to be that when I entered a faulty string into the Kingdom Generator, it would pop up an error and default to full random. Now it crashes the site and reloads the tab, kicking me back to the title screen. Is this intentional? To reproduce this, I just try to create a game with a string like "asdf".

Unfortunately I cannot get you a console log of this bug because the log is wiped out when the page crashes.

No problem. I happened to stumble upon this one a while back. I know the cause but I've hesitated to mess with otherwise working code that I don't fully understand. Doing so keeps getting me in trouble. I'll try to find a relativley non-intrusive fix.
Title: Re: Goko Dominion Salvager Discussion
Post by: Schneau on September 26, 2013, 08:29:32 pm
I have been having the problem that others have reported where the extension does not load the first time I visit Goko. And by that, I mean that I can't visit the extension options page, and (sometimes) the other extension features don't work. Refreshing the page usually fixes the problem. I grabbed a JS log of a time that the extension options link didn't appear. Note that the last two lines repeated indefinitely in the console. EDIT: I use Chrome, and get this error on both OSX and Vista. Extension 2.3.2, and the log below is from OSX.

Code: [Select]
gatherUrlCookieParams found the following URL params: [""] FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie {0: "", id: "funsocketsplayercookie", cookieid: null, connectionInfo: Object, httpUrl: "https://prod-webapps.goko.com/WebApps/bus/", vers: "1.3"…}
 FSSDK.js:560
ConnectionMaker merged the following cookie params: ["", cookieid: null] FSSDK.js:566
FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg04.goko.com:80 FSSDK.js:13427
Uncaught TypeError: Cannot call method 'depWait' of undefined settingsDialog.js:159
Uncaught TypeError: Cannot call method 'depWait' of undefined sidebar.js:69
Uncaught TypeError: Cannot call method 'depWait' of undefined tableState.js:29
Running Goko Salvager v2.3.x utils.js:8
[GSFN.Widget.Shell.initialize] loader.js:1
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Toggle utils.js:13
VP Toggle is missing dependency: mtgRoom utils.js:13
Checking deps for VP Calculator utils.js:13
Found deps for VP Calculator utils.js:13
Found deps and ran VP Calculator utils.js:13
Checking deps for Logviewer Module utils.js:13
Found deps for Logviewer Module utils.js:13
Found deps and ran Logviewer Module utils.js:13
Checking deps for Lobby Ratings Module utils.js:13
Found deps for Lobby Ratings Module utils.js:13
Found deps and ran Lobby Ratings Module utils.js:13
Checking deps for Kingdom Generator Module utils.js:13
Found deps for Kingdom Generator Module utils.js:13
Found deps and ran Kingdom Generator Module utils.js:13
Checking deps for Always Stack Module utils.js:13
Found deps for Always Stack Module utils.js:13
Found deps and ran Always Stack Module utils.js:13
Checking deps for Autokick module utils.js:13
Found deps for Autokick module utils.js:13
Found deps and ran Autokick module utils.js:13
Checking deps for Avatar Module utils.js:13
Found deps for Avatar Module utils.js:13
Found deps and ran Avatar Module utils.js:13
Checking deps for Blacklist Module utils.js:13
Found deps for Blacklist Module utils.js:13
Found deps and ran Blacklist Module utils.js:13
Checking deps for Decktracker Module utils.js:13
Found deps for Decktracker Module utils.js:13
Found deps and ran Decktracker Module utils.js:13
FSSDK: webSocket: onopen: top: url:ws://prod-wsg04.goko.com:80 FSSDK.js:13482
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13525
Checking deps for Automatch Gateway Listener utils.js:13
Found deps for Automatch Gateway Listener utils.js:13
Found deps and ran Automatch Gateway Listener utils.js:13
initMeetingRoom DominionClient.js:292
This element isn't a canvas - TypeError: Object #<HTMLDivElement> has no method 'getContext' FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L720px T0px FSSDK.Notifier.js:115
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Toggle utils.js:13
Found deps for VP Toggle utils.js:13
Found deps and ran VP Toggle utils.js:13
Successfully subscribed to player notifications FSSDK.js:20333
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4 loader.js:1
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Personal currencyClient.js:64
Avatar Inventory currencyClient.js:64
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Checking deps for VP Table utils.js:13
VP Table is missing dependency: #sidebar utils.js:13
Title: Re: Goko Dominion Salvager Discussion
Post by: jl8e on September 26, 2013, 09:26:35 pm
I'm using Safari (6.0.5 on OS X 10.7.5), and while the extension works (I get the automatch menu, log, score tracker, custom icons, and pro ratings), I don't get the settings menu. Occasionally, what looks like some unlabeled checkboxes appear in the black space at the bottom, but usually nothing.

A log from a session where those checkboxes didn't appear:
Code: [Select]
553gatherUrlCookieParams found the following URL params: [""]
FSSDK.js:560ConnectionMaker found the following cookie params:
Object
FSSDK.js:566ConnectionMaker merged the following cookie params: [""]
FSSDK.js:13427FS.MessageWebSocketConnection.prototype.connect: currently trying - wss://prod-wsg03.goko.com:443
gameClient.html:9Running Goko Salvager v2.3.x
FSSDK.js:13848FS.MessageWebSocketConnection.prototype.setupMultiConnect: trynextwsgTimeout: trying - wss://prod-wsg04.goko.com:8182
FSSDK.js:13427FS.MessageWebSocketConnection.prototype.connect: currently trying - wss://prod-wsg04.goko.com:8182
FSSDK.js:13482FSSDK: webSocket: onopen: top: url:wss://prod-wsg03.goko.com:443
FSSDK.js:13525Setting up GA connection heartbeat every: 60000 milliseconds
DominionClient.js:292initMeetingRoom
FSSDK.Notifier.js:198This element isn't a canvas - TypeError: 'undefined' is not a function (evaluating 'this.elem.getContext('2d')')
FSSDK.Notifier.js:102This is a HTML Element
FSSDK.Notifier.js:115Dimension: W0px H0px @L590px T0px
FSSDK.js:20333Successfully subscribed to player notifications
FSSDK.js:13482FSSDK: webSocket: onopen: top: url:wss://prod-wsg04.goko.com:8182
The page at https://play.goko.com/Dominion/gameClient.html displayed insecure content from http://dom.retrobox.eu/avatars/508439f30cf270038ff91a0b.png.
safari-extension://com.dominionstrategy.safari.gokosalvager-366P22F9M8/1a5e626c/images/ui-bg_fine-grain_10_c3c3c3_60x60.pngFailed to load resource: The requested URL was not found on this server.
http://dom.retrobox.eu/avatars/508439f30cf270038ff91a0b.pngFailed to load resource: the server responded with a status of 404 (Not Found)
Cross-origin image load denied by Cross-Origin Resource Sharing policy.
loader.js:1[GSFN.Widget.Shell.initialize]
loader.js:1[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4
currencyClient.js:64Personal
currencyClient.js:64Avatar Inventory
DominionClient.js:740Create achievements response: 
Object
The page at https://play.goko.com/Dominion/gameClient.html displayed insecure content from http://dom.retrobox.eu/avatars/516cd386e4b082c74d7a1c31.png.

(I trimmed out most of the "insecure content", image not found, and cross-origin image load errors)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 27, 2013, 03:55:24 am
I'm using Safari (6.0.5 on OS X 10.7.5), and while the extension works (I get the automatch menu, log, score tracker, custom icons, and pro ratings), I don't get the settings menu. Occasionally, what looks like some unlabeled checkboxes appear in the black space at the bottom, but usually nothing.

A log from a session where those checkboxes didn't appear:

Code: [Select]

(I trimmed out most of the "insecure content", image not found, and cross-origin image load errors)

I'm not seeing any messages related to the settings dialog. Do you have "extra logging" enabled?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 27, 2013, 03:56:57 am
I have been having the problem that others have reported where the extension does not load the first time I visit Goko. And by that, I mean that I can't visit the extension options page, and (sometimes) the other extension features don't work. Refreshing the page usually fixes the problem. I grabbed a JS log of a time that the extension options link didn't appear. Note that the last two lines repeated indefinitely in the console. EDIT: I use Chrome, and get this error on both OSX and Vista. Extension 2.3.2, and the log below is from OSX.

Thanks. Looks like the same error as Awaculus found in a different form. I should be able to fix it.
Title: Re: Goko Dominion Salvager Discussion
Post by: jl8e on September 27, 2013, 11:08:40 am
I'm using Safari (6.0.5 on OS X 10.7.5), and while the extension works (I get the automatch menu, log, score tracker, custom icons, and pro ratings), I don't get the settings menu. Occasionally, what looks like some unlabeled checkboxes appear in the black space at the bottom, but usually nothing.

A log from a session where those checkboxes didn't appear:

Code: [Select]

(I trimmed out most of the "insecure content", image not found, and cross-origin image load errors)

I'm not seeing any messages related to the settings dialog. Do you have "extra logging" enabled?

Safari doesn't appear to have any setting for extra logging. (If you mean extra logging in the extension, how do I enable that without a settings menu? (I am capable of editing source files, though my JS isn't great, and I don't know my way around browser extensions.))

Is it possible the menu's loading, but whatever image it uses isn't?
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on September 27, 2013, 12:31:03 pm
Quote
Using JS popups was a clumsy hack that at least works on all three browsers, but it doesn't let me do stuff like check which tab is currently active, trigger a tab change without showing a modal popup, etc. If anyone knows a better way, please let me know. Left to my own devices, I'll probably never make the visual alerts into a very polished feature.
can you cause the tab title bar to flash? change the icon there or something?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 27, 2013, 12:50:46 pm
Safari doesn't appear to have any setting for extra logging. (If you mean extra logging in the extension, how do I enable that without a settings menu? (I am capable of editing source files, though my JS isn't great, and I don't know my way around browser extensions.))

Sorry. I wasn't clear. I mean the "Extra Logging" option in the extension settings dialog. I gathered from your previous message that the settings dialog does sometimes work. If so, then just enable "extra logging" using the settings dialog when it's working. It'll stay enabled until you turn it off again. If the dialog never works at all, you can enable the option in the JS console by typing "GokoSalvager.set_option('debug_mode', true)".

Quote
Is it possible the menu's loading, but whatever image it uses isn't?

Missing images won't break the dialog. It's probably either a problem with jQuery building the dialog or with the AngularJS data binding. In either case, there's probably an error prior to the building/binding that's causing the problem. That's what I'm hoping to find in the log.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 27, 2013, 12:54:42 pm
Quote
Using JS popups was a clumsy hack that at least works on all three browsers, but it doesn't let me do stuff like check which tab is currently active, trigger a tab change without showing a modal popup, etc. If anyone knows a better way, please let me know. Left to my own devices, I'll probably never make the visual alerts into a very polished feature.
can you cause the tab title bar to flash? change the icon there or something?

I can't make it flash or get your attention like an app on your OS would, but yes, I can mess with the title and the icon. Depending on the OS, the browser, and the browser settings, that is. I'll look into it.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 27, 2013, 01:03:11 pm
Quote
Using JS popups was a clumsy hack that at least works on all three browsers, but it doesn't let me do stuff like check which tab is currently active, trigger a tab change without showing a modal popup, etc. If anyone knows a better way, please let me know. Left to my own devices, I'll probably never make the visual alerts into a very polished feature.
can you cause the tab title bar to flash? change the icon there or something?

I can't make it flash or get your attention like an app on your OS would, but yes, I can mess with the title and the icon. Depending on the OS, the browser, and the browser settings, that is. I'll look into it.

Isotropic made the title of your tab flash when it was your turn/you got an auto-match and you were in another tab. At least it did so in whatever Chrome versions I was using at the time under Windows 8.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 27, 2013, 01:12:59 pm
Isotropic made the title of your tab flash when it was your turn/you got an auto-match and you were in another tab. At least it did so in whatever Chrome versions I was using at the time under Windows 8.

I can probably do the same then. If someone points me to a page where I can see this in action, it'd be a big help.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on September 27, 2013, 01:53:48 pm
I think modifying document.title is the key. Don't have an example, but here's a stackoverflow question with a bit of sample code: http://stackoverflow.com/questions/5249692/flash-the-title-bar

and for flashing favicon, found this: http://stackoverflow.com/questions/5249692/flash-the-title-bar apparently I failed at actually copying the link at the time
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on September 27, 2013, 04:01:16 pm
Isotropic made the title of your tab flash when it was your turn/you got an auto-match and you were in another tab. At least it did so in whatever Chrome versions I was using at the time under Windows 8.

I can probably do the same then. If someone points me to a page where I can see this in action, it'd be a big help.
Maybe http://innovation.isotropic.org ?
Title: Re: Goko Dominion Salvager Discussion
Post by: jl8e on September 27, 2013, 08:48:59 pm
Safari doesn't appear to have any setting for extra logging. (If you mean extra logging in the extension, how do I enable that without a settings menu? (I am capable of editing source files, though my JS isn't great, and I don't know my way around browser extensions.))

Sorry. I wasn't clear. I mean the "Extra Logging" option in the extension settings dialog. I gathered from your previous message that the settings dialog does sometimes work. If so, then just enable "extra logging" using the settings dialog when it's working. It'll stay enabled until you turn it off again. If the dialog never works at all, you can enable the option in the JS console by typing "GokoSalvager.set_option('debug_mode', true)".
.

It hadn't ever appeared before.* Today, it did, and I turned on extra logging. I'll post if it goes missing again.

* Or I simply overlooked it entirely in several sessions, which isn't impossible.
Title: Re: Goko Dominion Salvager Discussion
Post by: jl8e on September 28, 2013, 10:13:39 pm
Got a failed load with the checkboxes appearing in the black space at the bottom:

Code: [Select]
atherUrlCookieParams found the following URL params: [""]
FSSDK.js:560ConnectionMaker found the following cookie params:
Object
FSSDK.js:566ConnectionMaker merged the following cookie params: [""]
FSSDK.js:13427FS.MessageWebSocketConnection.prototype.connect: currently trying - wss://prod-wsg01.goko.com:443
gameClient.html:9Running Goko Salvager v2.3.x
gameClient.html:14Checking deps for Kingdom Generator Module
gameClient.html:14Found deps for Kingdom Generator Module
gameClient.html:14Found deps and ran Kingdom Generator Module
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for Table Settings Module
gameClient.html:14Found deps for Table Settings Module
gameClient.html:14Found deps and ran Table Settings Module
gameClient.html:14Checking deps for Autokick module
gameClient.html:14Found deps for Autokick module
gameClient.html:14Found deps and ran Autokick module
gameClient.html:14Checking deps for Avatar Module
gameClient.html:14Found deps for Avatar Module
gameClient.html:14Found deps and ran Avatar Module
gameClient.html:14Checking deps for Blacklist Module
gameClient.html:14Found deps for Blacklist Module
gameClient.html:14Found deps and ran Blacklist Module
gameClient.html:14Checking deps for Sidebar
gameClient.html:14Found deps for Sidebar
gameClient.html:14Found deps and ran Sidebar
gameClient.html:14Checking deps for Logviewer Module
gameClient.html:14Found deps for Logviewer Module
gameClient.html:14Found deps and ran Logviewer Module
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for VP Calculator
gameClient.html:14Found deps for VP Calculator
gameClient.html:14Found deps and ran VP Calculator
gameClient.html:14Checking deps for Lobby Ratings Module
gameClient.html:14Found deps for Lobby Ratings Module
gameClient.html:14Found deps and ran Lobby Ratings Module
gameClient.html:14Checking deps for Always Stack Module
gameClient.html:14Found deps for Always Stack Module
gameClient.html:14Found deps and ran Always Stack Module
gameClient.html:14Checking deps for Decktracker Module
gameClient.html:14Found deps for Decktracker Module
gameClient.html:14Found deps and ran Decktracker Module
gameClient.html:14Checking deps for Automatch Gateway Listener
gameClient.html:14Found deps for Automatch Gateway Listener
gameClient.html:14Found deps and ran Automatch Gateway Listener
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
FSSDK.js:13482FSSDK: webSocket: onopen: top: url:wss://prod-wsg01.goko.com:443
FSSDK.js:13525Setting up GA connection heartbeat every: 60000 milliseconds
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: angular
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14VP Table is missing dependency: angular
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14VP Toggle is missing dependency: mtgRoom
DominionClient.js:292initMeetingRoom
FSSDK.Notifier.js:198This element isn't a canvas - TypeError: 'undefined' is not a function (evaluating 'this.elem.getContext('2d')')
FSSDK.Notifier.js:102This is a HTML Element
FSSDK.Notifier.js:115Dimension: W0px H0px @L590px T0px
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for VP Table
gameClient.html:14Found deps for VP Table
gameClient.html:14Found deps and ran VP Table
gameClient.html:14Checking deps for VP Toggle
gameClient.html:14Found deps for VP Toggle
gameClient.html:14Found deps and ran VP Toggle
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
FSSDK.js:20333Successfully subscribed to player notifications
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14User Settings Dialog is missing dependency: .fs-rs-logout-row
The page at https://play.goko.com/Dominion/gameClient.html displayed insecure content from http://dom.retrobox.eu/avatars/508439f30cf270038ff91a0b.png.
gameClient.html:14Checking deps for User Settings Dialog
gameClient.html:14Found deps for User Settings Dialog
gameClient.html:109TypeError: 'undefined' is not a function (evaluating '$('#settingsDialog').dialog')
http://dom.retrobox.eu/avatars/508439f30cf270038ff91a0b.pngFailed to load resource: the server responded with a status of 404 (Not Found)
Cross-origin image load denied by Cross-Origin Resource Sharing policy.
loader.js:1[GSFN.Widget.Shell.initialize]
currencyClient.js:64Personal
currencyClient.js:64Avatar Inventory
loader.js:1[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on September 29, 2013, 08:17:29 am
Feature request: Is it possible to make a game-name, which will be there by default, if I don't change it? Normally my game is named "5000+ #vpoff Nearly All", but if I search for a player, I only write his name there, so I have to change it after that. If there would be a button, where I can change the game name into my normal that would be cool. Not the most important thing, but it would be cool ;-)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 29, 2013, 10:47:30 am
Feature request: Is it possible to make a game-name, which will be there by default, if I don't change it? Normally my game is named "5000+ #vpoff Nearly All", but if I search for a player, I only write his name there, so I have to change it after that. If there would be a button, where I can change the game name into my normal that would be cool. Not the most important thing, but it would be cool ;-)

Really good suggestion. Shouldn't be very hard to implement either.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on September 29, 2013, 08:00:04 pm
Feature Request: Can you add an animation of an extremely angry duck on screen if an opponent's Sea Hag discards my Sea Hag on Turn 3?
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on September 30, 2013, 01:26:25 pm
I noticed this:

(http://img29.imageshack.us/img29/6576/9hdv.jpg)

and have seen Holger occupying the "Seeks" list before with multiple clones. He also doesn't appear in the extension users list, which leads me to suspect both that new requests don't automatically cancel old ones, as I think they should, and that requests don't get cancelled if the user quits, so maybe you want to periodically check (every 30 seconds or so?) whether a user in the seek list is still in the extension user list (you can't really expect him to quit gracefully b.c. of computer crashes and stuff).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 30, 2013, 01:43:40 pm
I noticed this:

(http://img29.imageshack.us/img29/6576/9hdv.jpg)

and have seen Holger occupying the "Seeks" list before with multiple clones. He also doesn't appear in the extension users list, which leads me to suspect both that new requests don't automatically cancel old ones, as I think they should, and that requests don't get cancelled if the user quits, so maybe you want to periodically check (every 30 seconds or so?) whether a user in the seek list is still in the extension user list (you can't really expect him to quit gracefully b.c. of computer crashes and stuff).


It does check periodically for disconnected users. I'm not sure how Holger managed to sneak through once, let alone a dozen times. FYI, the "Extension Users" are only the ones who are online and not currently in a game.

Obviously that UI isn't really ready for prime time. I'll just reset the server to get rid of Holger's seeks for now.
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on September 30, 2013, 03:17:38 pm
On page 25 of this thread people talk about the extension not always showing up when Goko loads. I had the same problem back then, and I now have a similar problem. The extension always loads, but sometimes (about half of the time, only partly. The "User Settings" link always shows up, but sometimes all other features of the extension do not work. I usually recognize this because my custom avatar does not display (and then I refresh, which usually makes everything work fine). Sometimes I don't check my avatar, and if I then go to multiplayer / play bots, it is as if I've got no extension.

Attached you'll find a screenshot where this happens (select this text and drag right to view attachment). The only thing which is "strange" in this image is that my custom avatar (top right) isn't displayed, instead a standard Goko avatar is displayed.

I work with Chrome (under Ubuntu), using Adblock Plus (I also tried disabling ABP, and then this bug also occurs, although my (very small) sample seems to suggest it happens less often). Extension version is v2.3.2 (and I have Extra Logging enabled).

I also copied two logs (hopefully the right ones). The first one is with ABP enabled, and the second with ABP disabled. They seem to be different (I can imagine that the first one shows non-related ABP issues).


Code: [Select]
Failed to load resource http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=191&utmn=5150355…n%3D(organic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=qh~
gatherUrlCookieParams found the following URL params:
Array[1]
 FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie
 FSSDK.js:560
ConnectionMaker merged the following cookie params:
Array[1]
 FSSDK.js:566
FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg04.goko.com:80 FSSDK.js:13427
FSSDK: webSocket: onopen: top: url:ws://prod-wsg04.goko.com:80 FSSDK.js:13482
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13525
Failed to load resource http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=192&utmn=1032049…ganic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=qhCAAAAAM~
Failed to load resource http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=193&utmn=1154638…ganic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=qhCAAAAAM~
Failed to load resource http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=194&utmn=9338040…ganic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=qhCAAAAAM~
initMeetingRoom DominionClient.js:292
This element isn't a canvas - TypeError: Object #<HTMLDivElement> has no method 'getContext' FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L607.5px T0px FSSDK.Notifier.js:115
Successfully subscribed to player notifications FSSDK.js:20333
Running Goko Salvager v2.3.x utils.js:8
Checking deps for Kingdom Generator Module utils.js:13
Found deps for Kingdom Generator Module utils.js:13
Found deps and ran Kingdom Generator Module utils.js:13
Checking deps for User Settings Dialog utils.js:13
Found deps for User Settings Dialog utils.js:13
Found deps and ran User Settings Dialog utils.js:13
Failed to load resource chrome-extension://kaignighoceeemhinbbophdeogpnedjn/images/ui-bg_fine-grain_10_c3c3c3_60x60.png
Checking deps for Table Settings Module utils.js:13
Found deps for Table Settings Module utils.js:13
Found deps and ran Table Settings Module utils.js:13
Checking deps for Autokick module utils.js:13
Found deps for Autokick module utils.js:13
Found deps and ran Autokick module utils.js:13
Checking deps for Avatar Module utils.js:13
Found deps for Avatar Module utils.js:13
Found deps and ran Avatar Module utils.js:13
Checking deps for Blacklist Module utils.js:13
Found deps for Blacklist Module utils.js:13
Found deps and ran Blacklist Module utils.js:13
Checking deps for Sidebar utils.js:13
Found deps for Sidebar utils.js:13
Found deps and ran Sidebar utils.js:13
Checking deps for Logviewer Module utils.js:13
Found deps for Logviewer Module utils.js:13
Found deps and ran Logviewer Module utils.js:13
Checking deps for VP Table utils.js:13
Found deps for VP Table utils.js:13
Found deps and ran VP Table utils.js:13
Checking deps for VP Toggle utils.js:13
Found deps for VP Toggle utils.js:13
Found deps and ran VP Toggle utils.js:13
Checking deps for VP Calculator utils.js:13
Found deps for VP Calculator utils.js:13
Found deps and ran VP Calculator utils.js:13
Checking deps for Lobby Ratings Module utils.js:13
Found deps for Lobby Ratings Module utils.js:13
Found deps and ran Lobby Ratings Module utils.js:13
Checking deps for Always Stack Module utils.js:13
Found deps for Always Stack Module utils.js:13
Found deps and ran Always Stack Module utils.js:13
Checking deps for Decktracker Module utils.js:13
Found deps for Decktracker Module utils.js:13
Found deps and ran Decktracker Module utils.js:13
Checking deps for Automatch Gateway Listener utils.js:13
Found deps for Automatch Gateway Listener utils.js:13
Found deps and ran Automatch Gateway Listener utils.js:13
[GSFN.Widget.Shell.initialize] loader.js:1
[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4 loader.js:1
Failed to load resource http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=195&utmn=1896561…ganic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=6hCAAAAAM~
Failed to load resource http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=196&utmn=1319106…ganic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=6hCAAAAAM~
GET http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=197&utmn=1263370…ganic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=6hCAAAAAM~  ga.js:61
gf ga.js:61
Sa ga.js:61
oe ga.js:61
Uc.(anonymous function).execute ga.js:21
j ga.js:14
E.Fa ga.js:46
a.(anonymous function) ga.js:14
E.O ga.js:27
E.push ga.js:25
a.(anonymous function) ga.js:14
FS.MessageWebSocketConnection.sendGATag FSSDK.js:14161
(anonymous function) FSSDK.js:13527
GET http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=198&utmn=1136769…ganic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=6hCAAAAAM~  ga.js:61
gf ga.js:61
Sa ga.js:61
oe ga.js:61
Uc.(anonymous function).execute ga.js:21
j ga.js:14
E.Fa ga.js:46
a.(anonymous function) ga.js:14
E.O ga.js:27
E.push ga.js:25
a.(anonymous function) ga.js:14
FS.MessageWebSocketConnection.sendGATag FSSDK.js:14162
(anonymous function) FSSDK.js:13527
GET http://www.google-analytics.com/__utm.gif?utmwv=5.4.5&utms=199&utmn=9366972…ganic)%7Cutmcmd%3Dorganic%7Cutmctr%3D(not%2520provided)%3B&utmu=6hCAAAAAM~  ga.js:61
gf ga.js:61
Sa ga.js:61
oe ga.js:61
Uc.(anonymous function).execute ga.js:21
j ga.js:14
E.Fa ga.js:46
a.(anonymous function) ga.js:14
E.O ga.js:27
E.push ga.js:25
a.(anonymous function) ga.js:14
FS.MessageWebSocketConnection.sendGATag FSSDK.js:14163
(anonymous function) FSSDK.js:13527

Code: [Select]
gatherUrlCookieParams found the following URL params:
Array[1]
 FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie
 FSSDK.js:560
ConnectionMaker merged the following cookie params:
Array[1]
 FSSDK.js:566
FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg04.goko.com:80 FSSDK.js:13427
FSSDK: webSocket: onopen: top: url:ws://prod-wsg04.goko.com:80 FSSDK.js:13482
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13525
initMeetingRoom DominionClient.js:292
This element isn't a canvas - TypeError: Object #<HTMLDivElement> has no method 'getContext' FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L607.5px T0px FSSDK.Notifier.js:115
Successfully subscribed to player notifications FSSDK.js:20333
Running Goko Salvager v2.3.x utils.js:8
Checking deps for Kingdom Generator Module utils.js:13
Found deps for Kingdom Generator Module utils.js:13
Found deps and ran Kingdom Generator Module utils.js:13
Checking deps for User Settings Dialog utils.js:13
Found deps for User Settings Dialog utils.js:13
Found deps and ran User Settings Dialog utils.js:13
Failed to load resource chrome-extension://kaignighoceeemhinbbophdeogpnedjn/images/ui-bg_fine-grain_10_c3c3c3_60x60.png
Checking deps for Table Settings Module utils.js:13
Found deps for Table Settings Module utils.js:13
Found deps and ran Table Settings Module utils.js:13
Checking deps for Autokick module utils.js:13
Found deps for Autokick module utils.js:13
Found deps and ran Autokick module utils.js:13
Checking deps for Avatar Module utils.js:13
Found deps for Avatar Module utils.js:13
Found deps and ran Avatar Module utils.js:13
Checking deps for Blacklist Module utils.js:13
Found deps for Blacklist Module utils.js:13
Found deps and ran Blacklist Module utils.js:13
Checking deps for Sidebar utils.js:13
Found deps for Sidebar utils.js:13
Found deps and ran Sidebar utils.js:13
Checking deps for Logviewer Module utils.js:13
Found deps for Logviewer Module utils.js:13
Found deps and ran Logviewer Module utils.js:13
Checking deps for VP Table utils.js:13
Found deps for VP Table utils.js:13
Found deps and ran VP Table utils.js:13
Checking deps for VP Toggle utils.js:13
Found deps for VP Toggle utils.js:13
Found deps and ran VP Toggle utils.js:13
Checking deps for VP Calculator utils.js:13
Found deps for VP Calculator utils.js:13
Found deps and ran VP Calculator utils.js:13
Checking deps for Lobby Ratings Module utils.js:13
Found deps for Lobby Ratings Module utils.js:13
Found deps and ran Lobby Ratings Module utils.js:13
Checking deps for Always Stack Module utils.js:13
Found deps for Always Stack Module utils.js:13
Found deps and ran Always Stack Module utils.js:13
Checking deps for Decktracker Module utils.js:13
Found deps for Decktracker Module utils.js:13
Found deps and ran Decktracker Module utils.js:13
Checking deps for Automatch Gateway Listener utils.js:13
Found deps for Automatch Gateway Listener utils.js:13
Found deps and ran Automatch Gateway Listener utils.js:13
[GSFN.Widget.Shell.initialize] loader.js:1
[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4 loader.js:1
Failed to load resource chrome-extension://kaignighoceeemhinbbophdeogpnedjn/images/ui-bg_fine-grain_20_cbaa6e_60x60.png
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on September 30, 2013, 03:21:48 pm
Feature request: Would it be possible if automatch ranges work on Isotropish rating instead of Goko's rating? Maybe even display Isotropish rating everywhere?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 30, 2013, 05:21:20 pm
On page 25 of this thread people talk about the extension not always showing up when Goko loads. I had the same problem back then, and I now have a similar problem. The extension always loads, but sometimes (about half of the time, only partly. The "User Settings" link always shows up, but sometimes all other features of the extension do not work. I usually recognize this because my custom avatar does not display (and then I refresh, which usually makes everything work fine). Sometimes I don't check my avatar, and if I then go to multiplayer / play bots, it is as if I've got no extension.

Attached you'll find a screenshot where this happens (select this text and drag right to view attachment). The only thing which is "strange" in this image is that my custom avatar (top right) isn't displayed, instead a standard Goko avatar is displayed.

I work with Chrome (under Ubuntu), using Adblock Plus (I also tried disabling ABP, and then this bug also occurs, although my (very small) sample seems to suggest it happens less often). Extension version is v2.3.2 (and I have Extra Logging enabled).

I also copied two logs (hopefully the right ones). The first one is with ABP enabled, and the second with ABP disabled. They seem to be different (I can imagine that the first one shows non-related ABP issues).

In the logs you attached, all of the features appear to have loaded correctly. However, it's possible for the avatars feature to load correctly and still not replace your image on the login screen. It's a bug created by the transition from GreaseMonkey script to browser extension.

I'll fix that when I eventually overhaul the avatars module, along with the multitude of invisible 404 and CORS errors too. I don't consider these high priority issues, though, since they don't really affect functionality. For now, don't take the absence of your custom icon as evidence that Salvager has failed to load.

I'll soon release the new version with fixes for the many feature(s)-not-loading problems. Actually, the fix is already checked into github, for those who are daring enough to compile and test it. So thanks for all your bug reports and logs, but there's no need to submit additional reports of this sort right now. Whatever new failure-to-load problem you're encountering is very likely to be fixed along with the others.
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on September 30, 2013, 07:50:49 pm
Okay, I actually thought this should already be fixed in the current version. Great that it will be fixed in a future version soon!
For now, don't take the absence of your custom icon as evidence that Salvager has failed to load.
Just want to remark on this: I have tested this a few times actually (sometimes accidentally), and in those cases other extension features didn't work until refreshing (didn't test all features, but at least the log, card stacking, VP counter and automatch didn't work (at least once) when my avatar didn't display)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on September 30, 2013, 08:33:21 pm
Okay, I actually thought this should already be fixed in the current version. Great that it will be fixed in a future version soon!

I haven't released any new versions in the past two weeks. The load order thing actually required some pretty major refactoring and everything else was on hold because of that.

For now, don't take the absence of your custom icon as evidence that Salvager has failed to load.
Just want to remark on this: I have tested this a few times actually (sometimes accidentally), and in those cases other extension features didn't work until refreshing (didn't test all features, but at least the log, card stacking, VP counter and automatch didn't work (at least once) when my avatar didn't display)

It's an "if" but not an "only if" ;)

Feature request: Would it be possible if automatch ranges work on Isotropish rating instead of Goko's rating? Maybe even display Isotropish rating everywhere?

This has been suggested before and I've planned to do it before. You can probably expect to see it in the next version after this one (i.e. not the current beta).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on October 01, 2013, 12:06:26 am
v2.3.4 BETA is out. :)

Testers needed! I'll release to the Chrome store after I've written some docs and after you guys help me squash whatever new bugs I've introduced this time.

https://www.gokosalvager.com:8888/v2.3.4.2/index.html

Same annoying install process for Chrome: download, then drag the file into the Extensions page. Safari: download and then double-click. Firefox: just click the link. Regardless of which version you install, it'll update automatically as I fix and re-release.

New features (enable notifications/chat in User Settings):
Fixed:
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on October 01, 2013, 02:09:32 am
Volunteering for testing the beta version! I only tested games against bots.

Good news: For me the extension loads every time I open the game! Yay!

Other remarks/bugs:
-My own custom avatar doesn't seem to work anymore. Anytime I open the game (100% of the ~20 times I refreshed) the Goko avatar is displayed. I also cannot click on this avatar (to change it). When I go to the multiplayer lobby, my own avatar is a standard Goko avatar, but I do see custom avatars of others. Also, in games (and on score screens), my custom avatar is displayed. Below are two logs with a lot of "Failed to load resource"-errors, which are probably related (most - but not all - of them say they fail to load some avatar image). The top log is the log of playing the game against a bot, the bottom log is of joining the multiplayer lobby.

-When I type #vphelp I get all messages twice, once sent by "**" and once sent by "florrat". (this is in games against bots)

-[non-reproducible error] In one game the vp tracker didn't work. I think it showed the players of the game I played before that game, but the VP-amounts had - AFAIK - no relation to either the current or the previous game. Attached you'll find a screenshot. When trying to give commands in chat (#vp? or #vphelp), nothing happened: my message didn't display, and I didn't get any response (I could send other non-command messages). I forgot to copy the log. Probably this isn't that helpful until I find a way to reproduce it, but I wanted to report it anyway.

- The log only fills part of the space next to the game (see attached screenshot).



Code: [Select]
gatherUrlCookieParams found the following URL params:
Array[1]
 FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie
 FSSDK.js:560
ConnectionMaker merged the following cookie params:
Array[1]
 FSSDK.js:566
FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg04.goko.com:80 FSSDK.js:13427
Running Goko Salvager 2.3.4 init.js:7
Loading Utils utils.js:7
FSSDK: webSocket: onopen: top: url:ws://prod-wsg04.goko.com:80 FSSDK.js:13482
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13525
Loading Settings Dialog settingsDialog.js:7
Loading Notifications Module notifications.js:10
Loading Kingdom Generator kingdom_generator.js:7
Loading autokick autokick.js:7
Loading Always Stack alwaysStack.js:7
Loading Module Loader chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:7
[GSFN.Widget.Shell.initialize] loader.js:1
initMeetingRoom DominionClient.js:292
This element isn't a canvas - TypeError: Object #<HTMLDivElement> has no method 'getContext' FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L607.5px T0px FSSDK.Notifier.js:115
Successfully subscribed to player notifications FSSDK.js:20333
Starting module User Settings Dialog chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:50
Starting module Notifications chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Lobby Ratings chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Deck Tracker chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Table State chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module autokick chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Blacklist chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Avatars chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Kingdom Generator chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Sidebar chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Prettified Log Viewer chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Chat Box chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module VP Calculator chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module VP Toggle chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module VP Counter chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Always Stack chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Automatch Game Popup chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Automatch Offer Popup chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Automatch Seek Popup chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Automatch chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Failed to load resource chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/images/ui-bg_fine-grain_10_c3c3c3_60x60.png
Personal currencyClient.js:64
Avatar Inventory currencyClient.js:64
King's Royal Court currencyClient.js:64
[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4 loader.js:1
Failed to load resource chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/images/ui-bg_fine-grain_20_cbaa6e_60x60.png
clicked notifications.js:63
Create achievements response: 
Object
 DominionClient.js:740
Time: 0.928 seconds FS.DeckBuilder.js:1293
FSSDK - called our ClientGameInstance constructor DominionGameClient.js:117
using query parameters for canvas size: 960 640 DominionUI.js:3952
calling FS.Advertising DominionGameClient.js:203
callback from FS.Advertising DominionGameClient.js:210
Using layout: layout960x640 DominionUI.js:1486
Room Chat: florrat: The VP Counter is ON because all the other players are bots. utils.js:11
Room Chat: florrat: Say "#vphelp" for more info. utils.js:11
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febdb067a04f40bcdecc6b9.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
creating dominionwindow DominionUI.js:13170
using card buidler. DominionUI.js:3739
canvas size: 960 640 layoutSize: [size 960 640] DominionUI.js:11360
using requestAnimationFrame DominionUI.js:13246
Hovel utils.js:11
trashed card: [Hovel] utils.js:11
Hovel utils.js:11
trashed card: [Hovel] utils.js:11
Mining Village utils.js:11
trashed card: [Mining Village] utils.js:11
Mining Village utils.js:11
trashed card: [Mining Village] utils.js:11
destroying  fan: hand DominionUI.js:6864
destroying flat: reveal DominionUI.js:6873
destroying deck: deck DominionUI.js:6868
destroying deck: discard DominionUI.js:6868
destroying flat: durationMat DominionUI.js:6873
destroying  fan: hand DominionUI.js:6864
destroying flat: reveal DominionUI.js:6873
destroying deck: deck DominionUI.js:6868
destroying deck: discard DominionUI.js:6868
destroying flat: durationMat DominionUI.js:6873
destroyed PlayerController DominionUI.js:13286
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febdb067a04f40bcdecc6b9.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/508574f80cf270038ff91f3c.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cda39e4b082c74d7a4b14.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50797e04fca2ca7237eeb056.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5063cfb10cf2b1ff4173e1b7.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d3d96e4b082c74d7b57e2.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d703ee4b082c74d7bfdcf.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516ccffbe4b082c74d79ff3c.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d31e6e4b082c74d7b33b2.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1


Code: [Select]
gatherUrlCookieParams found the following URL params:
Array[1]
 FSSDK.js:553
ConnectionMaker found the following cookie params:
FS.Utils.InfoCookie
 FSSDK.js:560
ConnectionMaker merged the following cookie params:
Array[1]
 FSSDK.js:566
FS.MessageWebSocketConnection.prototype.connect: currently trying - ws://prod-wsg04.goko.com:80 FSSDK.js:13427
FSSDK: webSocket: onopen: top: url:ws://prod-wsg04.goko.com:80 FSSDK.js:13482
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13525
initMeetingRoom DominionClient.js:292
This element isn't a canvas - TypeError: Object #<HTMLDivElement> has no method 'getContext' FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L607.5px T0px FSSDK.Notifier.js:115
Successfully subscribed to player notifications FSSDK.js:20333
[GSFN.Widget.Shell.initialize] loader.js:1
Running Goko Salvager 2.3.4 init.js:7
Loading Utils utils.js:7
Loading Settings Dialog settingsDialog.js:7
Loading Notifications Module notifications.js:10
Loading Kingdom Generator kingdom_generator.js:7
Loading autokick autokick.js:7
Loading Always Stack alwaysStack.js:7
Loading Module Loader chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:7
Starting module User Settings Dialog chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Notifications chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Lobby Ratings chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Deck Tracker chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Table State chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module autokick chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Blacklist chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Avatars chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Kingdom Generator chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Sidebar chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Prettified Log Viewer chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Chat Box chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module VP Calculator chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module VP Toggle chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module VP Counter chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Always Stack chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Automatch Game Popup chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Automatch Offer Popup chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Automatch Seek Popup chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Starting module Automatch chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/module_loader.js:39
Failed to load resource chrome-extension://mpdfbpmdilefgbkgcpndgadifgahkkgo/images/ui-bg_fine-grain_10_c3c3c3_60x60.png
[GSFN.Widget.initialize] 2030 -- jquery version: 1.6.4 loader.js:1
Create achievements response: 
Object
 DominionClient.js:740
XHR finished loading: "http://api.gameanalytics.com/1/97b7f5082cb3f71a137646605b09fe8a/user".
Automatch script loaded. utils.js:11
Initializing automatch. utils.js:11
Initializing Automatch utils.js:11
Connecting to Automatch server at wss://andrewiannaccone.com/automatch utils.js:11
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50b83d10e4b015dcbac5ebb1.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d771ee4b082c74d7c11fa.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/512bb1dbe4b0c02658febf1c.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5143eac9e4b0f496b6dd69bb.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d31f8e4b082c74d7b33ee.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d76f7e4b082c74d7c1188.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/510ca59ce4b02265335fddc6.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/512426c5e4b0bfc020b201bb.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50e938a8e4b0750f9b39d407.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d337ae4b082c74d7b38cb.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513befabe4b0da6e3de05837.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd6d0e4b082c74d7a3500.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d24b2e4b082c74d7b0781.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d28eae4b082c74d7b1612.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/514fd1cae4b0b79c883bbbe5.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d518ee4b082c74d7b9cd3.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/517c2de8e4b07cbd3b35b190.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d78ebe4b082c74d7c171c.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/506b004f0cf2c3b232a28435.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d3a25e4b082c74d7b4d7d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d2c1ee4b082c74d7b20b6.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5067a563a2e6086ef3c5a031.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5146a2c4e4b0bef57ec886f9.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/4febcf827a04f40bcdecc6b7.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5143f0b0e4b08529f80f9937.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/506f5eb6a2e63ef582b4e7ef.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d13a9e4b082c74d7ac66e.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d3f07e4b082c74d7b5c32.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d2a8ce4b082c74d7b1b9d.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5150fcbbe4b0b79c883bd312.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d5db4e4b082c74d7bc5bc.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5146a736e4b0f922253718ab.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d4119e4b082c74d7b6259.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513ce7a8e4b0da6e3de06985.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd5d8e4b082c74d7a2db6.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/511509cde4b05d0fdbb6607b.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5142173fe4b0434d02d09a9b.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d4b3fe4b082c74d7b866e.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d12a8e4b082c74d7ac27b.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516cd48fe4b082c74d7a2465.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513779f1e4b006f8dc8ccbf6.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513a371ee4b079bc05b01f3e.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513a0105e4b05fa06a311a11.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d575fe4b082c74d7bb0c8.png
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d263fe4b082c74d7b0ceb.png
3
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5177ecf1e4b0af878030b1f3.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d392de4b082c74d7b4a89.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/513b2eb3e4b05fa06a3133b9.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d04e1e4b082c74d7a833c.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Connected to Automatch server. utils.js:11
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/5143ebcce4b0434d02d0beae.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50afba85e4b0258f50b26805.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d24b0e4b082c74d7b0778.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/508e52cc0cf20691e0b37f4a.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/50b0d031e4b0c5dcbb3e0420.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Automatch server closed websocket. utils.js:11
Automatch connection failure: 1/100 utils.js:11
Not attempting to reconnect to automatch server. utils.js:11
Entered lobby: 5027185e14b17abbe2065298 utils.js:11
Connecting to Automatch server at wss://andrewiannaccone.com/automatch utils.js:11
Connected to Automatch server. utils.js:11
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/517e1ec1e4b0b903ada067cb.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516d8221e4b082c74d7c3090.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Running ping loop utils.js:11
Sending ping utils.js:11
Sent PING message to Automatch server: utils.js:11
Object
 utils.js:11
Got CONFIRM_RECEIPT message from Automatch server: utils.js:11
Object
 utils.js:11
Receipt of message confirmed: florrat1380604707781 utils.js:11
Title: Re: Goko Dominion Salvager Discussion
Post by: amalloy on October 01, 2013, 02:10:10 am
In version 2.3.4, when I join a game with #vpon in the title, this is how the chat starts:

Quote
Alan Malloy: I am using a VP counter (gokosalvager.com). Say #vp? to see the score in chat or #vphelp for more info.
Alan Malloy: #vpon
Alan Malloy: I'd like to use a VP counter (See gokosalvager.com). You can say "#vpoff" before Turn 5 to disallow it, or "#vp?" to see the score in chat. Say "#vphelp" for more info.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on October 01, 2013, 02:57:53 am
Thanks amalloy and florrat (and yed for testing and posting straight to github).

-My own custom avatar doesn't seem to work anymore. Anytime I open the game (100% of the ~20 times I refreshed) the Goko avatar is displayed. I also cannot click on this avatar (to change it). When I go to the multiplayer lobby, my own avatar is a standard Goko avatar, but I do see custom avatars of others. Also, in games (and on score screens), my custom avatar is displayed. Below are two logs with a lot of "Failed to load resource"-errors, which are probably related (most - but not all - of them say they fail to load some avatar image). The top log is the log of playing the game against a bot, the bottom log is of joining the multiplayer lobby.

The avatars module is due for a serious overhaul. The "Failed to load resource errors" are because it's looking on retrobox for every player's avatar image, regardless of whether they have one registered or not. Your own avatar is failing to show up because the original GreaseMonkey code relied on running immediately after the Goko page loaded, which I basically can't do in the current addon/extension implementation. I don't want to prioritize these fixes over automatch or vp counter issue, so avatars just may not work quite right in this version.

Quote
-When I type #vphelp I get all messages twice, once sent by "**" and once sent by "florrat". (this is in games against bots)

Will fix. I need to intercept the chat messages that are actually VP counter commands. Edit: fixed in v2.3.4.2

Quote
-[non-reproducible error] In one game the vp tracker didn't work. I think it showed the players of the game I played before that game, but the VP-amounts had - AFAIK - no relation to either the current or the previous game. Attached you'll find a screenshot. When trying to give commands in chat (#vp? or #vphelp), nothing happened: my message didn't display, and I didn't get any response (I could send other non-command messages). I forgot to copy the log. Probably this isn't that helpful until I find a way to reproduce it, but I wanted to report it anyway.

Definitely a high priority fix. I'll try to reproduce it. Send me a log if you can.

Quote
- The log only fills part of the space next to the game (see attached screenshot).

Do you have the sidebar chat option disabled? It looks like it's trying to make space for the chat area anyway. Edit: yeah, that was it. Fixed in this commit (https://github.com/aiannacc/Goko-Salvager/commit/e72d2a80863505d5307a77ee624ee41cfb48ced2), will be released in v2.3.4.3

In version 2.3.4, when I join a game with #vpon in the title, this is how the chat starts:

Quote
Alan Malloy: I am using a VP counter (gokosalvager.com). Say #vp? to see the score in chat or #vphelp for more info.
Alan Malloy: #vpon
Alan Malloy: I'd like to use a VP counter (See gokosalvager.com). You can say "#vpoff" before Turn 5 to disallow it, or "#vp?" to see the score in chat. Say "#vphelp" for more info.

Will fix. Edit: fixed in v2.3.4.2
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on October 01, 2013, 09:28:53 am
-My own custom avatar doesn't seem to work anymore. Anytime I open the game (100% of the ~20 times I refreshed) the Goko avatar is displayed. I also cannot click on this avatar (to change it). When I go to the multiplayer lobby, my own avatar is a standard Goko avatar, but I do see custom avatars of others. Also, in games (and on score screens), my custom avatar is displayed. Below are two logs with a lot of "Failed to load resource"-errors, which are probably related (most - but not all - of them say they fail to load some avatar image). The top log is the log of playing the game against a bot, the bottom log is of joining the multiplayer lobby.

The avatars module is due for a serious overhaul. The "Failed to load resource errors" are because it's looking on retrobox for every player's avatar image, regardless of whether they have one registered or not. Your own avatar is failing to show up because the original GreaseMonkey code relied on running immediately after the Goko page loaded, which I basically can't do in the current addon/extension implementation. I don't want to prioritize these fixes over automatch or vp counter issue, so avatars just may not work quite right in this version.

I'd like to put in my vote that automatch should be last priority after making sure everything else works.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on October 01, 2013, 03:36:32 pm
The avatars module is due for a serious overhaul. The "Failed to load resource errors" are because it's looking on retrobox for every player's avatar image, regardless of whether they have one registered or not. Your own avatar is failing to show up because the original GreaseMonkey code relied on running immediately after the Goko page loaded, which I basically can't do in the current addon/extension implementation. I don't want to prioritize these fixes over automatch or vp counter issue, so avatars just may not work quite right in this version.

I'd like to put in my vote that automatch should be last priority after making sure everything else works.

"After making sure everything else works" is a reasonable-sounding goal that stops development dead. It's how you wind up with a space shuttle that has less computing power than an Xbox.

Still, I'll consider it if you'll be more precise. Which of these do you mean?
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on October 01, 2013, 03:54:36 pm
The avatars module is due for a serious overhaul. The "Failed to load resource errors" are because it's looking on retrobox for every player's avatar image, regardless of whether they have one registered or not. Your own avatar is failing to show up because the original GreaseMonkey code relied on running immediately after the Goko page loaded, which I basically can't do in the current addon/extension implementation. I don't want to prioritize these fixes over automatch or vp counter issue, so avatars just may not work quite right in this version.

I'd like to put in my vote that automatch should be last priority after making sure everything else works.

"After making sure everything else works" is a reasonable-sounding goal that stops development dead. It's how you wind up with a space shuttle that has less computing power than an Xbox.

Still, I'll consider it if you'll be more precise. Which of these do you mean?
  • "I prefer custom avatars to automatch, Isotropish ratings, challenges, veto mode, and any other proposed improvements."
  • "I want you to put in as much time as it takes to keep improving the extension without ever breaking an existing feature."
  • "The GreaseMonkey script version was perfect. Please help me find it again."
  • "I'm willing to help out with testing and development."

Sorry, I'll try to be more precise.


As someone who never has trouble finding a game, I consider automatch a waste of time and resources. I wouldn't be against its development except for two reasons:

• From the little I understand, it's more invasive to Goko than any of the other features. It's my understanding that it basically puts you in several lobbies at once. That seems like something that Goko is likely to eventually crack down on. It's quite possible I'm misinformed about this.
• It seems to me (emphasis on seems) that ever since work started on automatch, other features (which I do use) have been breaking with increasing frequency.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on October 01, 2013, 03:57:22 pm
Automatch doesn't put you in multiple lobbies at once (and you can do that anyway with normal Goko, just have multiple tabs).  Automatch uses a third party to find someone else looking there as well to find a game.  You can only automatch with other people looking for an automatched game.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on October 01, 2013, 04:50:17 pm
Sorry, I'll try to be more precise.

  • "I prefer custom avatars, Isotropish ratings, challenges, veto mode, and any other proposed improvements to automatch."
  • "I want you to put in as much time as it takes to keep improving the extension without ever breaking an existing feature except automatch, which I don't care about."
  • "I'm willing to help out with testing, except with automatch."

As someone who never has trouble finding a game, I consider automatch a waste of time and resources. I wouldn't be against its development except for two reasons:

• From the little I understand, it's more invasive to Goko than any of the other features. It's my understanding that it basically puts you in several lobbies at once. That seems like something that Goko is likely to eventually crack down on. It's quite possible I'm misinformed about this.
• It seems to me (emphasis on seems) that ever since work started on automatch, other features (which I do use) have been breaking with increasing frequency.

sudgy is correct. Automatch imposes zero additional strain on Goko. It also isn't responsible for bugs elsewhere in Salvager. There have been four big things that have happened since I started on automatch that are causing problems, but they're not directly related to it:

First, I rewrote a bunch of code to try to satisfy Mozilla and put the extension in the Firefox add-on library. This was a huge mistake. I introduced a bunch of new bugs and we neither had regression testing in place nor enough beta testers. I should have waited a lot longer before releasing that version.

Second, I rewrote the VP counter code to reduce all the chatter. This turned out to be way more complicated than I'd realized. I finally ended up writing 42 QUnit test cases to deal with all the possible ways the counter is supposed to turn on and off and explain itself to users. I think that may just about do it.

Third, there were features in the extension left over from the GM script that relied on really precise timing and were occasionally breaking as a result. When I added code to deal with this I introduced more problems than I solved. I believe the current beta fixes this for everything except avatars, which I simply haven't treated as a priority.

Fourth and most importantly, michaeljb signed out. He did a lot of great work on the extension, and he had also been keeping my reckless tendencies in check. yed and amalloy continue to test and making contributions on github, and I don't mean to diminish the testing and reports people have submitted here. But michaeljb had been doing a whole lot of development and it's a lot tougher without him.

So you can blame me for the bugs, not automatch. And if you're serious about volunteering to test, I really would appreciate the help. More testing is really the only way to get these bugs out before I do official releases.
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on October 01, 2013, 05:24:46 pm
I wish I still had time to work on it! Silly degree taking up so much time...
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on October 01, 2013, 05:59:40 pm
I just wanted to thank you for your efforts.  Goko is, like, usable now.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on October 01, 2013, 06:37:54 pm
Sign me up for testing! I don't have as much time as I used to, but I'll try to help. Just explain how I can test. I'm rather browser-extension illiterate, I'm afraid.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on October 01, 2013, 06:56:08 pm
Sign me up for testing! I don't have as much time as I used to, but I'll try to help. Just explain how I can test. I'm rather browser-extension illiterate, I'm afraid.

Nothing technical. I just need people here to encounter and report the bugs before I release to the general public. My last release was a bit of a disaster and I want to make sure it's more polished this time.

Install the beta version (http://forum.dominionstrategy.com/index.php?topic=8163.msg299266#msg299266) and turn on extra logging. Then just play normally but change the options around every game or two. Try to use a wide range of options, including multiple browsers if you can.

Whenever something looks wrong, take a screenshot, copy the log (http://forum.dominionstrategy.com/index.php?topic=8163.msg297780#msg297780) and post the problem here or on the github issues list (https://github.com/aiannacc/Goko-Salvager/issues?milestone=none&state=open).
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on October 02, 2013, 09:41:50 am
Some minor issues:
The log sometimes is displayed in the lobby.
The scrollbar for the awesome new chat is not fully on the screen.


The vp counter notifications are still a bit off.
Quote
*** The VP Counter is ON and LOCKED because the table name contained "#vpon"
*** Say "#vphelp" for more info.
Watno I have joined the game.
[..., continues at about turn 2]
Watno I am using a VP counter (gokosalvager.com). Say #vp? to see the score in chat or #vphelp for more info.
Watno #vpon
Watno I'd like to use a VP counter (See gokosalvager.com). You can say "#vpoff" before Turn 5 to disallow it, or "#vp?" to see the score in chat. Say "#vphelp" for more info.

Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on October 03, 2013, 04:35:33 pm
The vp counter notifications are still a bit off.
Quote
*** The VP Counter is ON and LOCKED because the table name contained "#vpon"
*** Say "#vphelp" for more info.
Watno I have joined the game.
[..., continues at about turn 2]
Watno I am using a VP counter (gokosalvager.com). Say #vp? to see the score in chat or #vphelp for more info.
Watno #vpon
Watno I'd like to use a VP counter (See gokosalvager.com). You can say "#vpoff" before Turn 5 to disallow it, or "#vp?" to see the score in chat. Say "#vphelp" for more info.

I believe this is fixed in a more recent beta. The current version is v2.3.4.4

If you're in Chrome, you may need to enable "developer mode" or manually update your extensions to get the beta updates. If you're in Firefox, you may need to make sure automatic updating is enabled. I'm not sure about Safari.

Auto-updating extensions is trickier than I'd expected. It kinda looks like the major browsers all implemented it and then decided it was a security risk and broke it in various ways. Like Chrome extensions silently disabling themselves if you change the permission requests.
Title: Re: Goko Dominion Salvager Discussion
Post by: jaybeez on October 03, 2013, 07:58:39 pm
I was thinking last night about how much Goko Salvager does to, well, salvage the experience of playing Dominion on Goko.  It's great, and I really appreciate all the hard work that's been done on it, by Andrew/ragingduckd, michaeljb, and nutki (and maybe others I'm not aware of?) 

I was thinking, I'd like to make a small donation as a token of my appreciation.  Any way I can do that?  Maybe it'll be too logistically complicated since there are a number of contributors, but I just wanted to throw it out there anyway.
Title: Re: Goko Dominion Salvager Discussion
Post by: AdamH on October 04, 2013, 10:16:08 am
The log sometimes is displayed in the lobby.

I'm likely in the minority here, but I would actually prefer (at least the option to) have the log visible at all times when Goko is loaded. This is primarily to help with video-making setup.
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on October 09, 2013, 12:35:03 pm
Feature request:
It would be cool to make a list with friends, just like the blacklist. Automatch will check this people before others, so that you can play with them more often.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on October 09, 2013, 12:41:39 pm
The log sometimes is displayed in the lobby.

I'm likely in the minority here, but I would actually prefer (at least the option to) have the log visible at all times when Goko is loaded. This is primarily to help with video-making setup.
Yeah, why did I never suggest that. that woukd be really cool. Often while waiting for a game, I try to remember something from the last one and can't. In fact I even try to find what I'm looking for when the log pops back up while the next game is loading (which of course is impossible in that short time)
Title: Re: Goko Dominion Salvager Discussion
Post by: ShinKyo on October 09, 2013, 06:02:34 pm
Thanks for the great plugin! Is there an option to turn off the VP-Counter but still show the log? By the way if the plugin doesn't start it helped me to deactivate it in Chrome once and then activate it again after restart.
For all who sometimes want to play with the recommed sets from the original rules: I have extracted all sets out of the rules and format them a bit so that you only have to copy/paste it for the plugin. But at the two sets with fixed bane card I don't know how it works. I'm not sure if you can specify a bane card as 11th card there.
Dominion-Sets for Goko Dominion Salvager Plugin (http://www.file-upload.net/download-8161413/Dominion---Sets.txt.html)
Title: Re: Goko Dominion Salvager Discussion
Post by: GeoLib on October 09, 2013, 07:26:05 pm
Thanks for the great plugin! Is there an option to turn off the VP-Counter but still show the log? By the way if the plugin doesn't start it helped me to deactivate it in Chrome once and then activate it again after restart.
For all who sometimes want to play with the recommed sets from the original rules: I have extracted all sets out of the rules and format them a bit so that you only have to copy/paste it for the plugin. But at the two sets with fixed bane card I don't know how it works. I'm not sure if you can specify a bane card as 11th card there.
Dominion-Sets for Goko Dominion Salvager Plugin (http://www.file-upload.net/download-8161413/Dominion---Sets.txt.html)

If you go to user settings on the main goko page under your avatar you can change the settings (including automatically turning off the vp counter). You can also type #vpoff in the chat.

Specifying the bane merely requires putting in 11 cards with one of the first 10 being young witch. Full instructions here http://dom.retrobox.eu/kingdomgenerator.html
Title: Re: Goko Dominion Salvager Discussion
Post by: ShinKyo on October 10, 2013, 04:57:35 am
Thanks for the great plugin! Is there an option to turn off the VP-Counter but still show the log? By the way if the plugin doesn't start it helped me to deactivate it in Chrome once and then activate it again after restart.
For all who sometimes want to play with the recommed sets from the original rules: I have extracted all sets out of the rules and format them a bit so that you only have to copy/paste it for the plugin. But at the two sets with fixed bane card I don't know how it works. I'm not sure if you can specify a bane card as 11th card there.
Dominion-Sets for Goko Dominion Salvager Plugin (http://www.file-upload.net/download-8161413/Dominion---Sets.txt.html)

If you go to user settings on the main goko page under your avatar you can change the settings (including automatically turning off the vp counter). You can also type #vpoff in the chat.

Specifying the bane merely requires putting in 11 cards with one of the first 10 being young witch. Full instructions here http://dom.retrobox.eu/kingdomgenerator.html
I know the User Settings window. But to set #vpoff doesn't work. I don't want to type it everytime in the chat.
With the 11th card as a bane I figured out by myself. I overlooked the part in the instructions at retrobox.
Title: Re: Goko Dominion Salvager Discussion
Post by: hsiale on October 10, 2013, 05:31:21 am
I always play with points counter. My table name contains #vpon, so when I play a game and someone types #vpoff, the message "Sorry, point counter locked to ON due to #vpon in table name" appears and nothing happens. But during automatch games the table name gets changed to "For whomever I play" and in those games my opponent can turn the point counter off. Is it possible to add #vpon to automatch table name whenever the automatch is triggered by creating a table that has #vpon?
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on October 10, 2013, 07:48:08 am
I always play with points counter. My table name contains #vpon, so when I play a game and someone types #vpoff, the message "Sorry, point counter locked to ON due to #vpon in table name" appears and nothing happens. But during automatch games the table name gets changed to "For whomever I play" and in those games my opponent can turn the point counter off. Is it possible to add #vpon to automatch table name whenever the automatch is triggered by creating a table that has #vpon?
How about first go through current issues list on github?
https://github.com/aiannacc/Goko-Salvager/issues/36
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on October 10, 2013, 08:54:22 am
I always play with points counter. My table name contains #vpon, so when I play a game and someone types #vpoff, the message "Sorry, point counter locked to ON due to #vpon in table name" appears and nothing happens. But during automatch games the table name gets changed to "For whomever I play" and in those games my opponent can turn the point counter off. Is it possible to add #vpon to automatch table name whenever the automatch is triggered by creating a table that has #vpon?
How about first go through current issues list on github?
https://github.com/aiannacc/Goko-Salvager/issues/36

How about not discouraging people from making whatever suggestions they feel like making? :P You want to lower the cost to people giving feedback as much as possible, not raise unnecessary hoops.

I didn't know about that particular GitHub page until you linked it, I'm not planning to check it again in the future before making any suggestion and I certainly don't expect people who aren't hardcore programmers to do so either.

Furthermore, there is actually valuable information contained in a repeat suggestion: it shows that the issue matters to more people, so that if you care a lot about user satisfaction, you know what to prioritize. For me, this issue makes me very reluctant to accept auto-matches against unknowns, because I just really hate playing without point tracker.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on October 10, 2013, 09:15:23 am
I always play with points counter. My table name contains #vpon, so when I play a game and someone types #vpoff, the message "Sorry, point counter locked to ON due to #vpon in table name" appears and nothing happens. But during automatch games the table name gets changed to "For whomever I play" and in those games my opponent can turn the point counter off. Is it possible to add #vpon to automatch table name whenever the automatch is triggered by creating a table that has #vpon?
How about first go through current issues list on github?
https://github.com/aiannacc/Goko-Salvager/issues/36

How about not discouraging people from making whatever suggestions they feel like making? :P You want to lower the cost to people giving feedback as much as possible, not raise unnecessary hoops.

I didn't know about that particular GitHub page until you linked it, I'm not planning to check it again in the future before making any suggestion and I certainly don't expect people who aren't hardcore programmers to do so either.

Furthermore, there is actually valuable information contained in a repeat suggestion: it shows that the issue matters to more people, so that if you care a lot about user satisfaction, you know what to prioritize. For me, this issue makes me very reluctant to accept auto-matches against unknowns, because I just really hate playing without point tracker.

Issues page is linked from Salvanger description post.
http://forum.dominionstrategy.com/index.php?topic=9198.msg283465#msg283465

Sorry hsiale, I'm not in a good mood today. I should have just linked there.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on October 10, 2013, 09:51:37 am
In defense of yed's irritability...

It's hard to appreciate just how terrible forum threads are for tracking issues until you try using one yourself. The github issue tracker makes remembering, updating, and prioritizing issues sooo much easier. Any feedback is informative, but that doesn't make developers eager to receive feature requests on postcards or by telephone.

Personally, I also really like it when someone goes a little out of their way to submit an issue on github, or does some beta testing, or even just posts a bug report that includes a log or screenshot. Upvotes and complimentary posts aren't nearly as encouraging as seeing users put in just a little effort. Maybe that's petty, but Salvager is a labor of love. If you want your developers to keep loving their labor, then it's prudent to cater to their emotional foibles. ;)

Whether you agree with any of this or not, you're just a whole lot more likely to get your bug report or feature request dealt with if you post it on github. I'll try to find some way to make the link more conspicuous.
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on October 10, 2013, 12:13:02 pm
I'll try to find some way to make the link more conspicuous.
your signature perhaps?
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on October 10, 2013, 12:30:07 pm
Any feedback is informative, but that doesn't make developers eager to receive feature requests on postcards or by telephone.

Man, couldn't you have told me this before I dispatched my messenger pigeon across the Atlantic, a measure I was forced to take only because you ignored my prior smoke signals?
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on October 10, 2013, 03:11:30 pm
I'll try to find some way to make the link more conspicuous.
your signature perhaps?

I wouldn't count on it.
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on October 10, 2013, 03:46:53 pm
From now on I will keep the current state of the extension in this post. Please report any issues or ideas below.

Maybe this should be replaced with "... ideas on github: LINK"
Title: Re: Goko Dominion Salvager Discussion
Post by: quiteunicorn on October 16, 2013, 12:18:39 pm
so.... newbie question, be gentle ;)
I love the idea of the Salvager extension and downloaded it in the Chrome webstore, but now what....? none of the nifty features are showing up? Do I need to "activate" it somehow? What am I missing??

Thank you so much for your help!
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on October 16, 2013, 02:12:52 pm
so.... newbie question, be gentle ;)
I love the idea of the Salvager extension and downloaded it in the Chrome webstore, but now what....? none of the nifty features are showing up? Do I need to "activate" it somehow? What am I missing??

Thank you so much for your help!
You might have to refresh the Goko page sometimes if the User Settings button doesn't show below the Logout button.
Title: Re: Goko Dominion Salvager Discussion
Post by: quiteunicorn on October 16, 2013, 02:19:38 pm
it worked! Thank you, I can't wait to check it out!
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on October 17, 2013, 12:58:38 am
Hey folks. Just FYI, the current beta (https://www.gokosalvager.com:8888/v2.3.4.8/index.html) looks very reliable except for the launch screen issues (https://github.com/aiannacc/Goko-Salvager/issues/144), which I still can't figure out how to fix.  I'm sure it's Goko's fault, but I don't understand it well enough to blame them properly. :P

(http://s.quickmeme.com/img/0b/0b4ac5edb6319a661cc299a610aa62906a1ba0f4eabfbe86e0e12f36f697269d.jpg)

And what the hell, quickmeme? No font options?

Edit: Many thanks to serakfalcon for looking into this.  I've added a detailed comment on github about why this is difficult and how I've tried to solve it.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on October 19, 2013, 04:19:02 pm
Feature request: the option to display the number of cards left in the piles on the second page somewhere (that doesn't require clicking a button during a game).
Title: Re: Goko Dominion Salvager Discussion
Post by: blueblimp on October 20, 2013, 02:55:45 pm
Feature request (that has probably been posted already, but inline search is not cooperating with me): when using automatch from Create Game, if "#vpon" or "#vpoff" is in the title of the game I made, respect that when finding opponents and put the appropriate title in the name of the automatch game. I suppose the manual automatch should also support preferences here.

Rules:

I love the Create Game automatch, since it makes finding a game so easy, and usually I'm very happy with the pairing when automatch finds a game. It's just frustrating the times that I'm matched with somebody who forces #vpoff, since I don't really enjoy playing without the counter.

Edit: Well now search is cooperating and I see that it has been posted a couple times already:
http://forum.dominionstrategy.com/index.php?topic=8163.msg302991#msg302991 (http://forum.dominionstrategy.com/index.php?topic=8163.msg302991#msg302991)
https://github.com/aiannacc/Goko-Salvager/issues/36 (https://github.com/aiannacc/Goko-Salvager/issues/36)
So consider this another vote then. :)
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on October 20, 2013, 05:19:03 pm
Feature request (that has probably been posted already, but inline search is not cooperating with me): when using automatch from Create Game, if "#vpon" or "#vpoff" is in the title of the game I made, respect that when finding opponents and put the appropriate title in the name of the automatch game. I suppose the manual automatch should also support preferences here.

Rules:
  • #vpon players should not be matched with #vpoff players.
  • If either player is #vpon, then #vpon goes in the game name.
  • If either player is #vpoff, then #vpoff goes in the game name.

I love the Create Game automatch, since it makes finding a game so easy, and usually I'm very happy with the pairing when automatch finds a game. It's just frustrating the times that I'm matched with somebody who forces #vpoff, since I don't really enjoy playing without the counter.

Edit: Well now search is cooperating and I see that it has been posted a couple times already:
http://forum.dominionstrategy.com/index.php?topic=8163.msg302991#msg302991 (http://forum.dominionstrategy.com/index.php?topic=8163.msg302991#msg302991)
https://github.com/aiannacc/Goko-Salvager/issues/36 (https://github.com/aiannacc/Goko-Salvager/issues/36)
So consider this another vote then. :)
I think this could be best done by a choice in automatch-options. "#vpon", "#vpoff" or "doesn't matter". I have #vpoff in my table-names, but I don't care so much about playing with #vpon. So it would be sad not to find games, just because they have #vpon.
Title: Re: Goko Dominion Salvager Discussion
Post by: pst on October 20, 2013, 11:41:37 pm
I love the Create Game automatch, since it makes finding a game so easy, and usually I'm very happy with the pairing when automatch finds a game. It's just frustrating the times that I'm matched with somebody who forces #vpoff, since I don't really enjoy playing without the counter.

This. After I bought a few sets myself I've almost stopped using automatch entirely, since I can get games where I don't have to fear the #vpoff. I just set up my own #vpon tables, and join if I see another #vpon table.
Title: Re: Goko Dominion Salvager Discussion
Post by: Eevee on October 21, 2013, 05:08:32 pm
Is the extension broken somehow? I get the auto-match, but it doesn't save my settings or show the log viewer or the point counter. Basically only thing reminding me of a playable goko is the auto-match button.

// And it's back! Damn, AI.. I you are fast! Took you what, two minutes?
Title: Re: Goko Dominion Salvager Discussion
Post by: mail-mi on October 21, 2013, 05:29:30 pm
Is the extension broken somehow? I get the auto-match, but it doesn't save my settings or show the log viewer or the point counter. Basically only thing reminding me of a playable goko is the auto-match button.

// And it's back! Dang, AI.. I you are fast! Took you what, two minutes?
Just click refresh if you don't see the user settings button on the home page.
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on October 22, 2013, 11:14:00 am
Is automatch down? It has not been working for me today.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on October 22, 2013, 12:41:23 pm
Is automatch down? It has not been working for me today.

Goko hasn't been working recently.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on October 22, 2013, 05:59:49 pm
Is automatch down? It has not been working for me today.

Goko hasn't been working recently.

Fixed.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on November 02, 2013, 10:22:03 am
Feature request: #autovp? chat command to automatically display the VP in the chat at the beginning of each turn.
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on November 02, 2013, 12:16:48 pm
Feature request: #autovp? chat command to automatically display the VP in the chat at the beginning of each turn.

There's the thing at the top right, why would you need this?


Also, I just had a dream where you said you would stop making this extension.  It was horrible.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on November 02, 2013, 12:40:26 pm
Feature request: #autovp? chat command to automatically display the VP in the chat at the beginning of each turn.

There's the thing at the top right, why would you need this?


Also, I just had a dream where you said you would stop making this extension.  It was horrible.
Sometimes I play against people who don't have the thing at the top right.


Who said?
Title: Re: Goko Dominion Salvager Discussion
Post by: sudgy on November 02, 2013, 12:41:45 pm
Feature request: #autovp? chat command to automatically display the VP in the chat at the beginning of each turn.

There's the thing at the top right, why would you need this?


Also, I just had a dream where you said you would stop making this extension.  It was horrible.
Sometimes I play against people who don't have the thing at the top right.


Who said?

AI.
Title: Re: Goko Dominion Salvager Discussion
Post by: pingpongsam on December 11, 2013, 03:13:41 pm
I prefer to never have to play with tournament.

Using "All / Tournament" in Kingdom Selector is ineffective. How do I achieve preventing the inclusion of a specific card?
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on December 11, 2013, 03:39:03 pm
I prefer to never have to play with tournament.

Using "All / Tournament" in Kingdom Selector is ineffective. How do I achieve preventing the inclusion of a specific card?

What do you mean it's ineffective? Seems to work fine for me. Are you sure you spelled Tournament correctly when you tried it?
Title: Re: Goko Dominion Salvager Discussion
Post by: pingpongsam on December 11, 2013, 03:58:30 pm
I prefer to never have to play with tournament.

Using "All / Tournament" in Kingdom Selector is ineffective. How do I achieve preventing the inclusion of a specific card?

What do you mean it's ineffective? Seems to work fine for me. Are you sure you spelled Tournament correctly when you tried it?

I can't be sure because there is no way to check it once it is done that I know of. I can try again and double check the spelling before I submit and then play 500 games until I am satisfied that probability indicates that tournament is being ignored.
Title: Re: Goko Dominion Salvager Discussion
Post by: pingpongsam on December 11, 2013, 04:00:03 pm
While we're at it, is there anyway to fire Kingdom Selector again without logging out of Goko and back in?
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on December 11, 2013, 04:01:42 pm
While we're at it, is there anyway to fire Kingdom Selector again without logging out of Goko and back in?

??? The Kingdom Selector window should be appearing each time Goko tries to randomize a (non-Pro) set. How does it work for you?
Title: Re: Goko Dominion Salvager Discussion
Post by: pingpongsam on December 11, 2013, 04:03:48 pm
Well, I only play pro so I get it once when I first load the create game wizard.

Also, I just logged out and back in and no effect. I apparently have to delete cookies to be able to fire kingdom-selector again.

Anyway, I think I just figured out that I am not going to be able to use Kingdom Selector to filter cards out of a pro game which makes unfortunate sense.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on December 11, 2013, 04:18:46 pm
Anyway, I think I just figured out that I am not going to be able to use Kingdom Selector to filter cards out of a pro game which makes unfortunate sense.

Bingo. That's it.
Title: Re: Goko Dominion Salvager Discussion
Post by: serakfalcon on December 11, 2013, 07:34:48 pm
Well, I only play pro so I get it once when I first load the create game wizard.

Also, I just logged out and back in and no effect. I apparently have to delete cookies to be able to fire kingdom-selector again.

Anyway, I think I just figured out that I am not going to be able to use Kingdom Selector to filter cards out of a pro game which makes unfortunate sense.

Yes. The kingdom selector isn't supposed to fire AT ALL in pro, but haven't been able to fix that yet. so sorry about the confusion.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on December 15, 2013, 04:01:37 pm
Automatch seems to be offline.
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on January 11, 2014, 09:29:35 am
(this may have been asked before, but reading  20+ pages is a bit overkill)

i just installed the addon, and noticed that it contains a vp counter, which also works if you enable "always refuse (#vpoff)" in the settings. so, is there no way to disallow vp counters for your enemy? that would really suck because i consider counting vp's an element of skill and everything that makes the game more skill heavy is a good thing. i can of course disable the "show vp counter and log in sidebar" but that doesn't really fix the problem, it just makes things unfair.

i also don't like that it shows the game log, but since goko does that too i can't really complain
Title: Re: Goko Dominion Salvager Discussion
Post by: Watno on January 11, 2014, 09:33:30 am
If you activate the option "always refuse (#vpoff)", or manually type #vpoff in the game name or chat at the start of the game, the vp counter is disabled for all players in the game (unless they hacked their copy of the extension).
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on January 11, 2014, 09:35:24 am
If you activate the option "always refuse (#vpoff)", or manually type #vpoff in the game name or chat at the start of the game, the vp counter is disabled for all players in the game (unless they hacked their copy of the extension).

but i did activate that option and it still counted vp's
Title: Re: Goko Dominion Salvager Discussion
Post by: jsh357 on January 11, 2014, 10:17:59 am
For the record: the reason I use the point counter is that Goko displays the entire log.  It prevents both me and my opponent from having to scroll up and check on things.  I agree it's not 'part of the game' but Goko's so slow already that the point counter just helps speed things up.  To each his own, though.  My opponent saying #vpoff definitely disables it on my side.
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on January 11, 2014, 10:18:11 am
If you activate the option "always refuse (#vpoff)", or manually type #vpoff in the game name or chat at the start of the game, the vp counter is disabled for all players in the game (unless they hacked their copy of the extension).

but i did activate that option and it still counted vp's
If you join (or create) a game with #vpon in the title, you cannot turn off the point counter (because the host specified he wanted to play with the point counter). If you host games yourself, you can disable the point counter for both players by putting #vpoff in the title. In all other cases, you can turn off the point counter by saying #vpoff in chat (at the beginning of the game, I think, and if I'm correct this is what the "always refuse"-option does automatically)
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on January 11, 2014, 11:18:25 am
If you activate the option "always refuse (#vpoff)", or manually type #vpoff in the game name or chat at the start of the game, the vp counter is disabled for all players in the game (unless they hacked their copy of the extension).

but i did activate that option and it still counted vp's
If you join (or create) a game with #vpon in the title, you cannot turn off the point counter (because the host specified he wanted to play with the point counter). If you host games yourself, you can disable the point counter for both players by putting #vpoff in the title. In all other cases, you can turn off the point counter by saying #vpoff in chat (at the beginning of the game, I think, and if I'm correct this is what the "always refuse"-option does automatically)

the games where it didnt work were actually created by me... but it works now, so i must have messed up somehow. thanks anyway

theoretically, you could still count vp's by checking the game log, but i guess noone does that
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on January 11, 2014, 12:30:44 pm
Were you playing against just bots? I think it might always be on in such games, regardless of setting.
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on January 12, 2014, 02:05:28 pm
The site http://gokologs.drunkensailor.org/ is down again. Could you restart?
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on January 12, 2014, 02:32:02 pm
Assuming you have restarted it (because it is up now), thanks!

By the way, the link to the newest beta version is down (https://www.gokosalvager.com:8888/v2.3.4.8/index.html, linked in this post (http://forum.dominionstrategy.com/index.php?topic=9198.msg283465#msg283465)). Also, I've had no problems at all with that newest beta version for the last months, so I think you can make it the new official version.

EDIT: I could connect to it once, it is down again :S
Title: Re: Goko Dominion Salvager Discussion
Post by: Lotoreo on January 13, 2014, 04:50:30 am
Hey,

Yes, the link to the beta does not work.. Does anybody have a working link, or can send me a copy of the beta? ;)

I would have another feature request, if it is not asked to much:
Could you add another create game button, that works even if Goko's does not? ;) I read somewhere, that it is possible with only two lines of JS code, but i don't have the console for that. And it should be quite easy to add to the Salvager, right?
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on January 13, 2014, 05:11:59 am
Could you add another create game button, that works even if Goko's does not? ;) I read somewhere, that it is possible with only two lines of JS code, but i don't have the console for that. And it should be quite easy to add to the Salvager, right?
I'm working on this.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on January 13, 2014, 09:47:02 am
Could you add another create game button, that works even if Goko's does not? ;) I read somewhere, that it is possible with only two lines of JS code, but i don't have the console for that. And it should be quite easy to add to the Salvager, right?
I'm working on this.
Done: https://github.com/aiannacc/Goko-Salvager/commits/quick-create-game

Please can someone beta-test this?

In Chrome if you don't know how to build it yourself from github:
http://tash-kalar.singlepicture.org/goko-salvager-quick-create-game-chrome.tar.bz2
unpack it
Tools->Extensions->Remove current Goko Salvager->Developer Mode->Load unpacked extension...->select unpacked directory

EDIT: New is button "Quick Game" next to "Create Game". You can set game name, type and # of players in User Settings.

EDIT2: I have added AutoAutoMatch option for Quick Game button. Beta above is updated
Title: Re: Goko Dominion Salvager Discussion
Post by: Mic Qsenoch on January 13, 2014, 10:25:44 am
Remember that time people thought it was inappropriate to call this thing Goko Salvager?
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on January 13, 2014, 10:46:21 am
Thanks, yed, but this version of Salvager breaks the Kingdom Generator feature for most strings. It just kicks me back to the title screen. The Kingdom Generator is the key feature of Salvager for me, so this doesn't help me much.

EDIT: But just to be clear, I appreciate you adding this feature! I hope to see a version that still works with Kingdom Generator.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on January 13, 2014, 10:55:28 am
Thanks, yed, but this version of Salvager breaks the Kingdom Generator feature for most strings. It just kicks me back to the title screen. The Kingdom Generator is the key feature of Salvager for me, so this doesn't help me much.
I have not been doing anything with that...
Is it ok in latest master version? (http://tash-kalar.singlepicture.org/latest-master-chrome.tar.bz2)
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on January 13, 2014, 11:13:14 am
Thanks, yed, but this version of Salvager breaks the Kingdom Generator feature for most strings. It just kicks me back to the title screen. The Kingdom Generator is the key feature of Salvager for me, so this doesn't help me much.
I have not been doing anything with that...
Is it ok in latest master version? (http://tash-kalar.singlepicture.org/latest-master-chrome.tar.bz2)

Nope, it's broken there too. Any way you could apply your changes to the latest release, rather than the beta?
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on January 13, 2014, 11:15:11 am
(I used the version of your first post)

For me quick game worked. But for me the usual create game button also works...

For me the kingdom generator also did strange things (but I didn't use your latest version). It didn't accept kingdoms other than "All" (only tested 2 other strings), and sometimes when I hit enter (because the OK button doesn't work) the page reloads with URL
http://play.goko.com/Dominion/gameClient.html?selval=All#
(where "All" is the string in the kingdom generator input field). Don't know whether this is helpful or not. I'll try the newer version later.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on January 13, 2014, 11:25:13 am
(I used the version of your first post)

For me quick game worked. But for me the usual create game button also works...

For me the kingdom generator also did strange things (but I didn't use your latest version). It didn't accept kingdoms other than "All" (only tested 2 other strings), and sometimes when I hit enter (because the OK button doesn't work) the page reloads with URL
http://play.goko.com/Dominion/gameClient.html?selval=All#
(where "All" is the string in the kingdom generator input field). Don't know whether this is helpful or not. I'll try the newer version later.
Thank you for the report. Please try it also in latest master version http://tash-kalar.singlepicture.org/latest-master-chrome.tar.bz2
This is the version before I added Quick Game.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on January 13, 2014, 11:42:29 am
(I used the version of your first post)

For me quick game worked. But for me the usual create game button also works...

For me the kingdom generator also did strange things (but I didn't use your latest version). It didn't accept kingdoms other than "All" (only tested 2 other strings), and sometimes when I hit enter (because the OK button doesn't work) the page reloads with URL
http://play.goko.com/Dominion/gameClient.html?selval=All#
(where "All" is the string in the kingdom generator input field). Don't know whether this is helpful or not. I'll try the newer version later.
Thank you for the report. Please try it also in latest master version http://tash-kalar.singlepicture.org/latest-master-chrome.tar.bz2
This is the version before I added Quick Game.

As I already said, it's broken in the latest master version, too. So it's not your code that broke it.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on January 13, 2014, 12:03:46 pm
Ok I have heve found bug which redirects to main. But it does that only when you have error in your string.

All of these works for me:
All - use all the cards
Cellar, Market, Militia, Mine, Moat, Remodel, Smithy, Village, Woodcutter, Workshop - any specific kingdom
Dark Ages - use only Dark Ages cards
Dark Ages + Base Set - use only Dark Ages and base Dominion cards
2 * Dark Ages + Base Set - as above, but cards from Dark Ages are twice as more likely to be chosen
6 Seaside, 4 Base Set - 6 cards from Seaside, others from the base set
All / Alchemy - all but Alchemy cards
Moat, 3 Attack, All - include Moat and at least 3 attack cards
Moat, 3 Attack, All / Attack - include Moat and exactly 3 attack cards
3 (Seaside + Intrigue) * Victory, Seaside + Intrigue - only Seaside and Intrigue, at least 3 victory cards
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on January 13, 2014, 12:12:43 pm
Once I get back to my desk, I can give you specifics, but suffice to say that several strings of 10 Kingdom cards that work with the current release fail with the beta version.

If it matters, I use Chrome.

EDIT: To be clear, the bug that kicks you back to the main screen when you use an invalid string isn't new. What's new is that many strings that were once valid are no longer. For instance, the string "Ambassador" kicks you back to the main screen.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on January 13, 2014, 01:34:21 pm
Aha, I have discovered the issue. It has nothing to do with what the string is. It used to be that if you pressed "Enter" in the text field, it would submit. Now it shoots you back to the title page. If you actually click (or tab to) the "OK" button, it works fine. Seems like it should be an easy fix.
Title: Re: Goko Dominion Salvager Discussion
Post by: LibraryAdventurer on January 13, 2014, 10:55:53 pm
I'm just installed the beta.  The first second thing I noticed was that the setting screen is too big and there's no scrollbar so I can't see the bottom of it.
(The first thing was the nifty change avatar button.)

EDIT: minor feature request: option to look for an either pro or casual game with automatch instead of only one or the other.

EDIT2: It automatically put in my chat window something like "I have joined the game."  Was this something you put in while testing and forgot to remove?  (I've done that same kind of thing before.)
Title: Re: Goko Dominion Salvager Discussion
Post by: Lotoreo on January 14, 2014, 03:04:12 am
Wow, Yed, that really was a fast implementation! I am really impressed!

Concerning the "I have joined the game" String.. could you add a text field to the user settings, where one could replace that String with a custom welcome message? An automatically posted "hi, gl, hf" would save me so many keystrokes.. ;)

Title: Re: Goko Dominion Salvager Discussion
Post by: yed on January 14, 2014, 05:33:24 am
The first second thing I noticed was that the setting screen is too big and there's no scrollbar so I can't see the bottom of it.
Fixed.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on January 14, 2014, 05:37:27 am
Wow, Yed, that really was a fast implementation! I am really impressed!

Concerning the "I have joined the game" String.. could you add a text field to the user settings, where one could replace that String with a custom welcome message? An automatically posted "hi, gl, hf" would save me so many keystrokes.. ;)

What's the point of it though, if it's automated?
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on January 14, 2014, 06:33:47 am
EDIT2: It automatically put in my chat window something like "I have joined the game."  Was this something you put in while testing and forgot to remove?  (I've done that same kind of thing before.)
https://github.com/aiannacc/Goko-Salvager/issues/137
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on January 14, 2014, 06:36:28 am
Ok I have heve found bug which redirects to main. But it does that only when you have error in your string.
https://github.com/aiannacc/Goko-Salvager/issues/155

Aha, I have discovered the issue. It has nothing to do with what the string is. It used to be that if you pressed "Enter" in the text field, it would submit. Now it shoots you back to the title page. If you actually click (or tab to) the "OK" button, it works fine. Seems like it should be an easy fix.
https://github.com/aiannacc/Goko-Salvager/issues/154
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on January 17, 2014, 11:41:20 am
not sure if this request has already been made, but often you get people on auto-match who are afk and then you're basically stuck.  possible solutions include:

as of now, declining turns your automatch off, and if you turn it on again, you're very likely to get the same afk person again.
Title: Re: Goko Dominion Salvager Discussion
Post by: soulnet on January 17, 2014, 12:01:52 pm
not sure if this request has already been made, but often you get people on auto-match who are afk and then you're basically stuck.  possible solutions include:
  • time-out.  both get booted, with bell.  if you're present, you can just turn it back on.
  • if you decline, ban that person from your next auto-match.
  • a separate button for decline and ban.  probably the ban could be temporary, like this session only, or for the next five minutes or something like that.

as of now, declining turns your automatch off, and if you turn it on again, you're very likely to get the same afk person again.

Both you and the person you get automatched with are taken off the queue, so if you get automatch with someone that is AFK, their automatch will be off the next time.
Title: Re: Goko Dominion Salvager Discussion
Post by: ashersky on January 28, 2014, 11:30:12 pm
FYI, Donald X. on Salvager:

Quote
The log and chat window are currently not always present during games. You open them up and they aren't very good. Instead there could be a log on the side of the screen - where the mod puts it. It would be a lot better to be able to always see a log on the screen. And mildly better to have a few lines of chat always there.

Maybe people aren't clamoring for this because they are using the mod. I am not using the mod because I want to know what experience normal people are getting. There's uh this mod someone made, probably you have heard of it. It like adds a log and matchmaking and a point counter. You can see it in youtube videos. And that's why you see games in the lobbies with "#VPOFF" or whatever.

Incidentally I do not mind if you add a point counter. In case you were worried I might mind.
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on January 29, 2014, 04:01:06 pm
FYI, Donald X. on Salvager:

Quote
The log and chat window are currently not always present during games. You open them up and they aren't very good. Instead there could be a log on the side of the screen - where the mod puts it. It would be a lot better to be able to always see a log on the screen. And mildly better to have a few lines of chat always there.

Maybe people aren't clamoring for this because they are using the mod. I am not using the mod because I want to know what experience normal people are getting. There's uh this mod someone made, probably you have heard of it. It like adds a log and matchmaking and a point counter. You can see it in youtube videos. And that's why you see games in the lobbies with "#VPOFF" or whatever.

Incidentally I do not mind if you add a point counter. In case you were worried I might mind.

Where did he post this?
Title: Re: Goko Dominion Salvager Discussion
Post by: 2.71828..... on January 29, 2014, 04:08:31 pm
FYI, Donald X. on Salvager:

Quote
The log and chat window are currently not always present during games. You open them up and they aren't very good. Instead there could be a log on the side of the screen - where the mod puts it. It would be a lot better to be able to always see a log on the screen. And mildly better to have a few lines of chat always there.

Maybe people aren't clamoring for this because they are using the mod. I am not using the mod because I want to know what experience normal people are getting. There's uh this mod someone made, probably you have heard of it. It like adds a log and matchmaking and a point counter. You can see it in youtube videos. And that's why you see games in the lobbies with "#VPOFF" or whatever.

Incidentally I do not mind if you add a point counter. In case you were worried I might mind.

Where did he post this?

In "other suggestions and bug reports (http://forum.makingfun.com/showthread.php?4209-Log-chat&p=21707#post21707)"
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on January 30, 2014, 09:39:14 pm
Where did he post this?

In "other suggestions and bug reports (http://forum.makingfun.com/showthread.php?4209-Log-chat&p=21707#post21707)"

Who is "Making Fun?"  Is Goko transitioning from ignoring us on getsatisfaction to ignoring us there instead?  Does Donald X talk to us on that forum (http://forum.makingfun.com/showthread.php?4199-Wait-on-playing-these-that-s-my-advice) but not on this one (http://forum.dominionstrategy.com/index.php?action=profile;u=19)?
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on January 30, 2014, 09:42:10 pm
Where did he post this?

In "other suggestions and bug reports (http://forum.makingfun.com/showthread.php?4209-Log-chat&p=21707#post21707)"

Who is "Making Fun?"  Is Goko transitioning from ignoring us on getsatisfaction to ignoring us there instead?  Does Donald X talk to us on that forum (http://forum.makingfun.com/showthread.php?4199-Wait-on-playing-these-that-s-my-advice) but not on this one (http://forum.dominionstrategy.com/index.php?action=profile;u=19)?

He'll talk to us on the BGG forums, too. That's always been the case.
Title: Re: Goko Dominion Salvager Discussion
Post by: markusin on February 01, 2014, 05:40:21 pm
Gosh, the Chrome version of the extension seems to work so much better than the Firefox version. I was playing on Goko with Firefox for the longest time, but recently I've been having problems where scripts would stop running when the table was being made for auto-match. Problems were especially likely when I would be the guest. I was curious to know if this could have anything to do with playing against people using the beta version of Salvager for Chrome.

I apologize to everyone that had to deal with my automatch glitching up.
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on February 04, 2014, 12:41:00 am
say, is there any way to put someone on my banlist who has a name that i cant decipher... because he has russian letters or whatnot?
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on February 04, 2014, 01:17:03 am
say, is there any way to put someone on my banlist who has a name that i cant decipher... because he has russian letters or whatnot?
Install the Russian keyboard.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 04, 2014, 03:53:37 am
say, is there any way to put someone on my banlist who has a name that i cant decipher... because he has russian letters or whatnot?
Copy paste from log? In game or after.
Title: Re: Goko Dominion Salvager Discussion
Post by: Jeebus on February 04, 2014, 10:41:45 pm
Recently the after-game log stopped working. The normal Goko log shows up instead. I'm using Chrome on Windows 7. It used to work before.
I tested it now on my old computer, which still runs Windows XP, and for some reason the log works there in Chrome.

Anybody else experience this?
Title: Re: Goko Dominion Salvager Discussion
Post by: Mic Qsenoch on February 04, 2014, 10:59:44 pm
Recently the after-game log stopped working. The normal Goko log shows up instead. I'm using Chrome on Windows 7. It used to work before.
I tested it now on my old computer, which still runs Windows XP, and for some reason the log works there in Chrome.

Anybody else experience this?

See http://forum.dominionstrategy.com/index.php?topic=10215.msg340516#msg340516 and below.
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on February 05, 2014, 09:29:18 am
say, is there any way to put someone on my banlist who has a name that i cant decipher... because he has russian letters or whatnot?
Copy paste from log? In game or after.

i cant copy from the game log, neither in firefox nor in chrome. are you supposed to be able to do that?
Title: Re: Goko Dominion Salvager Discussion
Post by: Mic Qsenoch on February 05, 2014, 10:37:55 am
say, is there any way to put someone on my banlist who has a name that i cant decipher... because he has russian letters or whatnot?
Copy paste from log? In game or after.

i cant copy from the game log, neither in firefox nor in chrome. are you supposed to be able to do that?

Here's the name: Александр Логинов, I'm assuming

You can copy from the archived log. You can bring it up by clicking on the log button after the game is over. Or you can search for past games/logs here: gokologs.drunkensailor.org
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on February 06, 2014, 03:09:30 pm
say, is there any way to put someone on my banlist who has a name that i cant decipher... because he has russian letters or whatnot?
Copy paste from log? In game or after.

i cant copy from the game log, neither in firefox nor in chrome. are you supposed to be able to do that?

Here's the name: Александр Логинов, I'm assuming

You can copy from the archived log. You can bring it up by clicking on the log button after the game is over. Or you can search for past games/logs here: gokologs.drunkensailor.org

its scary that the community is so small that you can guess whom i meant... thanks though.
Title: Re: Goko Dominion Salvager Discussion
Post by: Awaclus on February 06, 2014, 03:19:57 pm
say, is there any way to put someone on my banlist who has a name that i cant decipher... because he has russian letters or whatnot?
Copy paste from log? In game or after.

i cant copy from the game log, neither in firefox nor in chrome. are you supposed to be able to do that?

Here's the name: Александр Логинов, I'm assuming

You can copy from the archived log. You can bring it up by clicking on the log button after the game is over. Or you can search for past games/logs here: gokologs.drunkensailor.org

its scary that the community is so small that you can guess whom i meant... thanks though.
There aren't that many people with Russian letters in their names on Goko, this person is the only one I have seen.
Title: Re: Goko Dominion Salvager Discussion
Post by: Mic Qsenoch on February 06, 2014, 03:33:37 pm
its scary that the community is so small that you can guess whom i meant... thanks though.

I didn't guess, I just used the logsearch.
Title: Re: Goko Dominion Salvager Discussion
Post by: Emeric on February 11, 2014, 02:14:40 pm
I don't know if it is the right place to talk about a bug on the VP counter.
Look on the screenshot attach to this post : VP Counter said I win 47/45 but real points are 45/45
and the log of the game : http://dom.retrobox.eu/?/20140211/log.5063625f0cf2b1ff4173dbab.1392145658783.txt
I don't think it was a game so hard for the VP counter except the vineyard



Title: Re: Goko Dominion Salvager Discussion
Post by: Rabid on February 11, 2014, 03:42:03 pm
I don't know if it is the right place to talk about a bug on the VP counter.
Look on the screenshot attach to this post : VP Counter said I win 47/45 but real points are 45/45
and the log of the game : http://dom.retrobox.eu/?/20140211/log.5063625f0cf2b1ff4173dbab.1392145658783.txt
I don't think it was a game so hard for the VP counter except the vineyard

Might be related to this?
http://forum.dominionstrategy.com/index.php?topic=8163.msg293031#msg293031
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on February 19, 2014, 05:52:56 pm
I don't know where to post bugs for the log prettifier, but this is a simple one. Soothsayer and Taxman are defined as type "action-attack" elements when they should be "action" elements. As a result, they don't have the CSS that adds the grey boxes to all the other actions isn't being applied to them.
Title: Re: Goko Dominion Salvager Discussion
Post by: jsh357 on February 20, 2014, 10:49:22 pm
I was playing a guy with a $ in his username, and I noticed the point tracker was not counting his score.  I'm guessing the $ is messing up the code for Salvager.  (Both of us using Chrome)
Title: Re: Goko Dominion Salvager Discussion
Post by: michaeljb on February 21, 2014, 01:32:21 am
inb4 bobby tables
Title: Re: Goko Dominion Salvager Discussion
Post by: minovsky on February 21, 2014, 04:29:24 am
using chrome on imac, but the side panel doesn't always load when starting a game (seems like a random thing). normally I am not the one who created the table, is that a problem? Also, this could happen even after I load goko in a new tab (after a game with no side panel and closed the original tab)
I don't want to abandon game because that will hurt my quit %....
Title: Re: Goko Dominion Salvager Discussion
Post by: AdamH on February 21, 2014, 11:03:29 am
using chrome on imac, but the side panel doesn't always load when starting a game (seems like a random thing). normally I am not the one who created the table, is that a problem? Also, this could happen even after I load goko in a new tab (after a game with no side panel and closed the original tab)
I don't want to abandon game because that will hurt my quit %....

I believe this is a timing issue with the way Goko loads in your browser. I see this sometimes too. The way I work around it is that I make sure on my home screen that I see the "user settings" button and my custom avatar in the upper right corner. If I see both of these things then I know the extension has loaded properly and I always see the log during the game.
Title: Re: Goko Dominion Salvager Discussion
Post by: minovsky on February 24, 2014, 10:53:00 am
I am having difficulty specifying bane cards when creating game. I was trying to use Beyond Awesome's set in the 2012 Kingdom Design Challenge...

When I tried "Caravan, Fishing Village, Herbalist, Horn of Plenty, Mandarin, Philosopher's Stone, Royal Seal, Trading Post, Vineyard, Young Witch, Watchtower", Vineyard got chose consistently as the bane card.
 
Thinking maybe it used the card before young witch as the bane, I tried "Caravan, Fishing Village, Herbalist, Horn of Plenty, Mandarin, Philosopher's Stone, Royal Seal, Trading Post, Watchtower, Young Witch, Vineyard", but that cause the page to reload... I have retried many times.

I am sure there's a way to do it but I am just missing it. thx!
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on February 24, 2014, 11:00:05 am
Your first string should have worked. Vineyard isn't even a valid Bane.
Title: Re: Goko Dominion Salvager Discussion
Post by: minovsky on February 24, 2014, 11:18:51 am
ah i see... i never started the game, i just saw the vineyard being the last card listed and thought it's the bane -_-
probably explain why the page reload with the 2nd string... thx!
Title: Re: Goko Dominion Salvager Discussion
Post by: LibraryAdventurer on February 26, 2014, 01:49:25 am
Recently, salvager has been autokicking people I want to play with. They have significantly lower ratings than me, but the autokick by rating option is turned off.
Title: Re: Goko Dominion Salvager Discussion
Post by: florrat on February 26, 2014, 02:29:02 am
What was your game title? If it was (accidentally) "for <user>", then salvager kicks everyone except <user> (unless you turn off that option).
Title: Re: Goko Dominion Salvager Discussion
Post by: LibraryAdventurer on February 26, 2014, 11:41:24 pm
oh. I put "for Stick Figure" while Stick Figure is a nickname for my brother but it isn't his username. I thought autokick by name referred to people on your blacklist.
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on February 26, 2014, 11:52:38 pm
Shortly after introducing this feature, Andrew welcomed me into his game by putting "For SCSN" in the title.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 27, 2014, 04:37:47 pm
Goko is probably changing URL. This means that probably all versions of extension will stop working.
http://forum.makingfun.com/showthread.php?4341-Release-Notes-2-27-2014-(after-the-migration-is-done)
Title: Re: Goko Dominion Salvager Discussion
Post by: GeoLib on February 27, 2014, 04:42:54 pm
OK, why is this a bug? I feel stupid and don't want to start a new thread.

Quote
Fixed bug: If you trash a single Cultist, Overgrown Estate, or Rats and you draw a Market Square as a result of that, you weren't allowed to reveal the Market Square in reaction to the original trashing.

It wasn't in your hand when you trashed, so you can't reveal it...but apparently not?

You're still in the process of resolving on-trash effects, which you can do in any order, so you can discard market square for gold. It's kind of an accountability thing, since there's no way to know whether you just drew the MS or whether it was in your hand the whole time.
Title: Re: Goko Dominion Salvager Discussion
Post by: Voltaire on February 27, 2014, 04:45:27 pm
You're still in the process of resolving on-trash effects, which you can do in any order, so you can discard market square for gold. It's kind of an accountability thing, since there's no way to know whether you just drew the MS or whether it was in your hand the whole time.

Yeah, apparently the issue is I just never read the card FAQ (which I just did and deleted my post but I see it's too late  :P).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 27, 2014, 05:55:01 pm
Goko is probably changing URL. This means that probably all versions of extension will stop working.
http://forum.makingfun.com/showthread.php?4341-Release-Notes-2-27-2014-(after-the-migration-is-done)

You're concerned about the extension permissions?  That might not end up being a problem, since playdominion.com seems to just redirect to the old URL.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 27, 2014, 06:09:14 pm
Goko is probably changing URL. This means that probably all versions of extension will stop working.
http://forum.makingfun.com/showthread.php?4341-Release-Notes-2-27-2014-(after-the-migration-is-done)

You're concerned about the extension permissions?  That might not end up being a problem, since playdominion.com seems to just redirect to the old URL.

Yes.

Now it does. But will it after the migration? I don't think so since they probably removed Goko brand too. We will see in a few hours ( or days).
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 27, 2014, 06:50:38 pm
Goko is probably changing URL. This means that probably all versions of extension will stop working.
http://forum.makingfun.com/showthread.php?4341-Release-Notes-2-27-2014-(after-the-migration-is-done)

You're concerned about the extension permissions?  That might not end up being a problem, since playdominion.com seems to just redirect to the old URL.

Yes.

Now it does. But will it after the migration? I don't think so since they probably removed Goko brand too. We will see in a few hours ( or days).

Oh, I see.  I'm way behind here.
Title: Re: Goko Dominion Salvager Discussion
Post by: minovsky on February 27, 2014, 10:58:40 pm
the goko brand is still there, but the extension doesn't work for now. really wish goko/making fun actually implemented this by themselves instead of needing fans to do the work for them...
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 27, 2014, 11:04:20 pm
the goko brand is still there, but the extension doesn't work for now. really wish goko/making fun actually implemented this by themselves instead of needing fans to do the work for them...

Okay, right.  Good call, yed.

Is the current master branch working properly?  I can make the domain change and do a release, but it's been an awful long time since I've tested anything.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on February 27, 2014, 11:16:51 pm
the goko brand is still there, but the extension doesn't work for now. really wish goko/making fun actually implemented this by themselves instead of needing fans to do the work for them...

Okay, right.  Good call, yed.

Is the current master branch working properly?  I can make the domain change and do a release, but it's been an awful long time since I've tested anything.

The only bug I know of is the one where it kicks you back to the title page if you press the return/enter key while your cursor is in the text field of the Kingdom Generator. It should be the same as clicking the submit button.
Title: Re: Goko Dominion Salvager Discussion
Post by: Robz888 on February 28, 2014, 12:35:25 am
I think the Extension no longer works.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 28, 2014, 12:39:16 am
the goko brand is still there, but the extension doesn't work for now. really wish goko/making fun actually implemented this by themselves instead of needing fans to do the work for them...

Okay, right.  Good call, yed.

Is the current master branch working properly?  I can make the domain change and do a release, but it's been an awful long time since I've tested anything.
Yes master works but extension does not load propetly some time.

LastFootnote's bug is easy to fix. It is described in issues. I just don't have time for it.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 28, 2014, 12:39:53 am
I think the Extension no longer works.

Correct.  I'm currently testing a new build.  It's available at https://www.gokosalvager.com:8888/v2.4/index.html for anyone else who wants to test.  Definitely not production-worthy yet tho. Actually, it looks pretty good to me so far.

Chrome isn't working yet.  Anyone know how to deal with the "utility process crashed" error?  Is anyone able to install the chrome extension without encountering this error?
Title: Re: Goko Dominion Salvager Discussion
Post by: theblankman on February 28, 2014, 01:05:30 am
Easy(ish) hack for Chrome users:
1. Find the extension folder.  If you're a mac user like me it's in ~/Library/Application Support/Google/Chrome/Default/Extensions/<some long random string>/<version>.  Not sure about other OSes.
2. Copy all those files to somewhere else.
3. In your new folder, open manifest.json and change every occurrence of ".goko.com" to "playdominion.com".
4. Go to Chrome's extension settings, uninstall Salvager, then click "Load Unpacked Extension" (you might need to turn on Developer Mode for this, not sure), and point to the folder you made in step 2.
5. Surprise Andrew I. with an automatch game like I just did :)

EDIT: Or just get the updated build from the link he posted, it seems to work for me.
Title: Re: Goko Dominion Salvager Discussion
Post by: theblankman on February 28, 2014, 01:23:29 am
Chrome isn't working yet.  Anyone know how to deal with the "utility process crashed" error?  Is anyone able to install the chrome extension without encountering this error?

I didn't hit "utility process crashed" but my environment might be different from yours.  Just clicking the link on your site, Chrome tried to open the file as if it were text for some reason.  Ugly.  Right-click -> Save -> Open from Finder made Chrome try to install it then redirect me here: https://support.google.com/chrome_webstore/answer/2664769?p=crx_warning&rd=1

Drag and drop the crx file onto Chrome's extension management page.  That's totally intuitive.  Still no crashes yet though.
Title: Re: Goko Dominion Salvager Discussion
Post by: jaybeez on February 28, 2014, 01:26:16 am
I think the Extension no longer works.

Correct.  I'm currently testing a new build.  It's available at https://www.gokosalvager.com:8888/v2.4/index.html for anyone else who wants to test.  Definitely not production-worthy yet tho. Actually, it looks pretty good to me so far.

Chrome isn't working yet.  Anyone know how to deal with the "utility process crashed" error?  Is anyone able to install the chrome extension without encountering this error?
For some reason I still can't get the extension to work (I assume it's because I'm dumb).  Firefox is completely up to date.  I tried installing the new version straight-up, disabling the extension and installing, removing the extension and installing.  What am I doing wrong, anyone have any suggestions?
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 28, 2014, 01:41:16 am
I think the Extension no longer works.

Correct.  I'm currently testing a new build.  It's available at https://www.gokosalvager.com:8888/v2.4/index.html for anyone else who wants to test.  Definitely not production-worthy yet tho. Actually, it looks pretty good to me so far.

Chrome isn't working yet.  Anyone know how to deal with the "utility process crashed" error?  Is anyone able to install the chrome extension without encountering this error?
For some reason I still can't get the extension to work (I assume it's because I'm dumb).  Firefox is completely up to date.  I tried installing the new version straight-up, disabling the extension and installing, removing the extension and installing.  What am I doing wrong, anyone have any suggestions?

It's not you.  It's me.  Working on it...
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 28, 2014, 01:47:53 am
I think the Extension no longer works.

Correct.  I'm currently testing a new build.  It's available at https://www.gokosalvager.com:8888/v2.4/index.html for anyone else who wants to test.  Definitely not production-worthy yet tho. Actually, it looks pretty good to me so far.

Chrome isn't working yet.  Anyone know how to deal with the "utility process crashed" error?  Is anyone able to install the chrome extension without encountering this error?
For some reason I still can't get the extension to work (I assume it's because I'm dumb).  Firefox is completely up to date.  I tried installing the new version straight-up, disabling the extension and installing, removing the extension and installing.  What am I doing wrong, anyone have any suggestions?

It's not you.  It's me.  Working on it...

Ok, Firefox version should work now.  But you have to download the xpi file and then do "Install Add-On from File" from your browser's Extensions page.  I don't know why and I'll try to fix the issue.
Title: Re: Goko Dominion Salvager Discussion
Post by: jaybeez on February 28, 2014, 01:52:07 am
Fixed in 20 minutes flat, what service.  You are the man.
Title: Re: Goko Dominion Salvager Discussion
Post by: Emeric on February 28, 2014, 02:14:29 am
Yes ! it works !

But a bug ;) The "User Settings" link is not more present may be because goko add a "profile" link
Title: Re: Goko Dominion Salvager Discussion
Post by: Robz888 on February 28, 2014, 02:17:53 am
Cheers to you, Andrew. You are a hero.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 28, 2014, 02:32:45 am
Yes ! it works !

But a bug ;) The "User Settings" link is not more present may be because goko add a "profile" link

What browser are you using?  And have you tried reloading a few times to see if the link appears?  Sadly, his has always been a somewhat unreliable feature.  I don't think the "profile" link should be causing problems.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 28, 2014, 02:41:45 am
Chrome isn't working yet.  Anyone know how to deal with the "utility process crashed" error?  Is anyone able to install the chrome extension without encountering this error?
After updating master from github, Chrome version works for me.
I'm using:
rake chrome:build
Tools->Extensions->Developer Mode->Load unpacked extension->Goko-Salvager/build/chrome
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 28, 2014, 02:50:28 am
But VP counter does not work. I have tried that only against bot.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 28, 2014, 03:00:15 am
But VP counter does not work. I have tried that only against bot.

Ok cool, the unpacked version works for me too.  I get an error when I try to install the crx file, but only on linux, it seems.  I haven't had any problems with the VP counter, oddly enough.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 28, 2014, 03:05:54 am
But VP counter does not work. I have tried that only against bot.

Ok cool, the unpacked version works for me too.  I get an error when I try to install the crx file, but only on linux, it seems.  I haven't had any problems with the VP counter, oddly enough.
It works now after reload. Probably the extension was not loaded fully(properly).
Title: Re: Goko Dominion Salvager Discussion
Post by: Emeric on February 28, 2014, 03:20:44 am
Yes ! it works !

But a bug ;) The "User Settings" link is not more present may be because goko add a "profile" link

What browser are you using?  And have you tried reloading a few times to see if the link appears?  Sadly, his has always been a somewhat unreliable feature.  I don't think the "profile" link should be causing problems.

I use firefox and after a reload, the link is here ! thanks !
Title: Re: Goko Dominion Salvager Discussion
Post by: Emeric on February 28, 2014, 03:23:32 am
I think it is complicate to find it but in the user settings the blacklist is empty !
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 28, 2014, 03:27:28 am
I think it is complicate to find it but in the user settings the blacklist is empty !
That is because blacklist is stored in your browser with goko.com label. Since now it runs at playdominion.com, extension won't find it. Nothing we can done about that. If you add bans again, it should save them.
Title: Re: Goko Dominion Salvager Discussion
Post by: TheMirrorMan on February 28, 2014, 05:28:21 am
Big thumbs up Andrew - you are amazing !!!
Title: Re: Goko Dominion Salvager Discussion
Post by: GwinnR on February 28, 2014, 06:07:18 am
What do the following options mean?:

-HTML5 "Desktop" Notifications (recommanded)
-Traditional Popups
-Extra logging (for error reports)
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on February 28, 2014, 10:33:48 am
goko is up, but salvager seems to be down.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 28, 2014, 10:37:58 am
Again, you need a new version of the extension because the Dominion URL has changed.  See the "Status" thread (http://forum.dominionstrategy.com/index.php?topic=9198.msg283465#msg283465) for the latest version and installation instructions.   I will do an official release to the Chrome Store shortly.  The new version is in the Chrome store.

What do the following options mean?:

-HTML5 "Desktop" Notifications (recommanded)
-Traditional Popups
-Extra logging (for error reports)

These are features that have been in the beta for some time, but which I never got around to publishing in the Chrome Store.
Also new compared to the old Chrome version:
There are several other less visible additions and fixes that yed and serakfalcon have made in my absence.  See the github log (https://github.com/aiannacc/Goko-Salvager/network) for details and please thank them for their contributions.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 28, 2014, 10:44:05 am
I will do an official release to the Chrome Store shortly.
Not sure if you did notice that on Github: Log URL after game does not work:
https://github.com/aiannacc/Goko-Salvager/issues/159
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on February 28, 2014, 10:52:44 am
small change to chrome update procedure: when you drag the crx file into your browser, the browser must be open to the extensions page under settings.

from https://support.google.com/chrome_webstore/answer/2664769?p=crx_warning&rd=1
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 28, 2014, 11:01:52 am
I will do an official release to the Chrome Store shortly.
Not sure if you did notice that on Github: Log URL after game does not work:
https://github.com/aiannacc/Goko-Salvager/issues/159

The release is already in progress.  I'll do an update when we get this fixed.  Anything else important broken?
Title: Re: Goko Dominion Salvager Discussion
Post by: Kirian on February 28, 2014, 11:26:55 am
Andrew, you deserve all the +1s.  Just... just all of them, man.
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on February 28, 2014, 11:54:30 am
Anything else important broken?
I don't know about anything.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on February 28, 2014, 12:02:45 pm
The Kingdom generator booting you back to the title screen is still broken. It would really be nice if that were fixed.

More importantly, there is no longer a link for User Settings on the title page. I'm using Chrome.

EDIT: Nevermind, it now shows up. I had refreshed several times before, but I guess for some reason it didn't take. Sorry about the false alarm.
Title: Re: Goko Dominion Salvager Discussion
Post by: Robz888 on February 28, 2014, 12:23:20 pm
When you click the log button to grab the log, Goko freezes! Just found that out playing my tournament games...
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on February 28, 2014, 12:35:09 pm
When you click the log button to grab the log, Goko freezes! Just found that out playing my tournament games...

Sorry about that.  They changed where the logs are stored, which broke nutki's log prettifier.  I've moved it to gokosalvager.com so that I could fix the log location.  Honestly, though, I'm really surprised that it crashed instead of just linking you to a blank log page.  It's working for me in v2.4.1, which is now in the Chrome Store, so please post your Javascript log if it happens again with v2.4.1 or higher.

More importantly, there is no longer a link for User Settings on the title page. I'm using Chrome.

EDIT: Nevermind, it now shows up. I had refreshed several times before, but I guess for some reason it didn't take. Sorry about the false alarm.

Quite a few of us have tried and failed to fix this problem.  The title page is a cantankerous POGS.  The links will show up if you reload it enough, but you don't actually need the links for the extension to work.  You only need them to change the settings or your avatar.

Andrew, you deserve all the +1s.  Just... just all of them, man.

Many thanks.  I'm flattered.  It's nice to do some work on this again... and to finally release those beta features. :)

Regarding automatic updating:
Title: Re: Goko Dominion Salvager Discussion
Post by: Beyond Awesome on February 28, 2014, 03:19:32 pm
Awesome! The chat is now to the side.  :D
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on March 01, 2014, 08:47:48 am
the avatars don't work for me since the goko server downtime thing. it displays the goko-avatars during games, the salvager avatars just in the rooms. using chrome
Title: Re: Goko Dominion Salvager Discussion
Post by: serakfalcon on March 01, 2014, 11:33:18 am
the avatars don't work for me since the goko server downtime thing. it displays the goko-avatars during games, the salvager avatars just in the rooms. using chrome
The script only tries once to get the salvager avatars, so if the page is slow to load (which the lobbies definitely are) it won't load. It could be set to retry on timeout.
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on March 01, 2014, 11:37:07 am
the avatars don't work for me since the goko server downtime thing. it displays the goko-avatars during games, the salvager avatars just in the rooms. using chrome
The script only tries once to get the salvager avatars, so if the page is slow to load (which the lobbies definitely are) it won't load. It could be set to retry on timeout.

it used to always work though. like, always, not just most of the times
Title: Re: Goko Dominion Salvager Discussion
Post by: markusin on March 01, 2014, 12:17:47 pm
the avatars don't work for me since the goko server downtime thing. it displays the goko-avatars during games, the salvager avatars just in the rooms. using chrome
I didn't even take note of this until today. This is after having played my GokoDom III Round 2 match no less.
Title: Re: Goko Dominion Salvager Discussion
Post by: silverspawn on March 01, 2014, 12:27:39 pm
the avatars don't work for me since the goko server downtime thing. it displays the goko-avatars during games, the salvager avatars just in the rooms. using chrome
I didn't even take note of this until today. This is after having played my GokoDom III Round 2 match no less.

well i already figured i'd probably be the only user who thinks this is a big deal. mentioning it can't hurt though.
Title: Re: Goko Dominion Salvager Discussion
Post by: Voltaire on March 01, 2014, 06:57:40 pm
Yeah, my avatar doesn't load on the results screen, even when it does load in the lobbies. Not a big deal, but consistent buggy behavior.

Overall though, I just want to say how amazing the new version is! I love sidechat (using Firefox, so it's new to me).
Title: Re: Goko Dominion Salvager Discussion
Post by: Holger on March 02, 2014, 03:37:37 pm
Since the extension seems to already check whether I play bots or real people, I'd like to make the following feature request:

Don't show the chat box in bot games (no matter my chat box settings), and don't post VP-Counter info there in this case; the bots don't bother to chat ;).

Either way, thanks for creating such an awesome extension; it greatly improves the game (whenever Goko works at all...).



Title: Re: Goko Dominion Salvager Discussion
Post by: minovsky on March 03, 2014, 01:32:59 am
thanks from me too for the awesome extension! I was using the chat on sidebar function in chrome and I noticed if I type a long sentence, the chat box got widened and the play area shifted slightly to the left, and when I tried to buy a card clicking on the "+" icon, it doesn't work, I need to shift my cursor to just a bit left to the outside of the "+" icon to buy the card. some of my friends even complained they got a different card from the one they tried to buy several turns after that chat box got widened (they quit afterwards :P)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 03, 2014, 02:40:59 am
thanks from me too for the awesome extension! I was using the chat on sidebar function in chrome and I noticed if I type a long sentence, the chat box got widened and the play area shifted slightly to the left, and when I tried to buy a card clicking on the "+" icon, it doesn't work, I need to shift my cursor to just a bit left to the outside of the "+" icon to buy the card. some of my friends even complained they got a different card from the one they tried to buy several turns after that chat box got widened (they quit afterwards :P)

This is clearly important, but I can't replicate it.

Can you tell me your browser and extension version number?  A screenshot would also help, plus knowing whether there's any particular conditions (e.g. window size) that make it happen.

Goko has some code that tries to resize the game screen in response to the size of your browser window.  This might be some weird interaction with that code.
Title: Re: Goko Dominion Salvager Discussion
Post by: minovsky on March 03, 2014, 12:11:42 pm
thanks from me too for the awesome extension! I was using the chat on sidebar function in chrome and I noticed if I type a long sentence, the chat box got widened and the play area shifted slightly to the left, and when I tried to buy a card clicking on the "+" icon, it doesn't work, I need to shift my cursor to just a bit left to the outside of the "+" icon to buy the card. some of my friends even complained they got a different card from the one they tried to buy several turns after that chat box got widened (they quit afterwards :P)

This is clearly important, but I can't replicate it.

Can you tell me your browser and extension version number?  A screenshot would also help, plus knowing whether there's any particular conditions (e.g. window size) that make it happen.

Goko has some code that tries to resize the game screen in response to the size of your browser window.  This might be some weird interaction with that code.

screenshot here: http://d.pr/i/TVn5
the chat area got "wider" because of the scroll bar, and the original goko screen area shifted slight to the left at the same time when the scroll bar appears

chrome Version 33.0.1750.117
extension 2.4.1

thx for looking into this!
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 03, 2014, 07:32:47 pm
thanks from me too for the awesome extension! I was using the chat on sidebar function in chrome and I noticed if I type a long sentence, the chat box got widened and the play area shifted slightly to the left, and when I tried to buy a card clicking on the "+" icon, it doesn't work, I need to shift my cursor to just a bit left to the outside of the "+" icon to buy the card. some of my friends even complained they got a different card from the one they tried to buy several turns after that chat box got widened (they quit afterwards :P)

This is clearly important, but I can't replicate it.

Can you tell me your browser and extension version number?  A screenshot would also help, plus knowing whether there's any particular conditions (e.g. window size) that make it happen.

Goko has some code that tries to resize the game screen in response to the size of your browser window.  This might be some weird interaction with that code.

screenshot here: http://d.pr/i/TVn5
the chat area got "wider" because of the scroll bar, and the original goko screen area shifted slight to the left at the same time when the scroll bar appears

chrome Version 33.0.1750.117
extension 2.4.1

thx for looking into this!

Fixed in v2.4.2.  Update should be automatic.  Check your version number if this issue persists.  Tested in Chrome and FF.
Also just released v2.4.3, which (probably) reenables Salvager on Safari (which apparently nobody is using).  It works for me in Safari 5.1.7 for Windows at least.

minovsky, please let me know if the '+' icon issue goes away.  I had noticed similar behavior before, but I hadn't connected it with the chat area scroll bar.
Title: Re: Goko Dominion Salvager Discussion
Post by: Senayen on March 04, 2014, 09:18:26 am
Did something change in how you use the Kingdom generator? It worked for me before (using Chrome, before the domain move), but now (i have 2.4.3) I don't get the popup when I create a new game ... do I have to invoke it somehow?
Title: Re: Goko Dominion Salvager Discussion
Post by: Mic Qsenoch on March 04, 2014, 09:28:26 am
Did something change in how you use the Kingdom generator? It worked for me before (using Chrome, before the domain move), but now (i have 2.4.3) I don't get the popup when I create a new game ... do I have to invoke it somehow?

The user settings were cleared in the most recent update, so you probably need to turn it back on. If you go to the Dominion Online home screen there is a "User Settings" button.

If it's not this, I would try hitting the randomize card button again, that seems to work for me if the Kingdom generator box doesn't pop up at first.
Title: Re: Goko Dominion Salvager Discussion
Post by: Mic Qsenoch on March 04, 2014, 09:43:06 am
Since the extension seems to already check whether I play bots or real people, I'd like to make the following feature request:

Don't show the chat box in bot games (no matter my chat box settings), and don't post VP-Counter info there in this case; the bots don't bother to chat ;).

Either way, thanks for creating such an awesome extension; it greatly improves the game (whenever Goko works at all...).

It would also be nice if the notifications for someone joining your game didn't pop up if the player is a bot that you just selected to join the game.
Title: Re: Goko Dominion Salvager Discussion
Post by: LastFootnote on March 04, 2014, 09:44:57 am
Since the extension seems to already check whether I play bots or real people, I'd like to make the following feature request:

Don't show the chat box in bot games (no matter my chat box settings), and don't post VP-Counter info there in this case; the bots don't bother to chat ;).

Either way, thanks for creating such an awesome extension; it greatly improves the game (whenever Goko works at all...).

It would also be nice if the notifications for someone joining your game didn't pop up if the player is a bot that you just selected to join the game.

Also, is it possible for the notification to tell you who is joining your game, along with their casual and pro rankings?
Title: Re: Goko Dominion Salvager Discussion
Post by: Senayen on March 04, 2014, 09:50:05 am
Did something change in how you use the Kingdom generator? It worked for me before (using Chrome, before the domain move), but now (i have 2.4.3) I don't get the popup when I create a new game ... do I have to invoke it somehow?

The user settings were cleared in the most recent update, so you probably need to turn it back on. If you go to the Dominion Online home screen there is a "User Settings" button.

If it's not this, I would try hitting the randomize card button again, that seems to work for me if the Kingdom generator box doesn't pop up at first.
Thanks. The button did not show for me at first, I deactivated the blocking of 3rd-party-cookies and it worked ... but I'm not so sure this was the cause, as I can't think of a reason why it would be related to cookies from makingfun.com
Title: Re: Goko Dominion Salvager Discussion
Post by: yed on March 04, 2014, 10:04:12 am
Did something change in how you use the Kingdom generator? It worked for me before (using Chrome, before the domain move), but now (i have 2.4.3) I don't get the popup when I create a new game ... do I have to invoke it somehow?

The user settings were cleared in the most recent update, so you probably need to turn it back on. If you go to the Dominion Online home screen there is a "User Settings" button.

If it's not this, I would try hitting the randomize card button again, that seems to work for me if the Kingdom generator box doesn't pop up at first.
Thanks. The button did not show for me at first, I deactivated the blocking of 3rd-party-cookies and it worked ... but I'm not so sure this was the cause, as I can't think of a reason why it would be related to cookies from makingfun.com
There is a bug which makes "user settings" link hidden sometimes. You need to refresh page when that happens.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 04, 2014, 11:59:29 am
Since the extension seems to already check whether I play bots or real people, I'd like to make the following feature request:

Don't show the chat box in bot games (no matter my chat box settings), and don't post VP-Counter info there in this case; the bots don't bother to chat ;).

Either way, thanks for creating such an awesome extension; it greatly improves the game (whenever Goko works at all...).

It would also be nice if the notifications for someone joining your game didn't pop up if the player is a bot that you just selected to join the game.

Also, is it possible for the notification to tell you who is joining your game, along with their casual and pro rankings?

All noted and added to github.  Thanks.

Thanks. The button did not show for me at first, I deactivated the blocking of 3rd-party-cookies and it worked ... but I'm not so sure this was the cause, as I can't think of a reason why it would be related to cookies from makingfun.com

Probably unrelated, but it would be sooo funny if this actually fixed the title page issues.
Title: Re: Goko Dominion Salvager Discussion
Post by: minovsky on March 05, 2014, 11:35:36 pm
thanks from me too for the awesome extension! I was using the chat on sidebar function in chrome and I noticed if I type a long sentence, the chat box got widened and the play area shifted slightly to the left, and when I tried to buy a card clicking on the "+" icon, it doesn't work, I need to shift my cursor to just a bit left to the outside of the "+" icon to buy the card. some of my friends even complained they got a different card from the one they tried to buy several turns after that chat box got widened (they quit afterwards :P)

This is clearly important, but I can't replicate it.

Can you tell me your browser and extension version number?  A screenshot would also help, plus knowing whether there's any particular conditions (e.g. window size) that make it happen.

Goko has some code that tries to resize the game screen in response to the size of your browser window.  This might be some weird interaction with that code.

screenshot here: http://d.pr/i/TVn5
the chat area got "wider" because of the scroll bar, and the original goko screen area shifted slight to the left at the same time when the scroll bar appears

chrome Version 33.0.1750.117
extension 2.4.1

thx for looking into this!

Fixed in v2.4.2.  Update should be automatic.  Check your version number if this issue persists.  Tested in Chrome and FF.
Also just released v2.4.3, which (probably) reenables Salvager on Safari (which apparently nobody is using).  It works for me in Safari 5.1.7 for Windows at least.

minovsky, please let me know if the '+' icon issue goes away.  I had noticed similar behavior before, but I hadn't connected it with the chat area scroll bar.

sorry i was busy the past couple of days didn't get to play at all. Just tried it and it worked! thx much for fixing :)
Title: Re: Goko Dominion Salvager Discussion
Post by: Narz on March 06, 2014, 04:57:41 pm
Sorry for not scanning thread but latest working Firefox extension is at?  Is there a link I should bookmark where updates will always be?

Thanks again for your hard work on this!  Goko should be paying you for! :)
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on March 06, 2014, 06:22:09 pm
if you want to try and replicate the + issue, I can tell you that I get it fairly reliably because I'm using another chrome extension "Type-ahead-find".  if this extension gets activated (tries to find as I type), the log and chat box get shifted a bit, and then I get the + error.  So if you want to try and debug the + issue, you can try using this extension to reliably reproduce the error.  (Extension here: https://chrome.google.com/webstore/detail/type-ahead-find/cpecbmjeidppdiampimghndkikcmoadk?hl=en  )
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 06, 2014, 06:43:04 pm
if you want to try and replicate the + issue, I can tell you that I get it fairly reliably because I'm using another chrome extension "Type-ahead-find".  if this extension gets activated (tries to find as I type), the log and chat box get shifted a bit, and then I get the + error.  So if you want to try and debug the + issue, you can try using this extension to reliably reproduce the error.  (Extension here: https://chrome.google.com/webstore/detail/type-ahead-find/cpecbmjeidppdiampimghndkikcmoadk?hl=en  )

Hmm... I'll look at it.  No promises though.  I expect this is deeply rooted in the Goko screen-resizing nonsense, a place I fear to tread.
Title: Re: Goko Dominion Salvager Discussion
Post by: flies on March 06, 2014, 06:54:03 pm
i wouldn't call this a high priority, personally.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 06, 2014, 07:21:49 pm
i wouldn't call this a high priority, personally.

That's what I meant to say. ;)
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 07, 2014, 11:31:40 am
New docs on how to contribute to Salvager:

https://github.com/aiannacc/Goko-Salvager/wiki/Development

It's not easy, but at least now it's not as confusing as it looked!
Title: Re: Goko Dominion Salvager Discussion
Post by: shwick222 on March 07, 2014, 05:12:24 pm
Hi I installed salvager on chrome but I can't see the blacklist?

Also how do I remove the in game chat it takes up half the screen I prefer it the original way.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 07, 2014, 06:48:16 pm
Hi I installed salvager on chrome but I can't see the blacklist?

Also how do I remove the in game chat it takes up half the screen I prefer it the original way.

Sidebar chat can be disabled under "User Settings".  You probably also want to disable the sidebar itself (with the log and VP counter) if you're trying to save screen space.

Sometimes the User Settings link doesn't appear on the main page.  Reloading once or twice should make it appear.
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 07, 2014, 07:05:02 pm
Blacklist Recovery:

The recent URL change makes it impossible for Salvager to access your previously-stored settings.  They're still there in your browser, but it takes a little hacking to fish them out:
Title: Re: Goko Dominion Salvager Discussion
Post by: SCSN on March 07, 2014, 07:11:39 pm
You'll get a 404 error, but that's okay

Now you're really starting to think like a Goko developer.
Title: Re: Goko Dominion Salvager Discussion
Post by: shwick222 on March 07, 2014, 07:18:57 pm
Wow I had to refresh the main page before this invisible user settings appeared wtf...

It had blacklist options in it and I unchecked the chat thanks!

edit: it seems the chat still leaves a big black space on the right side of the screen even if I uncheck it, I was hoping it would resize back to normal

also when I create a table with automatch enabled it doesnt seem to kick people below the point threshold
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 07, 2014, 08:14:37 pm
Wow I had to refresh the main page before this invisible user settings appeared wtf...

Goko hates us.  You have no idea how much effort has gone into failing to fix that.

Quote
It had blacklist options in it and I unchecked the chat thanks!

edit: it seems the chat still leaves a big black space on the right side of the screen even if I uncheck it, I was hoping it would resize back to normal

I can't replicate this.  What browser and extension version please?  A screenshot and copy of your Javascript console log would be helpful too (Ctrl-Shift-J, then copy the console output).

Quote
also when I create a table with automatch enabled it doesnt seem to kick people below the point threshold

What is the exact name of your table?  Do you have "Autokick: by rating range" enabled?
Title: Re: Goko Dominion Salvager Discussion
Post by: shwick222 on March 07, 2014, 09:17:16 pm
chrome version 33.0.1750.146 m
Goko Dominion Salvager 2.4.3

Code: [Select]
Failed to load resource: the server responded with a status of 404 (Not Found) http://dom.retrobox.eu/avatars/516fd1c2e4b082c74d7e24bb.png
Cross-origin image load denied by Cross-Origin Resource Sharing policy. gameClient.html:1
Uncaught TypeError: Object #<WebKitNotification> has no method 'close' notifications.js:133
Time: 1.402 seconds FS.DeckBuilder.js:1298
FSSDK - called our ClientGameInstance constructor DominionGameClient.js:118
using query parameters for canvas size: 760 570 DominionUI.js:3952
calling FS.Advertising DominionGameClient.js:204
callback from FS.Advertising DominionGameClient.js:211
canvas size different, using: layout1024x768 DominionUI.js:3343
Using layout: layout1024x768 DominionUI.js:1486
creating dominionwindow DominionUI.js:13175
using card buidler. DominionUI.js:3739
canvas size: 760 570 layoutSize: [size 1024 768] DominionUI.js:11360
using requestAnimationFrame DominionUI.js:13251

(http://i.imgur.com/QTnze2W.jpg)

http://i.imgur.com/QTnze2W.jpg


I think the auto kick was actually working, just once a guest got past it I dunno its good now :D
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 07, 2014, 10:02:50 pm
Hrm... I can't replicate in Chrome 33 on windows or linux.  Has anyone else experienced this?

Is that your whole log?  If so, then Salvager isn't running. ;)

For what it's worth, this is where the problem is:
Code: [Select]
canvas size: 760 570 layoutSize: [size 1024 768] DominionUI.js:11360
Goko is getting confused about how big your window is.  It's got some stupid code that tries to dynamically resize everything.

My best guess is that it's some funny interaction with the new GS version (I'm sure I changed the css layout stuff) and something specific to your browser.  Are you running an extension like NoSquint?  Does it change if you use Chrome's zoom (Ctrl-plus and Ctrl-minus) or resize the window?
Title: Re: Goko Dominion Salvager Discussion
Post by: shwick222 on March 07, 2014, 11:37:07 pm
That was the whole console log from the javascipt console that I could see, I copied it all

My only extension is adblock.

I use chrome to zoom in and out all the time with mousewheel but that doesnt change the chat window position

It's fine I will more than tolerate that for the banlist feature.  I never want to see kondzio again


also the autokick via pro rating isn't working, gamename is "all cards 3++ players"
Title: Re: Goko Dominion Salvager Discussion
Post by: ragingduckd on March 08, 2014, 01:25:22 am
That was the whole console log from the javascipt console that I could see, I copied it all

My only extension is adblock.

I use chrome to zoom in and out all the time with mousewheel but that doesnt change the chat window position

It's fine I will more than tolerate that for the banlist feature.  I never want to see kondzio again