Dominion Strategy Forum

Meta => Feedback => Topic started by: sudgy on December 08, 2018, 01:11:01 pm

Title: Upvoting refreshes?
Post by: sudgy on December 08, 2018, 01:11:01 pm
Did something change recently?  Whenever I upvote somebody, it refreshes the page to the post I upvoted.  It's not horribly broken or anything, just a little jarring that the page keeps shifting around.
Title: Re: Upvoting refreshes?
Post by: Awaclus on December 08, 2018, 02:04:48 pm
This is clearly just a trick to get more upvotes and I fell for it (and it worked and didn't refresh the page).
Title: Re: Upvoting refreshes?
Post by: GendoIkari on December 19, 2018, 03:40:17 pm
Mine just started doing this... in addition, I'm getting "oVotePost is not defined" in the console when I try to view vote counts.
Title: Re: Upvoting refreshes?
Post by: GendoIkari on December 19, 2018, 03:42:48 pm
Do you use the F.DS Extension? I'm worried that I may be causing this...
Title: Re: Upvoting refreshes?
Post by: Awaclus on December 19, 2018, 03:48:35 pm
Do you use the F.DS Extension? I'm worried that I may be causing this...

I use it and everything is still fine.
Title: Re: Upvoting refreshes?
Post by: GendoIkari on December 19, 2018, 03:50:28 pm
Do you use the F.DS Extension? I'm worried that I may be causing this...

I use it and everything is still fine.

Thanks.. and everything was fine for me yesterday... but now it is happening only when I have autolink checked; which suggests that it's somehow related. There could theoretically be an asynchronous race issue where it only happens sometimes, but can't happen without autolink.
Title: Re: Upvoting refreshes?
Post by: GendoIkari on December 19, 2018, 04:13:44 pm
Definitely seems like the extension... works fine when I uninstall it, or when I don't have autolink checked. But I re-installed it, and it breaks as soon as I check autolink.

A few different things that use Javascript break... clicking the post icon on one of your own posts to change the icon; or clicking the modify icon (NOT the modify button) to quick-modify a post; or clicking to view votes. Clicking to vote itself normally does the vote using Javascript, but if that Javascript fails; it does a full redirect to get the vote in instead.

The real question is why this was working fine for me yesterday, and is still working fine for other people. Could be an issue of browser version. Awaclus, is your Chrome up-to-date? It suddenly changing behavior (without my extension being updated) could be due to an update in the forum software, but then it should be the same for everyone...
Title: Re: Upvoting refreshes?
Post by: Awaclus on December 19, 2018, 04:31:28 pm
Awaclus, is your Chrome up-to-date?

I don't use Chrome but my Opera is up to date.
Title: Re: Upvoting refreshes?
Post by: GendoIkari on December 19, 2018, 05:00:19 pm
Awaclus, is your Chrome up-to-date?

I don't use Chrome but my Opera is up to date.

Opera allows Chrome extensions?
Title: Re: Upvoting refreshes?
Post by: Awaclus on December 19, 2018, 05:05:23 pm
Awaclus, is your Chrome up-to-date?

I don't use Chrome but my Opera is up to date.

Opera allows Chrome extensions?

Yes.
Title: Re: Upvoting refreshes?
Post by: sudgy on December 19, 2018, 07:24:19 pm
Can confirm that it's when I use autolink.  I'm using Chromium 72.0.3626.7 (by running chromium --version).
Title: Re: Upvoting refreshes?
Post by: GendoIkari on December 20, 2018, 09:36:45 am
I can think of ways that the autolink could cause this; but I can't think of why it would have always worked just fine for me until suddenly yesterday. Anyway, hopefully I can have it fixed by tomorrow if not today.
Title: Re: Upvoting refreshes?
Post by: GendoIkari on December 21, 2018, 11:04:10 pm
Should be fixed in the newest version. Thanks for finding the bug!

Still no clue why it worked fine for me until suddenly a couple days ago. Working for Awaclus could just be a difference between Chrome and Opera.